Conditions | 5 |
Paths | 4 |
Total Lines | 119 |
Code Lines | 83 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php declare(strict_types=1); |
||
62 | function xoops_module_install_suico(XoopsModule $module) |
||
63 | { |
||
64 | global $module_id; |
||
65 | $module_id = $module->getVar('mid'); |
||
66 | xoops_loadLanguage('user'); |
||
67 | require_once \dirname(__DIR__) . '/preloads/autoloader.php'; |
||
68 | $moduleDirName = \basename(\dirname(__DIR__)); |
||
69 | // Create registration steps |
||
70 | suico_install_addStep(_MI_SUICO_STEP_BASIC, '', 1, 1); |
||
71 | // Create categories |
||
72 | suico_install_addCategory(_MI_SUICO_CATEGORY_PERSONAL, 1); |
||
73 | suico_install_addCategory(_MI_SUICO_CATEGORY_MESSAGING, 2); |
||
74 | suico_install_addCategory(_MI_SUICO_CATEGORY_SETTINGS, 3); |
||
75 | suico_install_addCategory(_MI_SUICO_CATEGORY_COMMUNITY, 4); |
||
76 | // Add user fields |
||
77 | xoops_loadLanguage('notification'); |
||
78 | xoops_loadLanguage('main', $module->getVar('dirname', 'n')); |
||
|
|||
79 | require_once $GLOBALS['xoops']->path('include/notification_constants.php'); |
||
80 | $umode_options = [ |
||
81 | 'nest' => _NESTED, |
||
82 | 'flat' => _FLAT, |
||
83 | 'thread' => _THREADED, |
||
84 | ]; |
||
85 | $uorder_options = [ |
||
86 | 0 => _OLDESTFIRST, |
||
87 | 1 => _NEWESTFIRST, |
||
88 | ]; |
||
89 | $notify_mode_options = [ |
||
90 | XOOPS_NOTIFICATION_MODE_SENDALWAYS => _NOT_MODE_SENDALWAYS, |
||
91 | XOOPS_NOTIFICATION_MODE_SENDONCETHENDELETE => _NOT_MODE_SENDONCE, |
||
92 | XOOPS_NOTIFICATION_MODE_SENDONCETHENWAIT => _NOT_MODE_SENDONCEPERLOGIN, |
||
93 | ]; |
||
94 | $notify_method_options = [ |
||
95 | XOOPS_NOTIFICATION_METHOD_DISABLE => _NOT_METHOD_DISABLE, |
||
96 | XOOPS_NOTIFICATION_METHOD_PM => _NOT_METHOD_PM, |
||
97 | XOOPS_NOTIFICATION_METHOD_EMAIL => _NOT_METHOD_EMAIL, |
||
98 | ]; |
||
99 | suico_install_addField('name', _US_REALNAME, '', 1, 'textbox', 1, 1, 1, [], 0, 255); |
||
100 | suico_install_addField('user_from', _US_LOCATION, '', 1, 'textbox', 1, 2, 1, [], 0, 255); |
||
101 | suico_install_addField('user_occ', _US_OCCUPATION, '', 1, 'textbox', 1, 3, 1, [], 0, 255); |
||
102 | suico_install_addField('user_intrest', _US_INTEREST, '', 1, 'textbox', 1, 4, 1, [], 0, 255); |
||
103 | suico_install_addField('bio', _US_EXTRAINFO, '', 1, 'textarea', 2, 5, 1, [], 0, 0); |
||
104 | suico_install_addField('user_sig', _US_SIGNATURE, '', 1, 'dhtml', 1, 6, 1, [], 0, 0); |
||
105 | suico_install_addField('url', _MI_SUICO_URL_TITLE, '', 1, 'textbox', 1, 7, 1, [], 0, 255, false); |
||
106 | suico_install_addField('timezone_offset', _US_TIMEZONE, '', 3, 'timezone', 1, 0, 1, [], 0, 0, false); |
||
107 | suico_install_addField('user_viewemail', _US_ALLOWVIEWEMAIL, '', 3, 'yesno', 3, 1, 1, [], 0, 1, false); |
||
108 | suico_install_addField('attachsig', _US_SHOWSIG, '', 3, 'yesno', 3, 2, 1, [], 0, 1, false); |
||
109 | suico_install_addField('user_mailok', _US_MAILOK, '', 3, 'yesno', 3, 3, 1, [], 0, 1, false); |
||
110 | suico_install_addField('theme', _MD_SUICO_THEME, '', 3, 'theme', 1, 4, 1, [], 0, 0, false); |
||
111 | suico_install_addField('umode', _US_CDISPLAYMODE, '', 3, 'select', 1, 5, 1, $umode_options, 0, 0, false); |
||
112 | suico_install_addField('uorder', _US_CSORTORDER, '', 3, 'select', 3, 6, 1, $uorder_options, 0, 0, false); |
||
113 | suico_install_addField('notify_mode', _NOT_NOTIFYMODE, '', 3, 'select', 3, 7, 1, $notify_mode_options, 0, 0, false); |
||
114 | suico_install_addField('notify_method', _NOT_NOTIFYMETHOD, '', 3, 'select', 3, 8, 1, $notify_method_options, 0, 0, false); |
||
115 | suico_install_addField('user_regdate', _US_MEMBERSINCE, '', 4, 'datetime', 3, 1, 0, [], 0, 10); |
||
116 | suico_install_addField('posts', _US_POSTS, '', 4, 'textbox', 3, 2, 0, [], 0, 255); |
||
117 | suico_install_addField('rank', _US_RANK, '', 4, 'rank', 3, 3, 2, [], 0, 0); |
||
118 | suico_install_addField('last_login', _US_LASTLOGIN, '', 4, 'datetime', 3, 4, 0, [], 0, 10); |
||
119 | suico_install_initializeProfiles(); |
||
120 | $helper = Helper::getInstance(); |
||
121 | $utility = new Utility(); |
||
122 | $configurator = new Configurator(); |
||
123 | // Load language files |
||
124 | $helper->loadLanguage('admin'); |
||
125 | $helper->loadLanguage('modinfo'); |
||
126 | // default Permission Settings ---------------------- |
||
127 | $moduleId = $module->getVar('mid'); |
||
128 | //$moduleName = $module->getVar('name'); |
||
129 | $grouppermHandler = xoops_getHandler('groupperm'); |
||
130 | // access rights ------------------------------------------ |
||
131 | $grouppermHandler->addRight( |
||
132 | $moduleDirName . '_approve', |
||
133 | 1, |
||
134 | XOOPS_GROUP_ADMIN, |
||
135 | $moduleId |
||
136 | ); |
||
137 | $grouppermHandler->addRight($moduleDirName . '_submit', 1, XOOPS_GROUP_ADMIN, $moduleId); |
||
138 | $grouppermHandler->addRight($moduleDirName . '_view', 1, XOOPS_GROUP_ADMIN, $moduleId); |
||
139 | $grouppermHandler->addRight($moduleDirName . '_view', 1, XOOPS_GROUP_USERS, $moduleId); |
||
140 | $grouppermHandler->addRight($moduleDirName . '_view', 1, XOOPS_GROUP_ANONYMOUS, $moduleId); |
||
141 | // --- CREATE FOLDERS --------------- |
||
142 | if (count($configurator->uploadFolders) > 0) { |
||
143 | // foreach (array_keys($GLOBALS['uploadFolders']) as $i) { |
||
144 | foreach ( |
||
145 | array_keys( |
||
146 | $configurator->uploadFolders |
||
147 | ) as $i |
||
148 | ) { |
||
149 | $utility::createFolder($configurator->uploadFolders[$i]); |
||
150 | } |
||
151 | } |
||
152 | // --- COPY blank.png FILES --------------- |
||
153 | if (count($configurator->copyBlankFiles) > 0) { |
||
154 | $file = \dirname(__DIR__) . '/assets/images/blank.png'; |
||
155 | foreach (array_keys($configurator->copyBlankFiles) as $i) { |
||
156 | $dest = $configurator->copyBlankFiles[$i] . '/blank.png'; |
||
157 | $utility::copyFile($file, $dest); |
||
158 | } |
||
159 | } |
||
160 | /* |
||
161 | // --- COPY test folder files --------------- |
||
162 | if (count($configurator->copyTestFolders) > 0) { |
||
163 | // $file = \dirname(__DIR__) . '/testdata/images/'; |
||
164 | foreach (array_keys($configurator->copyTestFolders) as $i) { |
||
165 | $src = $configurator->copyTestFolders[$i][0]; |
||
166 | $dest = $configurator->copyTestFolders[$i][1]; |
||
167 | $utility::xcopy($src, $dest); |
||
168 | } |
||
169 | } |
||
170 | */ |
||
171 | //delete .html entries from the tpl table |
||
172 | $sql = 'DELETE FROM ' . $GLOBALS['xoopsDB']->prefix( |
||
173 | 'tplfile' |
||
174 | ) . " WHERE `tpl_module` = '" . $module->getVar( |
||
175 | 'dirname', |
||
176 | 'n' |
||
177 | ) . "' AND `tpl_file` LIKE '%.html%'"; |
||
178 | $GLOBALS['xoopsDB']->queryF($sql); |
||
179 | |||
180 | return true; |
||
181 | } |
||
380 |