suico_iteminfo()

Complexity

Conditions	5
Paths	5

Size

Total Lines	64
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php declare(strict_types=1);
function suico_iteminfo($category, $item_id)
{
    $moduleHandler = xoops_getHandler('module');
    $module        = $moduleHandler->getByDirname('suico');

The method getByDirname() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsModuleHandler or XoopsPersistableObjectHandler.

    if ('global' === $category) {
        $item['name'] = '';

$item was never initialized. Although not strictly required by PHP, it is generally a good practice to add $item = array(); before regardless.

        $item['url']  = '';

        return $item;
    }
    global $xoopsDB;
    if ('picture' === $category) {
        $sql          = 'SELECT title,uid_owner,filename FROM ' . $xoopsDB->prefix(
                'suico_images'
            ) . ' WHERE uid_owner = ' . $item_id . ' LIMIT 1';
        $result       = $xoopsDB->query($sql);
        $result_array = $xoopsDB->fetchArray($result);
        /**
         * Let's get the user name of the owner of the album
         */
        $owner        = new \XoopsUser();
        $identifier   = $owner::getUnameFromId($result_array['uid_owner']);
        $item['name'] = $identifier . "'s Album";
        $item['url']  = XOOPS_URL . '/modules/' . $module->getVar(
                'dirname'
            ) . '/album.php?uid=' . $result_array['uid_owner'];

        return $item;
    }
    if ('video' === $category) {
        $sql          = 'SELECT video_id,uid_owner,video_title,video_desc,youtube_code, featuredvideo FROM ' . $xoopsDB->prefix(
                'suico_images'
            ) . ' WHERE uid_owner = ' . $item_id . ' LIMIT 1';
        $result       = $xoopsDB->query($sql);
        $result_array = $xoopsDB->fetchArray($result);
        /**
         * Let's get the user name of the owner of the album
         */
        $owner        = new \XoopsUser();
        $identifier   = $owner::getUnameFromId($result_array['uid_owner']);
        $item['name'] = $identifier . "'s Videos";
        $item['url']  = XOOPS_URL . '/modules/' . $module->getVar(
                'dirname'
            ) . '/videos.php?uid=' . $result_array['uid_owner'];

        return $item;
    }
    if ('Note' === $category) {
        $sql          = 'SELECT note_id, note_from, note_to, note_text FROM ' . $xoopsDB->prefix(
                'suico_notes'
            ) . ' WHERE note_from = ' . $item_id . ' LIMIT 1';
        $result       = $xoopsDB->query($sql);
        $result_array = $xoopsDB->fetchArray($result);
        /**
         * Let's get the user name of the owner of the album
         */
        $owner        = new \XoopsUser();
        $identifier   = $owner::getUnameFromId($result_array['note_from']);
        $item['name'] = $identifier . "'s Notes";
        $item['url']  = XOOPS_URL . '/modules/' . $module->getVar(
                'dirname'
            ) . '/notebook.php?uid=' . $result_array['note_from'];

        return $item;
    }