| Conditions | 42 |
| Paths | 14961 |
| Total Lines | 117 |
| Code Lines | 95 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php declare(strict_types=1); |
||
| 73 | public function insert(\XoopsObject $object, $force = false) |
||
| 74 | { |
||
| 75 | if (!($object instanceof $this->className)) { |
||
| 76 | return false; |
||
| 77 | } |
||
| 78 | /** @var Suico\ProfileHandler $profileHandler */ |
||
| 79 | $profileHandler = Helper::getInstance()->getHandler('Profile'); |
||
| 80 | $object->setVar('field_name', \str_replace(' ', '_', $object->getVar('field_name'))); |
||
| 81 | $object->cleanVars(); |
||
| 82 | $defaultstring = ''; |
||
|
|
|||
| 83 | switch ($object->getVar('field_type')) { |
||
| 84 | case 'datetime': |
||
| 85 | case 'date': |
||
| 86 | $object->setVar('field_valuetype', \XOBJ_DTYPE_INT); |
||
| 87 | $object->setVar('field_maxlength', 10); |
||
| 88 | break; |
||
| 89 | case 'longdate': |
||
| 90 | $object->setVar('field_valuetype', \XOBJ_DTYPE_MTIME); |
||
| 91 | break; |
||
| 92 | case 'yesno': |
||
| 93 | $object->setVar('field_valuetype', \XOBJ_DTYPE_INT); |
||
| 94 | $object->setVar('field_maxlength', 1); |
||
| 95 | break; |
||
| 96 | case 'textbox': |
||
| 97 | if (\XOBJ_DTYPE_INT != $object->getVar('field_valuetype')) { |
||
| 98 | $object->setVar('field_valuetype', \XOBJ_DTYPE_TXTBOX); |
||
| 99 | } |
||
| 100 | break; |
||
| 101 | case 'autotext': |
||
| 102 | if (\XOBJ_DTYPE_INT != $object->getVar('field_valuetype')) { |
||
| 103 | $object->setVar('field_valuetype', \XOBJ_DTYPE_TXTAREA); |
||
| 104 | } |
||
| 105 | break; |
||
| 106 | case 'group_multi': |
||
| 107 | case 'select_multi': |
||
| 108 | case 'checkbox': |
||
| 109 | $object->setVar('field_valuetype', \XOBJ_DTYPE_ARRAY); |
||
| 110 | break; |
||
| 111 | case 'language': |
||
| 112 | case 'timezone': |
||
| 113 | case 'theme': |
||
| 114 | $object->setVar('field_valuetype', \XOBJ_DTYPE_TXTBOX); |
||
| 115 | break; |
||
| 116 | case 'dhtml': |
||
| 117 | case 'textarea': |
||
| 118 | $object->setVar('field_valuetype', \XOBJ_DTYPE_TXTAREA); |
||
| 119 | break; |
||
| 120 | } |
||
| 121 | if ('' === $object->getVar('field_valuetype')) { |
||
| 122 | $object->setVar('field_valuetype', \XOBJ_DTYPE_TXTBOX); |
||
| 123 | } |
||
| 124 | if ((!\in_array($object->getVar('field_name'), $this->getUserVars(), true)) && isset($_REQUEST['field_required'])) { |
||
| 125 | if ($object->isNew()) { |
||
| 126 | //add column to table |
||
| 127 | $changetype = 'ADD'; |
||
| 128 | } else { |
||
| 129 | //update column information |
||
| 130 | $changetype = 'MODIFY COLUMN'; |
||
| 131 | } |
||
| 132 | $maxlengthstring = $object->getVar('field_maxlength') > 0 ? '(' . $object->getVar('field_maxlength') . ')' : ''; |
||
| 133 | //set type |
||
| 134 | switch ($object->getVar('field_valuetype')) { |
||
| 135 | default: |
||
| 136 | case \XOBJ_DTYPE_ARRAY: |
||
| 137 | case \XOBJ_DTYPE_UNICODE_ARRAY: |
||
| 138 | $type = 'mediumtext'; |
||
| 139 | $maxlengthstring = ''; |
||
| 140 | break; |
||
| 141 | case \XOBJ_DTYPE_UNICODE_EMAIL: |
||
| 142 | case \XOBJ_DTYPE_UNICODE_TXTBOX: |
||
| 143 | case \XOBJ_DTYPE_UNICODE_URL: |
||
| 144 | case \XOBJ_DTYPE_EMAIL: |
||
| 145 | case \XOBJ_DTYPE_TXTBOX: |
||
| 146 | case \XOBJ_DTYPE_URL: |
||
| 147 | $type = 'varchar'; |
||
| 148 | // varchars must have a maxlength |
||
| 149 | if (!$maxlengthstring) { |
||
| 150 | //so set it to max if maxlength is not set - or should it fail? |
||
| 151 | $maxlengthstring = '(255)'; |
||
| 152 | $object->setVar('field_maxlength', 255); |
||
| 153 | } |
||
| 154 | break; |
||
| 155 | case \XOBJ_DTYPE_INT: |
||
| 156 | $type = 'int'; |
||
| 157 | break; |
||
| 158 | case \XOBJ_DTYPE_DECIMAL: |
||
| 159 | $type = 'decimal(14,6)'; |
||
| 160 | break; |
||
| 161 | case \XOBJ_DTYPE_FLOAT: |
||
| 162 | $type = 'float(15,9)'; |
||
| 163 | break; |
||
| 164 | case \XOBJ_DTYPE_OTHER: |
||
| 165 | case \XOBJ_DTYPE_UNICODE_TXTAREA: |
||
| 166 | case \XOBJ_DTYPE_TXTAREA: |
||
| 167 | $type = 'text'; |
||
| 168 | $maxlengthstring = ''; |
||
| 169 | break; |
||
| 170 | case \XOBJ_DTYPE_MTIME: |
||
| 171 | $type = 'date'; |
||
| 172 | $maxlengthstring = ''; |
||
| 173 | break; |
||
| 174 | } |
||
| 175 | $sql = 'ALTER TABLE `' . $profileHandler->table . '` ' . $changetype . ' `' . $object->cleanVars['field_name'] . '` ' . $type . $maxlengthstring . ' NULL'; |
||
| 176 | $result = $force ? $this->db->queryF($sql) : $this->db->query($sql); |
||
| 177 | if (!$result) { |
||
| 178 | $object->setErrors($this->db->error()); |
||
| 179 | |||
| 180 | return false; |
||
| 181 | } |
||
| 182 | } |
||
| 183 | //change this to also update the cached field information storage |
||
| 184 | $object->setDirty(); |
||
| 185 | if (!parent::insert($object, $force)) { |
||
| 186 | return false; |
||
| 187 | } |
||
| 188 | |||
| 189 | return $object->getVar('field_id'); |
||
| 190 | } |
||
| 268 |