Conditions | 42 |
Paths | 14961 |
Total Lines | 115 |
Code Lines | 95 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
77 | public function insert(\XoopsObject $obj, $force = false) |
||
78 | { |
||
79 | if (!($obj instanceof $this->className)) { |
||
80 | return false; |
||
81 | } |
||
82 | /* @var Suico\ProfileHandler $profileHandler */ |
||
83 | $profileHandler = Helper::getInstance()->getHandler('Profile'); |
||
84 | $obj->setVar('field_name', \str_replace(' ', '_', $obj->getVar('field_name'))); |
||
85 | $obj->cleanVars(); |
||
86 | $defaultstring = ''; |
||
|
|||
87 | switch ($obj->getVar('field_type')) { |
||
88 | case 'datetime': |
||
89 | case 'date': |
||
90 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_INT); |
||
91 | $obj->setVar('field_maxlength', 10); |
||
92 | break; |
||
93 | case 'longdate': |
||
94 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_MTIME); |
||
95 | break; |
||
96 | case 'yesno': |
||
97 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_INT); |
||
98 | $obj->setVar('field_maxlength', 1); |
||
99 | break; |
||
100 | case 'textbox': |
||
101 | if (\XOBJ_DTYPE_INT != $obj->getVar('field_valuetype')) { |
||
102 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_TXTBOX); |
||
103 | } |
||
104 | break; |
||
105 | case 'autotext': |
||
106 | if (\XOBJ_DTYPE_INT != $obj->getVar('field_valuetype')) { |
||
107 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_TXTAREA); |
||
108 | } |
||
109 | break; |
||
110 | case 'group_multi': |
||
111 | case 'select_multi': |
||
112 | case 'checkbox': |
||
113 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_ARRAY); |
||
114 | break; |
||
115 | case 'language': |
||
116 | case 'timezone': |
||
117 | case 'theme': |
||
118 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_TXTBOX); |
||
119 | break; |
||
120 | case 'dhtml': |
||
121 | case 'textarea': |
||
122 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_TXTAREA); |
||
123 | break; |
||
124 | } |
||
125 | if ('' === $obj->getVar('field_valuetype')) { |
||
126 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_TXTBOX); |
||
127 | } |
||
128 | if ((!\in_array($obj->getVar('field_name'), $this->getUserVars())) && isset($_REQUEST['field_required'])) { |
||
129 | if ($obj->isNew()) { |
||
130 | //add column to table |
||
131 | $changetype = 'ADD'; |
||
132 | } else { |
||
133 | //update column information |
||
134 | $changetype = 'MODIFY COLUMN'; |
||
135 | } |
||
136 | $maxlengthstring = $obj->getVar('field_maxlength') > 0 ? '(' . $obj->getVar('field_maxlength') . ')' : ''; |
||
137 | //set type |
||
138 | switch ($obj->getVar('field_valuetype')) { |
||
139 | default: |
||
140 | case \XOBJ_DTYPE_ARRAY: |
||
141 | case \XOBJ_DTYPE_UNICODE_ARRAY: |
||
142 | $type = 'mediumtext'; |
||
143 | $maxlengthstring = ''; |
||
144 | break; |
||
145 | case \XOBJ_DTYPE_UNICODE_EMAIL: |
||
146 | case \XOBJ_DTYPE_UNICODE_TXTBOX: |
||
147 | case \XOBJ_DTYPE_UNICODE_URL: |
||
148 | case \XOBJ_DTYPE_EMAIL: |
||
149 | case \XOBJ_DTYPE_TXTBOX: |
||
150 | case \XOBJ_DTYPE_URL: |
||
151 | $type = 'varchar'; |
||
152 | // varchars must have a maxlength |
||
153 | if (!$maxlengthstring) { |
||
154 | //so set it to max if maxlength is not set - or should it fail? |
||
155 | $maxlengthstring = '(255)'; |
||
156 | $obj->setVar('field_maxlength', 255); |
||
157 | } |
||
158 | break; |
||
159 | case \XOBJ_DTYPE_INT: |
||
160 | $type = 'int'; |
||
161 | break; |
||
162 | case \XOBJ_DTYPE_DECIMAL: |
||
163 | $type = 'decimal(14,6)'; |
||
164 | break; |
||
165 | case \XOBJ_DTYPE_FLOAT: |
||
166 | $type = 'float(15,9)'; |
||
167 | break; |
||
168 | case \XOBJ_DTYPE_OTHER: |
||
169 | case \XOBJ_DTYPE_UNICODE_TXTAREA: |
||
170 | case \XOBJ_DTYPE_TXTAREA: |
||
171 | $type = 'text'; |
||
172 | $maxlengthstring = ''; |
||
173 | break; |
||
174 | case \XOBJ_DTYPE_MTIME: |
||
175 | $type = 'date'; |
||
176 | $maxlengthstring = ''; |
||
177 | break; |
||
178 | } |
||
179 | $sql = 'ALTER TABLE `' . $profileHandler->table . '` ' . $changetype . ' `' . $obj->cleanVars['field_name'] . '` ' . $type . $maxlengthstring . ' NULL'; |
||
180 | $result = $force ? $this->db->queryF($sql) : $this->db->query($sql); |
||
181 | if (!$result) { |
||
182 | $obj->setErrors($this->db->error()); |
||
183 | return false; |
||
184 | } |
||
185 | } |
||
186 | //change this to also update the cached field information storage |
||
187 | $obj->setDirty(); |
||
188 | if (!parent::insert($obj, $force)) { |
||
189 | return false; |
||
190 | } |
||
191 | return $obj->getVar('field_id'); |
||
192 | } |
||
268 |