XoopsModules\Suico\NotesController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	fetchNotes()	0	10	2
A	checkPrivilege()	0	25	5

<?php declare(strict_types=1);

namespace XoopsModules\Suico;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

use Criteria;

/**
 * @category        Module
 * @copyright       {@link https://xoops.org/ XOOPS Project}
 * @license         GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author          Marcello Brandão aka  Suico, Mamba, LioMJ  <https://xoops.org>
 */
require_once XOOPS_ROOT_PATH . '/kernel/object.php';
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
require_once XOOPS_ROOT_PATH . '/class/criteria.php';
require_once XOOPS_ROOT_PATH . '/class/pagenav.php';

/**
 * Class NotesController
 */
class NotesController extends Controller
{
    /**
     * @param                                      $countNotes
     * @param \CriteriaElement|\CriteriaCompo|null $criteria
     * @return bool|array
     */
    public function fetchNotes(
        $countNotes,
        $criteria
    ) {
        $notes = $this->notesFactory->getNotes($countNotes, $criteria);
        if ($notes) {
            return $notes;
        }

        return false;
    }

    /**
     * @param string $privilegeType
     * @return bool|void
     */
    public function checkPrivilege(
        $privilegeType = ''
    ) {
        if (0 === $this->helper->getConfig('enable_notes')) {
            \redirect_header('index.php?uid=' . $this->owner->getVar('uid'), 3, \_MD_SUICO_NOTES_ENABLED_NOT);
        }
        if ('sendNotes' === $privilegeType) {
            $criteria = new Criteria('config_uid', $this->owner->getVar('uid'));

It seems like $this->owner->getVar('uid') can also be of type array and array; however, parameter $value of Criteria::__construct() does only seem to accept string, maybe add an additional type check?

            if (1 === $this->configsFactory->getCount($criteria)) {
                $configs = $this->configsFactory->getObjects($criteria);
                $config  = $configs[0]->getVar('sendNotes');

The assignment to $config is dead and can be removed.

            }
        }
        $criteria = new Criteria('config_uid', $this->owner->getVar('uid'));
        if (1 === $this->configsFactory->getCount($criteria)) {
            $configs = $this->configsFactory->getObjects($criteria);
            $config  = $configs[0]->getVar('notes');
            /*
            if (!$this->checkPrivilegeLevel($config)) {
                \redirect_header('index.php?uid=' . $this->owner->getVar('uid'), 10, sprintf(_MD_SUICO_NOPRIVILEGE,'Notes'));
            }
            */
        }

        return true;
    }
}