XoopsModules25x /
suico
| Total Complexity | 46 |
| Total Lines | 341 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like IshotHandler often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use IshotHandler, and based on these observations, apply Extract Interface, too.
| 1 | <?php declare(strict_types=1); |
||
| 32 | class IshotHandler extends XoopsPersistableObjectHandler |
||
| 33 | { |
||
| 34 | public Helper $helper; |
||
| 35 | public $isAdmin; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * Constructor |
||
| 39 | * @param \XoopsDatabase|null $xoopsDatabase |
||
| 40 | * @param \XoopsModules\Suico\Helper|null $helper |
||
| 41 | */ |
||
| 42 | public function __construct( |
||
| 43 | ?XoopsDatabase $xoopsDatabase = null, |
||
| 44 | $helper = null |
||
| 45 | ) { |
||
| 46 | /** @var \XoopsModules\Suico\Helper $this- >helper */ |
||
| 47 | if (null === $helper) { |
||
| 48 | $this->helper = Helper::getInstance(); |
||
| 49 | } else { |
||
| 50 | $this->helper = $helper; |
||
| 51 | } |
||
| 52 | $this->isAdmin = $this->helper->isUserAdmin(); |
||
| 53 | // parent::__construct($db, 'suico_groups', Image::class, 'group_id', 'group_title'); |
||
| 54 | } |
||
| 55 | |||
| 56 | /** |
||
| 57 | * create a new Groups |
||
| 58 | * |
||
| 59 | * @param bool $isNew flag the new objects as "new"? |
||
| 60 | * @return \XoopsObject Groups |
||
| 61 | */ |
||
| 62 | public function create( |
||
| 63 | $isNew = true |
||
| 64 | ) { |
||
| 65 | $obj = parent::create($isNew); |
||
| 66 | if ($isNew) { |
||
| 67 | $obj->setNew(); |
||
| 68 | } else { |
||
| 69 | $obj->unsetNew(); |
||
| 70 | } |
||
| 71 | $obj->helper = $this->helper; |
||
| 72 | |||
| 73 | return $obj; |
||
| 74 | } |
||
| 75 | |||
| 76 | /** |
||
| 77 | * retrieve a Ishot |
||
| 78 | * |
||
| 79 | * @param int|null $id of the Ishot |
||
| 80 | * @param null $fields |
||
|
Documentation
Bug
introduced
by
|
|||
| 81 | * @return false|\XoopsModules\Suico\Ishot reference to the {@link Ishot} object, FALSE if failed |
||
| 82 | */ |
||
| 83 | public function get2( |
||
| 84 | $id = null, |
||
| 85 | $fields = null |
||
| 86 | ) { |
||
| 87 | $sql = 'SELECT * FROM ' . $this->db->prefix('suico_ishot') . ' WHERE cod_ishot=' . $id; |
||
| 88 | if (!$result = $this->db->query($sql)) { |
||
| 89 | return false; |
||
| 90 | } |
||
| 91 | $numrows = $this->db->getRowsNum($result); |
||
| 92 | if (1 === $numrows) { |
||
| 93 | $suico_ishot = new Ishot(); |
||
| 94 | $suico_ishot->assignVars($this->db->fetchArray($result)); |
||
| 95 | |||
| 96 | return $suico_ishot; |
||
| 97 | } |
||
| 98 | |||
| 99 | return false; |
||
| 100 | } |
||
| 101 | |||
| 102 | /** |
||
| 103 | * insert a new Ishot in the database |
||
| 104 | * |
||
| 105 | * @param \XoopsObject $object reference to the {@link Ishot} |
||
| 106 | * object |
||
| 107 | * @param bool $force |
||
| 108 | * @return bool FALSE if failed, TRUE if already present and unchanged or successful |
||
| 109 | */ |
||
| 110 | public function insert2( |
||
| 111 | XoopsObject $object, |
||
| 112 | $force = false |
||
| 113 | ) { |
||
| 114 | global $xoopsConfig; |
||
| 115 | if (!$object instanceof Ishot) { |
||
| 116 | return false; |
||
| 117 | } |
||
| 118 | if (!$object->isDirty()) { |
||
| 119 | return true; |
||
| 120 | } |
||
| 121 | if (!$object->cleanVars()) { |
||
| 122 | return false; |
||
| 123 | } |
||
| 124 | $ishot = ''; |
||
| 125 | $uid_voted = ''; |
||
| 126 | $uid_voter = ''; |
||
| 127 | $cod_ishot = ''; |
||
| 128 | foreach ($object->cleanVars as $k => $v) { |
||
| 129 | ${$k} = $v; |
||
| 130 | } |
||
| 131 | // $now = 'date_add(now(), interval ' . $xoopsConfig['server_TZ'] . ' hour)'; |
||
| 132 | if ($object->isNew()) { |
||
| 133 | // ajout/modification d'un Ishot |
||
| 134 | $object = new Ishot(); |
||
| 135 | $format = 'INSERT INTO %s (cod_ishot, uid_voter, uid_voted, ishot, DATE)'; |
||
| 136 | $format .= 'VALUES (%u, %u, %u, %u, %s)'; |
||
| 137 | $sql = \sprintf( |
||
| 138 | $format, |
||
| 139 | $this->db->prefix('suico_ishot'), |
||
| 140 | $cod_ishot, |
||
| 141 | $uid_voter, |
||
| 142 | $uid_voted, |
||
| 143 | $ishot, |
||
| 144 | $this->db->quoteString($date) |
||
| 145 | ); |
||
| 146 | $force = true; |
||
| 147 | } else { |
||
| 148 | $format = 'UPDATE %s SET '; |
||
| 149 | $format .= 'cod_ishot=%u, uid_voter=%u, uid_voted=%u, ishot=%u, date_created=%s'; |
||
| 150 | $format .= ' WHERE cod_ishot = %u'; |
||
| 151 | $sql = \sprintf( |
||
| 152 | $format, |
||
| 153 | $this->db->prefix('suico_ishot'), |
||
| 154 | $cod_ishot, |
||
| 155 | $uid_voter, |
||
| 156 | $uid_voted, |
||
| 157 | $ishot, |
||
| 158 | $this->db->quoteString($date), |
||
| 159 | $cod_ishot |
||
| 160 | ); |
||
| 161 | } |
||
| 162 | if ($force) { |
||
| 163 | $result = $this->db->queryF($sql); |
||
| 164 | } else { |
||
| 165 | $result = $this->db->query($sql); |
||
| 166 | } |
||
| 167 | if (!$result) { |
||
| 168 | return false; |
||
| 169 | } |
||
| 170 | if (empty($cod_ishot)) { |
||
| 171 | $cod_ishot = $this->db->getInsertId(); |
||
| 172 | } |
||
| 173 | $object->assignVar('cod_ishot', $cod_ishot); |
||
| 174 | |||
| 175 | return true; |
||
| 176 | } |
||
| 177 | |||
| 178 | /** |
||
| 179 | * delete a Ishot from the database |
||
| 180 | * |
||
| 181 | * @param \XoopsObject $object reference to the Ishot to delete |
||
| 182 | * @param bool $force |
||
| 183 | * @return bool FALSE if failed. |
||
| 184 | */ |
||
| 185 | public function delete( |
||
| 186 | XoopsObject $object, |
||
| 187 | $force = false |
||
| 188 | ) { |
||
| 189 | if (!$object instanceof Ishot) { |
||
| 190 | return false; |
||
| 191 | } |
||
| 192 | $sql = \sprintf( |
||
| 193 | 'DELETE FROM %s WHERE cod_ishot = %u', |
||
| 194 | $this->db->prefix('suico_ishot'), |
||
| 195 | (int)$object->getVar('cod_ishot') |
||
| 196 | ); |
||
| 197 | if ($force) { |
||
| 198 | $result = $this->db->queryF($sql); |
||
| 199 | } else { |
||
| 200 | $result = $this->db->query($sql); |
||
| 201 | } |
||
| 202 | if (!$result) { |
||
| 203 | return false; |
||
| 204 | } |
||
| 205 | |||
| 206 | return true; |
||
| 207 | } |
||
| 208 | |||
| 209 | /** |
||
| 210 | * retrieve suico_ishots from the database |
||
| 211 | * |
||
| 212 | * @param \CriteriaElement|\CriteriaCompo|null $criteria {@link \CriteriaElement} conditions to be met |
||
| 213 | * @param bool $id_as_key use the UID as key for the array? |
||
| 214 | * @param bool $as_object |
||
| 215 | * @return array array of {@link Ishot} objects |
||
| 216 | */ |
||
| 217 | public function &getObjects( |
||
| 218 | ?CriteriaElement $criteria = null, |
||
| 219 | $id_as_key = false, |
||
| 220 | $as_object = true |
||
| 221 | ) { |
||
| 222 | $ret = []; |
||
| 223 | $start = 0; |
||
| 224 | $limit = 0; |
||
| 225 | $sql = 'SELECT * FROM ' . $this->db->prefix('suico_ishot'); |
||
| 226 | if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) { |
||
| 227 | $sql .= ' ' . $criteria->renderWhere(); |
||
| 228 | if ('' !== $criteria->getSort()) { |
||
| 229 | $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder(); |
||
| 230 | } |
||
| 231 | $limit = $criteria->getLimit(); |
||
| 232 | $start = $criteria->getStart(); |
||
| 233 | } |
||
| 234 | $result = $this->db->query($sql, $limit, $start); |
||
| 235 | if (!$result) { |
||
| 236 | return $ret; |
||
| 237 | } |
||
| 238 | while (false !== ($myrow = $this->db->fetchArray($result))) { |
||
| 239 | $suico_ishot = new Ishot(); |
||
| 240 | $suico_ishot->assignVars($myrow); |
||
| 241 | if ($id_as_key) { |
||
| 242 | $ret[$myrow['cod_ishot']] = &$suico_ishot; |
||
| 243 | } else { |
||
| 244 | $ret[] = &$suico_ishot; |
||
| 245 | } |
||
| 246 | unset($suico_ishot); |
||
| 247 | } |
||
| 248 | |||
| 249 | return $ret; |
||
| 250 | } |
||
| 251 | |||
| 252 | /** |
||
| 253 | * count suico_ishots matching a condition |
||
| 254 | * |
||
| 255 | * @param \CriteriaElement|\CriteriaCompo|null $criteria {@link CriteriaElement} to match |
||
| 256 | * @return int count of suico_ishots |
||
| 257 | */ |
||
| 258 | public function getCount( |
||
| 259 | ?CriteriaElement $criteria = null |
||
| 260 | ) { |
||
| 261 | $sql = 'SELECT COUNT(*) FROM ' . $this->db->prefix('suico_ishot'); |
||
| 262 | if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) { |
||
| 263 | $sql .= ' ' . $criteria->renderWhere(); |
||
| 264 | } |
||
| 265 | $result = $this->db->query($sql); |
||
| 266 | if (!$result) { |
||
| 267 | return 0; |
||
| 268 | } |
||
| 269 | [$count] = $this->db->fetchRow($result); |
||
| 270 | |||
| 271 | return $count; |
||
| 272 | } |
||
| 273 | |||
| 274 | /** |
||
| 275 | * delete suico_ishots matching a set of conditions |
||
| 276 | * |
||
| 277 | * @param \CriteriaElement|\CriteriaCompo|null $criteria {@link CriteriaElement} |
||
| 278 | * @param bool $force |
||
| 279 | * @param bool $asObject |
||
| 280 | * @return bool FALSE if deletion failed |
||
| 281 | */ |
||
| 282 | public function deleteAll( |
||
| 283 | ?CriteriaElement $criteria = null, |
||
| 284 | $force = true, |
||
| 285 | $asObject = false |
||
| 286 | ) { |
||
| 287 | $sql = 'DELETE FROM ' . $this->db->prefix('suico_ishot'); |
||
| 288 | if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) { |
||
| 289 | $sql .= ' ' . $criteria->renderWhere(); |
||
| 290 | } |
||
| 291 | if (!$result = $this->db->query($sql)) { |
||
| 292 | return false; |
||
| 293 | } |
||
| 294 | |||
| 295 | return true; |
||
| 296 | } |
||
| 297 | |||
| 298 | /** |
||
| 299 | * @param null $criteria |
||
| 300 | * @return array |
||
| 301 | */ |
||
| 302 | public function getHottest($criteria = null) |
||
| 303 | { |
||
| 304 | $sql = 'SELECT DISTINCTROW uname, user_avatar, uid_voted, COUNT(cod_ishot) AS qtd FROM ' . $this->db->prefix( |
||
| 305 | 'suico_ishot' |
||
| 306 | ) . ', ' . $this->db->prefix( |
||
| 307 | 'users' |
||
| 308 | ); |
||
| 309 | if (($criteria instanceof \CriteriaCompo) || ($criteria instanceof \Criteria)) { |
||
| 310 | $sql .= ' ' . $criteria->renderWhere(); |
||
| 311 | } |
||
| 312 | //attention here this is kind of a hack |
||
| 313 | $sql .= ' AND uid = uid_voted'; |
||
| 314 | if ('' !== $criteria->getGroupby()) { |
||
| 315 | $sql .= $criteria->getGroupby(); |
||
| 316 | } |
||
| 317 | if ('' !== $criteria->getSort()) { |
||
| 318 | $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder(); |
||
| 319 | } |
||
| 320 | $limit = $criteria->getLimit(); |
||
| 321 | $start = $criteria->getStart(); |
||
| 322 | $result = $this->db->query($sql, $limit, $start); |
||
| 323 | $vetor = []; |
||
| 324 | $i = 0; |
||
| 325 | while (false !== ($myrow = $this->db->fetchArray($result))) { |
||
| 326 | $vetor[$i]['qtd'] = $myrow['qtd']; |
||
| 327 | $vetor[$i]['uid_voted'] = $myrow['uid_voted']; |
||
| 328 | $vetor[$i]['uname'] = $myrow['uname']; |
||
| 329 | $vetor[$i]['user_avatar'] = $myrow['user_avatar']; |
||
| 330 | $i++; |
||
| 331 | } |
||
| 332 | |||
| 333 | return $vetor; |
||
| 334 | } |
||
| 335 | |||
| 336 | /** |
||
| 337 | * @param null $criteria |
||
| 338 | * @param bool $id_as_key |
||
| 339 | * @return array |
||
| 340 | */ |
||
| 341 | public function getHotFriends( |
||
| 373 | } |
||
| 374 | } |
||
| 375 | } |
||
| 376 |
Loading history...