b_hitcounter_show()

Complexity

Conditions	12
Paths	60

Size

Total Lines	89
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
function b_hitcounter_show($options)
{
    global $xoopsDB;
    $block    = [];
    $myts     = \MyTextSanitizer::getInstance();

The assignment to $myts is dead and can be removed.

    $result   = $xoopsDB->queryF('SELECT year, hits FROM ' . $xoopsDB->prefix('stats_year'));
    $counter  = 0;
    $yearhits = [];
    $cnt      = 0;
    while (list($year, $hits) = $xoopsDB->fetchRow($result)) {
        $counter += $hits;  // figure out total hits

        $yearhits[$cnt]['year']    = $year;
        $yearhits[$cnt]['counter'] = '';
        if (mb_strlen($hits) < 5) {
            $hits = sprintf('%05d', $hits);
        }
        for ($i = 0, $iMax = mb_strlen($hits); $i < $iMax; ++$i) {
            //the <img src> tag
            $imgsrc                    = mb_substr($hits, $i, 1);
            $yearhits[$cnt]['counter'] .= '<img src="' . XOOPS_URL . '/modules/statistics/assets/images/' . $imgsrc . '.gif" border = "0">';
        }

        ++$cnt;
    }

    //number images are stored in the images directory
    //and are numbered from 0.gif to 9.gif
    //loop through the values of $counter and
    //use the strlen function to check the length of $counter
    $cnt_graphic = '';
    if (mb_strlen($counter) < 5) {
        $counter = sprintf('%05d', $counter);
    }
    for ($i = 0, $iMax = mb_strlen($counter); $i < $iMax; ++$i) {
        //the <img src> tag
        $imgsrc      = mb_substr($counter, $i, 1);
        $cnt_graphic .= '<img src="' . XOOPS_URL . '/modules/statistics/assets/images/' . $imgsrc . '.gif" border = "0">';
    }

    if ('1' == $options[1]) { // check to see if we should show the blocked hits
        $result    = $xoopsDB->queryF('SELECT year, hits FROM ' . $xoopsDB->prefix('stats_blockedyear'));
        $bcounter  = 0;
        $byearhits = [];
        $cnt       = 0;
        while (list($year, $hits) = $xoopsDB->fetchRow($result)) {
            $bcounter += $hits;  // figure out total hits

            $byearhits[$cnt]['year']    = $year;
            $byearhits[$cnt]['counter'] = '';
            if (mb_strlen($hits) < 5) {
                $hits = sprintf('%05d', $hits);
            }
            for ($i = 0, $iMax = mb_strlen($hits); $i < $iMax; ++$i) {
                //the <img src> tag
                $imgsrc                     = mb_substr($hits, $i, 1);
                $byearhits[$cnt]['counter'] .= '<img src="' . XOOPS_URL . '/modules/statistics/assets/images/' . $imgsrc . '.gif" border = "0">';
            }

            ++$cnt;
        }

        //number images are stored in the images directory
        //and are numbered from 0.gif to 9.gif
        //loop through the values of $counter and
        //use the strlen function to check the length of $counter
        $bcnt_graphic = '';
        if (mb_strlen($bcounter) < 5) {
            $bcounter = sprintf('%05d', $bcounter);
        }
        for ($i = 0, $iMax = mb_strlen($bcounter); $i < $iMax; ++$i) {
            //the <img src> tag
            $imgsrc       = mb_substr($bcounter, $i, 1);
            $bcnt_graphic .= '<img src="' . XOOPS_URL . '/modules/statistics/assets/images/' . $imgsrc . '.gif" border = "0">';
        }
    }

    $block['display']            = $options[0];
    $block['displayblockedhits'] = $options[1];
    $block['counterhead']        = B_STATS_CNTHEAD;
    $block['bcounterhead']       = B_STATS_BLOCKED_CNTHEAD;
    $block['yearhead']           = B_STATS_YRHEAD;
    $block['byearhead']          = B_STATS_BLOCKED_YRHEAD;
    $block['counter']            = $cnt_graphic;
    $block['bcounter']           = $bcnt_graphic;

The variable $bcnt_graphic does not seem to be defined for all execution paths leading up to this point.

    $block['yearhits']           = $yearhits;
    $block['byearhits']          = $byearhits;

The variable $byearhits does not seem to be defined for all execution paths leading up to this point.

    return $block;
}