songlist_songs_get_form()

Complexity

Conditions	69
Paths	> 20000

Size

Total Lines	157
Code Lines	121

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	function songlist_songs_get_form($object, $as_array=false) {
		
		if (!is_object($object)) {
			$handler = xoops_getmodulehandler('songs', 'songlist');
			$object = $handler->create(); 
		}
		
		xoops_loadLanguage('forms', 'songlist');
		$ele = array();
		
		if ($object->isNew()) {
			$sform = new XoopsThemeForm(_FRM_SONGLIST_FORM_ISNEW_SONGS, 'songs', $_SERVER['PHP_SELF'], 'post');
			$ele['mode'] = new XoopsFormHidden('mode', 'new');
		} else {
			$sform = new XoopsThemeForm(_FRM_SONGLIST_FORM_EDIT_SONGS, 'songs', $_SERVER['PHP_SELF'], 'post');
			$ele['mode'] = new XoopsFormHidden('mode', 'edit');
		}
		
		$sform->setExtra( "enctype='multipart/form-data'" ) ;
		
		$id = $object->getVar('sid');
		if (empty($id)) $id = '0';
		
		$ele['op'] = new XoopsFormHidden('op', 'songs');
		$ele['fct'] = new XoopsFormHidden('fct', 'save');
		if ($as_array==false)
			$ele['id'] = new XoopsFormHidden('id', $id);
		else 
			$ele['id'] = new XoopsFormHidden('id['.$id.']', $id);
		$ele['sort'] = new XoopsFormHidden('sort', isset($_REQUEST['sort'])?$_REQUEST['sort']:'created');
		$ele['order'] = new XoopsFormHidden('order', isset($_REQUEST['order'])?$_REQUEST['order']:'DESC');
		$ele['start'] = new XoopsFormHidden('start', isset($_REQUEST['start'])?intval($_REQUEST['start']):0);
		$ele['limit'] = new XoopsFormHidden('limit', isset($_REQUEST['limit'])?intval($_REQUEST['limit']):0);
		$ele['filter'] = new XoopsFormHidden('filter', isset($_REQUEST['filter'])?$_REQUEST['filter']:'1,1');

		$ele['cid'] = new SonglistFormSelectCategory(($as_array==false?_FRM_SONGLIST_FORM_SONGS_CATEGORY:''), $id.'[cid]', (isset($_REQUEST['cid'])?$_REQUEST['cid']:$object->getVar('cid')), 1, false);

The call to SonglistFormSelectCategory::__construct() has too many arguments starting with $as_array == false ? _FRM_SONGLIST_FORM_SONGS_CATEGORY : ''.

		$ele['cid']->setDescription(($as_array==false?_FRM_SONGLIST_FORM_SONGS_CATEGORY_DESC:''));
		if ($GLOBALS['songlistModuleConfig']['genre']) {
			$ele['gids'] = new SonglistFormSelectGenre(($as_array==false?_FRM_SONGLIST_FORM_SONGS_GENRE:''), $id.'[gids]', (isset($_REQUEST['gids'])?$_REQUEST['gids']:$object->getVar('gids')), 8, true);

The call to SonglistFormSelectGenre::__construct() has too many arguments starting with $as_array == false ? _FRM_SONGLIST_FORM_SONGS_GENRE : ''.

			$ele['gids']->setDescription(($as_array==false?_FRM_SONGLIST_FORM_SONGS_GENRE_DESC:''));
		}
		if ($GLOBALS['songlistModuleConfig']['voice']) {
			$ele['vcid'] = new SonglistFormSelectVoice(($as_array==false?_FRM_SONGLIST_FORM_SONGS_VOICE:''), $id.'[vcid]', (isset($_REQUEST['vcid'])?$_REQUEST['vcid']:$object->getVar('vcid')), 1, false);

The call to SonglistFormSelectVoice::__construct() has too many arguments starting with $as_array == false ? _FRM_SONGLIST_FORM_SONGS_VOICE : ''.

			$ele['vcid']->setDescription(($as_array==false?_FRM_SONGLIST_FORM_SONGS_VOICE_DESC:''));
		}		
		if ($GLOBALS['songlistModuleConfig']['album']) {
			$ele['abid'] = new SonglistFormSelectAlbum(($as_array==false?_FRM_SONGLIST_FORM_SONGS_ALBUM:''), $id.'[abid]', $object->getVar('abid'), 1, false);

The call to SonglistFormSelectAlbum::__construct() has too many arguments starting with $as_array == false ? _FRM_SONGLIST_FORM_SONGS_ALBUM : ''.

			$ele['abid']->setDescription(($as_array==false?_FRM_SONGLIST_FORM_SONGS_ALBUM_DESC:''));
		}
		$ele['aids'] = new SonglistFormSelectArtist(($as_array==false?_FRM_SONGLIST_FORM_SONGS_ARTISTS:''), $id.'[aids]', $object->getVar('aids'), 7, true);

The call to SonglistFormSelectArtist::__construct() has too many arguments starting with $as_array == false ? _FRM_SONGLIST_FORM_SONGS_ARTISTS : ''.

		$ele['aids']->setDescription(($as_array==false?_FRM_SONGLIST_FORM_SONGS_ARTISTS_DESC:''));
		$ele['songid'] = new XoopsFormText(($as_array==false?_FRM_SONGLIST_FORM_SONGS_SONGID:''), $id.'[songid]', ($as_array==false?25:15),32, $object->getVar('songid'));

It seems like $object->getVar('songid') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

		$ele['songid']->setDescription(($as_array==false?_FRM_SONGLIST_FORM_SONGS_SONGID_DESC:''));
		$ele['traxid'] = new XoopsFormText(($as_array==false?_FRM_SONGLIST_FORM_SONGS_TRAXID:''), $id.'[traxid]', ($as_array==false?25:15),32, $object->getVar('traxid'));
		$ele['traxid']->setDescription(($as_array==false?_FRM_SONGLIST_FORM_SONGS_TRAXID_DESC:''));
		$ele['title'] = new XoopsFormText(($as_array==false?_FRM_SONGLIST_FORM_SONGS_TITLE:''), $id.'[title]', ($as_array==false?55:21),128, $object->getVar('title'));
		$ele['title']->setDescription(($as_array==false?_FRM_SONGLIST_FORM_SONGS_TITLE_DESC:''));
		$description_configs = array();
		$description_configs['name'] = $id.'[lyrics]';
		$description_configs['value'] = $object->getVar('lyrics');
		$description_configs['rows'] = 35;
		$description_configs['cols'] = 60;
		$description_configs['width'] = "100%";
		$description_configs['height'] = "400px";
		$ele['lyrics'] = new XoopsFormEditor(_FRM_SONGLIST_FORM_SONGS_LYRICS, $GLOBALS['songlistModuleConfig']['editor'], $description_configs);
		$ele['lyrics']->setDescription(($as_array==false?_FRM_SONGLIST_FORM_SONGS_LYRICS_DESC:''));
		$ele['mp3'] = new XoopsFormFile(($as_array==false?_FRM_SONGLIST_FORM_SONGS_MP3:''), 'mp3'.$id, $GLOBALS['songlistModuleConfig']['mp3_filesize']);
		$ele['mp3']->setDescription(($as_array==false?_FRM_SONGLIST_FORM_SONGS_MP3_DESC:''));
		$category_handler = xoops_getmodulehandler('category', 'songlist');
		$criteria = new CriteriaCompo(new Criteria('cid', (!empty($_REQUEST['cid']))?intval($_REQUEST['cid']):$object->getVar('cid')));

It seems like ! empty($_REQUEST['cid']) ? intval($_REQUEST['cid']) : $object->getVar('cid') can also be of type array and array; however, parameter $value of Criteria::__construct() does only seem to accept string, maybe add an additional type check?

		$all_categories = $category_handler->getObjects($criteria, true, false);

		// Dynamic fields
		$extras_handler = xoops_getmodulehandler('extras');
		$gperm_handler = xoops_gethandler('groupperm');
		$module_handler = xoops_gethandler('module');
		$xoModule = $module_handler->getByDirname('songlist');
		$modid = $xoModule->getVar('mid');
		
		if (is_object($GLOBALS['xoopsUser']))
			$groups = $GLOBALS['xoopsUser']->getGroups();
		else
			$groups = array(XOOPS_GROUP_ANONYMOUS=>XOOPS_GROUP_ANONYMOUS);
		
		$count_fields = 0;
		$fields = $extras_handler->loadFields();
		
		$required = array();
		$elements = array();
		$weights = array();
		if ($object->getVar('sid')>0)
			$extra = $extras_handler->get($object->getVar('sid'));
		else
			$extra = $extras_handler->create();
		$allnames = array();
		if (is_array($fields)) {
			foreach (array_keys($fields) as $i) {
				if (($object->getVar('sid')<>0&&$gperm_handler->checkRight('songlist_edit',$fields[$i]->getVar('field_id'),$groups, $modid)) ||

The method checkRight() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsGroupPermHandler or XoopsPersistableObjectHandler.

					($object->getVar('sid')==0&&$gperm_handler->checkRight('songlist_post',$fields[$i]->getVar('field_id'),$groups, $modid))) {
					$fieldinfo['element'] = $fields[$i]->getEditElement($object, $extra);
					$fieldinfo['required'] = $fields[$i]->getVar('field_required');
					foreach($fields[$i]->getVar('cids') as $catidid => $cid) {
						if (!in_array($fields[$i]->getVar('field_name'), $allnames)) {
							$allnames[] = $fields[$i]->getVar('field_name');
							if (in_array($cid, array_keys($all_categories))||$cid==((!empty($_REQUEST['cid']))?intval($_REQUEST['cid']):$object->getVar('cid'))) {
								$key = $all_categories[$cid]['weight'] * $count_fields + $object->getVar('cid');
								$elements[$key][] = $fieldinfo;
								$weights[$key][] = $fields[$i]->getVar('field_weight');
							} elseif (in_array(0, $fields[$i]->getVar('cids'))) {
								$key = $all_categories[$cid]['weight'] * $count_fields + $object->getVar('cid');
								$elements[$key][] = $fieldinfo;
								$weights[$key][] = $fields[$i]->getVar('field_weight');
							}
						}
					}
				}
			}
		}
		if (is_array($elements)) {

The condition is_array($elements) is always true.

			ksort($elements);
			foreach (array_keys($elements) as $k) {
				array_multisort($weights[$k], SORT_ASC, array_keys($elements[$k]), SORT_ASC, $elements[$k]);

array_keys($elements[$k]) cannot be passed to array_multisort() as the parameter $rest expects a reference.

SORT_ASC cannot be passed to array_multisort() as the parameter $rest expects a reference.

				foreach (array_keys($elements[$k]) as $i) {
					$ele[$k] = $elements[$k][$i]['element'];
					if ($elements[$k][$i]['required']==true) {
						$required[$k] = $elements[$k][$i]['element']->getName();
					}
				}
			}
		}
			
		if (!class_exists('XoopsFormTag')) {
			$ele['tags'] = new XoopsFormHidden('tags', $object->getVar('tags'));

It seems like $object->getVar('tags') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

		} else {
			$ele['tags'] = new XoopsFormTag('tags', 60, 255, $object->getVar('sid'), $object->getVar('cid'));

It seems like $object->getVar('sid') can also be of type array and array; however, parameter $value of XoopsFormTag::__construct() does only seem to accept integer|string, maybe add an additional type check?

		}
		
		$ele['hits'] = new XoopsFormLabel(($as_array==false?_FRM_SONGLIST_FORM_SONGS_HITS:''), $object->getVar('hits'));

It seems like $object->getVar('hits') can also be of type array and array; however, parameter $value of XoopsFormLabel::__construct() does only seem to accept string, maybe add an additional type check?

		$ele['rank'] = new XoopsFormLabel(($as_array==false?_FRM_SONGLIST_FORM_SONGS_RANK:''), number_format(($object->getVar('rank')>0&&$object->getVar('votes')>0?$object->getVar('rank')/$object->getVar('votes'):0),2). ' of 10');
		if ($object->getVar('created')>0) {
			$ele['created'] = new XoopsFormLabel(($as_array==false?_FRM_SONGLIST_FORM_SONGS_CREATED:''), date(_DATESTRING, $object->getVar('created')));
		}
		if ($object->getVar('updated')>0) {
			$ele['updated'] = new XoopsFormLabel(($as_array==false?_FRM_SONGLIST_FORM_SONGS_UPDATED:''), date(_DATESTRING, $object->getVar('updated')));
		}
		if ($as_array==true)
			return $ele;
		
		$ele['submit'] = new XoopsFormButton('', 'submit', _SUBMIT, 'submit');
		
		foreach($ele as $id => $obj)			
			if (in_array($id, $required))
				$sform->addElement($ele[$id], true);			
			else
				$sform->addElement($ele[$id], false);
		
		return $sform->render();
		
?>

It is not recommended to use PHP's closing tag ?> in files other than templates.