SonglistRequestsHandler

Complexity

Total Complexity

39

Size/Duplication

Total Lines	158
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getURL()	0	6	2
D	insert()	0	105	16
A	__construct()	0	3	1
A	filterFields()	0	2	1
A	getFilterForm()	0	6	2
C	getFilterCriteria()	0	24	17

<?php

if (!defined('XOOPS_ROOT_PATH')) {
	exit();
}

include_once(dirname(dirname(__FILE__)).'/include/songlist.object.php');
include_once(dirname(dirname(__FILE__)).'/include/songlist.form.php');

class SonglistRequests extends XoopsObject
{

    function SonglistRequests($fid = null)

It is generally recommended to explicitly declare the visibility for methods.

The parameter $fid is not used and could be removed.

    {
        $this->initVar('rid', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('aid', XOBJ_DTYPE_INT, 0, false);
		$this->initVar('artist', XOBJ_DTYPE_TXTBOX, null, false, 128);
		$this->initVar('album', XOBJ_DTYPE_TXTBOX, null, false, 128);
		$this->initVar('title', XOBJ_DTYPE_TXTBOX, null, false, 128);
		$this->initVar('lyrics', XOBJ_DTYPE_OTHER, null, false);
		$this->initVar('uid', XOBJ_DTYPE_INT, 0, false);
		$this->initVar('name', XOBJ_DTYPE_TXTBOX, null, false, 128);
		$this->initVar('email', XOBJ_DTYPE_TXTBOX, null, false, 255);
		$this->initVar('songid', XOBJ_DTYPE_TXTBOX, null, false, 32);
		$this->initVar('sid', XOBJ_DTYPE_INT, 0, false);
		$this->initVar('created', XOBJ_DTYPE_INT, 0, false);
		$this->initVar('updated', XOBJ_DTYPE_INT, 0, false);
	}

	function getForm($as_array = false) {

It is generally recommended to explicitly declare the visibility for methods.

		return songlist_requests_get_form($this, $as_array);
	}
	
	function toArray() {

It is generally recommended to explicitly declare the visibility for methods.

		$ret = parent::toArray();
		$form = $this->getForm(true);
		$form['songid'] = new XoopsFormText('', $this->getVar('rid').'[songid]', 11, 32);
		foreach($form as $key => $element) {
			$ret['form'][$key] = $form[$key]->render();	
		}
		foreach(array('created', 'updated') as $key) {
			if ($this->getVar($key)>0) {
				$ret['form'][$key] = date(_DATESTRING, $this->getVar($key)); 
				$ret[$key] = date(_DATESTRING, $this->getVar($key));
			}
		}
		return $ret;
	}
    
}


class SonglistRequestsHandler extends XoopsPersistableObjectHandler
{
    function __construct(&$db) 

It is generally recommended to explicitly declare the visibility for methods.

    {
        parent::__construct($db, "songlist_requests", 'SonglistRequests', "rid", "name");
    }

	function filterFields() {

It is generally recommended to explicitly declare the visibility for methods.

		return array('rid', 'artist', 'album', 'title', 'lyrics', 'uid', 'name', 'email', 'songid', 'sid', 'created', 'updated');
	}
	
    function getFilterCriteria($filter) {

It is generally recommended to explicitly declare the visibility for methods.

    	$parts = explode('|', $filter);
    	$criteria = new CriteriaCompo();
    	foreach($parts as $part) {
    		$var = explode(',', $part);
    		if (!empty($var[1])&&!is_numeric($var[0])) {
    			$object = $this->create();
    			if (		$object->vars[$var[0]]['data_type']==XOBJ_DTYPE_TXTBOX || 
    						$object->vars[$var[0]]['data_type']==XOBJ_DTYPE_TXTAREA) 	{
    				$criteria->add(new Criteria('`'.$var[0].'`', '%'.$var[1].'%', (isset($var[2])?$var[2]:'LIKE')));
    			} elseif (	$object->vars[$var[0]]['data_type']==XOBJ_DTYPE_INT || 
    						$object->vars[$var[0]]['data_type']==XOBJ_DTYPE_DECIMAL || 
    						$object->vars[$var[0]]['data_type']==XOBJ_DTYPE_FLOAT ) 	{
    				$criteria->add(new Criteria('`'.$var[0].'`', $var[1], (isset($var[2])?$var[2]:'=')));			
				} elseif (	$object->vars[$var[0]]['data_type']==XOBJ_DTYPE_ENUM ) 	{
    				$criteria->add(new Criteria('`'.$var[0].'`', $var[1], (isset($var[2])?$var[2]:'=')));    				
				} elseif (	$object->vars[$var[0]]['data_type']==XOBJ_DTYPE_ARRAY ) 	{
    				$criteria->add(new Criteria('`'.$var[0].'`', '%"'.$var[1].'";%', (isset($var[2])?$var[2]:'LIKE')));    				
				}
    		} elseif (!empty($var[1])&&is_numeric($var[0])) {
    			$criteria->add(new Criteria($var[0], $var[1]));
    		}
    	}
    	return $criteria;
    }
        
    function getFilterForm($filter, $field, $sort='created', $op = 'dashboard', $fct='list') {

It is generally recommended to explicitly declare the visibility for methods.

    	$ele = songlist_getFilterElement($filter, $field, $sort, $op, $fct);
    	if (is_object($ele))
    		return $ele->render();
    	else 
    		return ' ';
    }
    
	function insert($obj, $force=true) {

It is generally recommended to explicitly declare the visibility for methods.

    	if ($obj->isNew()) {
    		$obj->setVar('created', time());	
    		$new = true;
    		$sendmail = true;
       	} else {
    		$obj->setVar('updated', time());
    		$new = false;
    		if ($obj->vars['songid']['changed']==true) {
    			$songs_handler = xoops_getmodulehandler('songs', 'songlist');
    			$criteria = new Criteria('songid', $obj->getVar('songid'));
    			$songs = $songs_handler->getObjects($criteria, false);

The method getObjects() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of said class. However, the method does not exist in XoopsRankHandler or XoUserHandler. Are you sure you never get one of those?

    			if (is_object($songs[0])) {
    				foreach($songs[0]->getVar('aids') as $aid)
    					$ad[] = $aid;
    				$obj->setVar('sid', $songs[0]->getVar('sid'));
    				$obj->setVar('aid', $ad[0]);

The variable $ad seems to be defined by a foreach iteration on line 111. Are you sure the iterator is never empty, otherwise this variable is not defined?

    				$sendmail = true;
    			}
    		}
    	}
    	if ($rid = parent::insert($obj, $force)) {
    		if ($sendmail==true) {

The variable $sendmail does not seem to be defined for all execution paths leading up to this point.

    			if ($new==true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

    				xoops_loadLanguage('email', 'songlist');
    				$xoopsMailer =& getMailer();
					$xoopsMailer->setHTML(true);
					$xoopsMailer->setTemplateDir($GLOBALS['xoops']->path('/modules/songlist/language/'.$GLOBALS['xoopsConfig']['language'].'/mail_templates/'));
					$xoopsMailer->setTemplate('songlist_request_created.html');
					$xoopsMailer->setSubject(sprintf(_MN_SONGLIST_SUBJECT_REQUESTMADE, $rid));
					
					foreach(explode('|', $GLOBALS['songlistModuleConfig']['email']) as $email)
						$xoopsMailer->setToEmails($email);
					
					$xoopsMailer->setToEmails($obj->getVar('email'));
					
					$xoopsMailer->assign("SITEURL", XOOPS_URL);
					$xoopsMailer->assign("SITENAME", $GLOBALS['xoopsConfig']['sitename']);
					$xoopsMailer->assign("RID", $rid);
					$xoopsMailer->assign("TITLE", $obj->getVar('title'));
					$xoopsMailer->assign("ALBUM", $obj->getVar('album'));
					$xoopsMailer->assign("ARTIST", $obj->getVar('artist'));
					$xoopsMailer->assign("EMAIL", $obj->getVar('email'));	
					$xoopsMailer->assign("NAME", $obj->getVar('name'));
					
					if(!$xoopsMailer->send() ){
						xoops_error($xoopsMailer->getErrors(true), 'Email Send Error');
					}
    			} else {
    				xoops_loadLanguage('email', 'songlist');
    				$songs_handler = xoops_getmodulehandler('songs', 'songlist');
    				$artists_handler = xoops_getmodulehandler('artists', 'songlist');
    				$albums_handler = xoops_getmodulehandler('albums', 'songlist');

The assignment to $albums_handler is dead and can be removed.

    				$genre_handler = xoops_getmodulehandler('genre', 'songlist');
    				
    				$song = $songs_handler->get($obj->getVar('sid'));
    				if (is_object($song)) {
    					$sng = $genre->getVar('title');

The variable $genre seems to be never defined.

    				}
    				$album = $album_handler->get($song->getVar('abid'));

The variable $album_handler does not exist. Did you maybe mean $albums_handler?

    				if (is_object($album)) {
    					$alb = $genre->getVar('title');
    					$alb_img = $genre->getImage();

The assignment to $alb_img is dead and can be removed.

    				}
    				$genre = $genre_handler->get($song->getVar('abid'));
    				if (is_object($genre)) {
    					$gen = $genre->getVar('name');
    				}
    				$artists = $artists_handler->getObjects(new Criteria('aid', '('.implode(',', $song->getVar('aid')).')', 'IN'), false);

It seems like $song->getVar('aid') can also be of type boolean and null and string; however, parameter $pieces of implode() does only seem to accept array, maybe add an additional type check?

    				$art = '';
    				foreach($artists as $id => $artist) {
    					$art .= $artist->getVar('name') . ($id<sizeof($artists)-1?', ':'');
    				}
    				$xoopsMailer =& getMailer();
					$xoopsMailer->setHTML(true);
					$xoopsMailer->setTemplateDir($GLOBALS['xoops']->path('/modules/songlist/language/'.$GLOBALS['xoopsConfig']['language'].'/mail_templates/'));
					$xoopsMailer->setTemplate('songlist_request_updated.html');
					$xoopsMailer->setSubject(sprintf(_MN_SONGLIST_SUBJECT_REQUESTFOUND, $rid));
					
					$xoopsMailer->setToEmails($obj->getVar('email'));
					
					$xoopsMailer->assign("SITEURL", XOOPS_URL);
					$xoopsMailer->assign("SITENAME", $GLOBALS['xoopsConfig']['sitename']);
					$xoopsMailer->assign("RID", $rid);
					$xoopsMailer->assign("TITLE", $obj->getVar('title'));
					$xoopsMailer->assign("ALBUM", $obj->getVar('album'));
					$xoopsMailer->assign("ARTIST", $obj->getVar('artist'));
					$xoopsMailer->assign("EMAIL", $obj->getVar('email'));	
					$xoopsMailer->assign("NAME", $obj->getVar('name'));
					$xoopsMailer->assign("SONGID", $song->getVar('songid'));
					$xoopsMailer->assign("SONGURL", $song->getURL());

The method getURL() does not exist on XoopsObject. It seems like you code against a sub-type of XoopsObject such as SonglistAlbums or XoopsModules\Songlist\Genre or XoopsModules\Songlist\Voice or SonglistGenre or SonglistVoice or XoopsModules\Songlist\Category or XoopsModules\Songlist\Songs or SonglistArtists or SonglistSongs or XoopsModules\Songlist\Albums or SonglistCategory or XoopsModules\Songlist\Artists.

					$xoopsMailer->assign("FOUNDTITLE", $sng);

The variable $sng does not seem to be defined for all execution paths leading up to this point.

					$xoopsMailer->assign("FOUNDALBUM", $alb);

The variable $alb does not seem to be defined for all execution paths leading up to this point.

					$xoopsMailer->assign("FOUNDARTIST", $art);
					$xoopsMailer->assign("FOUNDGENRE", $gen);

The variable $gen does not seem to be defined for all execution paths leading up to this point.

					$xoopsMailer->assign("EMAIL", $obj->getVar('email'));	
					$xoopsMailer->assign("NAME", $obj->getVar('name'));
					
					if(!$xoopsMailer->send() ){
						xoops_error($xoopsMailer->getErrors(true), 'Email Send Error');
					}
    			}		
    		}
    	}
    	return $rid;
    }
    
    function getURL() {

It is generally recommended to explicitly declare the visibility for methods.

    	global $file, $op, $fct, $id, $value, $gid, $cid, $start, $limit;
    	if ($GLOBALS['songlistModuleConfig']['htaccess']) {
    		return XOOPS_URL.'/'.$GLOBALS['songlistModuleConfig']['baseofurl'].'/'.$file.'/'.$op.'-'.$fct.$GLOBALS['songlistModuleConfig']['endofurl'];
    	} else {
    		return XOOPS_URL.'/modules/songlist/'.$file.'.php?op='.$op.'&fct='.$fct;
    	}
    }
}
?>

It is not recommended to use PHP's closing tag ?> in files other than templates.