Conditions | 45 |
Paths | 10200 |
Total Lines | 130 |
Code Lines | 102 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php declare(strict_types=1); |
||
52 | public function insert(\XoopsObject $obj, $force = false) |
||
53 | { |
||
54 | $objectsHandler = \XoopsModules\Songlist\Helper::getInstance()->getHandler('Extras'); |
||
55 | $obj->setVar('field_name', \str_replace(' ', '_', $obj->getVar('field_name'))); |
||
56 | $obj->cleanVars(); |
||
57 | $defaultstring = ''; |
||
58 | switch ($obj->getVar('field_type')) { |
||
59 | case 'datetime': |
||
60 | case 'date': |
||
61 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_INT); |
||
62 | $obj->setVar('field_maxlength', 10); |
||
63 | break; |
||
64 | case 'longdate': |
||
65 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_MTIME); |
||
66 | break; |
||
67 | case 'yesno': |
||
68 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_INT); |
||
69 | $obj->setVar('field_maxlength', 1); |
||
70 | break; |
||
71 | case 'textbox': |
||
72 | if (\XOBJ_DTYPE_INT != $obj->getVar('field_valuetype')) { |
||
73 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_TXTBOX); |
||
74 | } |
||
75 | break; |
||
76 | case 'autotext': |
||
77 | if (\XOBJ_DTYPE_INT != $obj->getVar('field_valuetype')) { |
||
78 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_TXTAREA); |
||
79 | } |
||
80 | break; |
||
81 | case 'group_multi': |
||
82 | case 'select_multi': |
||
83 | case 'checkbox': |
||
84 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_ARRAY); |
||
85 | break; |
||
86 | case 'language': |
||
87 | case 'timezone': |
||
88 | case 'theme': |
||
89 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_TXTBOX); |
||
90 | break; |
||
91 | case 'dhtml': |
||
92 | case 'textarea': |
||
93 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_TXTAREA); |
||
94 | break; |
||
95 | } |
||
96 | |||
97 | if ('' == $obj->getVar('field_valuetype')) { |
||
98 | $obj->setVar('field_valuetype', \XOBJ_DTYPE_TXTBOX); |
||
99 | } |
||
100 | |||
101 | if (!\in_array($obj->getVar('field_name'), $this->getPostVars(), true)) { |
||
102 | if ($obj->isNew()) { |
||
103 | //add column to table |
||
104 | $changetype = 'ADD'; |
||
105 | } else { |
||
106 | //update column information |
||
107 | $changetype = 'CHANGE `' . $obj->getVar('field_name', 'n') . '`'; |
||
108 | } |
||
109 | $maxlengthstring = $obj->getVar('field_maxlength') > 0 ? '(' . $obj->getVar('field_maxlength') . ')' : ''; |
||
110 | $notnullstring = ' NOT NULL'; |
||
111 | //set type |
||
112 | switch ($obj->getVar('field_valuetype')) { |
||
113 | default: |
||
114 | case \XOBJ_DTYPE_ARRAY: |
||
115 | case \XOBJ_DTYPE_UNICODE_ARRAY: |
||
116 | $type = 'mediumtext'; |
||
117 | break; |
||
118 | case \XOBJ_DTYPE_UNICODE_EMAIL: |
||
119 | case \XOBJ_DTYPE_UNICODE_TXTBOX: |
||
120 | case \XOBJ_DTYPE_UNICODE_URL: |
||
121 | case \XOBJ_DTYPE_EMAIL: |
||
122 | case \XOBJ_DTYPE_TXTBOX: |
||
123 | case \XOBJ_DTYPE_URL: |
||
124 | $type = 'varchar'; |
||
125 | // varchars must have a maxlength |
||
126 | if (!$maxlengthstring) { |
||
127 | //so set it to max if maxlength is not set - or should it fail? |
||
128 | $maxlengthstring = '(255)'; |
||
129 | $obj->setVar('field_maxlength', 255); |
||
130 | } |
||
131 | //if ( $obj->getVar('field_default') ) { |
||
132 | $defaultstring = ' DEFAULT ' . $this->db->quote($obj->cleanVars['field_default']); |
||
133 | //} |
||
134 | break; |
||
135 | case \XOBJ_DTYPE_INT: |
||
136 | $type = 'int'; |
||
137 | if ($obj->getVar('field_default') || '' !== $obj->getVar('field_default')) { |
||
138 | $defaultstring = " DEFAULT '" . (int)$obj->cleanVars['field_default'] . "'"; |
||
139 | $obj->setVar('field_default', (int)$obj->cleanVars['field_default']); |
||
140 | } |
||
141 | break; |
||
142 | case \XOBJ_DTYPE_DECIMAL: |
||
143 | $type = 'decimal(14,6)'; |
||
144 | if ($obj->getVar('field_default') || '' !== $obj->getVar('field_default')) { |
||
145 | $defaultstring = " DEFAULT '" . (float)$obj->cleanVars['field_default'] . "'"; |
||
146 | $obj->setVar('field_default', (float)$obj->cleanVars['field_default']); |
||
147 | } |
||
148 | break; |
||
149 | case XOBJ_DTYPE_FLOAT: |
||
150 | $type = 'float(15,9)'; |
||
151 | if ($obj->getVar('field_default') || '' !== $obj->getVar('field_default')) { |
||
152 | $defaultstring = " DEFAULT '" . (float)$obj->cleanVars['field_default'] . "'"; |
||
153 | $obj->setVar('field_default', (float)$obj->cleanVars['field_default']); |
||
154 | } |
||
155 | break; |
||
156 | case \XOBJ_DTYPE_OTHER: |
||
157 | case \XOBJ_DTYPE_UNICODE_TXTAREA: |
||
158 | case \XOBJ_DTYPE_TXTAREA: |
||
159 | $type = 'text'; |
||
160 | $maxlengthstring = ''; |
||
161 | $notnullstring = ''; |
||
162 | break; |
||
163 | case \XOBJ_DTYPE_MTIME: |
||
164 | $type = 'date'; |
||
165 | $maxlengthstring = ''; |
||
166 | break; |
||
167 | } |
||
168 | |||
169 | $sql = 'ALTER TABLE `' . $objectsHandler->table . '` ' . $changetype . ' `' . $obj->cleanVars['field_name'] . '` ' . $type . $maxlengthstring . $notnullstring . $defaultstring; |
||
170 | if (!$this->db->query($sql)) { |
||
171 | return false; |
||
172 | } |
||
173 | } |
||
174 | |||
175 | //change this to also update the cached field information storage |
||
176 | $obj->setDirty(); |
||
177 | if (!parent::insert($obj, $force)) { |
||
178 | return false; |
||
179 | } |
||
180 | |||
181 | return $obj->getVar('field_id'); |
||
|
|||
182 | } |
||
245 |