XoopsModules\Songlist\Extras

Complexity

Total Complexity

5

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	init()	0	5	4

<?php declare(strict_types=1);

namespace XoopsModules\Songlist;

/**
 * Class Extras
 */
class Extras extends \XoopsObject
{
    public $handler;

    /**
     * Extras constructor.
     * @param $fields
     */
    public function __construct($fields)
    {
        $this->initVar('sid', \XOBJ_DTYPE_INT, null, true);
        $this->init($fields);
    }

    /**
     * Initiate variables
     * @param array $fields field information array of {@link \XoopsObjectsField} objects
     */
    public function init($fields): void
    {
        if ($fields && \is_array($fields)) {

The expression $fields of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach (\array_keys($fields) as $key) {
                $this->initVar($key, $fields[$key]->getVar('field_valuetype'), $fields[$key]->getVar('field_default', 'n'), $fields[$key]->getVar('field_required'), $fields[$key]->getVar('field_maxlength'));
            }
        }
    }
}