Issues in Utility.php (master) - Issues in master - XoopsModules25x/soapbox - Measure and Improve Code Quality continuously with Scrutinizer

Issues (278)

Security Analysis not enabled

File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
Response Splitting
Response Splitting can be used to send arbitrary responses.
File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
Header Injection
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.
class/Utility.php (2 issues)

Severity

<?php

namespace XoopsModules\Soapbox;

use XoopsModules\Soapbox;

/**
 * Class Utility
 */
class Utility extends \XoopsObject
{
    use Common\VersionChecks; //checkVerXoops, checkVerPhp Traits


    use Common\ServerStats; // getServerStats Trait

    use Common\FilesManagement; // Files Management Trait

    /**
     * getLinkedUnameFromId()
     *
     * @param  int $userid Userid of author etc
     * @param  int $name   :  0 Use Usenamer 1 Use realname
     * @return string
     */
    public static function getLinkedUnameFromId($userid = 0, $name = 0)
    {
        if (!is_numeric($userid)) {

            return $userid;
        }
        $myts   = \MyTextSanitizer::getInstance();
        $userid = (int)$userid;
        if ($userid > 0) {
            $memberHandler = xoops_getHandler('member');
            $user          = $memberHandler->getUser($userid);

            if (is_object($user)) {
                $username  = $user->getVar('uname');
                $usernameu = $user->getVar('name');

                if ($name && !empty($usernameu)) {
                    $username = $user->getVar('name');
                }
                if (!empty($usernameu)) {
                    $linkeduser = $myts->htmlSpecialChars($usernameu) . " [<a href='" . XOOPS_URL . '/userinfo.php?uid=' . $userid . "'>" . $myts->htmlSpecialChars($username) . '</a>]';
                } else {
                    //                    $linkeduser = "<a href='".XOOPS_URL."/userinfo.php?uid=".$userid."'>". ucfirst($ts->htmlSpecialChars($username)) .'</a>';
                    $linkeduser = "<a href='" . XOOPS_URL . '/userinfo.php?uid=' . $userid . "'>" . $myts->htmlSpecialChars($username) . '</a>';
                }

                return $linkeduser;
            }
        }

        return $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);
    }

    /*
    public static function displayimage($image = 'blank.gif', $path = '', $imgsource = '', $alttext = '')
    {
        global $xoopsConfig, $xoopsUser, $xoopsModule;
        $myts = \MyTextSanitizer::getInstance();
        $showimage = '';

        if ($path) {
            $showimage = "<a href='" . $myts->htmlSpecialChars(strip_tags($path)) . "'>";
        }

        if (!is_dir(XOOPS_ROOT_PATH."/".$imgsource."/".$image) && file_exists(XOOPS_ROOT_PATH."/".$imgsource."/".$image)) {
            $showimage .= "<img src='".XOOPS_URL."/".$myts->htmlSpecialChars(strip_tags($imgsource))."/".$myts->htmlSpecialChars(strip_tags($image))."' border='0' alt=".$myts->htmlSpecialChars(strip_tags($alttext))."></a>";
        } else {
            if ($xoopsUser && $xoopsUser->isAdmin($xoopsModule->mid())) {
                $showimage .= "<img src='".XOOPS_URL.'/modules/'.$xoopsModule->dirname()."/assets/images/brokenimg.png' border='0' alt='"._AM_SOAPBOX_ISADMINNOTICE."'></a>";
            } else {
                $showimage .= "<img src='".XOOPS_URL.'/modules/'.$xoopsModule->dirname()."/assets/images/blank.png' border='0' alt=".$myts->htmlSpecialChars(strip_tags($alttext))."></a>";
            }
        }
        // clearstatcache();
        return $showimage;
    }
    */

    /**
     * @param        $allowed_mimetypes
     * @param        $httppostfiles
     * @param string $redirecturl
     * @param int    $num
     * @param string $dir
     * @param int    $redirect
     */
    public static function uploadFile(
        $allowed_mimetypes,
        $httppostfiles,
        $redirecturl = 'index.php',
        $num = 0,
        $dir = 'uploads',
        $redirect = 0)
    {
        require_once XOOPS_ROOT_PATH . '/class/uploader.php';
        $myts = \MyTextSanitizer::getInstance();

        global $xoopsConfig, $_POST;
        /** @var Soapbox\Helper $helper */
        $helper = Soapbox\Helper::getInstance();

        $maxfilesize   = (int)$helper->getConfig('maxfilesize');
        $maxfilewidth  = (int)$helper->getConfig('maximgwidth');
        $maxfileheight = (int)$helper->getConfig('maximgheight');
        $uploaddir     = XOOPS_ROOT_PATH . '/' . $myts->htmlSpecialChars(strip_tags($dir)) . '/';

        $uploader = new \XoopsMediaUploader($uploaddir, $allowed_mimetypes, $maxfilesize, $maxfilewidth, $maxfileheight);

        if ($uploader->fetchMedia($myts->htmlSpecialChars(strip_tags($_POST['xoops_upload_file'][$num])))) {
            if (!$uploader->upload()) {
                $errors = $uploader->getErrors();
                redirect_header($redirecturl, 1, $errors);
            } else {
                if ($redirect) {
                    redirect_header($redirecturl, '1', 'Image Uploaded');
                }
            }
        } else {
            $errors = $uploader->getErrors();
            redirect_header($redirecturl, 1, $errors);
        }
    }

    /*
    public static function htmlarray($thishtmlpage, $thepath)
    {
        global $xoopsConfig, $wfsConfig;

        $file_array = filesarray( $thepath );

        echo "<select size='1' name='htmlpage'>";
        echo "<option value='-1'>------</option>";
        foreach ($file_array as $htmlpage) {
            if ($htmlpage == $thishtmlpage) {
                $opt_selected = "selected";
            } else {
                $opt_selected = "";
            }
            echo "<option value='" . $htmlpage . "' $opt_selected>" . $htmlpage . "</option>";
        }
        echo "</select>";

        return $htmlpage;
    }
    */
    /*
    public static function filesarray($filearray)
    {
        $files = array();
        $dir = opendir( $filearray );

        while ( ( $file = readdir( $dir ) ) !== false ) {
            if ( ( !preg_match( "/^[.]{1,2}$/", $file ) && preg_match( "/[.htm|.html|.xhtml]$/i", $file ) && !is_dir( $file ) ) ) {
                if ( strtolower( $file ) != 'cvs' && !is_dir( $file ) ) {
                    $files[$file] = $file;
                }
            }
        }
        closedir( $dir );
        asort( $files );
        reset( $files );

        return $files;
    }
    */
    /*
    public static function getuserForm($user)
    {
        global $xoopsDB, $xoopsConfig;
        $myts = \MyTextSanitizer::getInstance();

        echo "<select name='author'>";
        echo "<option value='-1'>------</option>";
        $result = $xoopsDB->query("SELECT uid, uname FROM ".$xoopsDB->prefix("users")." ORDER BY uname");

        while (false !== (list($uid, $uname) = $xoopsDB->fetchRow($result))) {
            if ($uid == $user) {
                $opt_selected = "selected";
            } else {
                $opt_selected = "";
            }
            echo "<option value='".(int)($uid)."' $opt_selected>".$myts->htmlSpecialChars($uname)."</option>";
        }
        echo "</select>";
    }
    */

    /**
     * @param $author
     * @return string
     */
    public static function getAuthorName($author)
    {
        $ret = '';
        //get author
        $_authoruserHandler = xoops_getHandler('user');
        $_authoruser        = $_authoruserHandler->get($author);
        if (!is_object($_authoruser)) {
            $name3      = '';
            $uname3     = '';
            $authorname = '';
        } else {
            $name3      = $_authoruser->getVar('name');
            $uname3     = $_authoruser->getVar('uname');
            $authorname = $name3;
        }
        //-------------------------------------
        $ret = $authorname;
        if (empty($authorname) || '' === $authorname) {
            $ret = $uname3;
        }

        return $ret;
        //-------------------------------------
    }

    /**
     * @param int $showCreate
     */
    public static function showColumns($showCreate = 0)
    {
        global $xoopsModule;
        /** @var Soapbox\Helper $helper */
        $helper = Soapbox\Helper::getInstance();

        $pathIcon16 = \Xmf\Module\Admin::iconUrl('', 16);
        $myts       = \MyTextSanitizer::getInstance();
        require_once XOOPS_ROOT_PATH . '/class/pagenav.php';
        require_once XOOPS_ROOT_PATH . '/class/xoopsform/grouppermform.php';
        //        require_once XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->dirname() . '/include/cleantags.php';
        $module_id = $xoopsModule->getVar('mid');
        $startcol  = \Xmf\Request::getInt('startcol', 0, 'GET');

        /* Code to show existing columns */
        echo "<h3 style='color: #2F5376; margin: 0 0 4px 0;'>" . _AM_SOAPBOX_SHOWCOLS . '</h3>';
        echo '<span style="color: #567; margin: 3px 0 12px 0; font-size: small; display: block; ">' . _AM_SOAPBOX_COLSTEXT . '</span>';

        //    if ($showCreate == 1) {
        //        echo
        //            "<a style='border: 1px solid #5E5D63; color: #000000; font-family: verdana, tahoma, arial, helvetica, sans-serif; font-size: 1em; padding: 4px 8px; text-align:center;' href='column.php'>"
        //            . _AM_SOAPBOX_CREATECOL . "</a><br><br>";
        //    }
        // To create existing columns table
        //----------------------------
        //get category object
        /** @var \XoopsModules\Soapbox\EntrydataHandler $entrydataHandler */
        $entrydataHandler = new \XoopsModules\Soapbox\EntrydataHandler();
        $numrows          = $entrydataHandler->getColumnCount();
        $criteria         = new \CriteriaCompo();
        $criteria->setSort('weight');
        $criteria->setLimit((int)$helper->getConfig('perpage'));
        $criteria->setStart($startcol);
        $categoryobArray = $entrydataHandler->getColumns($criteria);
        unset($criteria);
        if ($numrows > 0) {
            echo '<form action="column.php" method="post" name="reordercols">';
        }
        echo "<table width='100%' cellspacing='1' cellpadding='3' border='0' class='outer'>";
        echo '<tr>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_ID . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_WEIGHT . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_AUTHOR . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_ARTCOLNAME . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_DESCRIP . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_ACTION . '</b></td>';
        echo '</tr>';

        if ($numrows > 0) { // That is, if there ARE columns in the system
            //----------------------------
            $cont = 0;
            foreach ($categoryobArray as $_categoryob) {
                //----------------------------
                //get vars
                ++$cont;
                $category      = $_categoryob->toArray(); //all assign
                $category_vars = $_categoryob->getVars();
                foreach ($category_vars as $k => $v) {
                    ${$k} = $_categoryob->getVar($k);
                }
                //----------------------------

                $author = self::getLinkedUnameFromId($author, 0);
                $modify = "<a href='column.php?op=mod&columnID=" . $category['columnID'] . "'><img src='" . $pathIcon16 . "/edit.png' ALT='" . _AM_SOAPBOX_EDITCOL . "'></a>";
                $delete = "<a href='column.php?op=del&columnID=" . $category['columnID'] . "'><img src='" . $pathIcon16 . "/delete.png' ALT='" . _AM_SOAPBOX_DELETECOL . "'></a>";
                $style  = (0 === ($cont % 2)) ? 'even' : 'odd';
                echo '<tr class="' . $style . '">';
                echo '<td class="txtcenter">' . $category['columnID'] . '</td>';
                echo '<td class="txtcenter"><input type="text" name="columnweight[' . $category['columnID'] . ']" value="' . $weight . '" size="3" maxlength="3" style="text-align: center;"></td>';
                echo '<td class="txtcenter">' . $category['author'] . '</td>';
                echo '<td class="txtcenter">' . $category['name'] . '</td>';
                echo '<td class="txtcenter">' . $category['description'] . '</td>';
                echo '<td class="txtcenter">' . $modify . ' ' . $delete . '</td>';
                echo '</tr>';
            }
        } else { // that is, $numrows = 0, there's no columns yet
            echo '<tr>';
            echo "<td class='head' align='center' colspan= '7'>" . _AM_SOAPBOX_NOCOLS . '</td>';
            echo '</tr>';
            $category['columnID'] = '0';
        }
        echo "</table>\n";
        $pagenav = new \XoopsPageNav($numrows, (int)$helper->getConfig('perpage'), $startcol, 'startcol', 'columnID=' . $category['columnID']);
        echo '<div style="text-align:right;">' . $pagenav->renderNav() . '</div>';
        echo "<br>\n";

        if ($numrows > 0) {
            echo "<input type='hidden' name='op' value='reorder'>";
            //--------------------
            echo $GLOBALS['xoopsSecurity']->getTokenHTML();
            //--------------------
            echo '<div style="margin-bottom: 18px;"><input type="submit" name="submit" class="formButton" value="' . _AM_SOAPBOX_REORDERCOL . '"></div>';
            echo '</form>';
        }
    }

    /**
     * @param int $showCreate
     */
    public static function showArticles($showCreate = 0)
    {
        global $xoopsModule;
        $myts = \MyTextSanitizer::getInstance();
        /** @var Soapbox\Helper $helper */
        $helper = Soapbox\Helper::getInstance();

        $pathIcon16 = \Xmf\Module\Admin::iconUrl('', 16);
        require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
        require_once XOOPS_ROOT_PATH . '/class/pagenav.php';
        require_once XOOPS_ROOT_PATH . '/class/xoopsform/grouppermform.php';
        //        require_once XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->dirname() . '/include/cleantags.php';

        $module_id = $xoopsModule->getVar('mid');
        $startart  = \Xmf\Request::getInt('startart', 0, 'GET');
        if (\Xmf\Request::hasVar('entries', 'POST')) {
            $entries = \Xmf\Request::getInt('entries', 0, 'POST');
        } else {
            $entries = \Xmf\Request::getInt('entries', 0, 'GET');
        }
        //---GET view sort --
        $sortname = isset($_GET['sortname']) ? mb_strtolower(trim(strip_tags($myts->stripSlashesGPC($_GET['sortname'])))) : 'datesub';
        if (!in_array($sortname, ['datesub', 'weight', 'counter', 'rating', 'headline'], true)) {
            $sortname = 'datesub';
        }
        $sortorder = isset($_GET['sortorder']) ? mb_strtoupper(trim(strip_tags($myts->stripSlashesGPC($_GET['sortorder'])))) : 'DESC';
        if (!in_array($sortorder, ['ASC', 'DESC'], true)) {
            $sortorder = 'DESC';
        }
        //---------------
        /* Code to show existing articles */
        echo "<h3 style='color: #2F5376; margin: 0 0 4px 0;'>" . _AM_SOAPBOX_SHOWARTS . '</h3>';
        echo '<span style="color: #567; margin: 3px 0 12px 0; font-size: small; display: block; ">' . _AM_SOAPBOX_ARTSTEXT . '</span>';

        //    if ($showCreate == 1) {
        //        echo
        //            "<a style='border: 1px solid #5E5D63; color: #000000; font-family: verdana, tahoma, arial, helvetica, sans-serif; font-size: 1em; padding: 4px 8px; text-align:center;' href='article.php'>"
        //            . _AM_SOAPBOX_CREATEART . "</a><br><br>";
        //    }
        // Articles count
        /** @var \XoopsModules\Soapbox\EntrydataHandler $entrydataHandler */
        $entrydataHandler = new \XoopsModules\Soapbox\EntrydataHandler();
        //----------------------------
        $criteria = new \CriteriaCompo();
        $criteria->add(new \Criteria('submit', 0));
        $criteria->add(new \Criteria('offline', 0));
        $tot_published = $entrydataHandler->getArticleCount($criteria);
        unset($criteria);
        //----------------------------
        $criteria = new \CriteriaCompo();
        $criteria->add(new \Criteria('submit', 0));
        $criteria->add(new \Criteria('offline', 1));
        $tot_offline = $entrydataHandler->getArticleCount($criteria);
        unset($criteria);
        //----------------------------
        $criteria = new \CriteriaCompo();
        $criteria->add(new \Criteria('submit', 1));
        $tot_submitted = $entrydataHandler->getArticleCount($criteria);
        unset($criteria);
        //----------------------------
        $tot_all = $entrydataHandler->getArticleCount();
        //----------------------------
        $criteria = new \CriteriaCompo();
        $criteria->add(new \Criteria('submit', 0));
        $tot_ok = $entrydataHandler->getArticleCount($criteria);
        unset($criteria);
        //----------------------------

        // Prepare string for table head
        if (0 === $entries) {
            $string = _AM_SOAPBOX_SHWALL;
        }
        if (1 === $entries) {
            $string = _AM_SOAPBOX_SHWONL;
        }
        if (2 === $entries) {
            $string = _AM_SOAPBOX_SHWOFF;
        }
        if (3 === $entries) {
            $string = _AM_SOAPBOX_SHWSUB;
        }
        if (4 === $entries) {
            $string = _AM_SOAPBOX_SHWAPV;
        }

        /* Code to show selected articles */
        echo "<form name='pick' id='pick' action='" . $myts->htmlSpecialChars(xoops_getenv('PHP_SELF')) . "' method='POST' style='margin: 0;'>"; ?>
        <table width='100%' cellspacing='1' cellpadding='2' border='0'
               style='border-left: 1px solid #c0c0c0; border-top: 1px solid #c0c0c0; border-right: 1px solid #c0c0c0;'>
            <tr>
                <td class='odd'><span style='font-weight: bold; font-variant: small-caps;'><?php echo $string ?></span></td>
                <td class='odd' width='40%' align='right'><?php echo _AM_SOAPBOX_SELECTSTATUS; ?>
                    <select name='entries' onchange='submit()'>
                        <option value='0'
                            <?php
                            if (0 === $entries) {
                                echo 'selected';
                            } ?>>
                            <?php echo _AM_SOAPBOX_SELALL; ?>
                            [<?php echo $tot_all; ?>]
                        </option>
                        <option value='1' <?php if (1 === $entries) {
                            echo 'selected';
                        } ?>><?php echo _AM_SOAPBOX_SELONL; ?>
                            [<?php echo $tot_published; ?>]
                        </option>
                        <option value='2' <?php if (2 === $entries) {
                            echo 'selected';
                        } ?>>
                            <?php echo _AM_SOAPBOX_SELOFF; ?>
                            [<?php echo $tot_offline; ?>]
                        </option>
                        <option value='3' <?php if (3 === $entries) {
                            echo 'selected';
                        } ?>>
                            <?php echo _AM_SOAPBOX_SELSUB; ?>
                            [<?php echo $tot_submitted; ?>]
                        </option>
                        <option value='4' <?php if (4 === $entries) {
                            echo 'selected';
                        } ?>><?php echo _AM_SOAPBOX_SELAPV; ?>
                            [<?php echo $tot_ok; ?>]
                        </option>
                    </select>
                </td>
            </tr>
        </table>
        </form>
        <?php

        //----------------------------
        // Put column names in an array, to avoid a query in the while loop further ahead
        switch ($entries) {
            case 1:
                $submit  = 0;
                $offline = 0;
                break;
            case 2:
                //----------------------------
                $submit  = 0;
                $offline = 1;
                break;
            case 3:
                //----------------------------
                $submit  = 1;
                $offline = null;
                break;
            case 4:
                //----------------------------
                $submit = 0;
                break;
            case 0:
            default:
                $submit  = null;
                $offline = null;
                break;
        }
        //    function getArticlesAllPermcheck(
        //         $limit=0, $start=0,
        //         $checkRight = true, $published = true, $submit = 0, $offline = 0, $block = null ,
        //         $sortname = 'datesub', $sortorder = 'DESC',
        //         $select_sbcolumns = null , $NOTarticleIDs = null ,
        //         $approve_submit = false ,
        //         $id_as_key = false )
        //-------------------------------------
        $entryobArray = $entrydataHandler->getArticlesAllPermcheck((int)$helper->getConfig('perpage'), $startart, false, false, $submit, $offline, null, $sortname, $sortorder, null, null, false, true);
        // Get number of articles in the selected condition ($cond)
        $numrows = $entrydataHandler->total_getArticlesAllPermcheck;
        if ($numrows > 0) {
            echo '<form action="article.php" method="post" name="reorderarticles\">';
        }
        echo "<table width='100%' cellspacing='1' cellpadding='3' border='0' class='outer'>";
        echo '<tr>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_ARTID . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_WEIGHT . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_ARTCOLNAME . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_ARTHEADLINE . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_ARTCREATED . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_STATUS . '</b></td>';
        echo '<th class="txtcenter"><b>' . _AM_SOAPBOX_ACTION . '</b></td>';
        echo '</tr>';

        if ($numrows > 0) { // That is, if there ARE articles in the said condition
            // Retrieve rows for those items

            $colarray = [];
            $cont     = 0;

            foreach ($entryobArray as $key => $_entryob) {
                //get vars
                ++$cont;
                //-------------------------------------
                $articles = $_entryob->toArray();
                //--------------------
                $colname = !empty($_entryob->_sbcolumns) ? $_entryob->_sbcolumns->getVar('name') : '';
                //--------------------
                $created = $myts->htmlSpecialChars(formatTimestamp($articles['datesub'], $helper->getConfig('dateformat')));
                $modify  = "<a href='article.php?op=mod&articleID=" . $articles['articleID'] . "'><img src='" . $pathIcon16 . "/edit.png' ALT='" . _AM_SOAPBOX_EDITART . "'></a>";
                $delete  = "<a href='article.php?op=del&articleID=" . $articles['articleID'] . "'><img src='" . $pathIcon16 . "/delete.png' ALT='" . _AM_SOAPBOX_DELETEART . "'></a>";

                //if ($offline == 0) {
                if (0 === $articles['offline']) {
                    $status = "<img src='" . $pathIcon16 . "/1.png' alt='" . _AM_SOAPBOX_ARTISON . "'>";
                } else {
                    //if ($offline == 1 && $submit == 0) {
                    if (0 === $submit && 1 === $articles['offline']) {
                        $status = "<img src='" . $pathIcon16 . "/0.png' alt='" . _AM_SOAPBOX_ARTISOFF . "'>";
                    } else {
                        if (1 === $submit) {
                            $status = '<img src=' . XOOPS_URL . '/modules/' . $xoopsModule->dirname() . "/assets/images/icon/sub.gif alt='" . _AM_SOAPBOX_ARTISSUB . "'>";
                        }
                    }
                }

                //mb ----------------------------
                //echo $cont.' - '.$offline.': '.$status.'</br>';

                $style = (0 === ($cont % 2)) ? 'even' : 'odd';
                echo '<tr class="' . $style . '">';
                echo '<td align="center"><a href="' . XOOPS_URL . '/modules/' . $xoopsModule->dirname() . '/article.php?articleID=' . $articles['articleID'] . '" title="' . $articles['headline'] . '" target="_blank">' . $articles['articleID'] . '</a></td>';
                echo '<td class="txtcenter"><input type="text" name="articleweight[' . $articles['articleID'] . ']" value="' . $articles['weight'] . '" size="3" maxlength="3" style="text-align: center;"></td>';
                echo '<td class="txtcenter">' . $colname . '</td>';
                echo '<td>' . $articles['headline'] . '</td>';
                echo '<td class="txtcenter">' . $created . '</td>';
                echo '<td class="txtcenter">' . $status . '</td>';
                echo '<td class="txtcenter">' . $modify . $delete . '</td>';
                echo '</tr>';
            }
        } else { // that is, $numrows = 0, there's no columns yet
            echo '<tr>';
            echo "<td class='head' align='center' colspan= '7'>" . _AM_SOAPBOX_NOARTS . '</td>';
            echo '</tr>';
        }
        echo "</table>\n";
        $pagenav = new \XoopsPageNav($numrows, (int)$helper->getConfig('perpage'), $startart, 'startart', 'entries=' . $entries . '&sortname=' . $sortname . '&sortorder=' . $sortorder);
        echo '<div style="text-align:right;">' . $pagenav->renderNav() . '</div>';

        if ($numrows > 0) {
            echo "<input type='hidden' name='op' value='reorder'>";
            //--------------------
            echo $GLOBALS['xoopsSecurity']->getTokenHTML();
            //--------------------
            echo '<div style="margin-bottom: 18px;"><input type="submit" name="submit" class="formButton" value="' . _AM_SOAPBOX_REORDERART . '"></div>';
            echo '</form>';
        }
        echo "<br>\n";
    }

    public static function showSubmissions()
    {
        global $xoopsModule;
        /** @var Soapbox\Helper $helper */
        $helper = Soapbox\Helper::getInstance();

        $pathIcon16 = \Xmf\Module\Admin::iconUrl('', 16);
        $myts       = \MyTextSanitizer::getInstance();
        require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
        require_once XOOPS_ROOT_PATH . '/class/pagenav.php';
        require_once XOOPS_ROOT_PATH . '/class/xoopsform/grouppermform.php';
        //        require_once XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->dirname() . '/include/cleantags.php';
        $module_id = $xoopsModule->getVar('mid');
        $startsub  = \Xmf\Request::getInt('startsub', 0, 'GET');
        $datesub   = \Xmf\Request::getInt('datesub', 0, 'GET');

        //---GET view sort --
        $sortname = isset($_GET['sortname']) ? mb_strtolower(trim(strip_tags($myts->stripSlashesGPC($_GET['sortname'])))) : 'datesub';
        if (!in_array($sortname, ['datesub', 'weight', 'counter', 'rating', 'headline'], true)) {
            $sortname = 'datesub';
        }
        $sortorder = isset($_GET['sortorder']) ? mb_strtoupper(trim(strip_tags($myts->stripSlashesGPC($_GET['sortorder'])))) : 'DESC';
        if (!in_array($sortorder, ['ASC', 'DESC'], true)) {
            $sortorder = 'DESC';
        }
        //---------------
        /* Code to show submitted articles */
        echo "<h3 style='color: #2F5376; margin: 0 0 4px 0;'>" . _AM_SOAPBOX_SHOWSUBMISSIONS . '</h3>';
        echo '<span style="color: #567; margin: 3px 0 12px 0; font-size: small; display: block; ">' . _AM_SOAPBOX_SUBTEXT . '</span>';
        echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
        echo '<tr>';
        echo "<td width='40' class='bg3' align='center'><b>" . _AM_SOAPBOX_ARTID . '</b></td>';
        echo "<td width='20%' class='bg3' align='center'><b>" . _AM_SOAPBOX_ARTCOLNAME . '</b></td>';
        echo "<td width='45%' class='bg3' align='center'><b>" . _AM_SOAPBOX_ARTHEADLINE . '</b></td>';
        echo "<td width='90' class='bg3' align='center'><b>" . _AM_SOAPBOX_ARTCREATED . '</b></td>';
        echo "<td width='60' class='bg3' align='center'><b>" . _AM_SOAPBOX_ACTION . '</b></td>';
        echo '</tr>';

        // Put column names in an array, to avoid a query in the while loop farther ahead
        /* Code to show submitted articles */
        // Articles count
        //    function getArticlesAllPermcheck(
        //         $limit=0, $start=0,
        //         $checkRight = true, $published = true, $submit = 0, $offline = 0, $block = null ,
        //         $sortname = 'datesub', $sortorder = 'DESC',
        //         $select_sbcolumns = null , $NOTarticleIDs = null ,
        //         $approve_submit = false ,
        //         $id_as_key = false )
        // Articles count
        /** @var \XoopsModules\Soapbox\EntrydataHandler $entrydataHandler */
        $entrydataHandler = new \XoopsModules\Soapbox\EntrydataHandler();
        //-------------------------------------
        $entryobArray = $entrydataHandler->getArticlesAllPermcheck((int)$helper->getConfig('perpage'), $startsub, false, false, 1, null, null, $sortname, $sortorder, null, null, false);
        // Get number of articles in the selected condition ($cond)
        $numrows = $entrydataHandler->total_getArticlesAllPermcheck;

        if ($numrows > 0) { // That is, if there ARE unauthorized articles in the system
            foreach ($entryobArray as $_entryob) {
                //get vars
                //-------------------------------------
                $articles = $_entryob->toArray();
                //--------------------
                $colname = !empty($_entryob->_sbcolumns) ? $_entryob->_sbcolumns->getVar('name') : '';
                $created = $myts->htmlSpecialChars(formatTimestamp($datesub, $helper->getConfig('dateformat')));
                $modify  = "<a href='submissions.php?op=mod&articleID=" . $articles['articleID'] . "'><img src='" . $pathIcon16 . "/edit.png' ALT='" . _AM_SOAPBOX_EDITSUBM . "'></a>";
                $delete  = "<a href='submissions.php?op=del&articleID=" . $articles['articleID'] . "'><img src='" . $pathIcon16 . "/delete.png' ALT='" . _AM_SOAPBOX_DELETESUBM . "'></a>";

                echo '<tr>';
                echo "<td class='head' align='center'>" . $articles['articleID'] . '</td>';
                echo "<td class='even' align='left'>" . $colname . '</td>';
                echo "<td class='even' align='left'>" . $articles['headline'] . '</td>';
                echo "<td class='even' align='center'>" . $created . '</td>';
                echo "<td class='even' align='center'>" . $modify . $delete . '</td>';
                echo '</tr>';
            }
        } else { // that is, $numrows = 0, there's no columns yet
            echo '<tr>';
            echo "<td class='head' align='center' colspan= '7'>" . _AM_SOAPBOX_NOSUBMISSYET . '</td>';
            echo '</tr>';
        }
        echo "</table>\n";
        $pagenav = new \XoopsPageNav($numrows, $helper->getConfig('perpage'), $startsub, 'startsub', '&sortname=' . $sortname . '&sortorder=' . $sortorder);
        echo '<div style="text-align:right;">' . $pagenav->renderNav() . '</div>';
        echo "<br>\n";
    }

    //HACK bydomifara for add method

    /**
     * @return string
     */
    public static function getAcceptLang()
    {
        //---access language
        $al = 'en';
        if (\Xmf\Request::hasVar('HTTP_ACCEPT_LANGUAGE', 'SERVER')) {
            $accept_langs = explode(',', $_SERVER['HTTP_ACCEPT_LANGUAGE']);
            foreach ($accept_langs as $al) {
                $al     = mb_strtolower($al);
                $al_len = mb_strlen($al);
                if ($al_len > 2) {
                    if (preg_match('/([a-z]{2});q=[0-9.]+$/', $al, $al_match)) {
                        $al = $al_match[1];
                        break;
                    }
                    continue;
                }
            }
        }

        return $al;
    }
}

XoopsModules25x / soapbox

Issues (278)

Security Analysis not enabled

class/Utility.php (2 issues)

Severity

Introduced By

Duplication Side-by-Side

Filter issues like
