myblocksadmin_update_block() - Code Metrics - Inspection of "Merge pull request #7 from mambax7/master" - XoopsModules25x/soapbox - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 1b67ca...fcd6b4 )

by Michael
created 2019-02-19 18:59 UTC
myblocksadmin_update_block() F

↳ Parent: Project
Complexity

Conditions	17
Paths	560
Size

Total Lines	86
Code Lines	52
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	17
eloc	52
nc	560
nop	10
dl	0
loc	86
rs	1.6611
c	1
b	0
f	0
How to fix Long Method Complexity Many Parameters

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    XOOPS Project https://xoops.org/
 * @license      GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @package
 * @since
 * @author       XOOPS Development Team, Kazumi Ono (AKA onokazu)
 */

use Xmf\Request;

if (!is_object($xoopsUser) || !is_object($xoopsModule) || !$xoopsUser->isAdmin($xoopsModule->mid())) {
    exit('Access Denied');
}
require_once XOOPS_ROOT_PATH . '/class/xoopsblock.php';
require XOOPS_ROOT_PATH . '/modules/system/admin/blocksadmin/blocksadmin.php';

$op  = Request::getCmd('op', 'list', 'POST');
$bid = Request::getInt('bid', 0, 'POST');

$opArray = ['edit', 'delete', 'delete_ok', 'clone'];
$temp    = $op = Request::getString('op', '', 'GET');
if (isset($temp)) {
    if (in_array($temp, $opArray, true)) {
        $op  = $temp;
        $bid = Request::getInt('bid', 0, 'GET');
    }
}

//if (\Xmf\Request::hasVar('previewblock', 'POST')) {
if (Request::hasVar('previewblock', 'POST')) {
    //if ( !admin_refcheck("/modules/$admin_mydirname/admin/") ) {
    //  exit('Invalid Referer');
    //}
    if (!$GLOBALS['xoopsSecurity']->check()) {
        redirect_header(XOOPS_URL . '/', 3, $GLOBALS['xoopsSecurity']->getErrors());
    }

    if (empty($bid)) {
        exit('Invalid bid.');
    }

    $bside      = Request::getInt('bside', 0, 'POST');
    $bweight    = Request::getInt('bweight', 0, 'POST');
    $bvisible   = Request::getInt('bvisible', 0, 'POST');
    $bmodule    = Request::getArray('bmodule', [], 'POST');
    $btitle     = Request::getString('btitle', '', 'POST');
    $bcontent   = Request::getString('bcontent', '', 'POST');
    $bctype     = Request::getString('bctype', '', 'POST');
    $bcachetime = Request::getInt('bcachetime', 0, 'POST');

    xoops_cp_header();
    require_once XOOPS_ROOT_PATH . '/class/template.php';
    $xoopsTpl          = new \XoopsTpl();
    $xoopsTpl->caching = 0;
    $block['bid']      = $bid;

    if ('clone_ok' === $op) {
        $block['form_title']    = _AM_CLONEBLOCK;

        $block['submit_button'] = _CLONE;
        $myblock                = new \XoopsBlock();
        $myblock->setVar('block_type', 'C');
    } else {
        $op                     = 'update';
        $block['form_title']    = _AM_EDITBLOCK;

        $block['submit_button'] = _SUBMIT;
        $myblock                = new \XoopsBlock($bid);
        $block['name']          = $myblock->getVar('name');
    }

    $myts = \MyTextSanitizer::getInstance();
    $myblock->setVar('title', $myts->stripSlashesGPC($btitle));
    $myblock->setVar('content', $myts->stripSlashesGPC($bcontent));
    //  $dummyhtml = '<html><head><meta http-equiv="content-type" content="text/html; charset='._CHARSET.'"><meta http-equiv="content-language" content="'._LANGCODE.'"><title>'.$xoopsConfig['sitename'].'</title><link rel="stylesheet" type="text/css" media="all" href="'.getcss($xoopsConfig['theme_set']).'"></head><body><table><tr><th>'.$myblock->getVar('title').'</th></tr><tr><td>'.$myblock->getContent('S', $bctype).'</td></tr></table></body></html>';

    /* $dummyfile = '_dummyfile_'.time().'.html';
    $fp = fopen(XOOPS_CACHE_PATH.'/'.$dummyfile, 'w');
    fwrite($fp, $dummyhtml);
    fclose($fp);*/
    $block['edit_form'] = false;
    $block['template']  = '';
    $block['op']        = $op;
    $block['side']      = $bside;
    $block['weight']    = $bweight;
    $block['visible']   = $bvisible;
    $block['title']     = $myblock->getVar('title', 'E');
    $block['content']   = $myblock->getVar('content', 'n');
    $block['modules']   = $bmodule;
    $block['ctype']     = isset($bctype) ? $bctype : $myblock->getVar('c_type');
    $block['is_custom'] = true;
    $block['cachetime'] = $bcachetime;
    echo '<a href="myblocksadmin.php">' . _AM_BADMIN . '</a>&nbsp;<span style="font-weight:bold;">&raquo;&raquo;</span>&nbsp;' . $block['form_title'] . '<br><br>';

    require dirname(__DIR__) . '/admin/myblockform.php'; //GIJ
    //echo '<a href="admin.php?fct=blocksadmin">'. _AM_BADMIN .'</a>&nbsp;<span style="font-weight:bold;">&raquo;&raquo;</span>&nbsp;'.$block['form_title'].'<br><br>';
    //require XOOPS_ROOT_PATH.'/modules/system/admin/blocksadmin/blockform.php';
    //    $xoopsGTicket->addTicketXoopsFormElement($form, __LINE__, 1800, 'myblocksadmin'); //GIJ
    $form->display();

    $original_level = error_reporting(E_ALL);
    echo "
    <table width='100%' class='outer' cellspacing='1'>
      <tr>
        <th>" . $myblock->getVar('title') . "</th>
      </tr>
      <tr>
        <td class='odd'>" . $myblock->getContent('S', $bctype) . "</td>
      </tr>
    </table>\n";
    error_reporting($original_level);

    xoops_cp_footer();
    /* echo '<script type="text/javascript">
    preview_window = openWithSelfMain("'.XOOPS_URL.'/modules/system/admin.php?fct=blocksadmin&op=previewpopup&file='.$dummyfile.'", "popup", 250, 200);
    </script>';*/

    exit();
}

/* if ($op == 'previewpopup') {
  if ( !admin_refcheck("/modules/$admin_mydirname/admin/") ) {
    exit('Invalid Referer');
  }
  $file = str_replace('..', '', XOOPS_CACHE_PATH.'/'.trim($_GET['file']));
  if (file_exists($file)) {
    require $file;
    @unlink($file);
  }
  exit();
} */

/* if ($op == "list") {
  xoops_cp_header();
  list_blocks();
  xoops_cp_footer();
  exit();
} */

if ('order' === $op) {
    //if ( !admin_refcheck("/modules/$admin_mydirname/admin/") ) {
    //  exit('Invalid Referer');
    //}
    if (!$GLOBALS['xoopsSecurity']->check()) {
        redirect_header(XOOPS_URL . '/', 3, $GLOBALS['xoopsSecurity']->getErrors());
    }

    $side    = Request::getArray('side', [], 'POST');
    $visible = Request::getArray('visible', [], 'POST');

    //  if ( !empty($_POST['oldside']) ) { $oldside = $_POST['oldside']; }
    //  if ( !empty($_POST['oldweight']) ) { $oldweight = $_POST['oldweight']; }
    //  if ( !empty($_POST['oldvisible']) ) { $oldvisible = $_POST['oldvisible']; }

    $bid = Request::getArray('bid', [], 'POST');
    // GIJ start
    foreach (array_keys($bid) as $i) {
        if ($side[$i] < 0) {
            $visible[$i] = 0;
            $side[$i]    = -1;
        } else {
            $visible[$i] = 1;
        }

        //        $bmodule = (isset($_POST['bmodule'][$i]) && is_array($_POST['bmodule'][$i])) ? $_POST['bmodule'][$i] : array(-1);
        $bmodule = Request::getArray('bmodule', [-1], 'POST');

        $weight     = Request::getInt('weight', 0, 'POST');
        $title      = Request::getString('title', '', 'POST');
        $bcachetime = Request::getInt('bcachetime', 0, 'POST');

        myblocksadmin_update_block($i, $side[$i], $weight[$i], $visible[$i], $title[$i], null, null, $bcachetime[$i], $bmodule, []);

        //    if ( $oldweight[$i] != $weight[$i] || $oldvisible[$i] != $visible[$i] || $oldside[$i] != $side[$i] )
        //    order_block($bid[$i], $weight[$i], $visible[$i], $side[$i]);
    }
    $query4redirect = '?dirname=' . urlencode(strip_tags(mb_substr(Request::getString('query4redirect', '', 'POST'), 9)));
    redirect_header("myblocksadmin.php$query4redirect", 1, _AM_DBUPDATED);
    // GIJ end
}

if ('order2' === $op) {
    if (!$GLOBALS['xoopsSecurity']->check()) {
        redirect_header(XOOPS_URL . '/', 3, $GLOBALS['xoopsSecurity']->getErrors());
    }

    $addblock = Request::getArray('addblock', null, 'POST');
    if (isset($addblock) && is_array($addblock)) {
        // addblock
        foreach ($addblock as $bid => $val) {
            myblocksadmin_update_blockinstance(0, 0, 0, 0, '', null, null, 0, [], [], (int)$bid);
        }
    } else {
        // else change order
        $side    = Request::getArray('side', [], 'POST');
        $visible = Request::getArray('visible', [], 'POST');
        $id      = Request::getArray('id', [], 'POST');

        foreach (array_keys($id) as $i) {
            // separate side and visible
            if ($side[$i] < 0) {
                $visible[$i] = 0;
                $side[$i]    = -1;  // for not to destroy the original position
            } else {
                $visible[$i] = 1;
            }

            //            $bmodule = (isset($_POST['bmodule'][$i]) && is_array($_POST['bmodule'][$i])) ? $_POST['bmodule'][$i] : array(-1);

            $bmodule = Request::getArray('bmodule', [-1], 'POST');

            $weight     = Request::getInt('weight', 0, 'POST');
            $title      = Request::getString('title', '', 'POST');
            $bcachetime = Request::getInt('bcachetime', 0, 'POST');

            //            myblocksadmin_update_blockinstance($i, $side[$i], $_POST['weight'][$i], $visible[$i], $_POST['title'][$i], null, null, $_POST['bcachetime'][$i], $bmodule, array());
            myblocksadmin_update_blockinstance($i, $side[$i], $weight[$i], $visible[$i], $title[$i], null, null, $bcachetime[$i], $bmodule, []);
        }
    }

    $query4redirect = '?dirname=' . urlencode(strip_tags(mb_substr(Request::getString('query4redirect', '', 'POST'), 9)));
    redirect_header("myblocksadmin.php$query4redirect", 1, _MD_AM_DBUPDATED);

}

/* if ($op == 'save') {
  if ( !admin_refcheck("/modules/$admin_mydirname/admin/") ) {
    exit('Invalid Referer');
  }
  if ( ! $GLOBALS['xoopsSecurity']->check() ) {
    redirect_header(XOOPS_URL.'/',3,$GLOBALS['xoopsSecurity']->getErrors());
  }
  if ( !empty($_POST['bside']) ) { $bside = (int)($_POST['bside']); } else { $bside = 0; }
  if ( !empty($_POST['bweight']) ) { $bweight = (int)($_POST['bweight']); } else { $bweight = 0; }
  if ( !empty($_POST['bvisible']) ) { $bvisible = (int)($_POST['bvisible']); } else { $bvisible = 0; }
  if ( !empty($_POST['bmodule']) ) { $bmodule = $_POST['bmodule']; } else { $bmodule = array(); }
  if ( !empty($_POST['btitle']) ) { $btitle = $_POST['btitle']; } else { $btitle = ""; }
  if ( !empty($_POST['bcontent']) ) { $bcontent = $_POST['bcontent']; } else { $bcontent = ""; }
  if ( !empty($_POST['bctype']) ) { $bctype = $_POST['bctype']; } else { $bctype = ""; }
  if ( !empty($_POST['bcachetime']) ) { $bcachetime = (int)($_POST['bcachetime']); } else { $bcachetime = 0; }
  save_block($bside, $bweight, $bvisible, $btitle, $bcontent, $bctype, $bmodule, $bcachetime);
  exit();
} */

if ('update' === $op) {
    //if ( !admin_refcheck("/modules/$admin_mydirname/admin/") ) {
    //  exit('Invalid Referer');
    //}
    if (!$GLOBALS['xoopsSecurity']->check()) {
        redirect_header(XOOPS_URL . '/', 3, $GLOBALS['xoopsSecurity']->getErrors());
    }
    /*  if ( !empty($_POST['bside']) ) { $bside = (int)($_POST['bside']); } else { $bside = 0; }
      if ( !empty($_POST['bweight']) ) { $bweight = (int)($_POST['bweight']); } else { $bweight = 0; }
      if ( !empty($_POST['bvisible']) ) { $bvisible = (int)($_POST['bvisible']); } else { $bvisible = 0; }
      if ( !empty($_POST['btitle']) ) { $btitle = $_POST['btitle']; } else { $btitle = ""; }
      if ( !empty($_POST['bcontent']) ) { $bcontent = $_POST['bcontent']; } else { $bcontent = ""; }
      if ( !empty($_POST['bctype']) ) { $bctype = $_POST['bctype']; } else { $bctype = ""; }
      if ( !empty($_POST['bcachetime']) ) { $bcachetime = (int)($_POST['bcachetime']); } else { $bcachetime = 0; }
      if ( !empty($_POST['bmodule']) ) { $bmodule = $_POST['bmodule']; } else { $bmodule = array(); }
      if ( !empty($_POST['options']) ) { $options = $_POST['options']; } else { $options = array(); }
      update_block($bid, $bside, $bweight, $bvisible, $btitle, $bcontent, $bctype, $bcachetime, $bmodule, $options);*/

    $bside      = Request::getInt('bside', 0, 'POST');
    $bweight    = Request::getInt('bweight', 0, 'POST');
    $bvisible   = Request::getInt('bvisible', 0, 'POST');
    $btitle     = Request::getString('btitle', '', 'POST');
    $bcontent   = Request::getString('bcontent', '', 'POST');
    $bctype     = Request::getString('bctype', '', 'POST');
    $bcachetime = Request::getInt('bcachetime', 0, 'POST');
    //    $bmodule    = (isset($_POST['bmodule']) && is_array($_POST['bmodule'])) ? $_POST['bmodule'] : array(-1); // GIJ +
    $bmodule = Request::getArray('bmodule', [-1], 'POST');
    $options = Request::getArray('options', [], 'POST');

    $msg = myblocksadmin_update_block($_POST['bid'], $bside, $bweight, $bvisible, $btitle, $bcontent, $bctype, $bcachetime, $bmodule, $options); // GIJ !
    redirect_header('myblocksadmin.php', 1, $msg);
}

if ('delete_ok' === $op) {
    //if ( !admin_refcheck("/modules/$admin_mydirname/admin/") ) {
    //  exit('Invalid Referer');
    //}
    if (!$GLOBALS['xoopsSecurity']->check()) {
        redirect_header(XOOPS_URL . '/', 3, $GLOBALS['xoopsSecurity']->getErrors());
    }
    // delete_block_ok($bid); GIJ imported from blocksadmin.php
    $myblock = new \XoopsBlock($bid);
    if ('D' !== $myblock->getVar('block_type') && 'C' !== $myblock->getVar('block_type')) {
        redirect_header('myblocksadmin.php', 4, 'Invalid block');
    }
    $myblock->delete();
              delete();
    if (!defined('XOOPS_ORETEKI') && '' !== $myblock->getVar('template')) {
        $tplfileHandler = xoops_getHandler('tplfile');
        $btemplate      = $tplfileHandler->find($GLOBALS['xoopsConfig']['template_set'], 'block', $bid);
        $btemplate      = $tplfileHandler->find($GLOBALS['xoopsConfig']['template_set'], 'block', $bid);
        if (count($btemplate) > 0) {
            $tplman->delete($btemplate[0]);
        }
    }
    redirect_header('myblocksadmin.php', 1, _AM_DBUPDATED);
    //
    // end of delete_block_ok() GIJ
}

if ('delete' === $op) {
    xoops_cp_header();
    // delete_block($bid); GIJ imported from blocksadmin.php
    $myblock = new \XoopsBlock($bid);
    if ('S' === $myblock->getVar('block_type')) {
        $message = _AM_SYSTEMCANT;

        redirect_header('admin.php?fct=blocksadmin', 4, $message);
    } elseif ('M' === $myblock->getVar('block_type')) {
        $message = _AM_MODULECANT;

        redirect_header('admin.php?fct=blocksadmin', 4, $message);
    } else {
        xoops_confirm([
                          'fct' => 'blocksadmin',
                          'op'  => 'delete_ok',
                          'bid' => $myblock->getVar('bid'),
                      ], 'admin.php', sprintf(_AM_RUSUREDEL, $myblock->getVar('title')));
                      ], 'admin.php', sprintf(_AM_RUSUREDEL, /** @scrutinizer ignore-type */ $myblock->getVar('title')));
    }
    // end of delete_block() GIJ
    xoops_cp_footer();
    exit();
}

if ('edit' === $op) {
    xoops_cp_header();
    // edit_block($bid); GIJ imported from blocksadmin.php
    $myblock = new \XoopsBlock($bid);

    $db      = \XoopsDatabaseFactory::getDatabaseConnection();
    $sql     = 'SELECT module_id FROM ' . $db->prefix('block_module_link') . ' WHERE block_id=' . (int)$bid;
    $result  = $db->query($sql);
    $modules = [];
    while (false !== ($row = $db->fetchArray($result))) {
        $modules[] = (int)$row['module_id'];
    }
    $is_custom = ('C' === $myblock->getVar('block_type') || 'E' === $myblock->getVar('block_type'));
    $block     = [
        'form_title'    => _AM_EDITBLOCK,
        'name'          => $myblock->getVar('name'),
        'side'          => $myblock->getVar('side'),
        'weight'        => $myblock->getVar('weight'),
        'visible'       => $myblock->getVar('visible'),
        'title'         => $myblock->getVar('title', 'E'),
        'content'       => $myblock->getVar('content', 'n'),
        'modules'       => $modules,
        'is_custom'     => $is_custom,
        'ctype'         => $myblock->getVar('c_type'),
        'cachetime'     => $myblock->getVar('bcachetime'),
        'op'            => 'update',
        'bid'           => $myblock->getVar('bid'),
        'edit_form'     => $myblock->getOptions(),
        'template'      => $myblock->getVar('template'),
        'options'       => $myblock->getVar('options'),
        'submit_button' => _SUBMIT,
    ];

    echo '<a href="myblocksadmin.php">' . _AM_BADMIN . '</a>&nbsp;<span style="font-weight:bold;">&raquo;&raquo;</span>&nbsp;' . _AM_EDITBLOCK . '<br><br>';
    require dirname(__DIR__) . '/admin/myblockform.php'; //GIJ
    //    $xoopsGTicket->addTicketXoopsFormElement($form, __LINE__, 1800, 'myblocksadmin'); //GIJ
    $form->display();
    // end of edit_block() GIJ
    xoops_cp_footer();
    exit();
}

if ('clone' === $op) {
    xoops_cp_header();
    $myblock = new \XoopsBlock($bid);

    $db      = \XoopsDatabaseFactory::getDatabaseConnection();
    $sql     = 'SELECT module_id FROM ' . $db->prefix('block_module_link') . ' WHERE block_id=' . (int)$bid;
    $result  = $db->query($sql);
    $modules = [];
    while (false !== ($row = $db->fetchArray($result))) {
        $modules[] = (int)$row['module_id'];
    }
    $is_custom = ('C' === $myblock->getVar('block_type') || 'E' === $myblock->getVar('block_type'));
    $block     = [
        'form_title'    => _AM_CLONEBLOCK,
        'name'          => $myblock->getVar('name'),
        'side'          => $myblock->getVar('side'),
        'weight'        => $myblock->getVar('weight'),
        'visible'       => $myblock->getVar('visible'),
        'content'       => $myblock->getVar('content', 'N'),
        'title'         => $myblock->getVar('title', 'E'),
        'modules'       => $modules,
        'is_custom'     => $is_custom,
        'ctype'         => $myblock->getVar('c_type'),
        'cachetime'     => $myblock->getVar('bcachetime'),
        'op'            => 'clone_ok',
        'bid'           => $myblock->getVar('bid'),
        'edit_form'     => $myblock->getOptions(),
        'template'      => $myblock->getVar('template'),
        'options'       => $myblock->getVar('options'),
        'submit_button' => _CLONE,
    ];
    echo '<a href="myblocksadmin.php">' . _AM_BADMIN . '</a>&nbsp;<span style="font-weight:bold;">&raquo;&raquo;</span>&nbsp;' . _AM_CLONEBLOCK . '<br><br>';
    require dirname(__DIR__) . '/admin/myblockform.php';
    //    $xoopsGTicket->addTicketXoopsFormElement($form, __LINE__, 1800, 'myblocksadmin'); //GIJ
    $form->display();
    xoops_cp_footer();
    exit();
}

if ('clone_ok' === $op) {
    // Ticket Check
    if (!$GLOBALS['xoopsSecurity']->check()) {
        redirect_header(XOOPS_URL . '/', 3, $GLOBALS['xoopsSecurity']->getErrors());
    }

    $block = new \XoopsBlock($bid);

    // block type check
    $block_type = $block->getVar('block_type');
    if ('C' !== $block_type && 'M' !== $block_type && 'D' !== $block_type) {
        redirect_header('myblocksadmin.php', 4, 'Invalid block');
    }

    //    if (empty($_POST['options'])) {
    //        $options = array();
    //    } elseif (is_array($_POST['options'])) {
    //        $options = $_POST['options'];
    //    } else {
    //        $options = explode('|', $_POST['options']);
    //    }

    $options = Request::getArray('options', [], 'POST');
    if (!empty($options) && (!is_array($options))) {

        $options = explode('|', Request::getString('options', '', 'POST'));
    }

    // for backward compatibility
    // $cblock =& $block->clone(); or $cblock =& $block->xoopsClone();
    $cblock = new \XoopsBlock();
    foreach ($block->vars as $k => $v) {
        $cblock->assignVar($k, $v['value']);
    }
    $cblock->setNew();

    $myts = \MyTextSanitizer::getInstance();
    $cblock->setVar('side', Request::getInt('bside', 0, 'POST'));
    $cblock->setVar('weight', Request::getInt('bweight', 0, 'POST'));
    $cblock->setVar('visible', Request::getInt('bvisible', 0, 'POST'));
    $cblock->setVar('title', Request::getString('btitle', '', 'POST'));
    $cblock->setVar('content', Request::getString('bcontent', '', 'POST'));
    $cblock->setVar('c_type', Request::getString('bctype', '', 'POST'));
    $cblock->setVar('bcachetime', Request::getInt('bcachetime', 0, 'POST'));
    if (isset($options) && (count($options) > 0)) {
        $options = implode('|', $options);
        $cblock->setVar('options', $options);
    }
    $cblock->setVar('bid', 0);
    $cblock->setVar('block_type', 'C' === $block_type ? 'C' : 'D');
    $cblock->setVar('func_num', 255);
    $newid = $cblock->store();
    $newid = $cblock->store();
    if (!$newid) {
        xoops_cp_header();
        $cblock->getHtmlErrors();
        xoops_cp_footer();
        exit();
    }
    /*    if ($cblock->getVar('template') != '') {
            $tplfileHandler = xoops_getHandler('tplfile');
            $btemplate = $tplfileHandler->find($GLOBALS['xoopsConfig']['template_set'], 'block', $bid);
            if (count($btemplate) > 0) {
                $tplclone =& $btemplate[0]->clone();
                $tplclone->setVar('tpl_id', 0);
                $tplclone->setVar('tpl_refid', $newid);
                $tplman->insert($tplclone);
            }
        } */
    $db = \XoopsDatabaseFactory::getDatabaseConnection();
    //    $bmodule = (isset($_POST['bmodule']) && is_array($_POST['bmodule'])) ? $_POST['bmodule'] : array(-1); // GIJ +
    $bmodule = Request::getArray('bmodule', [-1], 'POST');
    foreach ($bmodule as $bmid) {
        $sql = 'INSERT INTO ' . $db->prefix('block_module_link') . ' (block_id, module_id) VALUES (' . $newid . ', ' . $bmid . ')';
        $db->query($sql);
    }

    /*    global $xoopsUser;
        $groups =& $xoopsUser->getGroups();
        $count = count($groups);
        for ($i = 0; $i < $count; ++$i) {
            $sql = "INSERT INTO ".$db->prefix('group_permission')." (gperm_groupid, gperm_itemid, gperm_modid, gperm_name) VALUES (".$groups[$i].", ".$newid.", 1, 'block_read')";
            $db->query($sql);
        }
    */

    $sql    = 'SELECT gperm_groupid FROM ' . $db->prefix('group_permission') . " WHERE gperm_name='block_read' AND gperm_modid='1' AND gperm_itemid='$bid'";
    $result = $db->query($sql);
    while (false !== (list($gid) = $db->fetchRow($result))) {
        $sql = 'INSERT INTO ' . $db->prefix('group_permission') . " (gperm_groupid, gperm_itemid, gperm_modid, gperm_name) VALUES ($gid, $newid, 1, 'block_read')";
        $db->query($sql);
    }

    redirect_header('myblocksadmin.php', 1, _AM_DBUPDATED);
}

// import from modules/system/admin/blocksadmin/blocksadmin.php
/**
 * @param         $bid
 * @param         $bside
 * @param         $bweight
 * @param         $bvisible
 * @param         $btitle
 * @param         $bcontent
 * @param         $bctype
 * @param         $bcachetime
 * @param         $bmodule
 * @param  array  $options
 * @return string
 */
function myblocksadmin_update_block(
    $bid,
    $bside,
    $bweight,
    $bvisible,
    $btitle,
    $bcontent,
    $bctype,
    $bcachetime,
    $bmodule,
    $options = [])
{
    global $xoopsConfig;
    /* if (empty($bmodule)) {
        xoops_cp_header();
        xoops_error(sprintf(_AM_NOTSELNG, _AM_VISIBLEIN));
        xoops_cp_footer();
        exit();
    } */
    $myblock = new \XoopsBlock($bid);
    // $myblock->setVar('side', $bside); GIJ -
    if ($bside >= 0) {
        $myblock->setVar('side', $bside);
    } // GIJ +
    $myblock->setVar('weight', $bweight);
    $myblock->setVar('visible', $bvisible);
    $myblock->setVar('title', $btitle);
    if (isset($bcontent)) {
        $myblock->setVar('content', $bcontent);
    }
    if (isset($bctype)) {
        $myblock->setVar('c_type', $bctype);
    }
    $myblock->setVar('bcachetime', $bcachetime);
    if (isset($options) && (count($options) > 0)) {
        $options = implode('|', $options);
        $myblock->setVar('options', $options);
    }
    if ('C' === $myblock->getVar('block_type')) {
        switch ($myblock->getVar('c_type')) {
            case 'H':
                $name = _AM_CUSTOMHTML;

                break;
            case 'P':
                $name = _AM_CUSTOMPHP;

                break;
            case 'S':
                $name = _AM_CUSTOMSMILE;

                break;
            default:
                $name = _AM_CUSTOMNOSMILE;

                break;
        }
        $myblock->setVar('name', $name);
    }
    $msg = _AM_DBUPDATED;
    if (false !== $myblock->store()) {
        $db  = \XoopsDatabaseFactory::getDatabaseConnection();
        $sql = sprintf('DELETE FROM `%s` WHERE block_id = %u', $db->prefix('block_module_link'), $bid);
        $db->query($sql);
        foreach ($bmodule as $bmid) {
            $sql = sprintf('INSERT INTO `%s` (block_id, module_id) VALUES (%u, %d)', $db->prefix('block_module_link'), $bid, (int)$bmid);
            $db->query($sql);
        }
        require_once XOOPS_ROOT_PATH . '/class/template.php';
        $xoopsTpl          = new \XoopsTpl();
        $xoopsTpl->caching = 2;
        if ('' !== $myblock->getVar('template')) {
            if ($xoopsTpl->is_cached('db:' . $myblock->getVar('template'))) {
                if (!$xoopsTpl->clear_cache('db:' . $myblock->getVar('template'))) {
                    $msg = 'Unable to clear cache for block ID' . $bid;
                }
            }
        } else {
            if ($xoopsTpl->is_cached('db:system_dummy.tpl', 'block' . $bid)) {
                if (!$xoopsTpl->clear_cache('db:system_dummy.tpl', 'block' . $bid)) {
                    $msg = 'Unable to clear cache for block ID' . $bid;
                }
            }
        }
    } else {
        $msg = 'Failed update of block. ID:' . $bid;
    }
    // redirect_header('admin.php?fct=blocksadmin&amp;t='.time(),1,$msg);
    // exit(); GIJ -
    return $msg; // GIJ +
}

// update block instance for 2.2
/**
 * @param         $id
 * @param         $bside
 * @param         $bweight
 * @param         $bvisible
 * @param         $btitle
 * @param         $bcontent
 * @param         $bctype
 * @param         $bcachetime
 * @param         $bmodule
 * @param  array  $options
 * @param  null   $bid

 * @return string
 */
function myblocksadmin_update_blockinstance(
    $id,
    $bside,
    $bweight,
    $bvisible,
    $btitle,
    $bcontent,
    /** @scrutinizer ignore-unused */ $bcontent,
    $bctype,
    /** @scrutinizer ignore-unused */ $bctype,
    $bcachetime,
    $bmodule,
    $options = [],
    $bid = null)
{
    global $xoopsDB;

    $instanceHandler = xoops_getHandler('blockinstance');
    $blockHandler    = xoops_getHandler('block');
    if ($id > 0) {
        // update
        $instance = $instanceHandler->get($id);
        if ($bside >= 0) {
            $instance->setVar('side', $bside);
        }
        if (!empty($options)) {
            $instance->setVar('options', $options);
        }
    } else {
        // insert
        $instance = $instanceHandler->create();
        $instance->setVar('bid', $bid);
        $instance->setVar('side', $bside);
        $block = $blockHandler->get($bid);
        $instance->setVar('options', $block->getVar('options'));
        if (empty($btitle)) {
            $btitle = $block->getVar('name');
        }
    }
    $instance->setVar('weight', $bweight);
    $instance->setVar('visible', $bvisible);
    $instance->setVar('title', $btitle);
    // if( isset( $bcontent ) ) $instance->setVar('content', $bcontent);
    // if( isset( $bctype ) ) $instance->setVar('c_type', $bctype);
    $instance->setVar('bcachetime', $bcachetime);

    if ($instanceHandler->insert($instance)) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $GLOBALS['xoopsDB']->query('DELETE FROM ' . $GLOBALS['xoopsDB']->prefix('block_module_link') . ' WHERE block_id=' . $instance->getVar('instanceid'));
        foreach ($bmodule as $mid) {
            $page   = explode('-', $mid);
            $mid    = $page[0];
            $pageid = $page[1];
            $GLOBALS['xoopsDB']->query('INSERT INTO ' . $GLOBALS['xoopsDB']->prefix('block_module_link') . ' VALUES (' . $instance->getVar('instanceid') . ', ' . (int)$mid . ', ' . (int)$pageid . ')');
        }

        return _MD_AM_DBUPDATED;

    }

    return 'Failed update of block instance. ID:' . $id;
    /*        // NAME for CUSTOM BLOCK
            if ( $instance->getVar('block_type') == 'C') {
                switch ( $instance->getVar('c_type') ) {
                case 'H':
                    $name = _AM_CUSTOMHTML;
                    break;
                case 'P':
                    $name = _AM_CUSTOMPHP;
                    break;
                case 'S':
                    $name = _AM_CUSTOMSMILE;
                    break;
                default:
                    $name = _AM_CUSTOMNOSMILE;
                    break;
                }
                $instance->setVar('name', $name);
            }
    */
    /*            // CLEAR TEMPLATE CACHE
                require_once XOOPS_ROOT_PATH.'/class/template.php';
                $xoopsTpl = new \XoopsTpl();
                $xoopsTpl->caching=(2);
                if ($instance->getVar('template') != '') {
                    if ($xoopsTpl->is_cached('db:'.$instance->getVar('template'))) {
                        if (!$xoopsTpl->clear_cache('db:'.$instance->getVar('template'))) {
                            $msg = 'Unable to clear cache for block ID'.$bid;
                        }
                    }
                } else {
                    if ($xoopsTpl->is_cached('db:system_dummy.tpl', 'block'.$bid)) {
                        if (!$xoopsTpl->clear_cache('db:system_dummy.tpl', 'block'.$bid)) {
                            $msg = 'Unable to clear cache for block ID'.$bid;
                        }
                    }
                }
    */
}

// TODO  edit2, delete2, customblocks

XoopsModules25x / soapbox

Push — master ( 1b67ca...fcd6b4 )

myblocksadmin_update_block() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity Many Parameters

Long Method

Many Parameters

Duplication Side-by-Side

Filter issues like
