XoopsModules25x /
soapbox
| Total Complexity | 54 |
| Total Lines | 225 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like FilesManagement often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FilesManagement, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 20 | trait FilesManagement |
||
| 21 | { |
||
| 22 | /** |
||
| 23 | * Function responsible for checking if a directory exists, we can also write in and create an index.html file |
||
| 24 | * |
||
| 25 | * @param string $folder The full path of the directory to check |
||
| 26 | */ |
||
| 27 | public static function createFolder($folder) |
||
| 28 | { |
||
| 29 | try { |
||
| 30 | if (!file_exists($folder)) { |
||
| 31 | if (!is_dir($folder) && !mkdir($folder) && !is_dir($folder)) { |
||
| 32 | throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder)); |
||
| 33 | } |
||
| 34 | |||
| 35 | file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>'); |
||
| 36 | } |
||
| 37 | } |
||
| 38 | catch (\Exception $e) { |
||
| 39 | echo 'Caught exception: ', $e->getMessage(), "\n", '<br>'; |
||
| 40 | } |
||
| 41 | } |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @param $file |
||
| 45 | * @param $folder |
||
| 46 | * @return bool |
||
| 47 | */ |
||
| 48 | public static function copyFile($file, $folder) |
||
| 49 | { |
||
| 50 | return copy($file, $folder); |
||
| 51 | } |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @param $src |
||
| 55 | * @param $dst |
||
| 56 | */ |
||
| 57 | public static function recurseCopy($src, $dst) |
||
| 58 | { |
||
| 59 | $dir = opendir($src); |
||
| 60 | // @mkdir($dst); |
||
| 61 | if (!@mkdir($dst) && !is_dir($dst)) { |
||
| 62 | throw new \RuntimeException('The directory ' . $dst . ' could not be created.'); |
||
| 63 | } |
||
| 64 | while (false !== ($file = readdir($dir))) { |
||
|
Bug
introduced
by
|
|||
| 65 | if (('.' !== $file) && ('..' !== $file)) { |
||
| 66 | if (is_dir($src . '/' . $file)) { |
||
| 67 | self::recurseCopy($src . '/' . $file, $dst . '/' . $file); |
||
| 68 | } else { |
||
| 69 | copy($src . '/' . $file, $dst . '/' . $file); |
||
| 70 | } |
||
| 71 | } |
||
| 72 | } |
||
| 73 | closedir($dir); |
||
| 74 | } |
||
| 75 | |||
| 76 | /** |
||
| 77 | * Remove files and (sub)directories |
||
| 78 | * |
||
| 79 | * @param string $src source directory to delete |
||
| 80 | * |
||
| 81 | * @uses \Xmf\Module\Helper::getHelper() |
||
| 82 | * @uses \Xmf\Module\Helper::isUserAdmin() |
||
| 83 | * |
||
| 84 | * @return bool true on success |
||
| 85 | */ |
||
| 86 | public static function deleteDirectory($src) |
||
| 123 | } |
||
| 124 | |||
| 125 | /** |
||
| 126 | * Recursively remove directory |
||
| 127 | * |
||
| 128 | * @todo currently won't remove directories with hidden files, should it? |
||
| 129 | * |
||
| 130 | * @param string $src directory to remove (delete) |
||
| 131 | * |
||
| 132 | * @return bool true on success |
||
| 133 | */ |
||
| 134 | public static function rrmdir($src) |
||
| 164 | } |
||
| 165 | |||
| 166 | /** |
||
| 167 | * Recursively move files from one directory to another |
||
| 168 | * |
||
| 169 | * @param string $src - Source of files being moved |
||
| 170 | * @param string $dest - Destination of files being moved |
||
| 171 | * |
||
| 172 | * @return bool true on success |
||
| 173 | */ |
||
| 174 | public static function rmove($src, $dest) |
||
| 204 | } |
||
| 205 | |||
| 206 | /** |
||
| 207 | * Recursively copy directories and files from one directory to another |
||
| 208 | * |
||
| 209 | * @param string $src - Source of files being moved |
||
| 210 | * @param string $dest - Destination of files being moved |
||
| 211 | * |
||
| 212 | * @uses \Xmf\Module\Helper::getHelper() |
||
| 213 | * @uses \Xmf\Module\Helper::isUserAdmin() |
||
| 214 | * |
||
| 215 | * @return bool true on success |
||
| 216 | */ |
||
| 217 | public static function rcopy($src, $dest) |
||
| 245 | } |
||
| 246 | } |
||
| 247 |
Loading history...
