b_columns_spot_show()

Complexity

Conditions	33
Paths	> 20000

Size

Total Lines	172
Code Lines	112

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function b_columns_spot_show($options)
{
    $block_outdata = [];
    //-------------------------------------
    $myts          = \MyTextSanitizer:: getInstance();
    $helper        = \XoopsModules\Soapbox\Helper::getInstance();

The assignment to $helper is dead and can be removed.

    $module_name   = 'soapbox';
    $moduleHandler = xoops_getHandler('module');
    $soapModule    = $moduleHandler->getByDirname($module_name);

The method getByDirname() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsModuleHandler or XoopsPersistableObjectHandler.

    if (!is_object($soapModule)) {
        return null;
    }

    $hModConfig = xoops_getHandler('config');
    $module_id  = $soapModule->getVar('mid');
    $soapConfig = $hModConfig->getConfigsByCat(0, $module_id);

The method getConfigsByCat() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsPersistableObjectHandler.

    //-------------------------------------
    // To handle options in the template
    if (isset($options[0]) && 1 === $options[0]) {
        $block_outdata['showspotlight'] = 1;
    } else {
        $block_outdata['showspotlight'] = 0;
    }
    //-------------------------------------
    if (isset($options[1])) {
        $options[1] = (int)$options[1];
    } else {
        $options[1] = 0;
    }
    if (0 === $options[1]) {
        $block_outdata['showartcles'] = 0;
    } else {
        $block_outdata['showartcles'] = 1;
    }
    //-------------------------------------
    if (isset($options[2]) && 1 === $options[2]) {
        $block_outdata['showdateask'] = 1;
    } else {
        $block_outdata['showdateask'] = 0;
    }
    //-------------------------------------
    if (isset($options[3]) && 1 === $options[3]) {
        $block_outdata['showbylineask'] = 1;
    } else {
        $block_outdata['showbylineask'] = 0;
    }
    //-------------------------------------
    if (isset($options[4]) && 1 === $options[4]) {
        $block_outdata['showstatsask'] = 1;
    } else {
        $block_outdata['showstatsask'] = 0;
    }
    //-------------------------------------
    if (isset($options[5]) && 'ver' === $options[5]) {
        $block_outdata['verticaltemplate'] = 1;
    } else {
        $block_outdata['verticaltemplate'] = 0;
    }
    //-------------------------------------
    if (isset($options[6]) && 1 === $options[6]) {
        $block_outdata['showpicask'] = 1;
    } else {
        $block_outdata['showpicask'] = 0;
    }
    //-------------------------------------
    $sortname = $options[7];
    if (!in_array($sortname, ['datesub', 'weight', 'counter', 'rating', 'headline'], true)) {
        $sortname = 'datesub';
    }
    $sortorder = 'DESC';
    if ('weight' === $sortname) {
        $sortorder = 'ASC';
    }
    //-------------------------------------
    if (isset($options[8]) && (int)$options[8] > 0) {
        $options[8] = (int)$options[8];
    } else {
        $options[8] = 65;
    }
    //-------------------------------------
    // Try to see what tabs are visibles (if we are in restricted view of course)
    $opt_columnIDs = [];
    if (!empty($options[9])) {
        $opt_columnIDs = array_slice($options, 9);
    }
    if (!empty($opt_columnIDs) && is_array($opt_columnIDs)) {
        foreach ($opt_columnIDs as $v) {
            $columnIDs[] = (int)$v;
        }
    } else {
        $columnIDs = null;
    }
    // Retrieve the column's name
    //    $resultB = $xoopsDB -> query( "SELECT name, colimage FROM ". $xoopsDB -> prefix( "sbcolumns" ) . " WHERE columnID = " . $options[0] . " " );
    //    list ( $name, $colimage ) = $xoopsDB -> fetchRow( $resultB );
    //-------------------------------------
    /** @var \XoopsModules\Soapbox\EntrygetHandler $entrydataHandler */
    $entrydataHandler = new \XoopsModules\Soapbox\EntrygetHandler();
    //-------------------------------------
    //get category object
    $categoryobArray = $entrydataHandler->getColumnsAllPermcheck(0, 0, true, 'weight', 'ASC', $columnIDs, null, true, false);

The call to XoopsModules\Soapbox\EntrygetHandler::getColumnsAllPermcheck() has too many arguments starting with false.

The variable $columnIDs does not seem to be defined for all execution paths leading up to this point.

    if (empty($categoryobArray) || 0 === count($categoryobArray)) {
        $block_outdata['display'] = 0;

        return $block_outdata;
    }
    $block_outdata['display'] = 1;
    //-------------------------------------
    $block_outdata['totalcols']   = $entrydataHandler->total_getColumnsAllPermcheck;
    $block_outdata['moduledir']   = $module_name;
    $block_outdata['modulename']  = $soapModule->getVar('name');
    $block_outdata['sbuploaddir'] = $myts->htmlSpecialChars($soapConfig['sbuploaddir']);
    //-------------------------------------
    $i_col = 1;
    xoops_load('XoopsUserUtility');
    foreach ($categoryobArray as $_categoryob) {
        //----------------------------
        $category                   = $_categoryob->toArray(); //all assign
        $_outdata_arr               = [];

The assignment to $_outdata_arr is dead and can be removed.

        $_outdata_arr               = $category;
        $_outdata_arr['authorname'] = \XoopsUserUtility::getUnameFromId((int)$category['author']);
        //-------------------------------------
        if (0 === $options[1]) {
            $_outdata_arr['artdatas'] = [];
        } else {
            //-------------------------------------
            // Retrieve the latest article in the selected column
            $entryobArray              = $entrydataHandler->getArticlesAllPermcheck($options[1], 0, true, true, 0, 0, 1, $sortname, $sortorder, $category['columnID'], null, false, false);
            $_outdata_arr['totalarts'] = $entrydataHandler->total_getArticlesAllPermcheck;
            //----------------------------
            //xoops_load('XoopsUserUtility');
            $i = 1;
            foreach ($entryobArray as $key => $_entryob) {
                // get vars initialize
                //-------------------------------------
                $articles   = $_entryob->toArray();
                $articles[] = $articles;
                //spot
                $articles['poster'] = \XoopsUserUtility::getUnameFromId($articles['uid']);
                $articles['date']   = $myts->htmlSpecialChars(formatTimestamp($articles['datesub'], $soapConfig['dateformat']));
                $articles['rating'] = number_format($articles['rating'], 2, '.', '');
                // -- Then the teaser text and as sorted data
                $articles['subhead']     = xoops_substr($articles['headline'], 0, $options[8]);
                $articles['sublead']     = xoops_substr($articles['lead'], 0, $options[8]);
                $articles['subteaser']   = xoops_substr($articles['teaser'], 0, $options[8]);
                $articles['subbodytext'] = xoops_substr($articles['bodytext'], 0, $options[8]);
                $articles['bodytext']    = '';

                if ('datesub' === $sortname) {
                    $articles['new'] = $myts->htmlSpecialChars(formatTimestamp($articles['datesub'], $soapConfig['dateformat']));
                } elseif ('counter' === $sortname) {
                    $articles['new'] = _MB_SOAPBOX_HITS . $articles['counter'];
                } elseif ('weight' === $sortname) {
                    $articles['new'] = _MB_SOAPBOX_WEIGHT . $articles['weight'];
                } elseif ('rating' === $sortname) {
                    $articles['new'] = _MB_SOAPBOX_RATING . number_format($articles['rating'], 2, '.', '') . _MB_SOAPBOX_VOTE . $articles['votes'];
                } else {
                    $articles['new'] = $myts->htmlSpecialChars(formatTimestamp($articles['datesub'], $soapConfig['dateformat']));
                }
                //--------------------
                $_outdata_arr['artdatas'][$i] = $articles;
                unset($articles);
                ++$i;
            }
        }
        //-------------------------------------
        $block_outdata['coldatas'][$i_col] = $_outdata_arr;
        unset($_outdata_arr);
        ++$i_col;
    }

    return $block_outdata;
}