XoopsModules25x / smartpartner

class/partnercatlink.php

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 37 and the first side effect is on line 31.

// 
// ------------------------------------------------------------------------ //
//               XOOPS - PHP Content Management System                      //
//                   Copyright (c) 2000-2016 XOOPS.org                           //
//                      <http://xoops.org/>                             //
// ------------------------------------------------------------------------ //
// This program is free software; you can redistribute it and/or modify     //
// it under the terms of the GNU General Public License as published by     //
// the Free Software Foundation; either version 2 of the License, or        //
// (at your option) any later version.                                      //

// You may not change or alter any portion of this comment or credits       //
// of supporting developers from this source code or any supporting         //
// source code which is considered copyrighted (c) material of the          //
// original comment or credit authors.                                      //
// This program is distributed in the hope that it will be useful,          //
// but WITHOUT ANY WARRANTY; without even the implied warranty of           //
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
// GNU General Public License for more details.                             //

// You should have received a copy of the GNU General Public License        //
// along with this program; if not, write to the Free Software              //
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
// ------------------------------------------------------------------------ //
// URL: http://xoops.org/                                               //
// Project: XOOPS Project                                               //
// -------------------------------------------------------------------------//

// defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

70% of this comment could be valid code. Did you maybe forget this after debugging?

include_once XOOPS_ROOT_PATH . '/modules/smartobject/class/smartobject.php';
include_once XOOPS_ROOT_PATH . '/modules/smartobject/class/smartobjecthandler.php';

/**
 * Class SmartpartnerPartnerCatLink
 */
class SmartpartnerPartner_cat_link extends SmartObject

The type SmartpartnerPartner_cat_link has been defined more than once; this definition is ignored, only the first definition in class/partner_cat_link.php (L37-48) is considered.

This class seems to be duplicated in your project.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * SmartpartnerPartnerCatLink constructor.
     */
    public function __construct()
    {
        $this->initVar('partner_cat_linkid', XOBJ_DTYPE_INT, '', true);
        $this->initVar('partnerid', XOBJ_DTYPE_INT, '', true);
        $this->initVar('categoryid', XOBJ_DTYPE_INT, '', true);
    }
}

/**
 * Class SmartpartnerPartnerCatLinkHandler
 */
class SmartpartnerPartner_cat_linkHandler extends SmartPersistableObjectHandler

The type SmartpartnerPartner_cat_linkHandler has been defined more than once; this definition is ignored, only the first definition in class/partner_cat_link.php (L53-80) is considered.

This class seems to be duplicated in your project.

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * SmartpartnerPartnerCatLinkHandler constructor.
     * @param object|XoopsDatabase $db
     */
    public function __construct(XoopsDatabase $db)
    {
        parent::__construct($db, 'partner_cat_link', array('partnerid', 'categoryid'), '', false, 'smartpartner');
    }

    /**
     * @param $partnerid
     * @return string
     */
    public function getParentIds($partnerid)
    {
        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('partnerid', $partnerid));
        $links        = $this->getObjects($criteria);
        $parent_array = array();
        foreach ($links as $link) {
            $parent_array[] = $link->getVar('categoryid');
        }

        return implode('|', $parent_array);
    }
}