Issues in import.php (master) - Issues in master - XoopsModules25x/smartpartner - Measure and Improve Code Quality continuously with Scrutinizer

Issues (733)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

admin/import.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 *
 * Module: SmartPartner
 * Author: The SmartFactory <www.smartfactory.ca>
 * Licence: GNU
 */

include_once __DIR__ . '/admin_header.php';

$op = 'none';

if (isset($_GET['op'])) {
    $op = $_GET['op'];
}
if (isset($_POST['op'])) {
    $op = $_POST['op'];
}

global $xoopsDB, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}

switch ($op) {

    case 'importExecute':
        $importfile      = isset($_POST['importfile']) ? $_POST['importfile'] : 'nonselected';
        $importfile_path = XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/' . $importfile . '.php';
        if (!file_exists($importfile_path)) {
            $errs[] = sprintf(_AM_SPARTNER_IMPORT_FILE_NOT_FOUND, $importfile_path);
            $error  = true;
        } else {
            include_once($importfile_path);
        }
        foreach ($msgs as $m) {
            echo $m . '<br>';
        }
        echo '<br>';
        if ($error == true) {

            $endMsg = _AM_SPARTNER_IMPORT_ERROR;
        } else {
            $endMsg = _AM_SPARTNER_IMPORT_SUCCESS;
        }

        echo $endMsg;
        echo '<br><br>';
        echo "<a href='import.php'>" . _AM_SPARTNER_IMPORT_BACK . '</a>';
        echo '<br><br>';
        break;

    case 'default':
    default:
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}

        $importfile = 'none';

        smartpartner_xoops_cp_header();
        $indexAdmin = new ModuleAdmin();
        echo $indexAdmin->addNavigation(basename(__FILE__));

        smartpartner_collapsableBar('bottomtable', 'bottomtableicon', _AM_SPARTNER_IMPORT_TITLE, _AM_SPARTNER_IMPORT_INFO);

        global $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $modify, $xoopsModuleConfig, $xoopsModule, $XOOPS_URL, $myts;
function myFunction($a, $b) {
    // Do something
}

        include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

        $moduleHandler = xoops_getHandler('module');
        if ($moduleHandler->getByDirname('xoopspartners')) {
            $importfile_select_array['xoopspartners'] = _AM_SPARTNER_IMPORT_XOOPSPARTNERS_110;
        }

        if (isset($importfile_select_array) && count($importfile_select_array) > 0) {
            $sform = new XoopsThemeForm(_AM_SPARTNER_IMPORT_SELECTION, 'op', xoops_getenv('PHP_SELF'));
            $sform->setExtra('enctype="multipart/form-data"');

            // Partners to import
            $importfile_select = new XoopsFormSelect('', 'importfile', $importfile);
            $importfile_select->addOptionArray($importfile_select_array);
            $importfile_tray = new XoopsFormElementTray(_AM_SPARTNER_IMPORT_SELECT_FILE, '&nbsp;');
            $importfile_tray->addElement($importfile_select);
            $importfile_tray->setDescription(_AM_SPARTNER_IMPORT_SELECT_FILE_DSC);
            $sform->addElement($importfile_tray);

            // Buttons
            $button_tray = new XoopsFormElementTray('', '');
            $hidden      = new XoopsFormHidden('op', 'importExecute');
            $button_tray->addElement($hidden);

            $butt_import = new XoopsFormButton('', '', _AM_SPARTNER_IMPORT, 'submit');
            $butt_import->setExtra('onclick="this.form.elements.op.value=\'importExecute\'"');
            $button_tray->addElement($butt_import);

            $butt_cancel = new XoopsFormButton('', '', _AM_SPARTNER_CANCEL, 'button');
            $butt_cancel->setExtra('onclick="history.go(-1)"');
            $button_tray->addElement($butt_cancel);

            $sform->addElement($button_tray);
            $sform->display();
            unset($hidden);
        } else {
            echo "<span style=\"color: #567; margin: 3px 0 12px 0; font-weight: bold; font-size: small; display: block; \">" . _AM_SPARTNER_IMPORT_NO_MODULE . '</span>';
        }

        // End of collapsable bar
        smartpartner_close_collapsable('bottomtable', 'bottomtableicon');

        break;
}

//smart_modFooter();

//xoops_cp_footer();
include_once __DIR__ . '/admin_footer.php';


1			<?php
2
3			/**
4			*
5			* Module: SmartPartner
6			* Author: The SmartFactory <www.smartfactory.ca>
7			* Licence: GNU
8			*/
9
10			include_once __DIR__ . '/admin_header.php';
11
12			$op = 'none';
13
14			if (isset($_GET['op'])) {
15			$op = $_GET['op'];
16			}
17			if (isset($_POST['op'])) {
18			$op = $_POST['op'];
19			}
20
21			global $xoopsDB, $xoopsModule;
			0 ignored issues – show Compatibility Best Practice introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
22
23			switch ($op) {
24
25			case 'importExecute':
26			$importfile = isset($_POST['importfile']) ? $_POST['importfile'] : 'nonselected';
27			$importfile_path = XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/' . $importfile . '.php';
28			if (!file_exists($importfile_path)) {
29			$errs[] = sprintf(_AM_SPARTNER_IMPORT_FILE_NOT_FOUND, $importfile_path);
30			$error = true;
31			} else {
32			include_once($importfile_path);
33			}
34			foreach ($msgs as $m) {
35			echo $m . '<br>';
36			}
37			echo '<br>';
38			if ($error == true) {
			0 ignored issues – show Coding Style Best Practice introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
39			$endMsg = _AM_SPARTNER_IMPORT_ERROR;
40			} else {
41			$endMsg = _AM_SPARTNER_IMPORT_SUCCESS;
42			}
43
44			echo $endMsg;
45			echo '<br><br>';
46			echo "<a href='import.php'>" . _AM_SPARTNER_IMPORT_BACK . '</a>';
47			echo '<br><br>';
48			break;
49
50			case 'default':
51			default:
			0 ignored issues – show Coding Style introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
52
53			$importfile = 'none';
54
55			smartpartner_xoops_cp_header();
56			$indexAdmin = new ModuleAdmin();
57			echo $indexAdmin->addNavigation(basename(__FILE__));
58
59			smartpartner_collapsableBar('bottomtable', 'bottomtableicon', _AM_SPARTNER_IMPORT_TITLE, _AM_SPARTNER_IMPORT_INFO);
60
61			global $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $modify, $xoopsModuleConfig, $xoopsModule, $XOOPS_URL, $myts;
			0 ignored issues – show Compatibility Best Practice introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
62
63			include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
64
65			$moduleHandler = xoops_getHandler('module');
66			if ($moduleHandler->getByDirname('xoopspartners')) {
67			$importfile_select_array['xoopspartners'] = _AM_SPARTNER_IMPORT_XOOPSPARTNERS_110;
68			}
69
70			if (isset($importfile_select_array) && count($importfile_select_array) > 0) {
71			$sform = new XoopsThemeForm(_AM_SPARTNER_IMPORT_SELECTION, 'op', xoops_getenv('PHP_SELF'));
72			$sform->setExtra('enctype="multipart/form-data"');
73
74			// Partners to import
75			$importfile_select = new XoopsFormSelect('', 'importfile', $importfile);
76			$importfile_select->addOptionArray($importfile_select_array);
77			$importfile_tray = new XoopsFormElementTray(_AM_SPARTNER_IMPORT_SELECT_FILE, ' ');
78			$importfile_tray->addElement($importfile_select);
79			$importfile_tray->setDescription(_AM_SPARTNER_IMPORT_SELECT_FILE_DSC);
80			$sform->addElement($importfile_tray);
81
82			// Buttons
83			$button_tray = new XoopsFormElementTray('', '');
84			$hidden = new XoopsFormHidden('op', 'importExecute');
85			$button_tray->addElement($hidden);
86
87			$butt_import = new XoopsFormButton('', '', _AM_SPARTNER_IMPORT, 'submit');
88			$butt_import->setExtra('onclick="this.form.elements.op.value=\'importExecute\'"');
89			$button_tray->addElement($butt_import);
90
91			$butt_cancel = new XoopsFormButton('', '', _AM_SPARTNER_CANCEL, 'button');
92			$butt_cancel->setExtra('onclick="history.go(-1)"');
93			$button_tray->addElement($butt_cancel);
94
95			$sform->addElement($button_tray);
96			$sform->display();
97			unset($hidden);
98			} else {
99			echo "<span style=\"color: #567; margin: 3px 0 12px 0; font-weight: bold; font-size: small; display: block; \">" . _AM_SPARTNER_IMPORT_NO_MODULE . '</span>';
100			}
101
102			// End of collapsable bar
103			smartpartner_close_collapsable('bottomtable', 'bottomtableicon');
104
105			break;
106			}
107
108			//smart_modFooter();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
109			//xoops_cp_footer();
110			include_once __DIR__ . '/admin_footer.php';
111

XoopsModules25x / smartpartner

Issues (733)

Security Analysis not enabled

admin/import.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like