onupdate.inc.php ➔ xoops_module_update_smartpartner()

Complexity

Conditions	18
Paths	978

Size

Total Lines	175
Code Lines	67

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function xoops_module_update_smartpartner($module)
{
    include_once(XOOPS_ROOT_PATH . '/modules/' . $module->getVar('dirname') . '/include/functions.php');
    include_once(XOOPS_ROOT_PATH . '/modules/smartobject/class/smartdbupdater.php');

    $dbupdater = new SmartobjectDbupdater();

$dbupdater is not used, you could remove the assignment.

    ob_start();

    $dbVersion = smartpartner_GetMeta('version');

    $dbupdater = new SmartobjectDbupdater();

    echo '<code>' . _SDU_UPDATE_UPDATING_DATABASE . '<br>';

    //smartpartner_create_upload_folders();

    // db migrate version = 3
    $newDbVersion = 3;
    if ($dbVersion < $newDbVersion) {
        echo 'Database migrate to version ' . $newDbVersion . '<br>';

        $table = new SmartDbTable('smartpartner_partner');
        $table->addNewField('email_priv', " tinyint(1) NOT NULL default '0'");
        $table->addNewField('phone_priv', " tinyint(1) NOT NULL default '0'");
        $table->addNewField('adress_priv', " tinyint(1) NOT NULL default '0'");

        if (!$dbupdater->updateTable($table)) {

This if statement is empty and can be removed.

            /**
             * @todo trap the errors
             */
        }
        unset($table);
    }
    // db migrate version =4
    $newDbVersion = 4;
    if ($dbVersion < $newDbVersion) {
        echo 'Database migrate to version ' . $newDbVersion . '<br>';
        //create new tables
        // Create table smartpartner_categories
        $table = new SmartDbTable('smartpartner_categories');
        if (!$table->exists()) {
            $table->setStructure("
              `categoryid` int(11) NOT NULL auto_increment,
              `parentid` int(11) NOT NULL default '0',
              `name` varchar(100) NOT NULL default '',
              `description` text NOT NULL,
              `image` varchar(255) NOT NULL default '',
              `total` int(11) NOT NULL default '0',
              `weight` int(11) NOT NULL default '1',
              `created` int(11) NOT NULL default '0',
              PRIMARY KEY  (`categoryid`)
            ");

            if (!$dbupdater->updateTable($table)) {

This if statement is empty and can be removed.

                /**
                 * @todo trap the errors
                 */
            }
        }
        // Create table smartpartner_partner_cat_link
        $table = new SmartDbTable('smartpartner_partner_cat_link');
        if (!$table->exists()) {
            $table->setStructure("
              `partner_cat_linkid` int(11) NOT NULL auto_increment,
              `categoryid` int(11) NOT NULL default '0',
              `partnerid` int(11) NOT NULL default '0',
               PRIMARY KEY  (`partner_cat_linkid`)
            ");

            if (!$dbupdater->updateTable($table)) {

This if statement is empty and can be removed.

                /**
                 * @todo trap the errors
                 */
            }
        }

        // Create table smartpartner_offer
        $table = new SmartDbTable('smartpartner_offer');
        if (!$table->exists()) {
            $table->setStructure("
               `offerid` int(11) NOT NULL auto_increment,
              `partnerid` int(11) NOT NULL default '0',
              `title` varchar(255) NOT NULL default '',
              `description` TEXT NOT NULL,
              `url` varchar(150) default '',
              `image` varchar(150) NOT NULL default '',
              `date_sub` int(11) NOT NULL default '0',
              `date_pub` int(11) NOT NULL default '0',
              `date_end` int(11) NOT NULL default '0',
              `status` int(10) NOT NULL default '-1',
              `weight` int(1) NOT NULL default '0',
              `dohtml` int(1) NOT NULL default '1',
              PRIMARY KEY  (`offerid`)
            ");

            if (!$dbupdater->updateTable($table)) {

This if statement is empty and can be removed.

                /**
                 * @todo trap the errors
                 */
            }
        }

        // Create table smartpartner_offer
        $table = new SmartDbTable('smartpartner_files');
        if (!$table->exists()) {
            $table->setStructure("
              `fileid` int(11) NOT NULL auto_increment,
              `id` int(11) NOT NULL default '0',
              `name` varchar(255) NOT NULL default '',
              `description` TEXT NOT NULL,
              `filename` varchar(255) NOT NULL default '',
              `mimetype` varchar(64) NOT NULL default '',
              `uid` int(6) default '0',
              `datesub` int(11) NOT NULL default '0',
              `status` int(1) NOT NULL default '-1',
              `notifypub` tinyint(1) NOT NULL default '1',
              `counter` int(8) unsigned NOT NULL default '0',
              PRIMARY KEY  (`fileid`)
            ");

            if (!$dbupdater->updateTable($table)) {

This if statement is empty and can be removed.

                /**
                 * @todo trap the errors
                 */
            }
        }
        //loop in partners to insert cat_links in partner_cat_link table
        $smartpartnerPartnerHandler = xoops_getModuleHandler('partner', 'smartpartner');
        //        $smartpartnerPartnerCatLinkHandler = xoops_getModuleHandler('partner_cat_link', 'smartpartner');

54% of this comment could be valid code. Did you maybe forget this after debugging?

        $smartpartnerPartnerCatLinkHandler = xoops_getModuleHandler('partner_cat_link', 'smartpartner');

        $modulepermHandler = xoops_getHandler('groupperm');
        $moduleHandler     = xoops_getHandler('module');
        $module            = $moduleHandler->getByDirname('smartpartner');
        $groupsArray       = $modulepermHandler->getGroupIds('module_read', $module->mid(), 1);

        $sql     = 'SELECT id, categoryid from ' . $smartpartnerPartnerHandler->table;
        $records = $smartpartnerPartnerHandler->query($sql);
        foreach ($records as $record) {
            if ($record['categoryid'] != 0) {
                $new_link = $smartpartnerPartnerCatLinkHandler->create();
                $new_link->setVar('partnerid', $record['id']);
                $new_link->setVar('categoryid', $record['categoryid']);
                $smartpartnerPartnerCatLinkHandler->insert($new_link);
                unset($new_link);
            }
            foreach ($groupsArray as $group) {
                $modulepermHandler->addRight('full_view', $record['id'], $group, $module->mid());
            }
        }
        //drop cat_id in partner table
        $table = new SmartDbTable('smartpartner_partner');
        $table->addNewField('last_update', " int(11) NOT NULL default '0'");
        $table->addNewField('showsummary', " tinyint(1) NOT NULL default '0'");
        $table->addDroppedField('categoryid');
        if (!$dbupdater->updateTable($table)) {

This if statement is empty and can be removed.

            /**
             * @todo trap the errors
             */
        }
        unset($table);
    }
    echo '</code>';

    $feedback = ob_get_clean();
    if (method_exists($module, 'setMessage')) {
        $module->setMessage($feedback);
    } else {
        echo $feedback;
    }
    smartpartner_SetMeta('version', isset($newDbVersion) ? $newDbVersion : 0); //Set meta version to current

    return true;
}