partner.php ➔ showfiles() - Code Metrics - XoopsModules25x/smartpartner - Measure and Improve Code Quality continuously with Scrutinizer

partner.php ➔ showfiles() B
last analyzed 2017-05-24 21:52 UTC

↳ Parent: Project

Complexity

Conditions	4
Paths	2

Size

Total Lines	66
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	56
nc	2
nop	1
dl	0
loc	66
rs	8.8291
c	0
b	0
f	0

How to fix Long Method

<?php


/**
 *
 * Module: SmartPartner
 * Author: The SmartFactory <www.smartfactory.ca>
 * Licence: GNU
 * @param $partnerObj
 */
function showfiles($partnerObj)
{
    // UPLOAD FILES
    //include_once XOOPS_ROOT_PATH . '/modules/smartpartner/include/functions.php';

    global $xoopsModule, $smartPartnerFileHandler;
function myFunction($a, $b) {
    // Do something
}
    $pathIcon16 = '../' . $xoopsModule->getInfo('icons16');
    smartpartner_collapsableBar('filetable', 'filetableicon', _AM_SPARTNER_FILES_LINKED);
    $filesObj = $smartPartnerFileHandler->getAllFiles($partnerObj->id());
    if (count($filesObj) > 0) {
        echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
        echo '<tr>';
        echo "<td width='50' class='bg3' align='center'><b>ID</b></td>";
        echo "<td width='150' class='bg3' align='left'><b>" . _AM_SPARTNER_FILENAME . '</b></td>';
        echo "<td class='bg3' align='left'><b>" . _AM_SPARTNER_DESCRIPTION . '</b></td>';
        echo "<td width='60' class='bg3' align='center'><b>" . _AM_SPARTNER_HITS . '</b></td>';
        echo "<td width='100' class='bg3' align='center'><b>" . _AM_SPARTNER_UPLOADED_DATE . '</b></td>';
        echo "<td width='60' class='bg3' align='center'><b>" . _AM_SPARTNER_ACTION . '</b></td>';
        echo '</tr>';

        for ($i = 0, $iMax = count($filesObj); $i < $iMax; ++$i) {
            $modify = "<a href='file.php?op=mod&fileid="
                      . $filesObj[$i]->fileid()
                      . "'><img src='"
                      . $pathIcon16
                      . '/edit.png'
                      . "'  title='"
                      . _AM_SPARTNER_EDITFILE
                      . "' alt='"
                      . _AM_SPARTNER_EDITFILE
                      . "' /></a>";
            $delete = "<a href='file.php?op=del&fileid="
                      . $filesObj[$i]->fileid()
                      . "'><img src='"
                      . $pathIcon16
                      . '/delete.png'
                      . "'  title='"
                      . _AM_SPARTNER_DELETEFILE
                      . "' alt='"
                      . _AM_SPARTNER_DELETEFILE
                      . "'/></a>";
            if ($filesObj[$i]->status() == 0) {
                $not_visible = "<img src='" . XOOPS_URL . '/modules/' . $xoopsModule->dirname() . "/assets/images/no.gif'/>";
            } else {
                $not_visible = '';
            }
            echo '<tr>';
            echo "<td class='head' align='center'>" . $filesObj[$i]->getVar('fileid') . '</td>';
            echo "<td class='odd' align='left'>" . $not_visible . $filesObj[$i]->getFileLink() . '</td>';
            echo "<td class='even' align='left'>" . $filesObj[$i]->description() . '</td>';
            echo "<td class='even' align='center'>" . $filesObj[$i]->counter() . '';
            echo "<td class='even' align='center'>" . $filesObj[$i]->datesub() . '</td>';
            echo "<td class='even' align='center'> $modify $delete </td>";
            echo '</tr>';
        }
        echo '</table>';
        echo '<br >';
    } else {
        echo "<span style=\"color: #567; margin: 3px 0 12px 0; font-size: small; display: block; \">" . _AM_SPARTNER_NOFILE . '</span>';
    }

    echo "<form><div style=\"margin-bottom: 24px;\">";
    echo "<input type='button' name='button' onclick=\"location='file.php?op=mod&id=" . $partnerObj->id() . "'\" value='" . _AM_SPARTNER_UPLOAD_FILE_NEW . "'>&nbsp;&nbsp;";
    echo '</div></form>';

    smartpartner_close_collapsable('filetable', 'filetableicon');
}

/**
 * @param bool $showmenu
 * @param int  $id
 */
function editpartner($showmenu = false, $id = 0)
{
    global $xoopsDB, $smartPartnerPartnerHandler, $xoopsUser, $xoopsConfig, $xoopsModuleConfig, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
    if (!isset($smartPartnerPartnerHandler)) {
        $smartPartnerPartnerHandler = smartpartner_gethandler('partner');
    }
    include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
    // If there is a parameter, and the id exists, retrieve data: we're editing a partner
    if ($id != 0) {
        // Creating the partner object
        $partnerObj = new SmartpartnerPartner($id);

        if ($partnerObj->notLoaded()) {
            redirect_header('partner.php', 1, _AM_SPARTNER_NOPARTNERSELECTED);
        }

        switch ($partnerObj->status()) {

            case _SPARTNER_STATUS_SUBMITTED:
                $breadcrumb_action1 = _AM_SPARTNER_SUBMITTED_PARTNERS;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $breadcrumb_action2 = _AM_SPARTNER_APPROVING;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $page_title         = _AM_SPARTNER_SUBMITTED_TITLE;
                $page_info          = _AM_SPARTNER_SUBMITTED_INFO;
                $button_caption     = _AM_SPARTNER_APPROVE;
                $new_status         = _SPARTNER_STATUS_ACTIVE;
                break;

            case _SPARTNER_STATUS_ACTIVE:
                $breadcrumb_action1 = _AM_SPARTNER_ACTIVE_PARTNERS;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $breadcrumb_action2 = _AM_SPARTNER_EDITING;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $page_title         = _AM_SPARTNER_ACTIVE_EDITING;
                $page_info          = _AM_SPARTNER_ACTIVE_EDITING_INFO;
                $button_caption     = _AM_SPARTNER_MODIFY;
                $new_status         = _SPARTNER_STATUS_ACTIVE;
                break;

            case _SPARTNER_STATUS_INACTIVE:
                $breadcrumb_action1 = _AM_SPARTNER_INACTIVE_PARTNERS;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $breadcrumb_action2 = _AM_SPARTNER_EDITING;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $page_title         = _AM_SPARTNER_INACTIVE_EDITING;
                $page_info          = _AM_SPARTNER_INACTIVE_EDITING_INFO;
                $button_caption     = _AM_SPARTNER_MODIFY;
                $new_status         = _SPARTNER_STATUS_INACTIVE;
                break;

            case _SPARTNER_STATUS_REJECTED:
                $breadcrumb_action1 = _AM_SPARTNER_REJECTED_PARTNERS;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $breadcrumb_action2 = _AM_SPARTNER_EDITING;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $page_title         = _AM_SPARTNER_REJECTED_EDITING;
                $page_info          = _AM_SPARTNER_REJECTED_EDITING_INFO;
                $button_caption     = _AM_SPARTNER_MODIFY;
                $new_status         = _SPARTNER_STATUS_REJECTED;
                break;

            case 'default':
            default:
                break;
        }

        echo "<br>\n";
        smartpartner_collapsableBar('editpartner', 'editpartmericon', $page_title, $page_info);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    } else {
        // there's no parameter, so we're adding a partner
        $partnerObj         = $smartPartnerPartnerHandler->create();
        $breadcrumb_action1 = _AM_SPARTNER_PARTNERS;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $breadcrumb_action2 = _AM_SPARTNER_CREATE;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $button_caption     = _AM_SPARTNER_CREATE;
        $new_status         = _SPARTNER_STATUS_ACTIVE;
        smartpartner_collapsableBar('addpartner', 'addpartnericon', _AM_SPARTNER_PARTNER_CREATING, _AM_SPARTNER_PARTNER_CREATING_DSC);
    }

    // PARTNER FORM
    $sform = new XoopsThemeForm(_AM_SPARTNER_PARTNERS, 'op', xoops_getenv('PHP_SELF'));
    $sform->setExtra('enctype="multipart/form-data"');

    // TITLE
    $title_text = new XoopsFormText(_AM_SPARTNER_TITLE, 'title', 50, 255, $partnerObj->title('e'));
    $sform->addElement($title_text, true);

    // Parent Category
    $mytree = new SmartTree($xoopsDB->prefix('smartpartner_categories'), 'categoryid', 'parentid');
    ob_start();
    $mytree->makeMySelBox('name', 'weight', explode('|', $partnerObj->categoryid()), 0, 'categoryid', '', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    //makeMySelBox($title,$order="",$preset_id=0, $none=0, $sel_name="", $onchange="")

    $parent_cat_select = new XoopsFormLabel(_AM_SPARTNER_CATEGORY_BELONG, ob_get_contents());
    $parent_cat_select->setDescription(_AM_SPARTNER_BELONG_CATEGORY_DSC);
    $sform->addElement($parent_cat_select);
    ob_end_clean();

    // LOGO
    $logo_array  = XoopsLists:: getImgListAsArray(smartpartner_getImageDir());
    $logo_select = new XoopsFormSelect('', 'image', $partnerObj->image());
    $logo_select->addOption('-1', '---------------');
    $logo_select->addOptionArray($logo_array);
    $logo_select->setExtra("onchange='showImgSelected(\"image3\", \"image\", \"" . 'uploads/' . SMARTPARTNER_DIRNAME . '/images' . "\", \"\", \"" . XOOPS_URL . "\")'");
    $logo_tray = new XoopsFormElementTray(_AM_SPARTNER_LOGO, '&nbsp;');
    $logo_tray->addElement($logo_select);
    $logo_tray->addElement(new XoopsFormLabel('', "<br><br><img src='" . smartpartner_getImageDir('', false) . $partnerObj->image() . "' name='image3' id='image3' alt='' />"));
    $logo_tray->setDescription(_AM_SPARTNER_LOGO_DSC);
    $sform->addElement($logo_tray);

    // LOGO UPLOAD
    $max_size = 5000000;
    $file_box = new XoopsFormFile(_AM_SPARTNER_LOGO_UPLOAD, 'logo_file', $max_size);
    $file_box->setExtra("size ='45'");
    $file_box->setDescription(sprintf(_AM_SPARTNER_LOGO_UPLOAD_DSC, $xoopsModuleConfig['img_max_width'], $xoopsModuleConfig['img_max_height']));
    $sform->addElement($file_box);

    // IMAGE_URL
    $image_url_text = new XoopsFormText(_CO_SPARTNER_IMAGE_URL, 'image_url', 50, 255, $partnerObj->image_url());
    $image_url_text->setDescription(_CO_SPARTNER_IMAGE_URL_DSC);
    $sform->addElement($image_url_text, false);

    // URL
    $url_text = new XoopsFormText(_AM_SPARTNER_URL, 'url', 50, 255, $partnerObj->url());
    $url_text->setDescription(_AM_SPARTNER_URL_DSC);
    $sform->addElement($url_text, false);

    // SUMMARY
    $summary_text = new XoopsFormTextArea(_AM_SPARTNER_SUMMARY, 'summary', $partnerObj->summary(0, 'e'), 7, 60);
    $summary_text->setDescription(_AM_SPARTNER_SUMMARY_DSC);
    $sform->addElement($summary_text, true);

    // SHOW summary on partner page
    $showsum_radio = new XoopsFormRadioYN(_AM_SPARTNER_SHOW_SUMMARY, 'showsummary', $partnerObj->getVar('showsummary'));
    $showsum_radio->setDescription(_AM_SPARTNER_SHOW_SUMMARY_DSC);
    $sform->addElement($showsum_radio);

    // DESCRIPTION
    $description_text = new XoopsFormDhtmlTextArea(_AM_SPARTNER_DESCRIPTION, 'description', $partnerObj->description(0, 'e'), 15, 60);
    $description_text->setDescription(_AM_SPARTNER_DESCRIPTION_DSC);
    $sform->addElement($description_text, false);

    // CONTACT_NAME
    $contact_name_text = new XoopsFormText(_CO_SPARTNER_CONTACT_NAME, 'contact_name', 50, 255, $partnerObj->contact_name('e'));
    $contact_name_text->setDescription(_CO_SPARTNER_CONTACT_NAME_DSC);
    $sform->addElement($contact_name_text, false);

    // CONTACT_EMAIL
    $contact_email_text = new XoopsFormText(_CO_SPARTNER_CONTACT_EMAIL, 'contact_email', 50, 255, $partnerObj->contact_email('e'));
    $contact_email_text->setDescription(_CO_SPARTNER_CONTACT_EMAIL_DSC);
    $sform->addElement($contact_email_text, false);

    // EMAIL_PRIV
    $email_priv_radio = new XoopsFormRadioYN(_CO_SPARTNER_CONTACT_EMAILPRIV, 'email_priv', $partnerObj->email_priv('e'));
    $email_priv_radio->setDescription(_CO_SPARTNER_CONTACT_EMAILPRIV_DSC);
    $sform->addElement($email_priv_radio);

    // CONTACT_PHONE
    $contact_phone_text = new XoopsFormText(_CO_SPARTNER_CONTACT_PHONE, 'contact_phone', 50, 255, $partnerObj->contact_phone('e'));
    $contact_phone_text->setDescription(_CO_SPARTNER_CONTACT_PHONE_DSC);
    $sform->addElement($contact_phone_text, false);

    // PHONE_PRIV
    $phone_priv_radio = new XoopsFormRadioYN(_CO_SPARTNER_CONTACT_PHONEPRIV, 'phone_priv', $partnerObj->phone_priv('e'));
    $phone_priv_radio->setDescription(_CO_SPARTNER_CONTACT_PHONEPRIV_DSC);
    $sform->addElement($phone_priv_radio);

    // ADRESS
    //$adress_text = new XoopsFormText(_CO_SPARTNER_ADRESS, 'adress', 50, 255, $partnerObj->adress('e'));

    $adress_text = new XoopsFormTextArea(_CO_SPARTNER_ADRESS, 'adress', $partnerObj->adress('e'));
    $adress_text->setDescription(_CO_SPARTNER_ADRESS_DSC);
    $sform->addElement($adress_text, false);

    // ADRESS_PRIV
    $adress_priv_radio = new XoopsFormRadioYN(_CO_SPARTNER_CONTACT_ADRESSPRIV, 'adress_priv', $partnerObj->adress_priv('e'));
    $adress_priv_radio->setDescription(_CO_SPARTNER_CONTACT_ADRESSPRIV_DSC);
    $sform->addElement($adress_priv_radio);

    // STATUS
    $options       = $partnerObj->getAvailableStatus();
    $status_select = new XoopsFormSelect(_AM_SPARTNER_STATUS, 'status', $new_status);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    $status_select->addOptionArray($options);
    $status_select->setDescription(_AM_SPARTNER_STATUS_DSC);
    $sform->addElement($status_select);

    // WEIGHT
    $weight_text = new XoopsFormText(_AM_SPARTNER_WEIGHT, 'weight', 4, 4, $partnerObj->weight());
    $weight_text->setDescription(_AM_SPARTNER_WEIGHT_DSC);
    $sform->addElement($weight_text);

    //perms
    global $smartPermissionsHandler;
function myFunction($a, $b) {
    // Do something
}
    include_once XOOPS_ROOT_PATH . '/modules/smartobject/class/smartobjectpermission.php';
    $smartPermissionsHandler = new SmartobjectPermissionHandler($smartPartnerPartnerHandler);

    if ($partnerObj->id() != 0) {
        $grantedGroups = $smartPermissionsHandler->getGrantedGroups('full_view', $partnerObj->id());
    } else {
        $grantedGroups = $xoopsModuleConfig['default_full_view'];
    }
    $full_view_select = new XoopsFormSelectGroup(_CO_SPARTNER_FULL_PERM_READ, 'full_view', true, $grantedGroups, 5, true);
    $full_view_select->setDescription(_CO_SPARTNER_FULL_PERM_READ_DSC);
    $sform->addElement($full_view_select);

    if ($partnerObj->id() != 0) {
        $partGrantedGroups = $smartPermissionsHandler->getGrantedGroups('partial_view', $partnerObj->id());
    } else {
        $partGrantedGroups = $xoopsModuleConfig['default_part_view'];
    }
    $part_view_select = new XoopsFormSelectGroup(_CO_SPARTNER_PART_PERM_READ, 'partial_view', true, $partGrantedGroups, 5, true);
    $part_view_select->setDescription(_CO_SPARTNER_PART_PERM_READ_DSC);
    $sform->addElement($part_view_select);

    // Partner id
    $sform->addElement(new XoopsFormHidden('id', $partnerObj->id()));

    $button_tray = new XoopsFormElementTray('', '');
    $hidden      = new XoopsFormHidden('op', 'addpartner');
    $button_tray->addElement($hidden);

    $sform->addElement(new XoopsFormHidden('original_status', $partnerObj->status()));

    if (!$id) {
        // there's no id? Then it's a new partner
        // $button_tray -> addElement( new XoopsFormButton( '', 'mod', _AM_SPARTNER_CREATE, 'submit' ) );

        $butt_create = new XoopsFormButton('', '', _AM_SPARTNER_CREATE, 'submit');
        $butt_create->setExtra('onclick="this.form.elements.op.value=\'addpartner\'"');
        $button_tray->addElement($butt_create);

        $butt_clear = new XoopsFormButton('', '', _AM_SPARTNER_CLEAR, 'reset');
        $button_tray->addElement($butt_clear);

        $butt_cancel = new XoopsFormButton('', '', _AM_SPARTNER_CANCEL, 'button');
        $butt_cancel->setExtra('onclick="history.go(-1)"');
        $button_tray->addElement($butt_cancel);
    } else {
        // else, we're editing an existing partner
        // $button_tray -> addElement( new XoopsFormButton( '', 'mod', _AM_SPARTNER_MODIFY, 'submit' ) );

        $butt_create = new XoopsFormButton('', '', $button_caption, 'submit');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $butt_create->setExtra('onclick="this.form.elements.op.value=\'addpartner\'"');
        $button_tray->addElement($butt_create);

        $butt_cancel = new XoopsFormButton('', '', _AM_SPARTNER_CANCEL, 'button');
        $butt_cancel->setExtra('onclick="history.go(-1)"');
        $button_tray->addElement($butt_cancel);
    }

    $sform->addElement($button_tray);
    $sform->display();
    unset($hidden);
    if (!$id) {
        smartpartner_close_collapsable('addpartner', 'addpartnericon');
    } else {
        smartpartner_close_collapsable('editpartner', 'editpartnericon');
    }
    if ($id != 0) {
        showfiles($partnerObj);
    }
}

include_once __DIR__ . '/admin_header.php';
include(XOOPS_ROOT_PATH . '/class/xoopstree.php');

$op = '';
if (isset($_GET['op'])) {
    $op = $_GET['op'];
}
if (isset($_POST['op'])) {
    $op = $_POST['op'];
}

// Where shall we start ?
$startpartner = isset($_GET['startpartner']) ? (int)$_GET['startpartner'] : 0;

if (!isset($smartPartnerPartnerHandler)) {
    $smartPartnerPartnerHandler = smartpartner_gethandler('partner');
}
/* -- Available operations -- */
switch ($op) {
    case 'add':
        xoops_cp_header();
        include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

        editpartner(true, 0);
        break;

    case 'mod':
        global $xoopsUser, $xoopsConfig, $xoopsModuleConfig, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
        $id = isset($_GET['id']) ? $_GET['id'] : 0;

        xoops_cp_header();
        include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

        editpartner(true, $id);
        break;

    case 'addpartner':
        global $xoopsUser;
function myFunction($a, $b) {
    // Do something
}

        if (!$xoopsUser) {
            if ($xoopsModuleConfig['anonpost'] == 1) {
                $uid = 0;
            } else {
                redirect_header('index.php', 3, _NOPERM);
            }
        } else {
            $uid = $xoopsUser->uid();
        }

        $id = isset($_POST['id']) ? (int)$_POST['id'] : 0;

        // Creating the partner object
        if ($id != 0) {
            $partnerObj = new SmartpartnerPartner($id);
        } else {
            $partnerObj = $smartPartnerPartnerHandler->create();
        }

        // Uploading the logo, if any
        // Retreive the filename to be uploaded
        if ($_FILES['logo_file']['name'] != '') {
            $filename = $_POST['xoops_upload_file'][0];
            if (!empty($filename) || $filename != '') {

                global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}

                $max_size          = 10000000;
                $max_imgwidth      = $xoopsModuleConfig['img_max_width'];
                $max_imgheight     = $xoopsModuleConfig['img_max_height'];
                $allowed_mimetypes = null; //smartpartner_getAllowedMimeTypes();

                include_once(XOOPS_ROOT_PATH . '/class/uploader.php');

                if ($_FILES[$filename]['tmp_name'] == '' || !is_readable($_FILES[$filename]['tmp_name'])) {
                    redirect_header('javascript:history.go(-1)', 2, _CO_SPARTNER_FILE_UPLOAD_ERROR);
                    exit;
                }

                $uploader = new XoopsMediaUploader(smartpartner_getImageDir(), $allowed_mimetypes, $max_size, $max_imgwidth, $max_imgheight);

                // TODO: prefix the image file with the partnerid, but for that we need to first save the partner to get partnerid...
                // $uploader->setTargetFileName($partnerObj->partnerid() . "_" . $_FILES['logo_file']['name']);


                if ($uploader->fetchMedia($filename) && $uploader->upload()) {
                    $partnerObj->setVar('image', $uploader->getSavedFileName());
                } else {
                    redirect_header('javascript:history.go(-1)', 2, _CO_SPARTNER_FILE_UPLOAD_ERROR . $uploader->getErrors());
                    exit;
                }
            }
        } else {
            $partnerObj->setVar('image', $_POST['image']);
        }

        // Putting the values in the partner object
        $partnerObj->setVar('id', isset($_POST['id']) ? (int)$_POST['id'] : 0);
        $partnerObj->setVar('categoryid', isset($_POST['categoryid']) ? implode('|', $_POST['categoryid']) : array(0));
        $partnerObj->setVar('status', isset($_POST['status']) ? (int)$_POST['status'] : 0);
        $partnerObj->setVar('title', $_POST['title']);
        $partnerObj->setVar('summary', $_POST['summary']);
        $partnerObj->setVar('image_url', $_POST['image_url']);
        $partnerObj->setVar('description', $_POST['description']);
        $partnerObj->setVar('contact_name', $_POST['contact_name']);
        $partnerObj->setVar('contact_email', $_POST['contact_email']);
        $partnerObj->setVar('contact_phone', $_POST['contact_phone']);
        $partnerObj->setVar('adress', $_POST['adress']);
        $partnerObj->setVar('url', $_POST['url']);
        $partnerObj->setVar('weight', isset($_POST['weight']) ? (int)$_POST['weight'] : 0);
        $partnerObj->setVar('email_priv', isset($_POST['email_priv']) ? (int)$_POST['email_priv'] : 0);
        $partnerObj->setVar('phone_priv', isset($_POST['phone_priv']) ? (int)$_POST['phone_priv'] : 0);
        $partnerObj->setVar('adress_priv', isset($_POST['adress_priv']) ? (int)$_POST['adress_priv'] : 0);
        $partnerObj->setVar('showsummary', isset($_POST['showsummary']) ? (int)$_POST['showsummary'] : 0);

        $redirect_msgs = $partnerObj->getRedirectMsg($_POST['original_status'], $_POST['status']);

        // Storing the partner
        if (!$partnerObj->store()) {
            redirect_header('javascript:history.go(-1)', 3, $redirect_msgs['error'] . smartpartner_formatErrors($partnerObj->getErrors()));
        }

        if (($_POST['original_status'] == _SPARTNER_STATUS_SUBMITTED) || ($_POST['status'] == _SPARTNER_STATUS_ACTIVE)) {
            $partnerObj->sendNotifications(array(_SPARTNER_NOT_PARTNER_APPROVED));
        }
        if ($partnerObj->isNew()) {
            $partnerObj->sendNotifications(array(_SPARTNER_NOT_PARTNER_NEW));
        }
        redirect_header('partner.php', 2, $redirect_msgs['success']);

        break;

    case 'del':

        global $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $_GET;
function myFunction($a, $b) {
    // Do something
}

        $module_id    = $xoopsModule->getVar('mid');
        $gpermHandler = xoops_getHandler('groupperm');

        $id = isset($_POST['id']) ? (int)$_POST['id'] : 0;
        $id = isset($_GET['id']) ? (int)$_GET['id'] : $id;

        $partnerObj = new SmartpartnerPartner($id);

        $confirm = isset($_POST['confirm']) ? $_POST['confirm'] : 0;
        $title   = isset($_POST['title']) ? $_POST['title'] : '';

        if ($confirm) {
            if (!$smartPartnerPartnerHandler->delete($partnerObj)) {
                redirect_header('partner.php', 2, _AM_SPARTNER_PARTNER_DELETE_ERROR);
                exit;
            }

            redirect_header('partner.php', 2, sprintf(_AM_SPARTNER_PARTNER_DELETE_SUCCESS, $partnerObj->title()));
        } else {
            // no confirm: show deletion condition
            $id = isset($_GET['id']) ? (int)$_GET['id'] : 0;
            xoops_cp_header();
            xoops_confirm(array('op' => 'del', 'id' => $partnerObj->id(), 'confirm' => 1, 'name' => $partnerObj->title()), 'partner.php',
                          _AM_SPARTNER_DELETETHISP . " <br>'" . $partnerObj->title() . "' <br> <br>", _AM_SPARTNER_DELETE);
            xoops_cp_footer();
        }

        exit();
        break;

    case 'default':
    default:
        smartpartner_xoops_cp_header();
        $indexAdmin = new ModuleAdmin();
        echo $indexAdmin->addNavigation(basename(__FILE__));

        $indexAdmin->addItemButton(_AM_SPARTNER_PARTNER_CREATE, 'partner.php?op=add', 'add', '');
        echo $indexAdmin->renderButton('left', '');

        //        echo "<br>\n";
        //        echo "<form><div style=\"margin-bottom: 12px;\">";

        //        echo "<input type='button' name='button' onclick=\"location='partner.php?op=mod'\" value='" . _AM_SPARTNER_PARTNER_CREATE . "'>&nbsp;&nbsp;";
        //        echo "</div></form>";

        include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
        include_once XOOPS_ROOT_PATH . '/class/pagenav.php';

        global $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $xoopsModuleConfig, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}

        smartpartner_collapsableBar('partners', 'partnersicon', _AM_SPARTNER_ACTIVE_PARTNERS, _AM_SPARTNER_ACTIVE_PARTNERS_DSC);

        // Get the total number of published PARTNER
        $totalpartners = $smartPartnerPartnerHandler->getPartnerCount(_SPARTNER_STATUS_ACTIVE);
        // creating the partner objects that are published
        $partnersObj         = $smartPartnerPartnerHandler->getPartners($xoopsModuleConfig['perpage_admin'], $startpartner);
        $totalPartnersOnPage = count($partnersObj);

        echo "<table width='100%' cellspacing='1' cellpadding='3' border='0' class='outer'>";
        echo '<tr>';
        echo "<td class='bg3' width='200px' align='left'><b>" . _AM_SPARTNER_NAME . '</b></td>';
        echo "<td width='' class='bg3' align='left'><b>" . _AM_SPARTNER_INTRO . '</b></td>';
        echo "<td width='90' class='bg3' align='center'><b>" . _AM_SPARTNER_HITS . '</b></td>';
        echo "<td width='90' class='bg3' align='center'><b>" . _AM_SPARTNER_STATUS . '</b></td>';
        echo "<td width='90' class='bg3' align='center'><b>" . _AM_SPARTNER_ACTION . '</b></td>';
        echo '</tr>';
        if ($totalpartners > 0) {
            for ($i = 0; $i < $totalPartnersOnPage; ++$i) {
                $modify = "<a href='partner.php?op=mod&id="
                          . $partnersObj[$i]->id()
                          . "'><img src='"
                          . $pathIcon16
                          . '/edit.png'
                          . "'  title='"
                          . _AM_SPARTNER_EDITPARTNER
                          . "' alt='"
                          . _AM_SPARTNER_EDITPARTNER
                          . "' /></a>&nbsp;";
                $delete = "<a href='partner.php?op=del&id="
                          . $partnersObj[$i]->id()
                          . "'><img src='"
                          . $pathIcon16
                          . '/delete.png'
                          . "'  title='"
                          . _AM_SPARTNER_DELETEPARTNER
                          . "' alt='"
                          . _AM_SPARTNER_DELETEPARTNER
                          . "'/></a>&nbsp;";

                echo '<tr>';
                echo "<td class='head' align='left'><a href='"
                     . SMARTPARTNER_URL
                     . 'partner.php?id='
                     . $partnersObj[$i]->id()
                     . "'><img src='"
                     . SMARTPARTNER_URL
                     . "assets/images/links/partner.gif' alt=''/>&nbsp;"
                     . $partnersObj[$i]->title()
                     . '</a></td>';
                echo "<td class='even' align='left'>" . $partnersObj[$i]->summary(100) . '</td>';
                echo "<td class='even' align='center'>" . $partnersObj[$i]->hits() . '</td>';
                echo "<td class='even' align='center'>" . $partnersObj[$i]->getStatusName() . '</td>';
                echo "<td class='even' align='center'> " . $modify . $delete . '</td>';
                echo '</tr>';
            }
        } else {
            $id = 0;
            echo '<tr>';
            echo "<td class='head' align='center' colspan= '7'>" . _AM_SPARTNER_NOPARTNERS . '</td>';
            echo '</tr>';
        }
        echo "</table>\n";
        echo "<br>\n";

        $pagenav = new XoopsPageNav($totalpartners, $xoopsModuleConfig['perpage_admin'], $startpartner, 'startpartner');
        echo '<div style="text-align:right;">' . $pagenav->renderNav() . '</div>';

        smartpartner_close_collapsable('partners', 'partnersicon');

        break;
}
//smart_modFooter();

//xoops_cp_footer();
include_once __DIR__ . '/admin_footer.php';


partner.php ➔ showfiles() B
last analyzed 2017-05-24 21:52 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 10 and the first side effect is on line 332. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			/**
4			*
5			* Module: SmartPartner
6			* Author: The SmartFactory <www.smartfactory.ca>
7			* Licence: GNU
8			* @param $partnerObj
9			*/
10			function showfiles($partnerObj)
11			{
12			// UPLOAD FILES
13			//include_once XOOPS_ROOT_PATH . '/modules/smartpartner/include/functions.php';
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report `38%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
14			global $xoopsModule, $smartPartnerFileHandler;
			0 ignored issues – show Compatibility Best Practice introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
15			$pathIcon16 = '../' . $xoopsModule->getInfo('icons16');
16			smartpartner_collapsableBar('filetable', 'filetableicon', _AM_SPARTNER_FILES_LINKED);
17			$filesObj = $smartPartnerFileHandler->getAllFiles($partnerObj->id());
18			if (count($filesObj) > 0) {
19			echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
20			echo '<tr>';
21			echo "<td width='50' class='bg3' align='center'><b>ID</b></td>";
22			echo "<td width='150' class='bg3' align='left'><b>" . _AM_SPARTNER_FILENAME . '</b></td>';
23			echo "<td class='bg3' align='left'><b>" . _AM_SPARTNER_DESCRIPTION . '</b></td>';
24			echo "<td width='60' class='bg3' align='center'><b>" . _AM_SPARTNER_HITS . '</b></td>';
25			echo "<td width='100' class='bg3' align='center'><b>" . _AM_SPARTNER_UPLOADED_DATE . '</b></td>';
26			echo "<td width='60' class='bg3' align='center'><b>" . _AM_SPARTNER_ACTION . '</b></td>';
27			echo '</tr>';
28
29			for ($i = 0, $iMax = count($filesObj); $i < $iMax; ++$i) {
30			$modify = "<a href='file.php?op=mod&fileid="
31			. $filesObj[$i]->fileid()
32			. "'><img src='"
33			. $pathIcon16
34			. '/edit.png'
35			. "' title='"
36			. _AM_SPARTNER_EDITFILE
37			. "' alt='"

XoopsModules25x / smartpartner

partner.php ➔ showfiles() B last analyzed 2017-05-24 21:52 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like

partner.php ➔ showfiles() B
last analyzed 2017-05-24 21:52 UTC