category.php ➔ displayCategory() - Code Metrics - XoopsModules25x/smartpartner - Measure and Improve Code Quality continuously with Scrutinizer

category.php ➔ displayCategory() B
last analyzed 2017-05-24 21:52 UTC

↳ Parent: Project

Complexity

Conditions	6
Paths	12

Size

Total Lines	59
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	50
nc	12
nop	2
dl	0
loc	59
rs	8.7117
c	0
b	0
f	0

How to fix Long Method

<?php


/**
 *
 * Module: SmarttPartner
 * Author: The SmartFactory <www.smartfactory.ca>
 * Licence: GNU
 * @param     $categoryObj
 * @param int $level
 */

function displayCategory($categoryObj, $level = 0)
{
    global $xoopsModule, $smartPartnerCategoryHandler, $pathIcon16;
function myFunction($a, $b) {
    // Do something
}
    $description = $categoryObj->description();
    if (!XOOPS_USE_MULTIBYTES) {
        if (strlen($description) >= 100) {
            $description = substr($description, 0, 100 - 1) . '...';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
    }
    $modify = "<a href='category.php?op=mod&categoryid="
              . $categoryObj->categoryid()
              . '&parentid='
              . $categoryObj->parentid()
              . "'><img src='"
              . $pathIcon16
              . '/edit.png'
              . "' title='"
              . _AM_SPARTNER_CATEGORY_EDIT
              . "' alt='"
              . _AM_SPARTNER_CATEGORY_EDIT
              . "' /></a>";
    $delete = "<a href='category.php?op=del&categoryid="
              . $categoryObj->categoryid()
              . "'><img src='"
              . $pathIcon16
              . '/delete.png'
              . "' title='"
              . _AM_SPARTNER_CATEGORY_DELETE
              . "' alt='"
              . _AM_SPARTNER_CATEGORY_DELETE
              . "' /></a>";

    $spaces = '';
    for ($j = 0; $j < $level; ++$j) {
        $spaces .= '&nbsp;&nbsp;&nbsp;';
    }

    echo '<tr>';
    echo "<td class='even' align='lefet'>"
         . $spaces
         . "<a href='"
         . $categoryObj->getCategoryUrl()
         . "'><img src='"
         . XOOPS_URL
         . "/modules/smartpartner/assets/images/icon/subcat.gif' alt='' />&nbsp;"
         . $categoryObj->name()
         . '</a></td>';
    echo "<td class='even' align='center'>" . $categoryObj->weight() . '</td>';
    echo "<td class='even' align='center'> $modify $delete </td>";
    echo '</tr>';
    $subCategoriesObj = $smartPartnerCategoryHandler->getCategories(0, 0, $categoryObj->categoryid());
    if (count($subCategoriesObj) > 0) {
        ++$level;
        foreach ($subCategoriesObj as $key => $thiscat) {
            displayCategory($thiscat, $level);
        }
    }
    unset($categoryObj);
}

/**
 * @param bool $showmenu
 * @param int  $categoryid
 * @param int  $nb_subcats
 * @param null $categoryObj
 */
function editcat($showmenu = false, $categoryid = 0, $nb_subcats = 4, $categoryObj = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsDB, $smartPartnerCategoryHandler, $xoopsUser, $myts, $xoopsConfig, $xoopsModuleConfig, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
    include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

    // If there is a parameter, and the id exists, retrieve data: we're editing a category
    if ($categoryid != 0) {

        // Creating the category object for the selected category
        //$categoryObj = new SmartpartnerCategory($categoryid);

        $categoryObj = $smartPartnerCategoryHandler->get($categoryid);

        echo "<br>\n";
        if ($categoryObj->notLoaded()) {
            redirect_header('category.php', 1, _AM_SPARTNER_NOCOLTOEDIT);
        }
        smartpartner_collapsableBar('edittable', 'edittableicon', _AM_SPARTNER_CATEGORY_EDIT, _AM_SPARTNER_CATEGORY_EDIT_INFO);
    } else {
        if (!$categoryObj) {
            $categoryObj = $smartPartnerCategoryHandler->create();
        }

        //echo "<br>\n";
        smartpartner_collapsableBar('createtable', 'createtableicon', _AM_SPARTNER_CATEGORY_CREATE, _AM_SPARTNER_CATEGORY_CREATE_INFO);
    }
    // Start category form
    $mytree = new XoopsTree($xoopsDB->prefix('smartpartner_categories'), 'categoryid', 'parentid');
    $sform  = new XoopsThemeForm(_AM_SPARTNER_CATEGORY, 'op', xoops_getenv('PHP_SELF'));
    $sform->setExtra('enctype="multipart/form-data"');

    // Name
    $sform->addElement(new XoopsFormText(_AM_SPARTNER_CATEGORY, 'name', 50, 255, $categoryObj->name('e')), true);

    // Description
    $sform->addElement(new XoopsFormTextArea(_AM_SPARTNER_CATEGORY_DSC, 'description', $categoryObj->description('e'), 7, 60));

    // IMAGE
    $image_array  = XoopsLists:: getImgListAsArray(smartpartner_getUploadDir('category'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    $image_select = new XoopsFormSelect('', 'image', $categoryObj->image());
    $image_select->addOption('-1', '---------------');
    $image_select->addOptionArray($image_array);
    $image_select->setExtra("onchange='showImgSelected(\"image3\", \"image\", \"" . 'uploads/smartpartner/assets/images/category/' . "\", \"\", \"" . XOOPS_URL . "\")'");
    $image_tray = new XoopsFormElementTray(_AM_SPARTNER_CATEGORY_IMAGE, '&nbsp;');
    $image_tray->addElement($image_select);
    $image_tray->addElement(new XoopsFormLabel('', "<br><br><img src='" . smartpartner_getImageDir('category', false) . $categoryObj->image() . "' name='image3' id='image3' alt='' />"));
    $image_tray->setDescription(_AM_SPARTNER_CATEGORY_IMAGE_DSC);
    $sform->addElement($image_tray);

    // IMAGE UPLOAD
    $max_size = 5000000;
    $file_box = new XoopsFormFile(_AM_SPARTNER_CATEGORY_IMAGE_UPLOAD, 'image_file', $max_size);
    $file_box->setExtra("size ='45'");
    $file_box->setDescription(_AM_SPARTNER_CATEGORY_IMAGE_UPLOAD_DSC);
    $sform->addElement($file_box);

    // Weight
    $sform->addElement(new XoopsFormText(_AM_SPARTNER_CATEGORY_WEIGHT, 'weight', 4, 4, $categoryObj->weight()));

    $memberHandler = xoops_getHandler('member');
    $group_list    = $memberHandler->getGroupList();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    $module_id = $xoopsModule->getVar('mid');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    // Parent Category
    ob_start();
    $mytree->makeMySelBox('name', 'weight', $categoryObj->parentid(), 1, 'parentid');
    //makeMySelBox($title,$order="",$preset_id=0, $none=0, $sel_name="", $onchange="")

    $parent_cat_select = new XoopsFormLabel(_AM_SPARTNER_CATEGORY_PARENT, ob_get_contents());
    $parent_cat_select->setDescription(_AM_SPARTNER_CATEGORY_PARENT_DSC);
    $sform->addElement($parent_cat_select);
    ob_end_clean();

    // Added by fx2024
    // sub Categories

    $cat_tray = new XoopsFormElementTray(_AM_SPARTNER_CATEGORY_SUBCATS_CREATE, '<br><br>');
    $cat_tray->setDescription(_AM_SPARTNER_CATEGORY_SUBCATS_CREATE_DSC);
    for ($i = 0; $i < $nb_subcats; ++$i) {
        if ($i < (isset($_POST['scname']) ? count($_POST['scname']) : 0)) {
            $subname = isset($_POST['scname']) ? $_POST['scname'][$i] : '';
        } else {
            $subname = '';
        }
        $cat_tray->addElement(new XoopsFormText('', 'scname[' . $i . ']', 50, 255, $subname), true);
    }

    $t = new XoopsFormText('', 'nb_subcats', 3, 2);
    $l = new XoopsFormLabel('', sprintf(_AM_SPARTNER_ADD_OPT, $t->render()));
    $b = new XoopsFormButton('', 'submit', _AM_SPARTNER_ADD_OPT_SUBMIT, 'submit');
    if ($categoryid == 0) {
        $b->setExtra('onclick="this.form.elements.op.value=\'addsubcats\'"');
    } else {
        $b->setExtra('onclick="this.form.elements.op.value=\'mod\'"');
    }
    $r = new XoopsFormElementTray('');
    $r->addElement($l);
    $r->addElement($b);
    $cat_tray->addElement($r);

    $sform->addElement($cat_tray);
    //End of fx2024 code

    /*$gpermHandler = xoops_getHandler('groupperm');

     $mod_perms = $gpermHandler->getGroupIds('category_moderation', $categoryid, $module_id);

     $moderators_select = new XoopsFormSelect('', 'moderators', $moderators, 5, true);
     $moderators_tray->addElement($moderators_select);

     $butt_mngmods = new XoopsFormButton('', '', 'Manage mods', 'button');
     $butt_mngmods->setExtra('onclick="javascript:small_window(\'pop.php\', 370, 350);"');
     $moderators_tray->addElement($butt_mngmods);

     $butt_delmod = new XoopsFormButton('', '', 'Delete mod', 'button');
     $butt_delmod->setExtra('onclick="javascript:deleteSelectedItemsFromList(this.form.elements[\'moderators[]\']);"');
     $moderators_tray->addElement($butt_delmod);

     $sform->addElement($moderators_tray);
     */
    $sform->addElement(new XoopsFormHidden('categoryid', $categoryid));

    //$parentid = $categoryObj->parentid('s');


    //$sform -> addElement( new XoopsFormHidden( 'parentid', $parentid ) );


    $sform->addElement(new XoopsFormHidden('nb_sub_yet', $nb_subcats));

    // Action buttons tray
    $button_tray = new XoopsFormElementTray('', '');

    /*for ($i = 0, $iMax = count($moderators); $i < $iMax; ++$i) {

     $allmods[] = $moderators[$i];
     }

     $hiddenmods = new XoopsFormHidden('allmods', $allmods);
     $button_tray->addElement($hiddenmods);
     */
    $hidden = new XoopsFormHidden('op', 'addcategory');
    $button_tray->addElement($hidden);

    // No ID for category -- then it's new category, button says 'Create'
    if (!$categoryid) {
        $butt_create = new XoopsFormButton('', '', _AM_SPARTNER_CREATE, 'submit');
        $butt_create->setExtra('onclick="this.form.elements.op.value=\'addcategory\'"');
        $button_tray->addElement($butt_create);

        $butt_clear = new XoopsFormButton('', '', _AM_SPARTNER_CLEAR, 'reset');
        $button_tray->addElement($butt_clear);

        $butt_cancel = new XoopsFormButton('', '', _AM_SPARTNER_CANCEL, 'button');
        $butt_cancel->setExtra('onclick="history.go(-1)"');
        $button_tray->addElement($butt_cancel);

        $sform->addElement($button_tray);
        $sform->display();
        smartpartner_close_collapsable('createtable', 'createtableicon');
    } else {
        // button says 'Update'
        $butt_create = new XoopsFormButton('', '', _AM_SPARTNER_MODIFY, 'submit');
        $butt_create->setExtra('onclick="this.form.elements.op.value=\'addcategory\'"');
        $button_tray->addElement($butt_create);

        $butt_cancel = new XoopsFormButton('', '', _AM_SPARTNER_CANCEL, 'button');
        $butt_cancel->setExtra('onclick="history.go(-1)"');
        $button_tray->addElement($butt_cancel);

        $sform->addElement($button_tray);
        $sform->display();
        smartpartner_close_collapsable('edittable', 'edittableicon');
    }
    /*
     //Added by fx2024
     if ($categoryid) {
         // TODO: displaysubcats comes from smartpartner and need to be adapted for smartpartner
         include_once XOOPS_ROOT_PATH . "/modules/smartpartner/include/displaysubcats.php";

         // TODO: displayitems comes from smartpartner and need to be adapted for smartpartner
         //include_once XOOPS_ROOT_PATH . "/modules/smartpartner/include/displayitems.php";
     }
     //end of fx2024 code
     */
    unset($hidden);
}

include_once __DIR__ . '/admin_header.php';
include(XOOPS_ROOT_PATH . '/class/xoopstree.php');

global $smartPartnerCategoryHandler;
function myFunction($a, $b) {
    // Do something
}

$op = '';

if (isset($_GET['op'])) {
    $op = $_GET['op'];
}
if (isset($_POST['op'])) {
    $op = $_POST['op'];
}

// Where do we start ?
$startcategory = isset($_GET['startcategory']) ? (int)$_GET['startcategory'] : 0;

switch ($op) {
    case 'mod':
        $categoryid = isset($_GET['categoryid']) ? (int)$_GET['categoryid'] : 0;

        //Added by fx2024

        $nb_subcats = isset($_POST['nb_subcats']) ? (int)$_POST['nb_subcats'] : 0;
        $nb_subcats += (isset($_POST['nb_sub_yet']) ? (int)$_POST['nb_sub_yet'] : 4);
        if ($categoryid == 0) {
            $categoryid = isset($_POST['categoryid']) ? (int)$_POST['categoryid'] : 0;
        }
        //end of fx2024 code

        smartpartner_xoops_cp_header();

        editcat(true, $categoryid, $nb_subcats);
        break;

    case 'addcategory':
        global $_POST, $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $xoopsModule, $xoopsModuleConfig, $modify, $myts, $categoryid;
function myFunction($a, $b) {
    // Do something
}

        $categoryid = isset($_POST['categoryid']) ? (int)$_POST['categoryid'] : 0;
        $parentid   = isset($_POST['parentid']) ? (int)$_POST['parentid'] : 0;

        if ($categoryid != 0) {
            $categoryObj = $smartPartnerCategoryHandler->get($categoryid);
        } else {
            $categoryObj = $smartPartnerCategoryHandler->create();
        }

        // Uploading the image, if any
        // Retreive the filename to be uploaded
        if (isset($_FILES['image_file']['name']) && $_FILES['image_file']['name'] != '') {
            $filename = $_POST['xoops_upload_file'][0];
            if (!empty($filename) || $filename != '') {

                global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}

                // TODO: implement smartpartner mimetype management

                $max_size          = $xoopsModuleConfig['maximum_imagesize'];
                $max_imgwidth      = $xoopsModuleConfig['img_max_width'];
                $max_imgheight     = $xoopsModuleConfig['img_max_height'];
                $allowed_mimetypes = smartpartner_getAllowedImagesTypes();

                include_once(XOOPS_ROOT_PATH . '/class/uploader.php');

                if ($_FILES[$filename]['tmp_name'] == '' || !is_readable($_FILES[$filename]['tmp_name'])) {
                    redirect_header('javascript:history.go(-1)', 2, _AM_SPARTNER_FILEUPLOAD_ERROR);
                    exit;
                }

                $uploader = new XoopsMediaUploader(smartpartner_getImageDir('category'), $allowed_mimetypes, $max_size, $max_imgwidth, $max_imgheight);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

                if ($uploader->fetchMedia($filename) && $uploader->upload()) {
                    $categoryObj->setVar('image', $uploader->getSavedFileName());
                } else {
                    redirect_header('javascript:history.go(-1)', 2, _AM_SPARTNER_FILEUPLOAD_ERROR . $uploader->getErrors());
                    exit;
                }
            }
        } else {
            if (isset($_POST['image'])) {
                $categoryObj->setVar('image', $_POST['image']);
            }
        }
        $categoryObj->setVar('parentid', isset($_POST['parentid']) ? (int)$_POST['parentid'] : 0);

        $applyall = isset($_POST['applyall']) ? (int)$_POST['applyall'] : 0;
        $categoryObj->setVar('weight', isset($_POST['weight']) ? (int)$_POST['weight'] : 1);

        $categoryObj->setVar('name', $_POST['name']);

        $categoryObj->setVar('description', $_POST['description']);

        if ($categoryObj->isNew()) {
            $redirect_msg = _AM_SPARTNER_CATEGORY_CREATED;
            $redirect_to  = 'category.php?op=mod';
        } else {
            $redirect_msg = _AM_SPARTNER_CATEGORY_MODIFIED;
            $redirect_to  = 'category.php';
        }

        if (!$categoryObj->store()) {

            redirect_header('javascript:history.go(-1)', 3, _AM_SPARTNER_CATEGORY_SAVE_ERROR . smartpartner_formatErrors($categoryObj->getErrors()));
            exit;
        }
        //Added by fx2024
        $parentCat = $categoryObj->categoryid();

        for ($i = 0, $iMax = count($_POST['scname']); $i < $iMax; ++$i) {
            if ($_POST['scname'][$i] != '') {
                $categoryObj = $smartPartnerCategoryHandler->create();
                $categoryObj->setVar('name', $_POST['scname'][$i]);
                $categoryObj->setVar('parentid', $parentCat);

                if (!$categoryObj->store()) {

                    redirect_header('javascript:history.go(-1)', 3, _AM_SPARTNER_CATEGORY_SUBCAT_SAVE_ERROR . smartpartner_formatErrors($categoryObj->getErrors()));
                    exit;
                }
            }
        }

        //end of fx2024 code
        redirect_header($redirect_to, 2, $redirect_msg);

        break;

    //Added by fx2024

    case 'addsubcats':
        $categoryid = 0;
        $nb_subcats = (int)$_POST['nb_subcats'] + $_POST['nb_sub_yet'];

        smartpartner_xoops_cp_header();

        $categoryObj = $smartPartnerCategoryHandler->create();
        $categoryObj->setVar('name', $_POST['name']);
        $categoryObj->setVar('description', $_POST['description']);
        $categoryObj->setVar('weight', $_POST['weight']);
        if (isset($parentCat)) {
            $categoryObj->setVar('parentid', $parentCat);
        }

        editcat(true, $categoryid, $nb_subcats, $categoryObj);
        exit();

        break;
    //end of fx2024 code

    case 'del':

        global $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $_GET;
function myFunction($a, $b) {
    // Do something
}

        $module_id    = $xoopsModule->getVar('mid');
        $gpermHandler = xoops_getHandler('groupperm');

        $categoryid = isset($_POST['categoryid']) ? (int)$_POST['categoryid'] : 0;
        $categoryid = isset($_GET['categoryid']) ? (int)$_GET['categoryid'] : $categoryid;

        //$categoryObj = new SmartpartnerCategory($categoryid);

        $categoryObj = $smartPartnerCategoryHandler->get($categoryid);

        $confirm = isset($_POST['confirm']) ? $_POST['confirm'] : 0;
        $name    = isset($_POST['name']) ? $_POST['name'] : '';

        if ($confirm) {
            if (!$smartPartnerCategoryHandler->delete($categoryObj)) {
                redirect_header('category.php', 1, _AM_SPARTNER_CATEGORY_DELETE_ERROR);
                exit;
            }

            redirect_header('category.php', 1, sprintf(_AM_SPARTNER_CATEGORY_DELETED, $name));
        } else {
            // no confirm: show deletion condition
            $categoryid = isset($_GET['categoryid']) ? (int)$_GET['categoryid'] : 0;
            xoops_cp_header();
            xoops_confirm(array('op' => 'del', 'categoryid' => $categoryObj->categoryid(), 'confirm' => 1, 'name' => $categoryObj->name()), 'category.php',
                          _AM_SPARTNER_CATEGORY_DELETE . " '" . $categoryObj->name() . "'. <br> <br>" . _AM_SPARTNER_CATEGORY_DELETE_CONFIRM, _AM_SPARTNER_DELETE);
            xoops_cp_footer();
        }
        exit();
        break;

    case 'cancel':

        redirect_header('category.php', 1, sprintf(_AM_SPARTNER_BACK2IDX, ''));

    case 'default':
    default:
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}

        smartpartner_xoops_cp_header();
        $indexAdmin = new ModuleAdmin();
        echo $indexAdmin->addNavigation(basename(__FILE__));

        $indexAdmin->addItemButton(_AM_SPARTNER_CATEGORY_CREATE, 'category.php?op=mod', 'add', '');
        echo $indexAdmin->renderButton('left', '');

        /*

                echo "<br>\n";
                echo "<form><div style=\"margin-bottom: 12px;\">";
                echo "<input type='button' name='button' onclick=\"location='category.php?op=mod'\" value='" . _AM_SPARTNER_CATEGORY_CREATE . "'>&nbsp;&nbsp;";
                //echo "<input type='button' name='button' onclick=\"location='partner.php?op=mod'\" value='" . _AM_SPARTNER_CREATEITEM . "'>&nbsp;&nbsp;";
                echo "</div></form>";
        */
        // Creating the objects for top categories
        $categoriesObj = $smartPartnerCategoryHandler->getCategories($xoopsModuleConfig['perpage_admin'], $startcategory, 0);

        smartpartner_collapsableBar('createdcategories', 'createdcategoriesicon', _AM_SPARTNER_CATEGORIES_TITLE, _AM_SPARTNER_CATEGORIES_DSC);

        echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
        echo '<tr>';
        echo "<td class='bg3' align='left'><b>" . _AM_SPARTNER_CATEGORY . '</b></td>';
        echo "<td class='bg3' width='65' align='center'><b>" . _AM_SPARTNER_WEIGHT . '</b></td>';
        echo "<td width='60' class='bg3' align='center'><b>" . _AM_SPARTNER_ACTION . '</b></td>';
        echo '</tr>';
        $totalCategories = $smartPartnerCategoryHandler->getCategoriesCount(0);
        if (count($categoriesObj) > 0) {
            foreach ($categoriesObj as $key => $thiscat) {
                displayCategory($thiscat);
            }
        } else {
            echo '<tr>';
            echo "<td class='head' align='center' colspan= '7'>" . _AM_SPARTNER_CATEGORY_NONE . '</td>';
            echo '</tr>';
            $categoryid = '0';
        }
        echo "</table>\n";
        include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
        $pagenav = new XoopsPageNav($totalCategories, $xoopsModuleConfig['perpage_admin'], $startcategory, 'startcategory');
        echo '<div style="text-align:right;">' . $pagenav->renderNav() . '</div>';
        echo '<br>';
        smartpartner_close_collapsable('createdcategories', 'createdcategoriesicon');
        echo '<br>';
        //editcat(false);
        break;
}

//smart_modFooter();

//xoops_cp_footer();
include_once __DIR__ . '/admin_footer.php';


category.php ➔ displayCategory() B
last analyzed 2017-05-24 21:52 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 12 and the first side effect is on line 261. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			/**
4			*
5			* Module: SmarttPartner
6			* Author: The SmartFactory <www.smartfactory.ca>
7			* Licence: GNU
8			* @param $categoryObj
9			* @param int $level
10			*/
11
12			function displayCategory($categoryObj, $level = 0)
13			{
14			global $xoopsModule, $smartPartnerCategoryHandler, $pathIcon16;
			0 ignored issues – show Compatibility Best Practice introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
15			$description = $categoryObj->description();
16			if (!XOOPS_USE_MULTIBYTES) {
17			if (strlen($description) >= 100) {
18			$description = substr($description, 0, 100 - 1) . '...';
			0 ignored issues – show Unused Code introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report `$description` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
19			}
20			}
21			$modify = "<a href='category.php?op=mod&categoryid="
22			. $categoryObj->categoryid()
23			. '&parentid='
24			. $categoryObj->parentid()
25			. "'><img src='"
26			. $pathIcon16
27			. '/edit.png'
28			. "' title='"
29			. _AM_SPARTNER_CATEGORY_EDIT
30			. "' alt='"
31			. _AM_SPARTNER_CATEGORY_EDIT
32			. "' /></a>";
33			$delete = "<a href='category.php?op=del&categoryid="
34			. $categoryObj->categoryid()
35			. "'><img src='"
36			. $pathIcon16
37			. '/delete.png'

XoopsModules25x / smartpartner

category.php ➔ displayCategory() B last analyzed 2017-05-24 21:52 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like

category.php ➔ displayCategory() B
last analyzed 2017-05-24 21:52 UTC