smartpartnerMimetypeHandler - Code Metrics - XoopsModules25x/smartpartner - Measure and Improve Code Quality continuously with Scrutinizer

smartpartnerMimetypeHandler A
last analyzed 2017-05-24 21:52 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	232
Duplicated Lines	25.43 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	59
loc	232
rs	10
c	0
b	0
f	0
wmc	25
lcom	1
cbo	1

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	get()	18	18	4
B	getObjects()	0	25	4
B	getArray()	0	38	2
A	checkMimeTypes()	0	21	4
B	_selectQuery()	17	17	5
A	_insertQuery()	12	13	2
A	_updateQuery()	12	13	2
A	_deleteQuery()	0	6	1

How to fix Duplicated Code

<?php

//
//  ------------------------------------------------------------------------ //
//                XOOPS - PHP Content Management System                      //
//                  Copyright (c) 2000-2016 XOOPS.org                        //
//                       <http://xoops.org/>                             //
//  ------------------------------------------------------------------------ //
// defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');
include_once XOOPS_ROOT_PATH . '/modules/smartpartner/include/common.php';
require_once(SMARTPARTNER_ROOT_PATH . 'class/baseObjectHandler.php');

/**
 * smartpartnerMimetype class
 *
 * Information about an individual mimetype
 *
 * <code>
 * $hMime = xoops_getModuleHandler('mimetype', 'smartpartner');
 * $mimetype =& $hMime->get(1);
 * $mime_id = $mimetype->getVar('id');
 * </code>
 *
 * @author  Eric Juden <[email protected]>
 * @access  public
 * @package smartpartner
 */
class smartpartnerMimetype extends XoopsObject
namespace YourVendor;

class YourClass { }
{
    /**
     * smartpartnerMimetype constructor.
     * @param null $id
     */
    public function __construct($id = null)
    {
        $this->initVar('mime_id', XOBJ_DTYPE_INT, null, false);
        $this->initVar('mime_ext', XOBJ_DTYPE_TXTBOX, null, true, 60);
        $this->initVar('mime_types', XOBJ_DTYPE_TXTAREA, null, false, 1024);
        $this->initVar('mime_name', XOBJ_DTYPE_TXTBOX, null, true, 255);
        $this->initVar('mime_admin', XOBJ_DTYPE_INT, null, false);
        $this->initVar('mime_user', XOBJ_DTYPE_INT, null, false);

        if (isset($id)) {
            if (is_array($id)) {
                $this->assignVars($id);
            }
        } else {
            $this->setNew();
        }
    }
} // end of class

/**
 * Class smartpartnerMimetypeHandler
 */
class smartpartnerMimetypeHandler extends SmartpartnerBaseObjectHandler
namespace YourVendor;

class YourClass { }
{
    /**
     * Name of child class
     *
     * @var string
     * @access    private
     */
    public $classname = 'smartpartnermimetype';

    /**
     * DB Table Name
     *
     * @var string
     * @access private
     */
    public $_dbtable = 'smartpartner_mimetypes';

    /**
     * Constructor
     *
     * @param object|XoopsDatabase $db reference to a xoopsDB object
     */
    public function __construct(XoopsDatabase $db)
    {
        parent::init($db);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * retrieve a mimetype object from the database
     * @param  int $id ID of mimetype
     * @return object {@link smartpartnerMimetype}

     * @access    public
     */
    public function &get($id)

    {
        $id = (int)$id;
        if ($id > 0) {
            $sql = $this->_selectQuery(new Criteria('mime_id', $id));
            if (!$result = $this->_db->query($sql)) {
                return false;
            }
            $numrows = $this->_db->getRowsNum($result);
            if ($numrows == 1) {
                $obj = new $this->classname($this->_db->fetchArray($result));

                return $obj;
            }
        }

        return false;
    }

    /**
     * retrieve objects from the database
     *
     * @param  object $criteria {@link CriteriaElement} conditions to be met

     * @return array  array of {@link smartpartnerMimetype} objects
     * @access    public
     */
    public function &getObjects($criteria = null)
    {
        $ret   = array();
        $limit = $start = 0;
        $sql   = $this->_selectQuery($criteria);
        if (isset($criteria)) {
            $limit = $criteria->getLimit();
            $start = $criteria->getStart();
        }
        //echo "<br>$sql<br>";exit;

        $result = $this->_db->query($sql, $limit, $start);
        // if no records from db, return empty array
        if (!$result) {
            return $ret;
        }

        // Add each returned record to the result array
        while ($myrow = $this->_db->fetchArray($result)) {
            $obj   = new $this->classname($myrow);
            $ret[] =& $obj;
            unset($obj);
        }

        return $ret;
    }

    /**
     * Format mime_types into array
     *
     * @param  null $mime_ext
     * @return array array of mime_types
     * @access public
     */
    public function getArray($mime_ext = null)
    {
        /*global $smartPartnerIsAdmin, $xoopsUser, $xoopsModule;


          $ret = array();
          if ($xoopsUser && !$smartPartnerIsAdmin) {
              // For user uploading
              $crit = new CriteriaCompo(new Criteria('mime_user', 1));   //$sql = sprintf("SELECT * FROM %s WHERE mime_user=1", $xoopsDB->prefix('smartpartner_mimetypes'));
          } elseif ($xoopsUser && $smartPartnerIsAdmin) {
              // For admin uploading
              $crit = new CriteriaCompo(new Criteria('mime_admin', 1));  //$sql = sprintf("SELECT * FROM %s WHERE mime_admin=1", $xoopsDB->prefix('smartpartner_mimetypes'));
          } else {
              return $ret;
          }
          if ($mime_ext) {
              $crit->add(new Criteria('mime_ext', $mime_ext));
          }
          $result = $this->getObjects($crit);

          // if no records from db, return empty array
          if (!$result) {
              return $ret;
          }

          foreach ($result as $mime) {
              $line = explode(" ", $mime->getVar('mime_types'));
              foreach ($line as $row) {
                  $allowed_mimetypes[] = array('type'=>$row, 'ext'=>$mime->getVar('mime_ext'));
              }
          }*/
        global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}
        $mymetypesArray = include_once(SMARTPARTNER_ROOT_PATH . '/include/mimetypes.inc.php');
        foreach (explode('|', $xoopsModuleConfig['allowed_ext']) as $ext) {
            $allowed_mimetypes[] = array('type' => $mymetypesArray[$ext], 'ext' => $ext);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return $allowed_mimetypes;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * Checks to see if the user uploading the file has permissions to upload this mimetype
     * @param $post_field file being uploaded
     * @return false if no permission, return mimetype if has permission

     * @access public
     */
    public function checkMimeTypes($post_field)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $fname      = $_FILES[$post_field]['name'];
        $farray     = explode('.', $fname);
        $fextension = strtolower($farray[count($farray) - 1]);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $allowed_mimetypes = $this->getArray();
        if (empty($allowed_mimetypes)) {
            return false;
        }
        foreach ($allowed_mimetypes as $mime) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if ($mime['type'] == $_FILES[$post_field]['type']) {
                $allowed_mimetypes = $mime['type'];
                break;
            } else {
                $allowed_mimetypes = false;
            }
        }

        return $allowed_mimetypes;
    }

    /**
     * Create a "select" SQL query
     * @param  object $criteria {@link CriteriaElement} to match

     * @param  bool   $join
     * @return string SQL query

     * @access    private
     */
    public function _selectQuery($criteria = null, $join = false)

    {
        if (!$join) {
            $sql = sprintf('SELECT * FROM %s', $this->_db->prefix($this->_dbtable));
        } else {
            echo 'no need for join...';
            exit;

        }
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

            $sql .= ' ' . $criteria->renderWhere();
            if ($criteria->getSort() != '') {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
        }

        return $sql;
    }

    /**
     * @param $obj
     * @return string
     */
    public function _insertQuery($obj)

    {
        // Copy all object vars into local variables
        foreach ($obj->cleanVars as $k => $v) {
            ${$k} = $v;
        }

        $sql = sprintf('INSERT INTO %s (mime_id, mime_ext, mime_types, mime_name, mime_admin, mime_user) VALUES
               (%u, %s, %s, %s, %u, %u)', $this->_db->prefix($this->_dbtable), $mime_id, $this->_db->quoteString($mime_ext), $this->_db->quoteString($mime_types), $this->_db->quoteString($mime_name),

                       $mime_admin, $mime_user);


        return $sql;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param $obj
     * @return string
     */
    public function _updateQuery($obj)

    {
        // Copy all object vars into local variables
        foreach ($obj->cleanVars as $k => $v) {
            ${$k} = $v;
        }

        $sql = sprintf('UPDATE %s SET mime_ext = %s, mime_types = %s, mime_name = %s, mime_admin = %u, mime_user = %u WHERE
               mime_id = %u', $this->_db->prefix($this->_dbtable), $this->_db->quoteString($mime_ext), $this->_db->quoteString($mime_types), $this->_db->quoteString($mime_name), $mime_admin,

                       $mime_user, $mime_id);


        return $sql;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param $obj
     * @return string
     */
    public function _deleteQuery($obj)
    {
        $sql = sprintf('DELETE FROM %s WHERE mime_id = %u', $this->_db->prefix($this->_dbtable), $obj->getVar('mime_id'));

        return $sql;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
} // end class



smartpartnerMimetypeHandler A
last analyzed 2017-05-24 21:52 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 27 and the first side effect is on line 9. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			//
3			// ------------------------------------------------------------------------ //
4			// XOOPS - PHP Content Management System //
5			// Copyright (c) 2000-2016 XOOPS.org //
6			// <http://xoops.org/> //
7			// ------------------------------------------------------------------------ //
8			// defined('XOOPS_ROOT_PATH') \|\| exit('XOOPS root path not defined');
9			include_once XOOPS_ROOT_PATH . '/modules/smartpartner/include/common.php';
10			require_once(SMARTPARTNER_ROOT_PATH . 'class/baseObjectHandler.php');
11
12			/**
13			* smartpartnerMimetype class
14			*
15			* Information about an individual mimetype
16			*
17			* <code>
18			* $hMime = xoops_getModuleHandler('mimetype', 'smartpartner');
19			* $mimetype =& $hMime->get(1);
20			* $mime_id = $mimetype->getVar('id');
21			* </code>
22			*
23			* @author Eric Juden <[email protected]>
24			* @access public
25			* @package smartpartner
26			*/
27			class smartpartnerMimetype extends XoopsObject
			0 ignored issues – show Coding Style Compatibility introduced 2016-05-31 10:14 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
28			{
29			/**
30			* smartpartnerMimetype constructor.
31			* @param null $id
32			*/
33			public function __construct($id = null)
34			{
35			$this->initVar('mime_id', XOBJ_DTYPE_INT, null, false);
36			$this->initVar('mime_ext', XOBJ_DTYPE_TXTBOX, null, true, 60);
37			$this->initVar('mime_types', XOBJ_DTYPE_TXTAREA, null, false, 1024);
38			$this->initVar('mime_name', XOBJ_DTYPE_TXTBOX, null, true, 255);

XoopsModules25x / smartpartner

smartpartnerMimetypeHandler A last analyzed 2017-05-24 21:52 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Duplication Side-by-Side

Filter issues like

smartpartnerMimetypeHandler A
last analyzed 2017-05-24 21:52 UTC