Issues in publicindex.php (master) - Issues in master - XoopsModules25x/smallworld - Measure and Improve Code Quality continuously with Scrutinizer

Issues (621)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

publicindex.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * SmallWorld
 *
 * @package      \XoopsModules\SmallWorld
 * @copyright    The XOOPS Project (https://xoops.org)
 * @license      GNU GPL (https://www.gnu.org/licenses/gpl-2.0.html/)
 * @copyright    2011 Culex
 * @author       Michael Albertsen (http://culex.dk) <[email protected]>
 * @link         https://github.com/XoopsModules25x/smallworld
 * @since        1.0
 */

use XoopsModules\Smallworld;
use XoopsModules\Smallworld\Constants;

require_once __DIR__ . '/header.php';

$page = basename(__FILE__, '.php');

// @ todo - figure out why the test for $page is here... $page will always equal 'publicindex'
if ($GLOBALS['xoopsUser'] && ($GLOBALS['xoopsUser'] instanceof \XoopsUser) && 'publicindex' !== $page) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
    $GLOBALS['xoopsOption']['template_main'] = 'smallworld_index.tpl';
} else {
    $GLOBALS['xoopsOption']['template_main'] = 'smallworld_publicindex.tpl';
}
require_once XOOPS_ROOT_PATH . '/header.php';

/** @var \XoopsModules\Smallworld\Helper $helper */
require_once $helper->path('include/functions.php');
//$GLOBALS['xoopsLogger']->activated = true;
//error_reporting(E_ALL);

$set      = smallworld_checkPrivateOrPublic();
$swDB     = new Smallworld\SwDatabase();
$id       = Constants::DEFAULT_UID;
$username = '';
$profile  = Constants::PROFILE_NONE;

if ($GLOBALS['xoopsUser'] instanceof \XoopsUser) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
    $id       = $GLOBALS['xoopsUser']->uid();
    $username = $GLOBALS['xoopsUser']->uname();
    //$check    = new Smallworld\User();
    //$profile  = $check->checkIfProfile($id);
    $profile  = $helper->getHandler('SwUser')->checkIfProfile($id);
}

$pub     = smallworld_checkUserPubPostPerm();
$wall    = new Smallworld\PublicWallUpdates();
$updates = $wall->Updates(0, $pub);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

if ($id > 0) {
    $GLOBALS['xoopsTpl']->assign('ownerofpage', $id);
    $GLOBALS['xoopsTpl']->assign('myusername', $username);
}

$tplAdmin = $helper->isUserAdmin() ? 'YES' : 'NO';

// Create form for private settings
$form         = new Smallworld\Form();
$usersettings = $form->usersettings($id, $selected = null);

$GLOBALS['xoopsTpl']->assign('usersetting', $usersettings);

//$xuser = new Smallworld\Profile();

$menu_home     = "<a href='" . $helper->url('/') . "'><img id='menuimg' src='" . $helper->url('assets/images/house.png') . "'>" . _SMALLWORLD_HOME . '</a>';
$menu_register = ($profile < Constants::PROFILE_HAS_BOTH) ? "<a href='" . $helper->url('register.php') . "'><img id='menuimg' src='" . $helper->url('assets/images/join.jpg') . "'>" . _MB_SYSTEM_RNOW . '</a>' : '';

$updatesarray = $wall->Updates(0, $pub);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
$wall->parsePubArray($updatesarray, $id);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

$GLOBALS['xoopsTpl']->assign(
    [
        'menu_home'     => $menu_home,
        'menu_register' => $menu_register,
        'pagename'      => 'publicindex',
        'check'         => $profile,
        'access'        => $set['access'],
        'isadminuser'   => $tplAdmin
    ]
);

require_once XOOPS_ROOT_PATH . '/footer.php';


1		<?php
2		/*
3		* You may not change or alter any portion of this comment or credits
4		* of supporting developers from this source code or any supporting source code
5		* which is considered copyrighted (c) material of the original comment or credit authors.
6		*
7		* This program is distributed in the hope that it will be useful,
8		* but WITHOUT ANY WARRANTY; without even the implied warranty of
9		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* SmallWorld
14		*
15		* @package \XoopsModules\SmallWorld
16		* @copyright The XOOPS Project (https://xoops.org)
17		* @license GNU GPL (https://www.gnu.org/licenses/gpl-2.0.html/)
18		* @copyright 2011 Culex
19		* @author Michael Albertsen (http://culex.dk) <[email protected]>
20		* @link https://github.com/XoopsModules25x/smallworld
21		* @since 1.0
22		*/
23
24		use XoopsModules\Smallworld;
25		use XoopsModules\Smallworld\Constants;
26
27		require_once __DIR__ . '/header.php';
28
29		$page = basename(__FILE__, '.php');
30
31		// @ todo - figure out why the test for $page is here... $page will always equal 'publicindex'
32		if ($GLOBALS['xoopsUser'] && ($GLOBALS['xoopsUser'] instanceof \XoopsUser) && 'publicindex' !== $page) {
		0 ignored issues – show Bug introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
33		$GLOBALS['xoopsOption']['template_main'] = 'smallworld_index.tpl';
34		} else {
35		$GLOBALS['xoopsOption']['template_main'] = 'smallworld_publicindex.tpl';
36		}
37		require_once XOOPS_ROOT_PATH . '/header.php';
38
39		/** @var \XoopsModules\Smallworld\Helper $helper */
40		require_once $helper->path('include/functions.php');
41		//$GLOBALS['xoopsLogger']->activated = true;
42		//error_reporting(E_ALL);
43
44		$set = smallworld_checkPrivateOrPublic();
45		$swDB = new Smallworld\SwDatabase();
46		$id = Constants::DEFAULT_UID;
47		$username = '';
48		$profile = Constants::PROFILE_NONE;
49
50	View Code Duplication	if ($GLOBALS['xoopsUser'] instanceof \XoopsUser) {
		0 ignored issues – show Duplication introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Bug introduced 2020-03-30 08:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
51		$id = $GLOBALS['xoopsUser']->uid();
52		$username = $GLOBALS['xoopsUser']->uname();
53		//$check = new Smallworld\User();
54		//$profile = $check->checkIfProfile($id);
55		$profile = $helper->getHandler('SwUser')->checkIfProfile($id);
56		}
57
58		$pub = smallworld_checkUserPubPostPerm();
59		$wall = new Smallworld\PublicWallUpdates();
60		$updates = $wall->Updates(0, $pub);
		0 ignored issues – show Bug introduced 2021-04-13 11:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$pub` defined by `smallworld_checkUserPubPostPerm()` on line `58` can also be of type `string`; however, `XoopsModules\Smallworld\...cWallUpdates::Updates()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
61
62		if ($id > 0) {
63		$GLOBALS['xoopsTpl']->assign('ownerofpage', $id);
64		$GLOBALS['xoopsTpl']->assign('myusername', $username);
65		}
66
67		$tplAdmin = $helper->isUserAdmin() ? 'YES' : 'NO';
68
69		// Create form for private settings
70		$form = new Smallworld\Form();
71		$usersettings = $form->usersettings($id, $selected = null);
		0 ignored issues – show Unused Code introduced 2020-03-29 20:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `Form::usersettings()` has too many arguments starting with `$selected = null`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
72		$GLOBALS['xoopsTpl']->assign('usersetting', $usersettings);
73
74		//$xuser = new Smallworld\Profile();
75
76		$menu_home = "<a href='" . $helper->url('/') . "'><img id='menuimg' src='" . $helper->url('assets/images/house.png') . "'>" . _SMALLWORLD_HOME . '</a>';
77		$menu_register = ($profile < Constants::PROFILE_HAS_BOTH) ? "<a href='" . $helper->url('register.php') . "'><img id='menuimg' src='" . $helper->url('assets/images/join.jpg') . "'>" . _MB_SYSTEM_RNOW . '</a>' : '';
78
79		$updatesarray = $wall->Updates(0, $pub);
		0 ignored issues – show Bug introduced 2021-04-13 11:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$pub` defined by `smallworld_checkUserPubPostPerm()` on line `58` can also be of type `string`; however, `XoopsModules\Smallworld\...cWallUpdates::Updates()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
80		$wall->parsePubArray($updatesarray, $id);
		0 ignored issues – show Bug introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$updatesarray` defined by `$wall->Updates(0, $pub)` on line `79` can also be of type `boolean`; however, `XoopsModules\Smallworld\...pdates::parsePubArray()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
81
82		$GLOBALS['xoopsTpl']->assign(
83		[
84		'menu_home' => $menu_home,
85		'menu_register' => $menu_register,
86		'pagename' => 'publicindex',
87		'check' => $profile,
88		'access' => $set['access'],
89		'isadminuser' => $tplAdmin
90		]
91		);
92
93		require_once XOOPS_ROOT_PATH . '/footer.php';
94

XoopsModules25x / smallworld

Issues (621)

Security Analysis not enabled

publicindex.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like