SmallWorldFriends::Showfriends() - Code Metrics - Inspection of "Merge pull request #11 from mambax7/master" - XoopsModules25x/smallworld - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2e271d...4ff4ed )

unknown

created 2021-01-06 16:27 UTC

SmallWorldFriends::Showfriends() A

↳ Parent: SmallWorldFriends

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	11
rs	9.9
c	0
b	0
f	0

<?php namespace Xoopsmodules\Smallworld;
/**
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * SmallWorld
 *
 * @copyright    The XOOPS Project (https://xoops.org)
 * @copyright    2011 Culex
 * @license      GNU GPL (http://www.gnu.org/licenses/gpl-2.0.html/)
 * @package      SmallWorld
 * @since        1.0
 * @author       Michael Albertsen (http://culex.dk) <[email protected]>
 */
class SmallWorldFriends
{

    /**
     * @Show friends of ID
     * @param int $id
     * @return string

     */
    public function Showfriends($id)
    {
        global $xoopsUser, $xoTheme, $xoopsTpl, $arr04, $arr05, $xoopsDB;
        if ($xoopsUser) {
            $user   = new \XoopsUser($id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $myName = $xoopsUser->getUnameFromId($xoopsUser->getVar('uid')); // My name
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $db     = new SmallWorldDB;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $check  = new SmallWorldUser;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else {
        }
    }

    /**
     * @Get friends array of ID
     * @param int    $id
     * @param string $action
     * @return array|bool
     */
    public function getFriends($id, $action)
    {
        global $xoopsUser, $xoopsDB;
        $meuser = $xoopsUser->getVar('uid');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $data   = [];
        if ($xoopsUser) {
            if ('pending' === $action) {
                $sql = 'SELECT * FROM ' . $xoopsDB->prefix('smallworld_friends') . " WHERE me = '" . $id . "' AND status = 1";
            } elseif ('friends' === $action) {
                $sql = 'SELECT * FROM ' . $xoopsDB->prefix('smallworld_friends') . " WHERE me = '" . $id . "' AND status = 2";
            } elseif ('following' === $action) {
                $sql = 'SELECT * FROM ' . $xoopsDB->prefix('smallworld_followers') . " WHERE me = '" . $id . "'";
            } elseif ('followingme' === $action) {
                $sql = 'SELECT * FROM ' . $xoopsDB->prefix('smallworld_followers') . " WHERE you = '" . $id . "'";
            }
            $result = $xoopsDB->queryF($sql);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $count  = $xoopsDB->getRowsNum($result);
            if ($count < 1) {
                return false;
            } else {
                while ($row = $xoopsDB->fetchArray($result)) {
                    $data[] = $row;
                }
            }
        }
        return $data;
    }
}


1			<?php namespace Xoopsmodules\Smallworld;
2			/**
3			* You may not change or alter any portion of this comment or credits
4			* of supporting developers from this source code or any supporting source code
5			* which is considered copyrighted (c) material of the original comment or credit authors.
6			*
7			* This program is distributed in the hope that it will be useful,
8			* but WITHOUT ANY WARRANTY; without even the implied warranty of
9			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* SmallWorld
14			*
15			* @copyright The XOOPS Project (https://xoops.org)
16			* @copyright 2011 Culex
17			* @license GNU GPL (http://www.gnu.org/licenses/gpl-2.0.html/)
18			* @package SmallWorld
19			* @since 1.0
20			* @author Michael Albertsen (http://culex.dk) <[email protected]>
21			*/
22			class SmallWorldFriends
23			{
24
25			/**
26			* @Show friends of ID
27			* @param int $id
28			* @return string
			0 ignored issues – show Documentation introduced 2020-04-14 12:42 UTC by Report Bug Copy Issue Report Should the return type not be `string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
29			*/
30			public function Showfriends($id)
31			{
32			global $xoopsUser, $xoTheme, $xoopsTpl, $arr04, $arr05, $xoopsDB;
33			if ($xoopsUser) {
34			$user = new \XoopsUser($id);
			0 ignored issues – show Unused Code introduced 2020-04-14 12:42 UTC by Report Bug Copy Issue Report `$user` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35			$myName = $xoopsUser->getUnameFromId($xoopsUser->getVar('uid')); // My name
			0 ignored issues – show Unused Code introduced 2020-04-14 12:42 UTC by Report Bug Copy Issue Report `$myName` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
36			$db = new SmallWorldDB;
			0 ignored issues – show Unused Code introduced 2020-03-29 20:20 UTC by Report Bug Copy Issue Report `$db` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
37			$check = new SmallWorldUser;
			0 ignored issues – show Unused Code introduced 2020-04-14 12:42 UTC by Report Bug Copy Issue Report `$check` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
38			} else {
39			}
40			}
41
42			/**
43			* @Get friends array of ID
44			* @param int $id
45			* @param string $action
46			* @return array\|bool
47			*/
48			public function getFriends($id, $action)
49			{
50			global $xoopsUser, $xoopsDB;
51			$meuser = $xoopsUser->getVar('uid');
			0 ignored issues – show Unused Code introduced 2020-04-14 12:42 UTC by Report Bug Copy Issue Report `$meuser` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
52			$data = [];
53			if ($xoopsUser) {
54			if ('pending' === $action) {
55			$sql = 'SELECT * FROM ' . $xoopsDB->prefix('smallworld_friends') . " WHERE me = '" . $id . "' AND status = 1";
56			} elseif ('friends' === $action) {
57			$sql = 'SELECT * FROM ' . $xoopsDB->prefix('smallworld_friends') . " WHERE me = '" . $id . "' AND status = 2";
58			} elseif ('following' === $action) {
59			$sql = 'SELECT * FROM ' . $xoopsDB->prefix('smallworld_followers') . " WHERE me = '" . $id . "'";
60			} elseif ('followingme' === $action) {
61			$sql = 'SELECT * FROM ' . $xoopsDB->prefix('smallworld_followers') . " WHERE you = '" . $id . "'";
62			}
63			$result = $xoopsDB->queryF($sql);
			0 ignored issues – show Bug introduced 2020-04-14 12:42 UTC by Report Bug Copy Issue Report The variable `$sql` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
64			$count = $xoopsDB->getRowsNum($result);
65			if ($count < 1) {
66			return false;
67			} else {
68			while ($row = $xoopsDB->fetchArray($result)) {
69			$data[] = $row;
70			}
71			}
72			}
73			return $data;
74			}
75			}
76

XoopsModules25x / smallworld

Push — master ( 2e271d...4ff4ed )

SmallWorldFriends::Showfriends() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like