upgrade.php ➔ smallworld_doUpgrade() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/smallworld - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 625b06...275716 )

by Michael

created 2016-06-01 04:04 UTC

upgrade.php ➔ smallworld_doUpgrade() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	15
nc	2
nop	0
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0

<?php
// Upgrade functions used when adding or altering tables etc between versions
/**
 * Function to do the creatind
 *
 */
function smallworld_doUpgrade () {
    global $xoopsDB, $xoopsUser;
function myFunction($a, $b) {
    // Do something
}
    varcharToBlog ();
    smallworld_comToBlog ();
    smallworld_adminAvatarRename ();
    if (smallworld_DoTableExists($xoopsDB->prefix('smallworld_settings'))) {
        // Table exists
        Return false;
    } else {
        // Table does not exist -> create
        
        $sql  = "CREATE TABLE IF NOT EXISTS ".$xoopsDB->prefix('smallworld_settings')." (";
        $sql .= "`id` int(11) NOT NULL AUTO_INCREMENT,";
        $sql .= "`userid` int(11) NOT NULL,";
        $sql .= "`value` text NOT NULL,";
        $sql .= "PRIMARY KEY (`id`)";
        $sql .= ") ENGINE=MyISAM DEFAULT CHARSET=utf8 AUTO_INCREMENT=1 ;";
        $result = $xoopsDB->queryF($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}

function smallworld_adminAvatarRename () {
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    $sql = "update ".$xoopsDB->prefix('smallworld_admin')." set userimage = '' WHERE userimage = 'blank.gif' || userimage NOT REGEXP '\.(jpe?g|gif|png|bmp)'";
    $sql2 = "update ".$xoopsDB->prefix('smallworld_user')." set userimage = '' WHERE userimage = 'blank.gif' || userimage NOT REGEXP '\.(jpe?g|gif|png|bmp)'";
    $result = $xoopsDB->queryF($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $result2 = $xoopsDB->queryF($sql2);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
}

function smallworld_DoTableExists($tablename) {
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    $result = $xoopsDB->queryF("SHOW TABLES LIKE '$tablename'");

    return ($xoopsDB->getRowsNum($result) > 0);
}

/**
 * Alter table messages from varchar(200) to text()
 * @return void
 */
function varcharToBlog () {
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    $sql ="ALTER TABLE ".$xoopsDB->prefix('smallworld_messages')." CHANGE message message TEXT";
    $result = $xoopsDB->queryF($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
}

/**
 * function to correct the comments from varchar to text
 * @return void
 */
 function smallworld_comToBlog () {
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    $sql ="ALTER TABLE ".$xoopsDB->prefix('smallworld_comments')." CHANGE comment comment TEXT";
    $result = $xoopsDB->queryF($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
 }


Push — master ( 625b06...275716 )

upgrade.php ➔ smallworld_doUpgrade() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			// Upgrade functions used when adding or altering tables etc between versions
3			/**
4			* Function to do the creatind
5			*
6			*/
7			function smallworld_doUpgrade () {
8			global $xoopsDB, $xoopsUser;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
9			varcharToBlog ();
10			smallworld_comToBlog ();
11			smallworld_adminAvatarRename ();
12			if (smallworld_DoTableExists($xoopsDB->prefix('smallworld_settings'))) {
13			// Table exists
14			Return false;
15			} else {
16			// Table does not exist -> create
17
18			$sql = "CREATE TABLE IF NOT EXISTS ".$xoopsDB->prefix('smallworld_settings')." (";
19			$sql .= "`id` int(11) NOT NULL AUTO_INCREMENT,";
20			$sql .= "`userid` int(11) NOT NULL,";
21			$sql .= "`value` text NOT NULL,";
22			$sql .= "PRIMARY KEY (`id`)";
23			$sql .= ") ENGINE=MyISAM DEFAULT CHARSET=utf8 AUTO_INCREMENT=1 ;";
24			$result = $xoopsDB->queryF($sql);
			0 ignored issues – show Unused Code introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
25			}
26			}
27
28			function smallworld_adminAvatarRename () {
29			global $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
30			$sql = "update ".$xoopsDB->prefix('smallworld_admin')." set userimage = '' WHERE userimage = 'blank.gif' \|\| userimage NOT REGEXP '\.(jpe?g\|gif\|png\|bmp)'";
31			$sql2 = "update ".$xoopsDB->prefix('smallworld_user')." set userimage = '' WHERE userimage = 'blank.gif' \|\| userimage NOT REGEXP '\.(jpe?g\|gif\|png\|bmp)'";
32			$result = $xoopsDB->queryF($sql);
			0 ignored issues – show Unused Code introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
33			$result2 = $xoopsDB->queryF($sql2);
			0 ignored issues – show Unused Code introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report `$result2` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
34			}
35
36			function smallworld_DoTableExists($tablename) {
37			global $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
38			$result = $xoopsDB->queryF("SHOW TABLES LIKE '$tablename'");
39
40			return ($xoopsDB->getRowsNum($result) > 0);
41			}
42
43			/**
44			* Alter table messages from varchar(200) to text()
45			* @return void
46			*/
47			function varcharToBlog () {
48			global $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
49			$sql ="ALTER TABLE ".$xoopsDB->prefix('smallworld_messages')." CHANGE message message TEXT";
50			$result = $xoopsDB->queryF($sql);
			0 ignored issues – show Unused Code introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
51			}
52
53			/**
54			* function to correct the comments from varchar to text
55			* @return void
56			*/
57			function smallworld_comToBlog () {
58			global $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
59			$sql ="ALTER TABLE ".$xoopsDB->prefix('smallworld_comments')." CHANGE comment comment TEXT";
60			$result = $xoopsDB->queryF($sql);
			0 ignored issues – show Unused Code introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
61			}
62

XoopsModules25x / smallworld

Push — master ( 625b06...275716 )

upgrade.php ➔ smallworld_doUpgrade() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like