Issues in Friends.php - Fixed Issues - Inspection of "Merge pull request #8 from XoopsModules25x/revert-..." - XoopsModules25x/smallworld - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fd0c8a...c024a6 )

unknown

created 2020-12-06 11:46 UTC

class/Friends.php (8 issues)

Labels

Severity

zyspec 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace XoopsModules\Smallworld;

/**
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

use XoopsModules\Smallworld\Constants;

/**
 * SmallWorld
 *
 * @copyright    The XOOPS Project (https://xoops.org)
 * @copyright    2011 Culex
 * @license      GNU GPL (http://www.gnu.org/licenses/gpl-2.0.html/)
 * @package      SmallWorld
 * @since        1.0
 * @author       Michael Albertsen (http://culex.dk) <[email protected]>
 */
class Friends
{
    /**
     * Show friends of ID
     *
     * @deprecated - DO NOT USE
     * @todo unfinished - needs completion
     *
     * @param int $id
     * @return string
     */
    public function showFriends($id)
    {
        if ($GLOBALS['xoopsUser'] && ($GLOBALS['xoopsUser'] instanceof \XoopsUser)) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $user   = new \XoopsUser($id);
            $myName = $user->getUnameFromId((int)$id); // My name
            $swDB   = new SwDatabase();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $check  = new User();
        }

        return [(int)$id => $myName];
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * Get friends array of ID
     *
     * must be registered user to call this function
     *
     * @param int    $id
     * @param string $action
     * @return array - empty if nothing found or not authorized
     */
    public function getFriends($id, $action)
    {
        $id = (int)$id;
        $data   = [];
        if ($GLOBALS['xoopsUser'] && ($GLOBALS['xoopsUser'] instanceof \XoopsUser)) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            switch ($action) {
                case 'pending':

                    $sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('smallworld_friends') . " WHERE me = '" . $id . "' AND status = " . Constants::FRIEND_STATUS_PENDING;
                    break;
                case 'friends':

                    $sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('smallworld_friends') . " WHERE me = '" . $id . "' AND status = " . Constants::FRIEND_STATUS_APPROVED;
                    break;
                case 'following':

                    $sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('smallworld_followers') . " WHERE me = '" . $id . "'";
                    break;
                case 'followingme':

                    $sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('smallworld_followers') . " WHERE you = '" . $id . "'";
                    break;
                default:
                    return $data;
            }
            $result = $GLOBALS['xoopsDB']->queryF($sql);
            while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
                $data[] = $row;
            }
        }

        return $data;
    }
}


1		<?php
2
3		namespace XoopsModules\Smallworld;
4
5		/**
6		* You may not change or alter any portion of this comment or credits
7		* of supporting developers from this source code or any supporting source code
8		* which is considered copyrighted (c) material of the original comment or credit authors.
9		*
10		* This program is distributed in the hope that it will be useful,
11		* but WITHOUT ANY WARRANTY; without even the implied warranty of
12		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
13		*/
14
15		use XoopsModules\Smallworld\Constants;
16
17		/**
18		* SmallWorld
19		*
20		* @copyright The XOOPS Project (https://xoops.org)
21		* @copyright 2011 Culex
22		* @license GNU GPL (http://www.gnu.org/licenses/gpl-2.0.html/)
23		* @package SmallWorld
24		* @since 1.0
25		* @author Michael Albertsen (http://culex.dk) <[email protected]>
26		*/
27		class Friends
28		{
29		/**
30		* Show friends of ID
31		*
32		* @deprecated - DO NOT USE
33		* @todo unfinished - needs completion
34		*
35		* @param int $id
36		* @return string
37		*/
38		public function showFriends($id)
39		{
40		if ($GLOBALS['xoopsUser'] && ($GLOBALS['xoopsUser'] instanceof \XoopsUser)) {
		0 ignored issues – show Bug introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
41		$user = new \XoopsUser($id);
42		$myName = $user->getUnameFromId((int)$id); // My name
43		$swDB = new SwDatabase();
		0 ignored issues – show Unused Code introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$swDB` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
44		$check = new User();
45		}
46
47		return [(int)$id => $myName];
		0 ignored issues – show Bug introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$myName` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
48		}
49
50		/**
51		* Get friends array of ID
52		*
53		* must be registered user to call this function
54		*
55		* @param int $id
56		* @param string $action
57		* @return array - empty if nothing found or not authorized
58		*/
59		public function getFriends($id, $action)
60		{
61		$id = (int)$id;
62		$data = [];
63		if ($GLOBALS['xoopsUser'] && ($GLOBALS['xoopsUser'] instanceof \XoopsUser)) {
		0 ignored issues – show Bug introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
64		switch ($action) {
65	View Code Duplication	case 'pending':
		0 ignored issues – show Duplication introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		$sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('smallworld_friends') . " WHERE me = '" . $id . "' AND status = " . Constants::FRIEND_STATUS_PENDING;
67		break;
68	View Code Duplication	case 'friends':
		0 ignored issues – show Duplication introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		$sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('smallworld_friends') . " WHERE me = '" . $id . "' AND status = " . Constants::FRIEND_STATUS_APPROVED;
70		break;
71	View Code Duplication	case 'following':
		0 ignored issues – show Duplication introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72		$sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('smallworld_followers') . " WHERE me = '" . $id . "'";
73		break;
74	View Code Duplication	case 'followingme':
		0 ignored issues – show Duplication introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		$sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('smallworld_followers') . " WHERE you = '" . $id . "'";
76		break;
77		default:
78		return $data;
79		}
80		$result = $GLOBALS['xoopsDB']->queryF($sql);
81		while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
82		$data[] = $row;
83		}
84		}
85
86		return $data;
87		}
88		}
89

XoopsModules25x / smallworld

Push — master ( fd0c8a...c024a6 )

class/Friends.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

Available Fixes

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like