Issues in Form.php - Fixed Issues - Inspection of "Merge pull request #8 from XoopsModules25x/revert-..." - XoopsModules25x/smallworld - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fd0c8a...c024a6 )

unknown

created 2020-12-06 11:46 UTC

class/Form.php (3 issues)

Labels

Severity

zyspec 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace XoopsModules\Smallworld;

/**
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * SmallWorld
 *
 * @package      \XoopsModules\Smallworld
 * @license      GNU GPL (https://www.gnu.org/licenses/gpl-2.0.html/)
 * @copyright    The XOOPS Project (https://xoops.org)
 * @copyright    2011 Culex
 * @author       Michael Albertsen (http://culex.dk) <[email protected]>
 * @link         https://github.com/XoopsModules25x/smallworld
 * @since        1.0
 */

 /**
 * Form Class
 *
 * creates HTML entities to display in forms
 *
 */
class Form
{
    /**
     * Create a dropdown select
     *
     * @param string $name
     * @param array  $options
     * @param string $selected (optional)
     * @param string $sep (optional)
     * @return string
     */
    public function dropdown($name, array $options, $selected = null, $sep = '<br>')
    {
        $dropdown = "<select name='{$name}' id='{$name}'>\n";
        foreach ($options as $key => $option) {
            $select    = $selected == $key ? ' selected' : '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $dropdown .= "<option value='{$key}'{$selected}>{$option}</option>\n";
        }
        $dropdown .= "</select>{$sep}";

        return $dropdown;
    }

    /**
     * Create a radio select
	 *
     * @param string $name
     * @param array  $options
     * @param string $selected (optional)
     * @param string $sep (optional)
     * @return string
     */
    public function radio($name, array $options, $selected = null, $sep = '<br>')
    {
        $selected = $selected;
        $form     = '';
        $i = 0;
        foreach ($options as $value => $option) {
            $select = $selected == $value ? ' checked' : '';
            $form   .= "<label for='{$name}-{$i}'><input type='radio' name='{$name}[]' id='{$name}-{$i}' value='{$value}'{$select}> "
            . "{$option}</label>{$sep}\n";
//            $form   .= "<input type='checkbox' name='{$name}[]' id='{$name}-{$i}' value='{$value}'{$select}> "
//            . "<label for='{$name}-{$i}'>{$option}</label>{$sep}\n";
            $i++;
        }

        return $form;
    }

    /**
	 * Create a HTML checkbox element
	 *
     * @param string $name
     * @param array  $options
     * @param array  $valuearray
     * @param string $selected (optional)
     * @param string $sep (optional)
     * @return string
     */
    public function retrieveRadio($name, $options, $valuearray, $selected = null, $sep = '<br>')

    {
        $form = '';
        $a    = count($options) - 1;
        for ($i = 0; $i <= $a; ++$i) {
            if (in_array($i, $valuearray)) {
                $form .= "<input type='checkbox' id='{$name}-{$i}' name='{$name}[]' value='{$i}' checked> "
                . "<label for='{$name}-{$i}'>{$options[$i]}</label>{$sep}";
            } else {
                $form .= "<input type='checkbox' id='{$name}-{$i}' name='{$name}[]' value='{$i}'> "
                . "<label for='{$name}-{$i}'>{$options[$i]}</label>{$sep}";
            }
        }

        return $form;
    }

    /**
	 * Create a HTML text input element
	 *
     * @param string $name
     * @param string $id
     * @param string $class
     * @param int    $size   (optional)
     * @param string $preset (optional)
     * @return string
     */
    public function input($name, $id, $class, $size = null, $preset = null)
    {
        $s    = $size ?: '50px';
        $data = "<input type='text' size='" . $s . "' name='" . $name . "' id='" . $id . "' class='" . $class . "' value='" . $preset . "'>";

        return $data;
    }

    /**
	 * Create a HTML hidden element
	 *
     * @param string $name
     * @param string $id
     * @param string $preset (optional)
     * @return string
     */
    public function hidden($name, $id, $preset = null)
    {
        $data = "<input type='hidden' name='" . $name . "' value='" . $preset . "' >";

        return $data;
    }

    /**
	 * Returns simple text string
	 *
     * @param string $value
     * @return string
     */
    public function simpleText($value)
    {
        $data = $value;

        return $data;
    }

    /**
	 * Create a HTML select (dropdown) element
	 *
     * @param string  $class
     * @param string  $name
     * @param         $name2
     * @param string  $rel
     * @param array   $options
     * @param string  $textmore
     * @param string  $selected (optional)
     * @param string  $preset   (optional)
     * @return string
     */
    public function dropdown_add($class, $name, $name2, $rel, array $options, $textmore, $selected = null, $preset = null)
    {
        $dropdown = '<span id="' . $name . '"><input type="text" name="' . $name2 . '[]" value="' . $preset . '">';
        $dropdown .= '<select class="smallworld_select" name="' . $name . '[]" id="' . $name . '">' . '<br>';
        foreach ($options as $key => $option) {
            $select   = $selected == $key ? ' selected' : null;
            $dropdown .= '<option value="' . $key . '"' . $select . '>' . $option . '</option>' . '<br>';
        }
        $dropdown .= '</select></span>';

        return $dropdown;
    }

    /**
     * @param string  $class
     * @param string  $name
     * @param         $name2
     * @param string  $rel
     * @param int     $size
     * @param string  $textmore
     * @param string  $preset (optional)
     * @param string  $id     (optional)
     * @return string
     */
    public function input_add($class, $name, $name2, $rel, $size, $textmore, $preset = null, $id = null)
    {
        $s    = $size ?: '50px';
        $i    = $id ?: '';
        $data = "<span id='" . $name . "'><input type='text' size='" . $s . "' name='" . $name2 . "[]' value='" . $preset . "' id='" . $i . "'></span>";

        return $data;
    }

    /**
     * @param string $name
     * @param string $id
     * @param string $title
     * @param string $rows
     * @param string $cols
     * @param string $class
     * @param string $preset (optional)
     * @return string
     * @return string
     */
    public function textarea($name, $id, $title, $rows, $cols, $class, $preset = null)
    {
        return "<textarea name='" . $name . "' id='" . $id . "'  title='" . $title . "' rows='" . $rows . "' cols='" . $cols . "' class='" . $class . "'>" . $preset . '</textarea>';
    }

    /**
     * @param string $class
     * @param string $name
     * @param string $name2
     * @param string $rel
     * @param array  $options
     * @param string $textmore
     * @param string $selected      (optional)
     * @param string $preset        (optional)
     * @param string $selectedstart (optional)
     * @param string $selectedstop  (optional)
     * @return string
     */
    public function school_add(
        $class,
        $name,
        $name2,
        $rel,
        array $options,
        $textmore,
        $selected = null,
        $preset = null,
        $selectedstart = null,
        $selectedstop = null
    ) {
        $dropdown = '<div id="' . $name . '"><p class="smallworld_clonebreaker">' . _SMALLWORLD_SCHOOLNAME . '<input class="school" type="text" value="' . $preset . '" name="' . $name2 . '[]">'
                  . '<br><br>' . _SMALLWORLD_SCHOOLTYPE . '<select class="school" name="' . $name . '[]" id="' . $name . '"">' . '<br>';
        foreach ($options as $key => $option) {
            $select   = $selected == $key ? ' selected="selected"' : null;
            $dropdown .= '<option  class="school" value="' . $key . '"' . $select . '>' . $option . '</option>' . '<br>';
        }
        $dropdown .= '</select>'
                   . '<br><br>'
                   . _SMALLWORLD_START . '<select class="schooltime" name="schoolstart[]" id="schoolstart">';
        $array    = SmallworldGetTimestampsToForm();
        foreach ($array as $key => $option) {
            $selectstart = $selectedstart == $key ? ' selected="selected"' : null;
            $dropdown    .= '<option value="' . $key . '"' . $selectstart . '>' . $option . '</option>' . '<br>';
        }
        $dropdown .= '</select>'
                   . '<br><br>'
                   . _SMALLWORLD_STOP . '<select class="schooltime" name="schoolstop[]" id="schoolstop">';
        $array    = SmallworldGetTimestampsToForm();
        foreach ($array as $key => $option) {
            $selectstop = $selectedstop == $key ? ' selected="selected"' : null;
            $dropdown   .= '<option value="' . $key . '"' . $selectstop . '>' . $option . '</option>' . '<br>';
        }
        $dropdown .= '</select><br></p></div>';

        return $dropdown;
    }

    /**
     * Create HTML form elements for Job fields
     *
     * @param string  $class - not used
     * @param string  $name
     * @param string  $name2 - not used
     * @param string  $rel   - not used
     * @param string  $textmore - not used
     * @param string  $employer      (optional)
     * @param string  $position      (optional)
     * @param string  $selectedstart (optional)
     * @param string  $selectedstop  (optional)
     * @param string  $description   (optional)
     * @return string
     */
    public function job(
        $class,
        $name,
        $name2,
        $rel,
        $textmore,
        $employer = null,
        $position = null,
        $selectedstart = null,
        $selectedstop = null,
        $description = null
    ) {
        $text = '<div id="' . $name . '"><p class="smallworld_clonebreaker">' . _SMALLWORLD_EMPLOYER . '<input class="job" id="job" value="' . $employer . '" type="text" name="employer[]">'
              . '<br><br>' . _SMALLWORLD_POSITION . '<input class="job" type="text" value="' . $position . '" name="position[]">'
              . '<br><br>' . _SMALLWORLD_JOBSTART . '<input class="jobstart" type="text" value="' . $selectedstart . '" name="jobstart[]">'
              . '<br><br>' . _SMALLWORLD_JOBSTOP . '<input class="jobstop" value="' . $selectedstop . '" type="text" name="jobstop[]">'
              . '<br><br><span class="jobdescText">' . _SMALLWORLD_DESCRIPTION . '</span><textarea class="jobdesc" name="description[]" rows="20" cols="20">' . $description . '</textarea><br></p></div>'
              . '' . '<br>';

        return $text;
    }

    /**
     * Create a HTML upload form
     *
     * @param int $userID - not used
     * @return string
     */
    public function uploadform($userID)
    {
        $text = '<form action="' . Helper::getInstance()->url('imgupload.php') . '" method="POST" enctype="multipart/form-data">'
              . '<input type="file" name="file[]" multiple>'
              . '<button type="submit">' . _SMALLWORLD_UPLOADTEXT . '</button>'
              . '<span class="file_upload_label">' . _SMALLWORLD_UPLOADFILESTEXT . '</span>'
              . '</form>';

        return $text;
    }

    /**
     * @param int    $userID - not used
     * @param string $imgurl
     * @param string $imgdesc
     * @param string $id
     * @return string
     */
    public function edit_images($userID, $imgurl, $imgdesc, $id)
    {
        $text = '<p class="smallworld_clonebreaker"><br>'
              . '<table class="smallworld_table" border="0" cellspacing="0" cellpadding="0">'
              . '<tr>'
              . '<td><img class="smallworld_edit_image" src="' . $imgurl . '" height="100px" width="80px;"></td>'
              . '<td><span class="smallworld_editTextSpan">' . _SMALLWORLD_UPLOADDESC . '</span><br><br><textarea class="smallworld_edit_desc" name="imgdesc[]" rows="1" cols="1">' . stripslashes($imgdesc) . '</textarea><br><br></td>'
              . '<input value="' . $id . '" type="hidden" name="id[]">'
              . '</tr></table></p>';

        return $text;
    }

    /**
     * Create HTML radio selects for user settings
     *
     * @param int $userid
     * @return string
     */
    public function usersettings($userid)
    {
        $form = "<div style='display:none'><div class='smallworld_usersetings'>";
        $form .= '<fieldset><legend>' . _SMALLWORLD_SHOWIFPUBLICORPRIVATE . '</legend>';
        $form .= "<form id='perset'>";
        if ($GLOBALS['xoopsUser'] && $GLOBALS['xoopsUser'] instanceof \XoopsUser) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $sql    = 'SELECT value FROM ' . $GLOBALS['xoopsDB']->prefix('smallworld_settings') . ' WHERE userid = ' . (int)$userid;
            $result = $GLOBALS['xoopsDB']->queryF($sql);
            $i      = $GLOBALS['xoopsDB']->getRowsNum($result);
            $v      = [];
            if ($i >= 1) {
                while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
                    $v    = unserialize(stripslashes($row['value']));
                    $pv   = ('1' == $v['posts']) ? ' checked' : '';
                    $cv   = ('1' == $v['comments']) ? ' checked' : '';
                    $nv   = ('1' == $v['notify']) ? ' checked' : '';
                    $form .= '<input type="checkbox" name="usersettings[]" id="posts" value="' . $v['posts'] . '" ' . $pv . '> ' . _SMALLWORLD_SHOWMYPOSTS . '<br>';
                    $form .= '<input type="checkbox" name="usersettings[]" id="comments" value="' . $v['comments'] . '" ' . $cv . '> ' . _SMALLWORLD_SHOWMYCOMMENTS . '<br>';
                    $form .= '<input type="checkbox" name="usersettings[]" id="notify" value="' . $v['notify'] . '" ' . $nv . '> ' . _SMALLWORLD_NOTIFYME . '<br>';
                }
            } else {
                $form .= '<input type="checkbox" name="usersettings[]" id="posts" value="0"> ' . _SMALLWORLD_SHOWMYPOSTS . '<br>';
                $form .= '<input type="checkbox" name="usersettings[]" id="comments" value="0"> ' . _SMALLWORLD_SHOWMYCOMMENTS . '<br>';
                $form .= '<input type="checkbox" name="usersettings[]" id="notify" value="0"> ' . _SMALLWORLD_NOTIFYME . '<br>';
            }
        }
        $form .= "<br><input type='submit' id='smallworld_privsave' value='" . _SMALLWORLD_SUBMIT . "' class='smallworld_finish'>";
        $form .= '</form></fieldset></div></div>';

        return $form;
    }
}


Push — master ( fd0c8a...c024a6 )

class/Form.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

1		<?php
2
3		namespace XoopsModules\Smallworld;
4
5		/**
6		* You may not change or alter any portion of this comment or credits
7		* of supporting developers from this source code or any supporting source code
8		* which is considered copyrighted (c) material of the original comment or credit authors.
9		*
10		* This program is distributed in the hope that it will be useful,
11		* but WITHOUT ANY WARRANTY; without even the implied warranty of
12		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
13		*/
14
15		/**
16		* SmallWorld
17		*
18		* @package \XoopsModules\Smallworld
19		* @license GNU GPL (https://www.gnu.org/licenses/gpl-2.0.html/)
20		* @copyright The XOOPS Project (https://xoops.org)
21		* @copyright 2011 Culex
22		* @author Michael Albertsen (http://culex.dk) <[email protected]>
23		* @link https://github.com/XoopsModules25x/smallworld
24		* @since 1.0
25		*/
26
27		/**
28		* Form Class
29		*
30		* creates HTML entities to display in forms
31		*
32		*/
33		class Form
34		{
35		/**
36		* Create a dropdown select
37		*
38		* @param string $name
39		* @param array $options
40		* @param string $selected (optional)
41		* @param string $sep (optional)
42		* @return string
43		*/
44		public function dropdown($name, array $options, $selected = null, $sep = '<br>')
45		{
46		$dropdown = "<select name='{$name}' id='{$name}'>\n";
47		foreach ($options as $key => $option) {
48		$select = $selected == $key ? ' selected' : '';
		0 ignored issues – show Unused Code introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$select` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
49		$dropdown .= "<option value='{$key}'{$selected}>{$option}</option>\n";
50		}
51		$dropdown .= "</select>{$sep}";
52
53		return $dropdown;
54		}
55
56		/**
57		* Create a radio select
58		*
59		* @param string $name
60		* @param array $options
61		* @param string $selected (optional)
62		* @param string $sep (optional)
63		* @return string
64		*/
65		public function radio($name, array $options, $selected = null, $sep = '<br>')
66		{
67		$selected = $selected;
68		$form = '';
69		$i = 0;
70		foreach ($options as $value => $option) {
71		$select = $selected == $value ? ' checked' : '';
72		$form .= "<label for='{$name}-{$i}'><input type='radio' name='{$name}[]' id='{$name}-{$i}' value='{$value}'{$select}> "
73		. "{$option}</label>{$sep}\n";
74		// $form .= "<input type='checkbox' name='{$name}[]' id='{$name}-{$i}' value='{$value}'{$select}> "
75		// . "<label for='{$name}-{$i}'>{$option}</label>{$sep}\n";
76		$i++;
77		}
78
79		return $form;
80		}
81
82		/**
83		* Create a HTML checkbox element
84		*
85		* @param string $name
86		* @param array $options
87		* @param array $valuearray
88		* @param string $selected (optional)
89		* @param string $sep (optional)
90		* @return string
91		*/
92		public function retrieveRadio($name, $options, $valuearray, $selected = null, $sep = '<br>')
		0 ignored issues – show Unused Code introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$selected` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
93		{
94		$form = '';
95		$a = count($options) - 1;
96		for ($i = 0; $i <= $a; ++$i) {
97		if (in_array($i, $valuearray)) {
98		$form .= "<input type='checkbox' id='{$name}-{$i}' name='{$name}[]' value='{$i}' checked> "
99		. "<label for='{$name}-{$i}'>{$options[$i]}</label>{$sep}";
100		} else {
101		$form .= "<input type='checkbox' id='{$name}-{$i}' name='{$name}[]' value='{$i}'> "
102		. "<label for='{$name}-{$i}'>{$options[$i]}</label>{$sep}";
103		}
104		}
105
106		return $form;
107		}
108
109		/**
110		* Create a HTML text input element
111		*
112		* @param string $name
113		* @param string $id
114		* @param string $class
115		* @param int $size (optional)
116		* @param string $preset (optional)
117		* @return string
118		*/
119	View Code Duplication	public function input($name, $id, $class, $size = null, $preset = null)
120		{
121		$s = $size ?: '50px';
122		$data = "<input type='text' size='" . $s . "' name='" . $name . "' id='" . $id . "' class='" . $class . "' value='" . $preset . "'>";
123
124		return $data;
125		}
126
127		/**
128		* Create a HTML hidden element
129		*
130		* @param string $name
131		* @param string $id
132		* @param string $preset (optional)
133		* @return string
134		*/
135		public function hidden($name, $id, $preset = null)
136		{
137		$data = "<input type='hidden' name='" . $name . "' value='" . $preset . "' >";
138
139		return $data;
140		}
141
142		/**
143		* Returns simple text string
144		*
145		* @param string $value
146		* @return string
147		*/
148		public function simpleText($value)
149		{
150		$data = $value;
151
152		return $data;
153		}
154
155		/**
156		* Create a HTML select (dropdown) element
157		*
158		* @param string $class
159		* @param string $name
160		* @param $name2
161		* @param string $rel
162		* @param array $options
163		* @param string $textmore
164		* @param string $selected (optional)
165		* @param string $preset (optional)
166		* @return string
167		*/
168	View Code Duplication	public function dropdown_add($class, $name, $name2, $rel, array $options, $textmore, $selected = null, $preset = null)
169		{
170		$dropdown = '<span id="' . $name . '"><input type="text" name="' . $name2 . '[]" value="' . $preset . '">';
171		$dropdown .= '<select class="smallworld_select" name="' . $name . '[]" id="' . $name . '">' . '<br>';
172		foreach ($options as $key => $option) {
173		$select = $selected == $key ? ' selected' : null;
174		$dropdown .= '<option value="' . $key . '"' . $select . '>' . $option . '</option>' . '<br>';
175		}
176		$dropdown .= '</select></span>';
177
178		return $dropdown;
179		}
180
181		/**
182		* @param string $class
183		* @param string $name
184		* @param $name2
185		* @param string $rel
186		* @param int $size
187		* @param string $textmore
188		* @param string $preset (optional)
189		* @param string $id (optional)
190		* @return string
191		*/
192	View Code Duplication	public function input_add($class, $name, $name2, $rel, $size, $textmore, $preset = null, $id = null)
193		{
194		$s = $size ?: '50px';
195		$i = $id ?: '';
196		$data = "<span id='" . $name . "'><input type='text' size='" . $s . "' name='" . $name2 . "[]' value='" . $preset . "' id='" . $i . "'></span>";
197
198		return $data;
199		}
200
201		/**
202		* @param string $name
203		* @param string $id
204		* @param string $title
205		* @param string $rows
206		* @param string $cols
207		* @param string $class
208		* @param string $preset (optional)
209		* @return string
210		* @return string
211		*/
212		public function textarea($name, $id, $title, $rows, $cols, $class, $preset = null)
213		{
214		return "<textarea name='" . $name . "' id='" . $id . "' title='" . $title . "' rows='" . $rows . "' cols='" . $cols . "' class='" . $class . "'>" . $preset . '</textarea>';
215		}
216
217		/**
218		* @param string $class
219		* @param string $name
220		* @param string $name2
221		* @param string $rel
222		* @param array $options
223		* @param string $textmore
224		* @param string $selected (optional)
225		* @param string $preset (optional)
226		* @param string $selectedstart (optional)
227		* @param string $selectedstop (optional)
228		* @return string
229		*/
230		public function school_add(
231		$class,
232		$name,
233		$name2,
234		$rel,
235		array $options,
236		$textmore,
237		$selected = null,
238		$preset = null,
239		$selectedstart = null,
240		$selectedstop = null
241		) {
242		$dropdown = '<div id="' . $name . '"><p class="smallworld_clonebreaker">' . _SMALLWORLD_SCHOOLNAME . '<input class="school" type="text" value="' . $preset . '" name="' . $name2 . '[]">'
243		. '<br><br>' . _SMALLWORLD_SCHOOLTYPE . '<select class="school" name="' . $name . '[]" id="' . $name . '"">' . '<br>';
244		foreach ($options as $key => $option) {
245		$select = $selected == $key ? ' selected="selected"' : null;
246		$dropdown .= '<option class="school" value="' . $key . '"' . $select . '>' . $option . '</option>' . '<br>';
247		}
248		$dropdown .= '</select>'
249		. '<br><br>'
250		. _SMALLWORLD_START . '<select class="schooltime" name="schoolstart[]" id="schoolstart">';
251		$array = SmallworldGetTimestampsToForm();
252	View Code Duplication	foreach ($array as $key => $option) {
253		$selectstart = $selectedstart == $key ? ' selected="selected"' : null;
254		$dropdown .= '<option value="' . $key . '"' . $selectstart . '>' . $option . '</option>' . '<br>';
255		}
256		$dropdown .= '</select>'
257		. '<br><br>'
258		. _SMALLWORLD_STOP . '<select class="schooltime" name="schoolstop[]" id="schoolstop">';
259		$array = SmallworldGetTimestampsToForm();
260	View Code Duplication	foreach ($array as $key => $option) {
261		$selectstop = $selectedstop == $key ? ' selected="selected"' : null;
262		$dropdown .= '<option value="' . $key . '"' . $selectstop . '>' . $option . '</option>' . '<br>';
263		}
264		$dropdown .= '</select><br></p></div>';
265
266		return $dropdown;
267		}
268
269		/**
270		* Create HTML form elements for Job fields
271		*
272		* @param string $class - not used
273		* @param string $name
274		* @param string $name2 - not used
275		* @param string $rel - not used
276		* @param string $textmore - not used
277		* @param string $employer (optional)
278		* @param string $position (optional)
279		* @param string $selectedstart (optional)
280		* @param string $selectedstop (optional)
281		* @param string $description (optional)
282		* @return string
283		*/
284		public function job(
285		$class,
286		$name,
287		$name2,
288		$rel,
289		$textmore,
290		$employer = null,
291		$position = null,
292		$selectedstart = null,
293		$selectedstop = null,
294		$description = null
295		) {
296		$text = '<div id="' . $name . '"><p class="smallworld_clonebreaker">' . _SMALLWORLD_EMPLOYER . '<input class="job" id="job" value="' . $employer . '" type="text" name="employer[]">'
297		. '<br><br>' . _SMALLWORLD_POSITION . '<input class="job" type="text" value="' . $position . '" name="position[]">'
298		. '<br><br>' . _SMALLWORLD_JOBSTART . '<input class="jobstart" type="text" value="' . $selectedstart . '" name="jobstart[]">'
299		. '<br><br>' . _SMALLWORLD_JOBSTOP . '<input class="jobstop" value="' . $selectedstop . '" type="text" name="jobstop[]">'
300		. '<br><br><span class="jobdescText">' . _SMALLWORLD_DESCRIPTION . '</span><textarea class="jobdesc" name="description[]" rows="20" cols="20">' . $description . '</textarea><br></p></div>'
301		. '' . '<br>';
302
303		return $text;
304		}
305
306		/**
307		* Create a HTML upload form
308		*
309		* @param int $userID - not used
310		* @return string
311		*/
312		public function uploadform($userID)
313		{
314		$text = '<form action="' . Helper::getInstance()->url('imgupload.php') . '" method="POST" enctype="multipart/form-data">'
315		. '<input type="file" name="file[]" multiple>'
316		. '<button type="submit">' . _SMALLWORLD_UPLOADTEXT . '</button>'
317		. '<span class="file_upload_label">' . _SMALLWORLD_UPLOADFILESTEXT . '</span>'
318		. '</form>';
319
320		return $text;
321		}
322
323		/**
324		* @param int $userID - not used
325		* @param string $imgurl
326		* @param string $imgdesc
327		* @param string $id
328		* @return string
329		*/
330		public function edit_images($userID, $imgurl, $imgdesc, $id)
331		{
332		$text = '<p class="smallworld_clonebreaker"><br>'
333		. '<table class="smallworld_table" border="0" cellspacing="0" cellpadding="0">'
334		. '<tr>'
335		. '<td><img class="smallworld_edit_image" src="' . $imgurl . '" height="100px" width="80px;"></td>'
336		. '<td><span class="smallworld_editTextSpan">' . _SMALLWORLD_UPLOADDESC . '</span><br><br><textarea class="smallworld_edit_desc" name="imgdesc[]" rows="1" cols="1">' . stripslashes($imgdesc) . '</textarea><br><br></td>'
337		. '<input value="' . $id . '" type="hidden" name="id[]">'
338		. '</tr></table></p>';
339
340		return $text;
341		}
342
343		/**
344		* Create HTML radio selects for user settings
345		*
346		* @param int $userid
347		* @return string
348		*/
349		public function usersettings($userid)
350		{
351		$form = "<div style='display:none'><div class='smallworld_usersetings'>";
352		$form .= '<fieldset><legend>' . _SMALLWORLD_SHOWIFPUBLICORPRIVATE . '</legend>';
353		$form .= "<form id='perset'>";
354		if ($GLOBALS['xoopsUser'] && $GLOBALS['xoopsUser'] instanceof \XoopsUser) {
		0 ignored issues – show Bug introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
355		$sql = 'SELECT value FROM ' . $GLOBALS['xoopsDB']->prefix('smallworld_settings') . ' WHERE userid = ' . (int)$userid;
356		$result = $GLOBALS['xoopsDB']->queryF($sql);
357		$i = $GLOBALS['xoopsDB']->getRowsNum($result);
358		$v = [];
359	View Code Duplication	if ($i >= 1) {
360		while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
361		$v = unserialize(stripslashes($row['value']));
362		$pv = ('1' == $v['posts']) ? ' checked' : '';
363		$cv = ('1' == $v['comments']) ? ' checked' : '';
364		$nv = ('1' == $v['notify']) ? ' checked' : '';
365		$form .= '<input type="checkbox" name="usersettings[]" id="posts" value="' . $v['posts'] . '" ' . $pv . '> ' . _SMALLWORLD_SHOWMYPOSTS . '<br>';
366		$form .= '<input type="checkbox" name="usersettings[]" id="comments" value="' . $v['comments'] . '" ' . $cv . '> ' . _SMALLWORLD_SHOWMYCOMMENTS . '<br>';
367		$form .= '<input type="checkbox" name="usersettings[]" id="notify" value="' . $v['notify'] . '" ' . $nv . '> ' . _SMALLWORLD_NOTIFYME . '<br>';
368		}
369		} else {
370		$form .= '<input type="checkbox" name="usersettings[]" id="posts" value="0"> ' . _SMALLWORLD_SHOWMYPOSTS . '<br>';
371		$form .= '<input type="checkbox" name="usersettings[]" id="comments" value="0"> ' . _SMALLWORLD_SHOWMYCOMMENTS . '<br>';
372		$form .= '<input type="checkbox" name="usersettings[]" id="notify" value="0"> ' . _SMALLWORLD_NOTIFYME . '<br>';
373		}
374		}
375		$form .= "<br><input type='submit' id='smallworld_privsave' value='" . _SMALLWORLD_SUBMIT . "' class='smallworld_finish'>";
376		$form .= '</form></fieldset></div></div>';
377
378		return $form;
379		}
380		}
381

XoopsModules25x / smallworld

Push — master ( fd0c8a...c024a6 )

class/Form.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like