Issues in index.php - Fixed Issues - Inspection of "Merge pull request #8 from XoopsModules25x/revert-..." - XoopsModules25x/smallworld - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fd0c8a...c024a6 )

unknown

created 2020-12-06 11:46 UTC

admin/index.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

zyspec 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * SmallWorld
 *
 * @package      \XoopsModules\SmallWorld
 * @license      GNU GPL (http://www.gnu.org/licenses/gpl-2.0.html/)
 * @copyright    The XOOPS Project (https://xoops.org)
 * @copyright    2011 Culex
 * @author       Michael Albertsen (http://culex.dk) <[email protected]>
 * @link         https://github.com/XoopsModules25x/smallworld
 * @since        1.0
 */

use XoopsModules\Smallworld;
use XoopsModules\Smallworld\Constants;
use XoopsModules\Smallworld\Utility;

require_once __DIR__ . '/admin_header.php';
/**
 * Vars defined by inclusion of ./admin_header.php
 *
 * @var \XoopsModules\Smallworld\Admin $admin
 * @var \XoopsModules\Smallworld\SwUserHandler $swUserHandler
 * @var \XoopsModules\Smallworld\DoSync $d
 * @var \XoopsModules\Smallworld\User $check
 * @var \XoopsModules\Smallworld\SwDatabase $swDB
 * @var \XoopsModules\Smallworld\WallUpdates $wall
 * @var \Xmf\Module\Admin $adminObject
 * @var \XoopsModules\Smallworld\Helper $helper
 * @var string $moduleDirName
 * @var string $moduleDirNameUpper
 */
require_once $helper->path('include/functions.php');

xoops_cp_header();
$GLOBALS['xoTheme']->addStylesheet($helper->url('assets/css/SmallworldAdmin.css'));
$GLOBALS['xoTheme']->addScript($helper->url('assets/js/adminsmallworld.js'));

$configurator = include dirname(__DIR__) . '/include/config.php';
foreach (array_keys($configurator->uploadFolders) as $i) {
    Utility::createFolder($configurator->uploadFolders[$i]);
    $adminObject->addConfigBoxLine($configurator->uploadFolders[$i], 'folder');
}

// Sync check for orphans
$d->checkOrphans();

// Find oldest message and apply to template
$dfm = $admin->oldestMsg();
$dateoffirstmessage = (Constants::NO_DATE == $dfm) ? _AM_SMALLWORLD_NONEYET : date(_SHORTDATESTRING, $dfm);

// Get days number
$totaldays = $admin->countDays();
// get average messages per day
$avgperday = $admin->AvgMsgDay($totaldays);
// Smallworld version number
$installversion = $admin->ModuleInstallVersion();
// Smallworld install date
$installdate = $admin->ModuleInstallDate();
//check current version of Smallworld, return desc,link,version if new available
$installCheck = $admin->doCheckUpdate();
// Count members using Smallworld
$sumallusers = $swUserHandler->getCount();
//$sumallusers = $admin->TotalUsers();
// Find list of most active users (total)
$maAllround = $admin->mostactiveusers_allround();
$ma_cnt     = 0;
$count      = !empty($maAllround) ? count($maAllround['cnt']) : 0;
$mat_cnt    = 0;
if (0 !== $count) {
    $ma_cnt = 1;
    $ma     = "<table class='smallworldadmin'><tr>";
    $ma     .= '<td><b>' . _AM_SMALLWORLD_STATS_POS . '</b></td><td><b>' . _AM_SMALLWORLD_STATS_IMG . '</b></td><td><b>' . _AM_SMALLWORLD_STATS_AMOUNT . '</b></td><td><b>' . _AM_SMALLWORLD_STATS_NAME . '</b></td></tr>';
    $i      = 1;
    while ($i <= count($maAllround['cnt'])) {
        $ma .= vsprintf('<tr><td>%s</td>', [$maAllround['counter'][$i]]);
        $ma .= vsprintf('<td>%s</td>', [$maAllround['img'][$i]]);
        $ma .= vsprintf('<td>%s</td>', [$maAllround['cnt'][$i]]);
        $ma .= vsprintf('<td>%s</td></tr>', [$maAllround['from'][$i]]);
        ++$i;
    }
    $ma .= '</tr></table>';
} else {
    $maAllround = 0;
}
// Find list of most active users (24 hours)
$maToday = $admin->mostactiveusers_today();
$count   = !empty($maToday) ? count($maToday['cnt']) : 0;
$mat_cnt = 0;
if (0 !== $count) {
    $mat_cnt = 1;
    $mat     = "<table class='smallworldadmin'><tr>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_POS . "</td>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_IMG . "</td>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_AMOUNT . "</td>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_NAME . "</td></tr>\n";
    $i = 1;
    while ($i <= $count) {
        $mat .= vsprintf('<tr><td>%s</td>', [$maToday['counter'][$i]]);
        $mat .= vsprintf('<td>%s</td>', [$maToday['img'][$i]]);
        $mat .= vsprintf('<td>%s</td>', [$maToday['cnt'][$i]]);
        $mat .= vsprintf('<td>%s</td></tr>', [$maToday['from'][$i]]);
        ++$i;
    }
    $mat .= "</tr></table>\n";
} else {
    $mat = 0;
}
// FInd list of best rated users overall
$topusers = $admin->topratedusers('up');
$count    = !empty($topusers) ? count($topusers['cnt']) : 0;
$top_cnt  = 0;
if (0 !== $count) {
    $top_cnt = 1;
    $top     = "<table class='smallworldadmin'><tr>\n"
             . "  <td class='bold'>" . _AM_SMALLWORLD_STATS_POS . "</td>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_IMG . "</td>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_AMOUNT . "</td>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_NAME . "</td></tr>\n";
    $i       = 1;
    while ($i <= $count) {
        $top .= vsprintf('<tr><td>%s</td>', [$topusers['counter'][$i]]);
        $top .= vsprintf('<td>%s</td>', [$topusers['img'][$i]]);
        $top .= vsprintf('<td>%s</td>', [$topusers['cnt'][$i]]);
        $top .= vsprintf('<td>%s</td></tr>', [$topusers['user'][$i]]);
        ++$i;
    }
    $top .= "</tr></table>\n";
} else {
    $top = 0;
}

// FInd list of worst rated users overall
$lowusers = $admin->topratedusers('down');
$low_cnt  = 0;
$count    = !empty($lowusers) ? count($lowusers['cnt']) : 0;
if (0 !== $count) {

    $low_cnt = 1;
    $low     = "<table class='smallworldadmin'><tr>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_POS . "</td>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_IMG . "</td>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_AMOUNT . "</td>\n"
             . "<td class='bold'>" . _AM_SMALLWORLD_STATS_NAME . "</td></tr>\n";
    $i       = 1;
    while ($i <= $count) {
        $low .= vsprintf('<tr><td>%s</td>', [$lowusers['counter'][$i]]);
        $low .= vsprintf('<td>%s</td>', [$lowusers['img'][$i]]);
        $low .= vsprintf('<td>%s</td>', [$lowusers['cnt'][$i]]);
        $low .= vsprintf('<td>%s</td></tr>', [$lowusers['user'][$i]]);
        ++$i;
    }
    $low .= "</tr></table>\n";
} else {
    $low = 0;
}

//-----------------------

// template assignments
$GLOBALS['xoopsTpl']->assign([
    'lang_moduleinfo'            => _AM_SMALLWORLD_MODULEINFO,
    'lang_installversion'        => _AM_SMALLWORLD_MODULEINSTALL,
    'lang_installversion_status' => _AM_SMALLWORLD_UPDATE_STATUS,
    'lang_installdate'           => _AM_SMALLWORLD_INSTALLDATE
]);

//$GLOBALS['xoopsTpl']->assign('installversion', $installversion);
//$GLOBALS['xoopsTpl']->assign('installdate', $installdate);
//$GLOBALS['xoopsTpl']->assign('installversion_status',$installCheck);
//$GLOBALS['xoopsTpl']->display($helper->path('templates/admin_moduleinfo.tpl'));

//-----------------------

$adminObject->addInfoBox(_AM_SMALLWORLD_MODULEINFO);
$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . _AM_SMALLWORLD_MODULEINSTALL . ' : %s</br>', $installversion), '', 'Green', 'default');
$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . _AM_SMALLWORLD_INSTALLDATE . ': %s', $installdate), '', 'Green', 'default');
$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . '%s', $installCheck), '', 'Green', 'default');

$adminObject->addInfoBox(_AM_SMALLWORLD_USERSTATS);
$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . _AM_SMALLWORLD_DATEOFFIRSTMESSAGE . ' : %s</br>', $dateoffirstmessage), '', 'Green', 'default');
$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . _AM_SMALLWORLD_TOTALUSERS . ' : %s</br>', $sumallusers), '', 'Red', 'default');

if ($avgperday > 0) {
    $adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . _AM_SMALLWORLD_AVERAGEMSGPERDAY . ' : %s</br>', $avgperday), '', 'Red', 'default');
}

if (0 != $mat_cnt) {
    $adminObject->addInfoBoxLine(sprintf("<p class='smallworldadmin'>" . _AM_SMALLWORLD_TOPCHATTERS_TODAY . ' : %s</p>', $mat), '', 'Red', 'default');
}
if (0 != $ma_cnt) {
    $adminObject->addInfoBoxLine(sprintf("<p class='smallworldadmin'>" . _AM_SMALLWORLD_TOPCHATTERS . ' : %s</p>', $ma), '', 'Red', 'default');
}
if (0 != $top_cnt) {
    $adminObject->addInfoBoxLine(sprintf("<p class='smallworldadmin'>" . _AM_SMALLWORLD_TOPRATEDUSERS . ' : %s</p>', $top), '', 'Red', 'default');
}
if (0 != $low_cnt) {
    $adminObject->addInfoBoxLine(sprintf("<p class='smallworldadmin'>" . _AM_SMALLWORLD_BOTTOMRATEDUSERS . ' : %s</p>', $low), '', 'Red', 'default');
}

echo $adminObject->displayNavigation('index.php');
echo $adminObject->displayIndex();

echo Utility::getServerStats();

require_once __DIR__ . '/admin_footer.php';


1		<?php
2		/*
3		* You may not change or alter any portion of this comment or credits
4		* of supporting developers from this source code or any supporting source code
5		* which is considered copyrighted (c) material of the original comment or credit authors.
6		*
7		* This program is distributed in the hope that it will be useful,
8		* but WITHOUT ANY WARRANTY; without even the implied warranty of
9		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* SmallWorld
14		*
15		* @package \XoopsModules\SmallWorld
16		* @license GNU GPL (http://www.gnu.org/licenses/gpl-2.0.html/)
17		* @copyright The XOOPS Project (https://xoops.org)
18		* @copyright 2011 Culex
19		* @author Michael Albertsen (http://culex.dk) <[email protected]>
20		* @link https://github.com/XoopsModules25x/smallworld
21		* @since 1.0
22		*/
23
24		use XoopsModules\Smallworld;
25		use XoopsModules\Smallworld\Constants;
26		use XoopsModules\Smallworld\Utility;
27
28		require_once __DIR__ . '/admin_header.php';
29		/**
30		* Vars defined by inclusion of ./admin_header.php
31		*
32		* @var \XoopsModules\Smallworld\Admin $admin
33		* @var \XoopsModules\Smallworld\SwUserHandler $swUserHandler
34		* @var \XoopsModules\Smallworld\DoSync $d
35		* @var \XoopsModules\Smallworld\User $check
36		* @var \XoopsModules\Smallworld\SwDatabase $swDB
37		* @var \XoopsModules\Smallworld\WallUpdates $wall
38		* @var \Xmf\Module\Admin $adminObject
39		* @var \XoopsModules\Smallworld\Helper $helper
40		* @var string $moduleDirName
41		* @var string $moduleDirNameUpper
42		*/
43		require_once $helper->path('include/functions.php');
44
45		xoops_cp_header();
46		$GLOBALS['xoTheme']->addStylesheet($helper->url('assets/css/SmallworldAdmin.css'));
47		$GLOBALS['xoTheme']->addScript($helper->url('assets/js/adminsmallworld.js'));
48
49		$configurator = include dirname(__DIR__) . '/include/config.php';
50		foreach (array_keys($configurator->uploadFolders) as $i) {
51		Utility::createFolder($configurator->uploadFolders[$i]);
52		$adminObject->addConfigBoxLine($configurator->uploadFolders[$i], 'folder');
53		}
54
55		// Sync check for orphans
56		$d->checkOrphans();
57
58		// Find oldest message and apply to template
59		$dfm = $admin->oldestMsg();
60		$dateoffirstmessage = (Constants::NO_DATE == $dfm) ? _AM_SMALLWORLD_NONEYET : date(_SHORTDATESTRING, $dfm);
61
62		// Get days number
63		$totaldays = $admin->countDays();
64		// get average messages per day
65		$avgperday = $admin->AvgMsgDay($totaldays);
66		// Smallworld version number
67		$installversion = $admin->ModuleInstallVersion();
68		// Smallworld install date
69		$installdate = $admin->ModuleInstallDate();
70		//check current version of Smallworld, return desc,link,version if new available
71		$installCheck = $admin->doCheckUpdate();
72		// Count members using Smallworld
73		$sumallusers = $swUserHandler->getCount();
74		//$sumallusers = $admin->TotalUsers();
75		// Find list of most active users (total)
76		$maAllround = $admin->mostactiveusers_allround();
77		$ma_cnt = 0;
78		$count = !empty($maAllround) ? count($maAllround['cnt']) : 0;
79		$mat_cnt = 0;
80		if (0 !== $count) {
81		$ma_cnt = 1;
82		$ma = "<table class='smallworldadmin'><tr>";
83		$ma .= '<td><b>' . _AM_SMALLWORLD_STATS_POS . '</b></td><td><b>' . _AM_SMALLWORLD_STATS_IMG . '</b></td><td><b>' . _AM_SMALLWORLD_STATS_AMOUNT . '</b></td><td><b>' . _AM_SMALLWORLD_STATS_NAME . '</b></td></tr>';
84		$i = 1;
85		while ($i <= count($maAllround['cnt'])) {
86		$ma .= vsprintf('<tr><td>%s</td>', [$maAllround['counter'][$i]]);
87		$ma .= vsprintf('<td>%s</td>', [$maAllround['img'][$i]]);
88		$ma .= vsprintf('<td>%s</td>', [$maAllround['cnt'][$i]]);
89		$ma .= vsprintf('<td>%s</td></tr>', [$maAllround['from'][$i]]);
90		++$i;
91		}
92		$ma .= '</tr></table>';
93		} else {
94		$maAllround = 0;
95		}
96		// Find list of most active users (24 hours)
97		$maToday = $admin->mostactiveusers_today();
98		$count = !empty($maToday) ? count($maToday['cnt']) : 0;
99		$mat_cnt = 0;
100	View Code Duplication	if (0 !== $count) {
101		$mat_cnt = 1;
102		$mat = "<table class='smallworldadmin'><tr>\n"
103		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_POS . "</td>\n"
104		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_IMG . "</td>\n"
105		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_AMOUNT . "</td>\n"
106		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_NAME . "</td></tr>\n";
107		$i = 1;
108		while ($i <= $count) {
109		$mat .= vsprintf('<tr><td>%s</td>', [$maToday['counter'][$i]]);
110		$mat .= vsprintf('<td>%s</td>', [$maToday['img'][$i]]);
111		$mat .= vsprintf('<td>%s</td>', [$maToday['cnt'][$i]]);
112		$mat .= vsprintf('<td>%s</td></tr>', [$maToday['from'][$i]]);
113		++$i;
114		}
115		$mat .= "</tr></table>\n";
116		} else {
117		$mat = 0;
118		}
119		// FInd list of best rated users overall
120		$topusers = $admin->topratedusers('up');
121		$count = !empty($topusers) ? count($topusers['cnt']) : 0;
122		$top_cnt = 0;
123	View Code Duplication	if (0 !== $count) {
124		$top_cnt = 1;
125		$top = "<table class='smallworldadmin'><tr>\n"
126		. " <td class='bold'>" . _AM_SMALLWORLD_STATS_POS . "</td>\n"
127		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_IMG . "</td>\n"
128		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_AMOUNT . "</td>\n"
129		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_NAME . "</td></tr>\n";
130		$i = 1;
131		while ($i <= $count) {
132		$top .= vsprintf('<tr><td>%s</td>', [$topusers['counter'][$i]]);
133		$top .= vsprintf('<td>%s</td>', [$topusers['img'][$i]]);
134		$top .= vsprintf('<td>%s</td>', [$topusers['cnt'][$i]]);
135		$top .= vsprintf('<td>%s</td></tr>', [$topusers['user'][$i]]);
136		++$i;
137		}
138		$top .= "</tr></table>\n";
139		} else {
140		$top = 0;
141		}
142
143		// FInd list of worst rated users overall
144		$lowusers = $admin->topratedusers('down');
145		$low_cnt = 0;
146		$count = !empty($lowusers) ? count($lowusers['cnt']) : 0;
147	View Code Duplication	if (0 !== $count) {
		0 ignored issues – show Duplication introduced 2020-12-04 14:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
148		$low_cnt = 1;
149		$low = "<table class='smallworldadmin'><tr>\n"
150		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_POS . "</td>\n"
151		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_IMG . "</td>\n"
152		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_AMOUNT . "</td>\n"
153		. "<td class='bold'>" . _AM_SMALLWORLD_STATS_NAME . "</td></tr>\n";
154		$i = 1;
155		while ($i <= $count) {
156		$low .= vsprintf('<tr><td>%s</td>', [$lowusers['counter'][$i]]);
157		$low .= vsprintf('<td>%s</td>', [$lowusers['img'][$i]]);
158		$low .= vsprintf('<td>%s</td>', [$lowusers['cnt'][$i]]);
159		$low .= vsprintf('<td>%s</td></tr>', [$lowusers['user'][$i]]);
160		++$i;
161		}
162		$low .= "</tr></table>\n";
163		} else {
164		$low = 0;
165		}
166
167		//-----------------------
168
169		// template assignments
170		$GLOBALS['xoopsTpl']->assign([
171		'lang_moduleinfo' => _AM_SMALLWORLD_MODULEINFO,
172		'lang_installversion' => _AM_SMALLWORLD_MODULEINSTALL,
173		'lang_installversion_status' => _AM_SMALLWORLD_UPDATE_STATUS,
174		'lang_installdate' => _AM_SMALLWORLD_INSTALLDATE
175		]);
176
177		//$GLOBALS['xoopsTpl']->assign('installversion', $installversion);
178		//$GLOBALS['xoopsTpl']->assign('installdate', $installdate);
179		//$GLOBALS['xoopsTpl']->assign('installversion_status',$installCheck);
180		//$GLOBALS['xoopsTpl']->display($helper->path('templates/admin_moduleinfo.tpl'));
181
182		//-----------------------
183
184		$adminObject->addInfoBox(_AM_SMALLWORLD_MODULEINFO);
185		$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . _AM_SMALLWORLD_MODULEINSTALL . ' : %s</br>', $installversion), '', 'Green', 'default');
186		$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . _AM_SMALLWORLD_INSTALLDATE . ': %s', $installdate), '', 'Green', 'default');
187		$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . '%s', $installCheck), '', 'Green', 'default');
188
189		$adminObject->addInfoBox(_AM_SMALLWORLD_USERSTATS);
190		$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . _AM_SMALLWORLD_DATEOFFIRSTMESSAGE . ' : %s</br>', $dateoffirstmessage), '', 'Green', 'default');
191		$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . _AM_SMALLWORLD_TOTALUSERS . ' : %s</br>', $sumallusers), '', 'Red', 'default');
192
193		if ($avgperday > 0) {
194		$adminObject->addInfoBoxLine(sprintf("<class='smallworldadmin'>" . _AM_SMALLWORLD_AVERAGEMSGPERDAY . ' : %s</br>', $avgperday), '', 'Red', 'default');
195		}
196
197		if (0 != $mat_cnt) {
198		$adminObject->addInfoBoxLine(sprintf("<p class='smallworldadmin'>" . _AM_SMALLWORLD_TOPCHATTERS_TODAY . ' : %s</p>', $mat), '', 'Red', 'default');
199		}
200		if (0 != $ma_cnt) {
201		$adminObject->addInfoBoxLine(sprintf("<p class='smallworldadmin'>" . _AM_SMALLWORLD_TOPCHATTERS . ' : %s</p>', $ma), '', 'Red', 'default');
202		}
203		if (0 != $top_cnt) {
204		$adminObject->addInfoBoxLine(sprintf("<p class='smallworldadmin'>" . _AM_SMALLWORLD_TOPRATEDUSERS . ' : %s</p>', $top), '', 'Red', 'default');
205		}
206		if (0 != $low_cnt) {
207		$adminObject->addInfoBoxLine(sprintf("<p class='smallworldadmin'>" . _AM_SMALLWORLD_BOTTOMRATEDUSERS . ' : %s</p>', $low), '', 'Red', 'default');
208		}
209
210		echo $adminObject->displayNavigation('index.php');
211		echo $adminObject->displayIndex();
212
213		echo Utility::getServerStats();
214
215		require_once __DIR__ . '/admin_footer.php';
216

XoopsModules25x / smallworld

Push — master ( fd0c8a...c024a6 )

admin/index.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like