XoopsModules25x /
smallworld
| Conditions | 19 |
| Paths | 194 |
| Total Lines | 90 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 62 | public static function truncateHtml($text, $length = 100, $ending = '...', $exact = false, $considerHtml = true) |
||
| 63 | { |
||
| 64 | if ($considerHtml) { |
||
| 65 | // if the plain text is shorter than the maximum length, return the whole text |
||
| 66 | if (mb_strlen(preg_replace('/<.*?' . '>/', '', $text)) <= $length) { |
||
| 67 | return $text; |
||
| 68 | } |
||
| 69 | // splits all html-tags to scanable lines |
||
| 70 | preg_match_all('/(<.+?' . '>)?([^<>]*)/s', $text, $lines, PREG_SET_ORDER); |
||
| 71 | $total_length = mb_strlen($ending); |
||
| 72 | $open_tags = []; |
||
| 73 | $truncate = ''; |
||
| 74 | foreach ($lines as $line_matchings) { |
||
|
|
|||
| 75 | // if there is any html-tag in this line, handle it and add it (uncounted) to the output |
||
| 76 | if (!empty($line_matchings[1])) { |
||
| 77 | // if it's an "empty element" with or without xhtml-conform closing slash |
||
| 78 | if (preg_match('/^<(\s*.+?\/\s*|\s*(img|br|input|hr|area|base|basefont|col|frame|isindex|link|meta|param)(\s.+?)?)>$/is', $line_matchings[1])) { |
||
| 79 | // do nothing |
||
| 80 | // if tag is a closing tag |
||
| 81 | } elseif (preg_match('/^<\s*\/([^\s]+?)\s*>$/s', $line_matchings[1], $tag_matchings)) { |
||
| 82 | // delete tag from $open_tags list |
||
| 83 | $pos = array_search($tag_matchings[1], $open_tags, true); |
||
| 84 | if (false !== $pos) { |
||
| 85 | unset($open_tags[$pos]); |
||
| 86 | } |
||
| 87 | // if tag is an opening tag |
||
| 88 | } elseif (preg_match('/^<\s*([^\s>!]+).*?' . '>$/s', $line_matchings[1], $tag_matchings)) { |
||
| 89 | // add tag to the beginning of $open_tags list |
||
| 90 | array_unshift($open_tags, mb_strtolower($tag_matchings[1])); |
||
| 91 | } |
||
| 92 | // add html-tag to $truncate'd text |
||
| 93 | $truncate .= $line_matchings[1]; |
||
| 94 | } |
||
| 95 | // calculate the length of the plain text part of the line; handle entities as one character |
||
| 96 | $content_length = mb_strlen(preg_replace('/&[0-9a-z]{2,8};|&#[0-9]{1,7};|[0-9a-f]{1,6};/i', ' ', $line_matchings[2])); |
||
| 97 | if ($total_length + $content_length > $length) { |
||
| 98 | // the number of characters which are left |
||
| 99 | $left = $length - $total_length; |
||
| 100 | $entities_length = 0; |
||
| 101 | // search for html entities |
||
| 102 | if (preg_match_all('/&[0-9a-z]{2,8};|&#[0-9]{1,7};|[0-9a-f]{1,6};/i', $line_matchings[2], $entities, PREG_OFFSET_CAPTURE)) { |
||
| 103 | // calculate the real length of all entities in the legal range |
||
| 104 | foreach ($entities[0] as $entity) { |
||
| 105 | if ($left >= $entity[1] + 1 - $entities_length) { |
||
| 106 | $left--; |
||
| 107 | $entities_length += mb_strlen($entity[0]); |
||
| 108 | } else { |
||
| 109 | // no more characters left |
||
| 110 | break; |
||
| 111 | } |
||
| 112 | } |
||
| 113 | } |
||
| 114 | $truncate .= mb_substr($line_matchings[2], 0, $left + $entities_length); |
||
| 115 | // maximum lenght is reached, so get off the loop |
||
| 116 | break; |
||
| 117 | } |
||
| 118 | $truncate .= $line_matchings[2]; |
||
| 119 | $total_length += $content_length; |
||
| 120 | |||
| 121 | // if the maximum length is reached, get off the loop |
||
| 122 | if ($total_length >= $length) { |
||
| 123 | break; |
||
| 124 | } |
||
| 125 | } |
||
| 126 | } else { |
||
| 127 | if (mb_strlen($text) <= $length) { |
||
| 128 | return $text; |
||
| 129 | } |
||
| 130 | $truncate = mb_substr($text, 0, $length - mb_strlen($ending)); |
||
| 131 | } |
||
| 132 | // if the words shouldn't be cut in the middle... |
||
| 133 | if (!$exact) { |
||
| 134 | // ...search the last occurance of a space... |
||
| 135 | $spacepos = mb_strrpos($truncate, ' '); |
||
| 136 | if (isset($spacepos)) { |
||
| 137 | // ...and cut the text in this position |
||
| 138 | $truncate = mb_substr($truncate, 0, $spacepos); |
||
| 139 | } |
||
| 140 | } |
||
| 141 | // add the defined ending to the text |
||
| 142 | $truncate .= $ending; |
||
| 143 | if ($considerHtml) { |
||
| 144 | // close all unclosed html-tags |
||
| 145 | foreach ($open_tags as $tag) { |
||
| 146 | $truncate .= '</' . $tag . '>'; |
||
| 147 | } |
||
| 148 | } |
||
| 149 | |||
| 150 | return $truncate; |
||
| 151 | } |
||
| 152 | |||
| 206 |
Loading history...
There are different options of fixing this problem.
If you want to be on the safe side, you can add an additional type-check:
If you are sure that the expression is traversable, you might want to add a doc comment cast to improve IDE auto-completion and static analysis:
Mark the issue as a false-positive: Just hover the remove button, in the top-right corner of this issue for more options.