XoopsModules\Smallworld\UploadHandler

Complexity

Total Complexity

198

Size/Duplication

Total Lines	916
Duplicated Lines	4.48 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

42 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	84	3
B	initialize()	0	22	8
B	get_full_url()	0	9	8
A	get_user_id()	0	5	1
A	get_user_path()	0	7	2
A	get_upload_path()	0	6	3
A	get_query_separator()	0	4	2
A	get_download_url()	0	12	4
A	set_file_delete_properties()	0	11	3
A	fix_integer_overflow()	0	7	2
A	get_file_size()	0	7	2
A	is_valid_file_object()	0	5	2
A	get_file_object()	0	19	5
A	get_file_objects()	0	8	2
A	count_file_objects()	0	4	1
C	create_scaled_image()	5	58	17
A	get_error_message()	0	4	2
A	get_config_bytes()	0	16	4
D	validate()	20	54	23
A	upcount_name_callback()	0	6	3
A	upcount_name()	0	4	1
A	get_unique_filename()	0	15	4
A	trim_file_name()	0	16	4
A	get_file_name()	0	4	1
A	handle_form_data()	0	4	1
B	orient_image()	0	32	7
D	handle_file_upload()	16	71	18
A	getFileExtension()	0	5	1
A	readfile()	0	4	1
A	body()	0	4	1
A	header()	0	4	1
B	generate_response()	0	20	10
A	get_version_param()	0	4	2
A	get_file_name_param()	0	4	2
A	get_file_type()	0	14	5
A	download()	0	27	5
A	send_content_type_header()	0	9	3
A	send_access_control_headers()	0	7	2
A	head()	0	12	2
A	get()	0	17	4
D	post()	0	34	19
B	delete()	0	25	7

<?php namespace XoopsModules\Smallworld;

/*
 * jQuery File Upload Plugin PHP Class 6.1.2
 * https://github.com/blueimp/jQuery-File-Upload
 *
 * Copyright 2010, Sebastian Tschan
 * https://blueimp.net
 *
 * Licensed under the MIT license:
 * http://www.opensource.org/licenses/MIT
 */

/**
 * Class UploadHandler
 */
class UploadHandler
{
    public    $xoopsUser;
    protected $options;

    // PHP File Upload error message codes:
    // http://php.net/manual/en/features.file-upload.errors.php
    protected $error_messages = [
        1                     => 'The uploaded file exceeds the upload_max_filesize directive in php.ini',
        2                     => 'The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form',
        3                     => 'The uploaded file was only partially uploaded',
        4                     => 'No file was uploaded',
        6                     => 'Missing a temporary folder',
        7                     => 'Failed to write file to disk',
        8                     => 'A PHP extension stopped the file upload',
        'post_max_size'       => 'The uploaded file exceeds the post_max_size directive in php.ini',
        'max_file_size'       => 'File is too big',
        'min_file_size'       => 'File is too small',
        'accept_file_types'   => 'Filetype not allowed',
        'max_number_of_files' => 'Maximum number of files exceeded',
        'max_width'           => 'Image exceeds maximum width',
        'min_width'           => 'Image requires a minimum width',
        'max_height'          => 'Image exceeds maximum height',
        'min_height'          => 'Image requires a minimum height',
    ];

    /**
     * UploadHandler constructor.
     * @param null $options
     * @param bool $initialize
     */
    public function __construct($options = null, $initialize = true)
    {
        global $xoopsUser;
        $userID        = $xoopsUser->getVar('uid');
        $this->options = [
            'script_url'                       => $this->get_full_url() . '/imgupload.php',
            'upload_dir'                       => XOOPS_ROOT_PATH . '/uploads/albums_smallworld/' . $userID . '/',
            'upload_url'                       => XOOPS_URL . '/uploads/albums_smallworld/' . $userID . '/',
            'user_dirs'                        => false,
            'mkdir_mode'                       => 0755,
            'param_name'                       => 'files',
            // Set the following option to 'POST', if your server does not support
            // DELETE requests. This is a parameter sent to the client:
            'delete_type'                      => 'DELETE',
            'access_control_allow_origin'      => '*',
            'access_control_allow_credentials' => false,
            'access_control_allow_methods'     => [
                'OPTIONS',
                'HEAD',
                'GET',
                'POST',
                'PUT',
                'PATCH',
                'DELETE',
            ],
            'access_control_allow_headers'     => [
                'Content-Type',
                'Content-Range',
                'Content-Disposition',
            ],
            // Enable to provide file downloads via GET requests to the PHP script:
            'download_via_php'                 => false,
            // Defines which files can be displayed inline when downloaded:
            'inline_file_types'                => '/\.(gif|jpe?g|png|JPE?G)$/i',
            // Defines which files (based on their names) are accepted for upload:
            'accept_file_types'                => '/.+$/i',
            // The php.ini settings upload_max_filesize and post_max_size
            // take precedence over the following max_file_size setting:
            'max_file_size'                    => null,
            'min_file_size'                    => 1,
            // The maximum number of files for the upload directory:
            'max_number_of_files'              => null,
            // Image resolution restrictions:
            'max_width'                        => null,
            'max_height'                       => null,
            'min_width'                        => 1,
            'min_height'                       => 1,
            // Set the following option to false to enable resumable uploads:
            'discard_aborted_uploads'          => true,
            // Set to true to rotate images based on EXIF meta data, if available:
            'orient_image'                     => false,
            'image_versions'                   => [
                // Uncomment the following version to restrict the size of
                // uploaded images:
                /*
                '' => array(
                    'max_width' => 1920,
                    'max_height' => 1200,
                    'jpeg_quality' => 95
                ),
                */
                // Uncomment the following to create medium sized images:
                /*
                'medium' => array(
                    'max_width' => 800,
                    'max_height' => 600,
                    'jpeg_quality' => 80
                ),
                */
                'thumbnails' => [
                    'upload_dir' => XOOPS_ROOT_PATH . '/uploads/albums_smallworld' . '/' . $userID . '/thumbnails/',
                    'upload_url' => XOOPS_URL . '/uploads/albums_smallworld' . '/' . $userID . '/thumbnails/',
                    'max_width'  => 80,
                    'max_height' => 80,
                ],
            ],
        ];
        if ($options) {
            $this->options = array_merge($this->options, $options);
        }
        if ($initialize) {
            $this->initialize();
        }
    }

    protected function initialize()
    {
        switch ($_SERVER['REQUEST_METHOD']) {
            case 'OPTIONS':
            case 'HEAD':
                $this->head();
                break;
            case 'GET':
                $this->get();
                break;
            case 'PATCH':
            case 'PUT':
            case 'POST':
                $this->post();
                break;
            case 'DELETE':
                $this->delete();
                break;
            default:
                $this->header('HTTP/1.1 405 Method Not Allowed');
        }
    }

    /**
     * @return string
     */
    protected function get_full_url()
    {
        $https = !empty($_SERVER['HTTPS']) && 'off' !== $_SERVER['HTTPS'];
        return ($https ? 'https://' : 'http://')
               . (!empty($_SERVER['REMOTE_USER']) ? $_SERVER['REMOTE_USER'] . '@' : '')
               . (isset($_SERVER['HTTP_HOST']) ? $_SERVER['HTTP_HOST'] : ($_SERVER['SERVER_NAME'] . ($https && 443 === $_SERVER['SERVER_PORT'] || 80 === $_SERVER['SERVER_PORT'] ? '' : ':'
                                                                                                                                                                                        . $_SERVER['SERVER_PORT'])))
               . substr($_SERVER['SCRIPT_NAME'], 0, strrpos($_SERVER['SCRIPT_NAME'], '/'));
    }

    /**
     * @return string
     */
    protected function get_user_id()
    {
        @session_start();

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        return session_id();
    }

    /**
     * @return string
     */
    protected function get_user_path()
    {
        if ($this->options['user_dirs']) {
            return $this->get_user_id() . '/';
        }
        return '';
    }

    /**
     * @param null|string $file_name
     * @param null        $version
     * @return string
     */
    protected function get_upload_path($file_name = null, $version = null)
    {
        $file_name    = $file_name ?: '';
        $version_path = empty($version) ? '' : $version . '/';
        return $this->options['upload_dir'] . $this->get_user_path() . $version_path . $file_name;
    }

    /**
     * @param $url
     * @return string
     */
    protected function get_query_separator($url)
    {
        return false === strpos($url, '?') ? '?' : '&';
    }

    /**
     * @param      $file_name
     * @param null $version
     * @return string
     */
    protected function get_download_url($file_name, $version = null)
    {
        if ($this->options['download_via_php']) {
            $url = $this->options['script_url'] . $this->get_query_separator($this->options['script_url']) . 'file=' . rawurlencode($file_name);
            if ($version) {
                $url .= '&version=' . rawurlencode($version);
            }
            return $url . '&download=1';
        }
        $version_path = empty($version) ? '' : rawurlencode($version) . '/';
        return $this->options['upload_url'] . $this->get_user_path() . $version_path . rawurlencode($file_name);
    }

    /**
     * @param $file
     */
    protected function set_file_delete_properties($file)
    {
        $file->delete_url  = $this->options['script_url'] . $this->get_query_separator($this->options['script_url']) . 'file=' . rawurlencode($file->name);
        $file->delete_type = $this->options['delete_type'];
        if ('DELETE' !== $file->delete_type) {
            $file->delete_url .= '&_method=DELETE';
        }
        if ($this->options['access_control_allow_credentials']) {
            $file->delete_with_credentials = true;
        }
    }

    // Fix for overflowing signed 32 bit integers,
    // works for sizes up to 2^32-1 bytes (4 GiB - 1):
    /**
     * @param $size
     * @return float|int
     */
    protected function fix_integer_overflow($size)
    {
        if ($size < 0) {
            $size += 2.0 * (PHP_INT_MAX + 1);
        }
        return $size;
    }

    /**
     * @param      $file_path
     * @param bool $clear_stat_cache
     * @return float|int
     */
    protected function get_file_size($file_path, $clear_stat_cache = false)
    {
        if ($clear_stat_cache) {
            clearstatcache(true, $file_path);
        }
        return $this->fix_integer_overflow(filesize($file_path));
    }

    /**
     * @param $file_name
     * @return bool
     */
    protected function is_valid_file_object($file_name)
    {
        $file_path = $this->get_upload_path($file_name);
        return is_file($file_path) && '.' !== $file_name[0];
    }

    /**
     * @param $file_name
     * @return null|\stdClass
     */
    protected function get_file_object($file_name)
    {
        if ($this->is_valid_file_object($file_name)) {
            $file       = new \stdClass();
            $file->name = $file_name;
            $file->size = $this->get_file_size($this->get_upload_path($file_name));
            $file->url  = $this->get_download_url($file->name);
            foreach ($this->options['image_versions'] as $version => $options) {

The expression $this->options['image_versions'] of type string|integer|array<integer,string,{"0":"string","1":"string","2":"string"}>|null|boolean|array<string,array<string,string|integer,{"upload_dir":"string","upload_url":"string","max_width":"integer","max_height":"integer"}>,{"thumbnails":"array<string,string|integer,{\"upload_dir\":\"string\",\"upload_url\":\"string\",\"max_width\":\"integer\",\"max_height\":\"integer\"}>"}> is not guaranteed to be traversable. How about adding an additional type check?

                if (!empty($version)) {
                    if (is_file($this->get_upload_path($file_name, $version))) {
                        $file->{$version . '_url'} = $this->get_download_url($file->name, $version);
                    }
                }
            }
            $this->set_file_delete_properties($file);
            return $file;
        }
        return null;
    }

    /**
     * @param string $iteration_method
     * @return array
     */
    protected function get_file_objects($iteration_method = 'get_file_object')
    {
        $upload_dir = $this->get_upload_path();
        if (!is_dir($upload_dir)) {
            return [];
        }
        return array_values(array_filter(array_map([$this, $iteration_method], scandir($upload_dir, SCANDIR_SORT_NONE))));
    }

    /**
     * @return int
     */
    protected function count_file_objects()
    {
        return count($this->get_file_objects('is_valid_file_object'));
    }

    /**
     * @param $file_name
     * @param $version
     * @param $options
     * @return bool
     */
    protected function create_scaled_image($file_name, $version, $options)
    {
        $file_path = $this->get_upload_path($file_name);
        if (!empty($version)) {
            $version_dir = $this->get_upload_path(null, $version);
            if (!is_dir($version_dir)) {

This code seems to be duplicated across your project.

                if (!mkdir($version_dir, $this->options['mkdir_mode'], true) && !is_dir($version_dir)) {
                    throw new \RuntimeException(sprintf('Directory "%s" was not created', $version_dir));
                }
            }
            $new_file_path = $version_dir . '/' . $file_name;
        } else {
            $new_file_path = $file_path;
        }
        list($img_width, $img_height) = @getimagesize($file_path);
        if (!$img_width || !$img_height) {
            return false;
        }
        $scale = min($options['max_width'] / $img_width, $options['max_height'] / $img_height);
        if ($scale >= 1) {
            if ($file_path !== $new_file_path) {
                return copy($file_path, $new_file_path);
            }
            return true;
        }
        $new_width  = $img_width * $scale;
        $new_height = $img_height * $scale;
        $new_img    = @imagecreatetruecolor($new_width, $new_height);
        switch (strtolower(substr(strrchr($file_name, '.'), 1))) {
            case 'jpg':
            case 'jpeg':
                $src_img       = @imagecreatefromjpeg($file_path);
                $write_image   = 'imagejpeg';
                $image_quality = isset($options['jpeg_quality']) ? $options['jpeg_quality'] : 75;
                break;
            case 'gif':
                @imagecolortransparent($new_img, @imagecolorallocate($new_img, 0, 0, 0));

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                $src_img       = @imagecreatefromgif($file_path);
                $write_image   = 'imagegif';
                $image_quality = null;
                break;
            case 'png':
                @imagecolortransparent($new_img, @imagecolorallocate($new_img, 0, 0, 0));

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                @imagealphablending($new_img, false);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                @imagesavealpha($new_img, true);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                $src_img       = @imagecreatefrompng($file_path);
                $write_image   = 'imagepng';
                $image_quality = isset($options['png_quality']) ? $options['png_quality'] : 9;
                break;
            default:
                $src_img = null;
        }
        $success = $src_img && @imagecopyresampled($new_img, $src_img, 0, 0, 0, 0, $new_width, $new_height, $img_width, $img_height) && $write_image($new_img, $new_file_path, $image_quality);

The variable $write_image does not seem to be defined for all execution paths leading up to this point.

The variable $image_quality does not seem to be defined for all execution paths leading up to this point.

        // Free up memory (imagedestroy does not delete files):
        @imagedestroy($src_img);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        @imagedestroy($new_img);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        return $success;
    }

    /**
     * @param $error
     * @return mixed
     */
    protected function get_error_message($error)
    {
        return array_key_exists($error, $this->error_messages) ? $this->error_messages[$error] : $error;
    }

    /**
     * @param $val
     * @return float|int
     */
    public function get_config_bytes($val)
    {
        $val  = trim($val);
        $last = strtolower($val[strlen($val) - 1]);
        switch ($last) {
            case 'g':
                $val *= 1024;
            // no break
            case 'm':
                $val *= 1024;
            // no break
            case 'k':
                $val *= 1024;
        }
        return $this->fix_integer_overflow($val);
    }

    /**
     * @param $uploaded_file
     * @param $file
     * @param $error
     * @param $index
     * @return bool
     */
    protected function validate($uploaded_file, $file, $error, $index)

The parameter $index is not used and could be removed.

    {
        if ($error) {
            $file->error = $this->get_error_message($error);
            return false;
        }
        $content_length = $this->fix_integer_overflow((int)$_SERVER['CONTENT_LENGTH']);
        $post_max_size  = $this->get_config_bytes(ini_get('post_max_size'));
        if ($post_max_size && ($content_length > $post_max_size)) {
            $file->error = $this->get_error_message('post_max_size');
            return false;
        }
        if (!preg_match($this->options['accept_file_types'], $file->name)) {
            $file->error = $this->get_error_message('accept_file_types');
            return false;
        }
        if ($uploaded_file && is_uploaded_file($uploaded_file)) {
            $file_size = $this->get_file_size($uploaded_file);
        } else {
            $file_size = $content_length;
        }
        if ($this->options['max_file_size'] && ($file_size > $this->options['max_file_size'] || $file->size > $this->options['max_file_size'])) {
            $file->error = $this->get_error_message('max_file_size');
            return false;
        }
        if ($this->options['min_file_size'] && $file_size < $this->options['min_file_size']) {
            $file->error = $this->get_error_message('min_file_size');
            return false;
        }
        if (is_int($this->options['max_number_of_files']) && ($this->count_file_objects() >= $this->options['max_number_of_files'])) {
            $file->error = $this->get_error_message('max_number_of_files');
            return false;
        }
        list($img_width, $img_height) = @getimagesize($uploaded_file);
        if (is_int($img_width)) {
            if ($this->options['max_width'] && $img_width > $this->options['max_width']) {

This code seems to be duplicated across your project.

                $file->error = $this->get_error_message('max_width');
                return false;
            }
            if ($this->options['max_height'] && $img_height > $this->options['max_height']) {

This code seems to be duplicated across your project.

                $file->error = $this->get_error_message('max_height');
                return false;
            }
            if ($this->options['min_width'] && $img_width < $this->options['min_width']) {

This code seems to be duplicated across your project.

                $file->error = $this->get_error_message('min_width');
                return false;
            }
            if ($this->options['min_height'] && $img_height < $this->options['min_height']) {

This code seems to be duplicated across your project.

                $file->error = $this->get_error_message('min_height');
                return false;
            }
        }
        return true;
    }

    /**
     * @param $matches
     * @return string
     */
    protected function upcount_name_callback($matches)
    {
        $index = isset($matches[1]) ? (int)$matches[1] + 1 : 1;
        $ext   = isset($matches[2]) ? $matches[2] : '';
        return ' (' . $index . ')' . $ext;
    }

    /**
     * @param $name
     * @return null|string|string[]
     */
    protected function upcount_name($name)
    {
        return preg_replace_callback('/(?:(?: \(([\d]+)\))?(\.[^.]+))?$/', [$this, 'upcount_name_callback'], $name, 1);
    }

    /**
     * @param $name
     * @param $type
     * @param $index
     * @param $content_range
     * @return null|string|string[]
     */
    protected function get_unique_filename($name, $type, $index, $content_range)

The parameter $type is not used and could be removed.

The parameter $index is not used and could be removed.

    {
        while (is_dir($this->get_upload_path($name))) {
            $name = $this->upcount_name($name);
        }
        // Keep an existing filename if this is part of a chunked upload:
        $uploaded_bytes = $this->fix_integer_overflow((int)$content_range[1]);
        while (is_file($this->get_upload_path($name))) {
            if ($uploaded_bytes === $this->get_file_size($this->get_upload_path($name))) {
                break;
            }
            $name = $this->upcount_name($name);
        }
        return $name;
    }

    /**
     * @param $name
     * @param $type
     * @param $index
     * @param $content_range
     * @return mixed|string
     */
    protected function trim_file_name($name, $type, $index, $content_range)

The parameter $index is not used and could be removed.

The parameter $content_range is not used and could be removed.

    {
        // Remove path information and dots around the filename, to prevent uploading
        // into different directories or replacing hidden system files.
        // Also remove control characters and spaces (\x00..\x20) around the filename:
        $name = trim(basename(stripslashes($name)), ".\x00..\x20");
        // Use a timestamp for empty filenames:
        if (!$name) {
            $name = str_replace('.', '-', microtime(true));
        }
        // Add missing file extension for known image types:
        if (false === strpos($name, '.') && preg_match('/^image\/(gif|jpe?g|png)/', $type, $matches)) {
            $name .= '.' . $matches[1];
        }
        return $name;
    }

    /**
     * @param $name
     * @param $type
     * @param $index
     * @param $content_range
     * @return null|string|string[]
     */
    protected function get_file_name($name, $type, $index, $content_range)
    {
        return $this->get_unique_filename($this->trim_file_name($name, $type, $index, $content_range), $type, $index, $content_range);
    }

    /**
     * @param $file
     * @param $index
     */
    protected function handle_form_data($file, $index)

The parameter $file is not used and could be removed.

The parameter $index is not used and could be removed.

    {
        // Handle form data, e.g. $_REQUEST['description'][$index]
    }

    /**
     * @param $file_path
     * @return bool
     */
    protected function orient_image($file_path)
    {
        if (!function_exists('exif_read_data')) {
            return false;
        }
        $exif = @exif_read_data($file_path);
        if (false === $exif) {
            return false;
        }
        $orientation = (int)(@$exif['Orientation']);
        if (!in_array($orientation, [3, 6, 8])) {
            return false;
        }
        $image = @imagecreatefromjpeg($file_path);
        switch ($orientation) {
            case 3:
                $image = @imagerotate($image, 180, 0);
                break;
            case 6:
                $image = @imagerotate($image, 270, 0);
                break;
            case 8:
                $image = @imagerotate($image, 90, 0);
                break;
            default:
                return false;
        }
        $success = imagejpeg($image, $file_path);
        // Free up memory (imagedestroy does not delete files):
        @imagedestroy($image);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        return $success;
    }

    /**
     * @param      $uploaded_file
     * @param      $name
     * @param      $size
     * @param      $type
     * @param      $error
     * @param null $index
     * @param null $content_range
     * @return \XoopsModules\Smallworld|\stdClass
     */
    protected function handle_file_upload(
        $uploaded_file,
        $name,
        $size,
        $type,
        $error,
        $index = null,
        $content_range = null
    ) {
        global $xoopsUser, $SwDatabase;
        $file = new \stdClass();

        $file->name = $this->get_file_name($name, $type, $index, $content_range);
        $file->size = $this->fix_integer_overflow((int)$size);
        $file->type = $type;

        // Save to database for later use
        $db     = new SwDatabase();
        $userid = $xoopsUser->getVar('uid');

        // Generate new name for file
        $file->name = basename(stripslashes($name));
        $file->name = time() . mt_rand(0, 99999) . '.' . $this->getFileExtension($name);
        $img        = XOOPS_URL . '/uploads/albums_smallworld/' . $userid . '/' . $file->name;
        $db->saveImage("'', '" . $userid . "', '" . $file->name . "', '" . addslashes($img) . "', '" . time() . "', ''");

        if ($this->validate($uploaded_file, $file, $error, $index)) {
            $this->handle_form_data($file, $index);
            $upload_dir = $this->get_upload_path();
            if (!is_dir($upload_dir)) {

This code seems to be duplicated across your project.

                if (!mkdir($upload_dir, $this->options['mkdir_mode'], true) && !is_dir($upload_dir)) {
                    throw new \RuntimeException(sprintf('Directory "%s" was not created', $upload_dir));
                }
            }
            $file_path   = $this->get_upload_path($file->name);
            $append_file = $content_range && is_file($file_path) && $file->size > $this->get_file_size($file_path);
            if ($uploaded_file && is_uploaded_file($uploaded_file)) {

This code seems to be duplicated across your project.

                // multipart/formdata uploads (POST method uploads)
                if ($append_file) {
                    file_put_contents($file_path, fopen($uploaded_file, 'r'), FILE_APPEND);
                } else {
                    move_uploaded_file($uploaded_file, $file_path);
                }
            } else {
                // Non-multipart uploads (PUT method support)
                file_put_contents($file_path, fopen('php://input', 'r'), $append_file ? FILE_APPEND : 0);
            }
            $file_size = $this->get_file_size($file_path, $append_file);
            if ($file_size === $file->size) {
                if ($this->options['orient_image']) {
                    $this->orient_image($file_path);
                }
                $file->url = $this->get_download_url($file->name);
                foreach ($this->options['image_versions'] as $version => $options) {

The expression $this->options['image_versions'] of type string|integer|array<integer,string,{"0":"string","1":"string","2":"string"}>|null|boolean|array<string,array<string,string|integer,{"upload_dir":"string","upload_url":"string","max_width":"integer","max_height":"integer"}>,{"thumbnails":"array<string,string|integer,{\"upload_dir\":\"string\",\"upload_url\":\"string\",\"max_width\":\"integer\",\"max_height\":\"integer\"}>"}> is not guaranteed to be traversable. How about adding an additional type check?

                    if ($this->create_scaled_image($file->name, $version, $options)) {
                        if (!empty($version)) {
                            $file->{$version . '_url'} = $this->get_download_url($file->name, $version);
                        } else {
                            $file_size = $this->get_file_size($file_path, true);
                        }
                    }
                }
            } elseif (!$content_range && $this->options['discard_aborted_uploads']) {
                unlink($file_path);
                $file->error = 'abort';
            }
            $file->size = $file_size;
            $this->set_file_delete_properties($file);
        }
        return $file;
    }

    //function to return file extension from a path or file name

    /**
     * @param $path
     * @return mixed
     */
    public function getFileExtension($path)
    {
        $parts = pathinfo($path);
        return $parts['extension'];
    }

    /**
     * @param $file_path
     * @return false|int
     */
    protected function readfile($file_path)
    {
        return readfile($file_path);
    }

    /**
     * @param $str
     */
    protected function body($str)
    {
        echo $str;
    }

    /**
     * @param $str
     */
    protected function header($str)
    {
        header($str);
    }

    /**
     * @param      $content
     * @param bool $print_response
     */
    protected function generate_response($content, $print_response = true)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if ($print_response) {
            $json     = json_encode($content);
            $redirect = isset($_REQUEST['redirect']) ? stripslashes($_REQUEST['redirect']) : null;
            if ($redirect) {

The expression $redirect of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

                $this->header('Location: ' . sprintf($redirect, rawurlencode($json)));
                return;
            }
            $this->head();
            if (isset($_SERVER['HTTP_CONTENT_RANGE'])) {
                $files = isset($content[$this->options['param_name']]) ? $content[$this->options['param_name']] : null;
                if ($files && is_array($files) && is_object($files[0]) && $files[0]->size) {
                    $this->header('Range: 0-' . ($this->fix_integer_overflow((int)$files[0]->size) - 1));
                }
            }
            $this->body($json);
        }
        return $content;
    }

    /**
     * @return null|string
     */
    protected function get_version_param()
    {
        return isset($_GET['version']) ? basename(stripslashes($_GET['version'])) : null;
    }

    /**
     * @return null|string
     */
    protected function get_file_name_param()
    {
        return isset($_GET['file']) ? basename(stripslashes($_GET['file'])) : null;
    }

    /**
     * @param $file_path
     * @return string
     */
    protected function get_file_type($file_path)
    {
        switch (strtolower(pathinfo($file_path, PATHINFO_EXTENSION))) {
            case 'jpeg':
            case 'jpg':
                return 'image/jpeg';
            case 'png':
                return 'image/png';
            case 'gif':
                return 'image/gif';
            default:
                return '';
        }
    }

    protected function download()
    {
        if (!$this->options['download_via_php']) {
            $this->header('HTTP/1.1 403 Forbidden');
            return;
        }
        $file_name = $this->get_file_name_param();
        if ($this->is_valid_file_object($file_name)) {
            $file_path = $this->get_upload_path($file_name, $this->get_version_param());

It seems like $this->get_version_param() targeting XoopsModules\Smallworld\UploadHandler::get_version_param() can also be of type string; however, XoopsModules\Smallworld\UploadHandler::get_upload_path() does only seem to accept null, maybe add an additional type check?

            if (is_file($file_path)) {
                if (!preg_match($this->options['inline_file_types'], $file_name)) {
                    $this->header('Content-Description: File Transfer');
                    $this->header('Content-Type: application/octet-stream');
                    $this->header('Content-Disposition: attachment; filename="' . $file_name . '"');
                    $this->header('Content-Transfer-Encoding: binary');
                } else {
                    // Prevent Internet Explorer from MIME-sniffing the content-type:
                    $this->header('X-Content-Type-Options: nosniff');
                    $this->header('Content-Type: ' . $this->get_file_type($file_path));
                    $this->header('Content-Disposition: inline; filename="' . $file_name . '"');
                }
                $this->header('Content-Length: ' . $this->get_file_size($file_path));
                $this->header('Last-Modified: ' . gmdate('D, d M Y H:i:s T', filemtime($file_path)));
                $this->readfile($file_path);
            }
        }
    }

    protected function send_content_type_header()
    {
        $this->header('Vary: Accept');
        if (isset($_SERVER['HTTP_ACCEPT']) && (false !== strpos($_SERVER['HTTP_ACCEPT'], 'application/json'))) {
            $this->header('Content-type: application/json');
        } else {
            $this->header('Content-type: text/plain');
        }
    }

    protected function send_access_control_headers()
    {
        $this->header('Access-Control-Allow-Origin: ' . $this->options['access_control_allow_origin']);
        $this->header('Access-Control-Allow-Credentials: ' . ($this->options['access_control_allow_credentials'] ? 'true' : 'false'));
        $this->header('Access-Control-Allow-Methods: ' . implode(', ', $this->options['access_control_allow_methods']));
        $this->header('Access-Control-Allow-Headers: ' . implode(', ', $this->options['access_control_allow_headers']));
    }

    public function head()
    {
        $this->header('Pragma: no-cache');
        $this->header('Cache-Control: no-store, no-cache, must-revalidate');
        $this->header('Content-Disposition: inline; filename="files.json"');
        // Prevent Internet Explorer from MIME-sniffing the content-type:
        $this->header('X-Content-Type-Options: nosniff');
        if ($this->options['access_control_allow_origin']) {
            $this->send_access_control_headers();
        }
        $this->send_content_type_header();
    }

    /**
     * @param bool $print_response
     */
    public function get($print_response = true)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if ($print_response && isset($_GET['download'])) {
            return $this->download();
        }
        $file_name = $this->get_file_name_param();
        if (null !== $file_name) {
            $response = [
                substr($this->options['param_name'], 0, -1) => $this->get_file_object($file_name),
            ];
        } else {
            $response = [
                $this->options['param_name'] => $this->get_file_objects(),
            ];
        }
        return $this->generate_response($response, $print_response);
    }

    /**
     * @param bool $print_response
     */
    public function post($print_response = true)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if (isset($_REQUEST['_method']) && 'DELETE' === $_REQUEST['_method']) {
            return $this->delete($print_response);
        }
        $upload = isset($_FILES[$this->options['param_name']]) ? $_FILES[$this->options['param_name']] : null;
        // Parse the Content-Disposition header, if available:
        $file_name = isset($_SERVER['HTTP_CONTENT_DISPOSITION']) ? rawurldecode(preg_replace('/(^[^"]+")|("$)/', '', $_SERVER['HTTP_CONTENT_DISPOSITION'])) : null;
        // Parse the Content-Range header, which has the following form:
        // Content-Range: bytes 0-524287/2000000
        $content_range = isset($_SERVER['HTTP_CONTENT_RANGE']) ? preg_split('/[^0-9]+/', $_SERVER['HTTP_CONTENT_RANGE']) : null;
        $size          = $content_range ? $content_range[3] : null;
        $files         = [];
        if ($upload && is_array($upload['tmp_name'])) {
            // param_name is an array identifier like "files[]",
            // $_FILES is a multi-dimensional array:
            foreach ($upload['tmp_name'] as $index => $value) {
                $files[] = $this->handle_file_upload($upload['tmp_name'][$index], $file_name ?: $upload['name'][$index], $size ?: $upload['size'][$index], $upload['type'][$index], $upload['error'][$index], $index, $content_range);

It seems like $content_range defined by isset($_SERVER['HTTP_CONTENT_RANGE']) ? preg_split('/[^0-9]+/', $_SERVER['HTTP_CONTENT_RANGE']) : null on line 879 can also be of type array; however, XoopsModules\Smallworld\UploadHandler::handle_file_upload() does only seem to accept null, maybe add an additional type check?

            }
        } else {
            // param_name is a single object identifier like "file",
            // $_FILES is a one-dimensional array:
            $files[] = $this->handle_file_upload(
                isset($upload['tmp_name']) ? $upload['tmp_name'] : null,
                $file_name ?: (isset($upload['name']) ? $upload['name'] : null),
                $size ?: (isset($upload['size']) ? $upload['size'] : $_SERVER['CONTENT_LENGTH']),
                isset($upload['type']) ? $upload['type'] : $_SERVER['CONTENT_TYPE'],
                isset($upload['error']) ? $upload['error'] : null,
                null,
                $content_range

It seems like $content_range defined by isset($_SERVER['HTTP_CONTENT_RANGE']) ? preg_split('/[^0-9]+/', $_SERVER['HTTP_CONTENT_RANGE']) : null on line 879 can also be of type array; however, XoopsModules\Smallworld\UploadHandler::handle_file_upload() does only seem to accept null, maybe add an additional type check?

            );
        }
        return $this->generate_response([$this->options['param_name'] => $files], $print_response);
    }

    /**
     * @param bool $print_response
     */
    public function delete($print_response = true)

The return type could not be reliably inferred; please add a @return annotation.

    {
        global $xoopsUser;
        $userid    = $xoopsUser->getVar('uid');
        $db        = new SwDatabase();
        $file_name = $this->get_file_name_param();
        $file_path = $this->get_upload_path($file_name);
        $success   = is_file($file_path) && '.' !== $file_name[0] && unlink($file_path);

        // Delete file based on user and filename
        $db->DeleteImage($userid, $file_name);
        $db->DeleteImage($userid, 'Thumbs.db');

        if ($success) {
            foreach ($this->options['image_versions'] as $version => $options) {

The expression $this->options['image_versions'] of type string|integer|array<integer,string,{"0":"string","1":"string","2":"string"}>|null|boolean|array<string,array<string,string|integer,{"upload_dir":"string","upload_url":"string","max_width":"integer","max_height":"integer"}>,{"thumbnails":"array<string,string|integer,{\"upload_dir\":\"string\",\"upload_url\":\"string\",\"max_width\":\"integer\",\"max_height\":\"integer\"}>"}> is not guaranteed to be traversable. How about adding an additional type check?

                if (!empty($version)) {
                    $file = $this->get_upload_path($file_name, $version);
                    if (is_file($file)) {
                        unlink($file);
                    }
                }
            }
        }
        return $this->generate_response(['success' => $success], $print_response);
    }
}