Form - Code Metrics - Inspection of "namespaces, PHP7" - XoopsModules25x/smallworld - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Michael

created 2020-03-30 08:38 UTC

Form A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	318
Duplicated Lines	6.29 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	20
loc	318
rs	9.44
c	0
b	0
f	0
wmc	37
lcom	0
cbo	0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	dropdown()	4	11	3
A	radio()	0	10	3
A	RetrieveRadio()	0	13	3
A	input()	0	6	2
A	hidden()	0	5	1
A	simpleText()	0	5	1
A	dropdown_add()	4	11	3
A	input_add()	0	7	3
A	textarea()	0	4	1
B	school_add()	12	37	7
A	job()	0	20	1
A	uploadform()	0	9	1
A	edit_images()	0	12	1
B	usersettings()	0	32	7

How to fix Duplicated Code

<?php namespace XoopsModules\Smallworld;

/**
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * SmallWorld
 *
 * @copyright    The XOOPS Project (https://xoops.org)
 * @copyright    2011 Culex
 * @license      GNU GPL (http://www.gnu.org/licenses/gpl-2.0.html/)
 * @package      SmallWorld
 * @since        1.0
 * @author       Michael Albertsen (http://culex.dk) <[email protected]>
 */
class Form
{
    /**
     * @create a dropdown select
     * @param string $name
     * @param array  $options
     * @param string $selected (optional)

     * @return string
     */
    public function dropdown($name, array $options, $selected = null)
    {
        $dropdown = '<select name="' . $name . '" id="' . $name . '">' . '<br>';
        $selected = $selected;

        foreach ($options as $key => $option) {

            $select   = $selected == $key ? ' selected="yes"' : '';
            $dropdown .= '<option value="' . $key . '"' . $select . '>' . $option . '</option>' . '<br>';
        }
        $dropdown .= '</select>' . '<br>';
        return $dropdown;
    }

    /**
     * @create a radio select
     * @param string $name
     * @param array  $options
     * @param string $selected (optional)

     * @return string
     */
    public function radio($name, array $options, $selected = null)
    {
        $selected = $selected;

        $form     = '';
        foreach ($options as $value => $option) {
            $select = $selected == $value ? ' checked' : ' checked="unchecked"';
            $form   .= '<input type="checkbox" name="' . $name . '[]" id="' . $name . '" value="' . $value . '" ' . $select . '> ' . $option . '<br>';
        }
        return $form;
    }

    /**
     * @param string $name
     * @param array  $options
     * @param array  $valuearray
     * @param string $selected (optional)

     * @return string
     */
    public function RetrieveRadio($name, $options, $valuearray, $selected = null)

    {
        $form = '';
        $a    = count($options) - 1;
        for ($i = 0; $i <= $a; ++$i) {
            if (in_array($i, $valuearray)) {
                $form .= '<input type="checkbox" id="' . $name . '-' . $i . '" name="' . $name . '[]" value="' . $i . '" checked>' . $options[$i] . '<br>';
            } else {
                $form .= '<input type="checkbox" id="' . $name . '-' . $i . '" name="' . $name . '[]" value="' . $i . '" >' . $options[$i] . '<br>';
            }
        }
        return $form;
    }

    /**
     * @param string $name
     * @param string $id
     * @param string $class
     * @param int    $size   (optional)

     * @param string $preset (optional)

     * @return string
     */
    public function input($name, $id, $class, $size = null, $preset = null)
    {
        $s    = $size ?: '50px';
        $data = "<input type='text' size='" . $s . "' name='" . $name . "' id='" . $id . "' class='" . $class . "' value='" . $preset . "' >";
        return $data;
    }

    /**
     * @param string $name
     * @param string $id
     * @param string $preset (optional)

     * @return string
     */
    public function hidden($name, $id, $preset = null)

    {
        $data = "<input type='hidden' name='" . $name . "' value='" . $preset . "' >";
        return $data;
    }

    /**
     * @param string $value
     * @return string
     */
    public function simpleText($value)
    {
        $data = $value;
        return $data;
    }

    /**
     *
     * @param string  $class
     * @param string  $name
     * @param         $name2
     * @param string  $rel
     * @param array   $options
     * @param string  $textmore
     * @param string  $selected (optional)

     * @param string  $preset   (optional)

     * @return as|string
     */
    public function dropdown_add($class, $name, $name2, $rel, array $options, $textmore, $selected = null, $preset = null)

    {
        $dropdown = '<span id="' . $name . '"><input type="text" name="' . $name2 . '[]" value="' . $preset . '">';
        $dropdown .= '<select class="smallworld_select" name="' . $name . '[]" id="' . $name . '"></p>' . '<br>';
        foreach ($options as $key => $option) {

            $select   = $selected == $key ? ' selected' : null;
            $dropdown .= '<option value="' . $key . '"' . $select . '>' . $option . '</option>' . '<br>';
        }
        $dropdown .= '</select></span>';
        return $dropdown;
    }

    /**
     *
     * @param string  $class
     * @param string  $name
     * @param         $name2
     * @param string  $rel
     * @param int     $size
     * @param string  $textmore
     * @param string  $preset (optional)

     * @param string  $id     (optional)

     * @return dynamic|string
     */
    public function input_add($class, $name, $name2, $rel, $size, $textmore, $preset = null, $id = null)

    {
        $s    = $size ?: '50px';
        $i    = $id ?: '';
        $data = "<span id='" . $name . "'><input type='text' size='" . $s . "' name='" . $name2 . "[]' value='" . $preset . "' id='" . $i . "'></span>";
        return $data;
    }

    /**
     * @param string $name
     * @param string $id
     * @param string $title
     * @param string $rows
     * @param string $cols
     * @param string $class
     * @param string $preset (optional)

     * @return string|textarea
     * @return string
     */
    public function textarea($name, $id, $title, $rows, $cols, $class, $preset = null)
    {
        return "<textarea name='" . $name . "' id='" . $id . "'  title='" . $title . "' rows='" . $rows . "' cols='" . $cols . "' class='" . $class . "'>" . $preset . '</textarea>';
    }

    /**
     * @param string $class
     * @param string $name
     * @param string $name2
     * @param string $rel
     * @param array  $options
     * @param string $textmore
     * @param string $selected      (optional)

     * @param string $preset        (optional)

     * @param string $selectedstart (optional)

     * @param string $selectedstop  (optional)

     * @return dynamic|string
     * @return string
     */
    public function school_add(
        $class,

        $name,
        $name2,
        $rel,

        array $options,
        $textmore,

        $selected = null,
        $preset = null,
        $selectedstart = null,
        $selectedstop = null
    ) {
        $dropdown = '<div id="' . $name . '"><p class="smallworld_clonebreaker">' . _SMALLWORLD_SCHOOLNAME . '<input class="school" type="text" value="' . $preset . '" name="' . $name2 . '[]">';
        $dropdown .= '<br><br>' . _SMALLWORLD_SCHOOLTYPE . '<select class="school" name="' . $name . '[]" id="' . $name . '"">' . '<br>';
        foreach ($options as $key => $option) {

            $select   = $selected == $key ? ' selected="selected"' : null;
            $dropdown .= '<option  class="school" value="' . $key . '"' . $select . '>' . $option . '</option>' . '<br>';
        }
        $dropdown .= '</select>';
        $dropdown .= '<br><br>';
        $dropdown .= _SMALLWORLD_START . '<select class="schooltime" name="schoolstart[]" id="schoolstart">';
        $array    = SmallworldGetTimestampsToForm();
        foreach ($array as $key => $option) {

            $selectstart = $selectedstart == $key ? ' selected="selected"' : null;
            $dropdown    .= '<option value="' . $key . '"' . $selectstart . '>' . $option . '</option>' . '<br>';
        }
        $dropdown .= '</select>';
        $dropdown .= '<br><br>';
        $dropdown .= _SMALLWORLD_STOP . '<select class="schooltime" name="schoolstop[]" id="schoolstop">';
        $array    = SmallworldGetTimestampsToForm();
        foreach ($array as $key => $option) {

            $selectstop = $selectedstop == $key ? ' selected="selected"' : null;
            $dropdown   .= '<option value="' . $key . '"' . $selectstop . '>' . $option . '</option>' . '<br>';
        }
        $dropdown .= '</select><br></p></div>';
        return $dropdown;
    }

    /**
     *
     * @param string  $class
     * @param string  $name
     * @param         $name2
     * @param string  $rel
     * @param string  $textmore
     * @param string  $employer      (optional)

     * @param string  $position      (optional)

     * @param string  $selectedstart (optional)

     * @param string  $selectedstop  (optional)

     * @param string  $description   (optional)

     * @return dynamic|string
     */
    public function job(
        $class,

        $name,
        $name2,

        $rel,

        $textmore,

        $employer = null,
        $position = null,
        $selectedstart = null,
        $selectedstop = null,
        $description = null
    ) {
        $text = '<div id="' . $name . '"><p class="smallworld_clonebreaker">' . _SMALLWORLD_EMPLOYER . '<input class="job" id="job" value="' . $employer . '" type="text" name="employer[]">';
        $text .= '<br><br>' . _SMALLWORLD_POSITION . '<input class="job" type="text" value="' . $position . '" name="position[]">';
        $text .= '<br><br>' . _SMALLWORLD_JOBSTART . '<input class="jobstart" type="text" value="' . $selectedstart . '" name="jobstart[]">';
        $text .= '<br><br>' . _SMALLWORLD_JOBSTOP . '<input class="jobstop" value="' . $selectedstop . '" type="text" name="jobstop[]">';
        $text .= '<br><br><span class="jobdescText">' . _SMALLWORLD_DESCRIPTION . '</span><textarea class="jobdesc" name="description[]" rows="20" cols="20">' . $description . '</textarea><br></p></div>';
        $text .= '' . '<br>';
        return $text;
    }

    /**
     * @param int $userID
     * @return file|string
     * @return string
     */
    public function uploadform($userID)

    {
        $text = '<form action="imgupload.php" method="POST" enctype="multipart/form-data">';
        $text .= '<input type="file" name="file[]" multiple>';
        $text .= '<button type="submit">' . _SMALLWORLD_UPLOADTEXT . '</button>';
        $text .= '<span class="file_upload_label">' . _SMALLWORLD_UPLOADFILESTEXT . '</span>';
        $text .= '</form>';
        return $text;
    }

    /**
     * @param int    $userID
     * @param string $imgurl
     * @param string $imgdesc
     * @param string $id
     * @return dynamic|string
     * @return string
     */
    public function edit_images($userID, $imgurl, $imgdesc, $id)

    {
        global $xoopsUser;
        $text = '<p class="smallworld_clonebreaker"><br>';
        $text .= '<table class="smallworld_table" border="0" cellspacing="0" cellpadding="0">';
        $text .= '<tr>';
        $text .= '<td><img class="smallworld_edit_image" src="' . $imgurl . '" height="100px" width="80px;"></td>';
        $text .= '<td><span class="smallworld_editTextSpan">' . _SMALLWORLD_UPLOADDESC . '</span><br><br><textarea class="smallworld_edit_desc" name="imgdesc[]" rows="1" cols="1">' . stripslashes($imgdesc) . '</textarea><br><br></td>';
        $text .= '<input value="' . $id . '" type="hidden" name="id[]"></p>';
        $text .= '</tr></table>';
        return $text;
    }

    /**
     * @create a radio select
     * @param $userid
     * @return string
     */
    public function usersettings($userid)
    {
        global $xoopsUser, $xoopsDB;

        $form = "<div style='display:none'><div class='smallworld_usersetings'>";
        $form .= '<fieldset><legend>' . _SMALLWORLD_SHOWIFPUBLICORPRIVATE . '</legend>';
        $form .= "<form id='perset'>";
        if ($xoopsUser) {
            $sql    = 'SELECT value FROM ' . $xoopsDB->prefix('smallworld_settings') . ' WHERE userid = ' . (int)$userid;
            $result = $xoopsDB->queryF($sql);
            $i      = $xoopsDB->getRowsNum($result);
            $v      = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            if ($i >= 1) {
                while ($row = $xoopsDB->fetchArray($result)) {
                    $v    = unserialize(stripslashes($row['value']));
                    $pv   = ('1' == $v['posts']) ? ' checked' : '';
                    $cv   = ('1' == $v['comments']) ? ' checked' : '';
                    $nv   = ('1' == $v['notify']) ? ' checked' : '';
                    $form .= '<input type="checkbox" name="usersettings[]" id="posts" value="' . $v['posts'] . '" ' . $pv . '> ' . _SMALLWORLD_SHOWMYPOSTS . '<br>';
                    $form .= '<input type="checkbox" name="usersettings[]" id="comments" value="' . $v['comments'] . '" ' . $cv . '> ' . _SMALLWORLD_SHOWMYCOMMENTS . '<br>';
                    $form .= '<input type="checkbox" name="usersettings[]" id="notify" value="' . $v['notify'] . '" ' . $nv . '> ' . _SMALLWORLD_NOTIFYME . '<br>';
                }
            } else {
                $form .= '<input type="checkbox" name="usersettings[]" id="posts" value="0"> ' . _SMALLWORLD_SHOWMYPOSTS . '<br>';
                $form .= '<input type="checkbox" name="usersettings[]" id="comments" value="0"> ' . _SMALLWORLD_SHOWMYCOMMENTS . '<br>';
                $form .= '<input type="checkbox" name="usersettings[]" id="notify" value="0"> ' . _SMALLWORLD_NOTIFYME . '<br>';
            }
        }
        $form .= "<br><input type='submit' id='smallworld_privsave' value='" . _SMALLWORLD_SUBMIT . "' class='smallworld_finish'>";
        $form .= '</form></fieldset></div></div>';
        return $form;
    }
}


1		<?php namespace XoopsModules\Smallworld;
2
3		/**
4		* You may not change or alter any portion of this comment or credits
5		* of supporting developers from this source code or any supporting source code
6		* which is considered copyrighted (c) material of the original comment or credit authors.
7		*
8		* This program is distributed in the hope that it will be useful,
9		* but WITHOUT ANY WARRANTY; without even the implied warranty of
10		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11		*/
12
13		/**
14		* SmallWorld
15		*
16		* @copyright The XOOPS Project (https://xoops.org)
17		* @copyright 2011 Culex
18		* @license GNU GPL (http://www.gnu.org/licenses/gpl-2.0.html/)
19		* @package SmallWorld
20		* @since 1.0
21		* @author Michael Albertsen (http://culex.dk) <[email protected]>
22		*/
23		class Form
24		{
25		/**
26		* @create a dropdown select
27		* @param string $name
28		* @param array $options
29		* @param string $selected (optional)
		0 ignored issues – show Documentation introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report Should the type for parameter `$selected` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
30		* @return string
31		*/
32		public function dropdown($name, array $options, $selected = null)
33		{
34		$dropdown = '<select name="' . $name . '" id="' . $name . '">' . '<br>';
35		$selected = $selected;
		0 ignored issues – show Bug introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report Why assign `$selected` to itself? This checks looks for cases where a variable has been assigned to itself. This assignement can be removed without consequences. Loading history...
36	View Code Duplication	foreach ($options as $key => $option) {
		0 ignored issues – show Duplication introduced 2016-01-18 10:30 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		$select = $selected == $key ? ' selected="yes"' : '';

XoopsModules25x / smallworld

Pull Request — master (#5)

Form A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like