XoopsModules25x /
rssfit
| Conditions | 13 |
| Paths | 13 |
| Total Lines | 49 |
| Code Lines | 36 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 95 | public static function checkVerModule(Helper $helper, ?string $source = 'github', ?string $default = 'master'): ?array |
||
| 96 | { |
||
| 97 | $moduleDirName = \basename(\dirname(__DIR__, 2)); |
||
| 98 | $moduleDirNameUpper = mb_strtoupper($moduleDirName); |
||
| 99 | $update = ''; |
||
| 100 | $repository = 'XoopsModules25x/' . $moduleDirName; |
||
| 101 | // $repository = 'XoopsModules25x/publisher'; //for testing only |
||
| 102 | $ret = null; |
||
| 103 | $infoReleasesUrl = "https://api.github.com/repos/$repository/releases"; |
||
| 104 | if ('github' === $source) { |
||
| 105 | if (\function_exists('curl_init') && false !== ($curlHandle = \curl_init())) { |
||
| 106 | \curl_setopt($curlHandle, \CURLOPT_URL, $infoReleasesUrl); |
||
| 107 | \curl_setopt($curlHandle, \CURLOPT_RETURNTRANSFER, true); |
||
| 108 | \curl_setopt($curlHandle, \CURLOPT_SSL_VERIFYPEER, true); //TODO: how to avoid an error when 'Peer's Certificate issuer is not recognized' |
||
| 109 | \curl_setopt($curlHandle, \CURLOPT_HTTPHEADER, ["User-Agent:Publisher\r\n"]); |
||
| 110 | $curlReturn = \curl_exec($curlHandle); |
||
| 111 | if (false === $curlReturn) { |
||
| 112 | \trigger_error(\curl_error($curlHandle)); |
||
| 113 | } elseif (\is_string($curlReturn) && false !== \strpos($curlReturn, 'Not Found')) { |
||
| 114 | \trigger_error('Repository Not Found: ' . $infoReleasesUrl); |
||
| 115 | } elseif (\is_string($curlReturn)) { |
||
| 116 | $file = json_decode($curlReturn, false); |
||
| 117 | $latestVersionLink = \sprintf("https://github.com/$repository/archive/%s.zip", $file ? \reset($file)->tag_name : $default); |
||
| 118 | $latestVersion = $file[0]->tag_name; |
||
| 119 | $prerelease = $file[0]->prerelease; |
||
| 120 | if ('master' !== $latestVersionLink) { |
||
| 121 | $update = \constant('CO_' . $moduleDirNameUpper . '_' . 'NEW_VERSION') . $latestVersion; |
||
| 122 | } |
||
| 123 | //"PHP-standardized" version |
||
| 124 | $latestVersion = mb_strtolower($latestVersion); |
||
| 125 | if (false !== mb_strpos($latestVersion, 'final')) { |
||
| 126 | $latestVersion = \str_replace('_', '', mb_strtolower($latestVersion)); |
||
| 127 | $latestVersion = \str_replace('final', '', mb_strtolower($latestVersion)); |
||
| 128 | } |
||
| 129 | $moduleVersion = ($helper->getModule()->getInfo('version') . '_' . $helper->getModule()->getInfo('module_status')); |
||
| 130 | //"PHP-standardized" version |
||
| 131 | $moduleVersion = \str_replace(' ', '', mb_strtolower($moduleVersion)); |
||
| 132 | // $moduleVersion = '1.0'; //for testing only |
||
| 133 | // $moduleDirName = 'publisher'; //for testing only |
||
| 134 | if (!$prerelease && \version_compare($moduleVersion, $latestVersion, '<')) { |
||
| 135 | $ret = []; |
||
| 136 | $ret[] = $update; |
||
| 137 | $ret[] = $latestVersionLink; |
||
| 138 | } |
||
| 139 | } |
||
| 140 | \curl_close($curlHandle); |
||
| 141 | } |
||
| 142 | } |
||
| 143 | return $ret; |
||
| 144 | } |
||
| 146 |
Loading history...