XoopsModules25x / oledrion

include/notification.inc.php

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link https://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 * @param $category
 * @param $item_id
 * @return mixed
 */
function oledrion_notify_iteminfo($category, $item_id)
{
    global $xoopsModule, $xoopsModuleConfig;
    /** @var \XoopsDatabase $db */
    $db = \XoopsDatabaseFactory::getDatabaseConnection();
    $item_id = (int)$item_id;

    if (empty($xoopsModule) || 'oledrion' !== $xoopsModule->getVar('dirname')) {
        /** @var \XoopsModuleHandler $moduleHandler */
        $moduleHandler = xoops_getHandler('module');
        $module        = $moduleHandler->getByDirname('oledrion');
        /** @var \XoopsConfigHandler $configHandler */
        $configHandler = xoops_getHandler('config');
        $config        = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
    } else {
        $module = $xoopsModule;
        // TODO: Never used !!!
        $config = $xoopsModuleConfig;
    }

    if ('global' === $category) {
        $item['name'] = '';

$item was never initialized. Although not strictly required by PHP, it is generally a good practice to add $item = array(); before regardless.

        $item['url']  = '';

        return $item;
    }

    if ('new_category' === $category) {
        include OLEDRION_PATH . 'include/common.php';
        $categoryHandler = new \XoopsModules\Oledrion\CategoryHandler($db);
        $category        = $categoryHandler->get($item_id);
        if (is_object($category)) {
            $item['name'] = $category->getVar('cat_title');
            $item['url']  = OLEDRION_URL . 'category.php?cat_cid=' . $item_id;
        }

        return $item;

The variable $item does not seem to be defined for all execution paths leading up to this point.

    }

    if ('new_product' === $category) {
        include OLEDRION_PATH . 'include/common.php';
        $productsHandler = new \XoopsModules\Oledrion\ProductsHandler($db);
        $product         = $productsHandler->get($item_id);
        if (is_object($product)) {
            $item['name'] = $product->getVar('product_title');
            $item['url']  = OLEDRION_URL . 'product.php?product_id=' . $item_id;
        }

        return $item;
    }
}