XoopsModules25x / oledrion

class/VendorsHandler.php

<?php

namespace XoopsModules\Oledrion;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link https://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 */

use XoopsModules\Oledrion;

/**
 * Gestion des vendeurs
 */

/**
 * Class VendorsHandler
 */
class VendorsHandler extends OledrionPersistableObjectHandler
{
    /**
     * VendorsHandler constructor.
     * @param \XoopsDatabase|null $db
     */
    public function __construct(\XoopsDatabase $db = null)
    {
        //                            Table               Classe          Id          Libellé
        parent::__construct($db, 'oledrion_vendors', Vendors::class, 'vendor_id', 'vendor_name');

It seems like $db can also be of type null; however, parameter $db of XoopsModules\Oledrion\OledrionPersistableObjectHandler::__construct() does only seem to accept XoopsDatabase, maybe add an additional type check?

    }

    /**
     * Renvoie la liste de tous les vendeurs du module
     *
     * @param  Parameters $parameters
     * @return array               tableau d'objets de type vendors
     * @internal param int $start Position de départ
     * @internal param int $limit Nombre total d'enregistrements à renvoyer
     * @internal param string $order Champ sur lequel faire le tri
     * @internal param string $order Ordre du tri
     * @internal param bool $idaskey Indique si le tableau renvoyé doit avoir pour clé l'identifiant unique de l'enregistrement
     */
    public function getAllVendors(Parameters $parameters)
    {
        $parameters = $parameters->extend(new Oledrion\Parameters([
                                                                      'start'   => 0,
                                                                      'limit'   => 0,
                                                                      'sort'    => 'vendor_name',
                                                                      'order'   => 'ASC',
                                                                      'idaskey' => true,
                                                                  ]));
        $critere    = new \Criteria('vendor_id', 0, '<>');
        $critere->setLimit($parameters['limit']);
        $critere->setStart($parameters['start']);
        $critere->setSort($parameters['sort']);
        $critere->setOrder($parameters['order']);
        $categories = [];

The assignment to $categories is dead and can be removed.

        $categories = $this->getObjects($critere, $parameters['idaskey']);

        return $categories;
    }

    /**
     * Retourne le nombre de produits associés à un vendeur
     *
     * @param int $vendor_id L'ID du vendeur
     * @return int Le nombre de produits du vendeur
     */
    public function getVendorProductsCount($vendor_id)
    {
        global $productsHandler;

        return $productsHandler->getVendorProductsCount($vendor_id);
    }

    /**
     * Supprime un vendeur
     *
     * @param  Vendors $vendor
     * @return bool          Le résultat de la suppression
     */
    public function deleteVendor(Vendors $vendor)
    {
        return $this->delete($vendor, true);
    }

    /**
     * Retourne des vendeurs selon leur ID
     *
     * @param  array $ids Les ID des vendeurs à retrouver
     * @return array Objets de type Vendors
     */
    public function getVendorsFromIds($ids)
    {
        $ret = [];
        if ($ids && is_array($ids)) {

The expression $ids of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $criteria = new \Criteria('vendor_id', '(' . implode(',', $ids) . ')', 'IN');
            $ret      = $this->getObjects($criteria, true, true, '*', false);

The call to XoopsPersistableObjectHandler::getObjects() has too many arguments starting with '*'.

        }

        return $ret;
    }
}