XoopsModules25x / oledrion

class/PaymentHandler.php

<?php

namespace XoopsModules\Oledrion;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link https://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hossein Azizabadi (azizabadi@faragostaresh.com)
 */

use XoopsModules\Oledrion;

/**
 * Class PaymentHandler
 */
class PaymentHandler extends OledrionPersistableObjectHandler
{
    /**
     * PaymentHandler constructor.
     * @param \XoopsDatabase|null $db
     */
    public function __construct(\XoopsDatabase $db = null)
    {
        //                                       Table                    Classe              Id
        parent::__construct($db, 'oledrion_payment', Payment::class, 'payment_id');

It seems like $db can also be of type null; however, parameter $db of XoopsModules\Oledrion\OledrionPersistableObjectHandler::__construct() does only seem to accept XoopsDatabase, maybe add an additional type check?

    }

    /**
     * @param  Parameters $parameters
     * @return array
     */
    public function getAllPayment(Parameters $parameters)
    {
        $parameters = $parameters->extend(new Oledrion\Parameters([
                                                                      'start' => 0,
                                                                      'limit' => 0,
                                                                      'sort'  => 'payment_id',
                                                                      'order' => 'ASC',
                                                                  ]));
        $critere    = new \Criteria('payment_id', 0, '<>');
        $critere->setLimit($parameters['limit']);
        $critere->setStart($parameters['start']);
        $critere->setSort($parameters['sort']);
        $critere->setOrder($parameters['order']);
        $categories = [];

The assignment to $categories is dead and can be removed.

        $categories = $this->getObjects($critere);

        return $categories;
    }

    /**
     * @param $delivery_id
     * @return array
     */
    public function getThisDeliveryPayment($delivery_id)
    {
        /** @var \XoopsDatabase $db */
        $db = \XoopsDatabaseFactory::getDatabaseConnection();
        $deliveryPaymentHandler = new Oledrion\DeliveryPaymentHandler($db);
        $ret             = [];
        $parameters      = ['delivery' => $delivery_id];
        $deliveryPayment = $deliveryPaymentHandler->getDeliveryPaymantId($parameters);
        foreach ($deliveryPayment as $payment) {
            $id[] = $payment['dp_payment'];
        }

        $critere = new \CriteriaCompo();
        $critere->add(new \Criteria('payment_id', '(' . implode(',', $id) . ')', 'IN'));

The variable $id seems to be defined by a foreach iteration on line 75. Are you sure the iterator is never empty, otherwise this variable is not defined?

        $critere->add(new \Criteria('payment_online', 1));
        $obj = $this->getObjects($critere);
        if ($obj) {

The expression $obj of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($obj as $root) {
                $tab   = [];

The assignment to $tab is dead and can be removed.

                $tab   = $root->toArray();
                $ret[] = $tab;
            }
        }

        return $ret;
    }
}