XoopsModules25x / oledrion

class/CaddyAttributesHandler.php

<?php

namespace XoopsModules\Oledrion;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link https://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 */

use XoopsModules\Oledrion;

/**
 * Gestion des options (attributs) produits dans les commandes
 */

/**
 * Class CaddyAttributesHandler
 */
class CaddyAttributesHandler extends OledrionPersistableObjectHandler
{
    /**
     * CaddyAttributesHandler constructor.
     * @param \XoopsDatabase|null $db
     */
    public function __construct(\XoopsDatabase $db = null)
    {
        //                                Table                   Classe                      Id
        parent::__construct($db, 'oledrion_caddy_attributes', CaddyAttributes::class, 'ca_id');

It seems like $db can also be of type null; however, parameter $db of XoopsModules\Oledrion\OledrionPersistableObjectHandler::__construct() does only seem to accept XoopsDatabase, maybe add an additional type check?

    }

    /**
     * Retourne le nombre d'attributs liés à un caddy
     *
     * @param int $ca_caddy_id L'ID du caddy concerné
     * @return int
     * @since 2.3.2009.03.23
     */
    public function getAttributesCountForCaddy($ca_caddy_id)
    {
        return $this->getCount(new \Criteria('ca_caddy_id', $ca_caddy_id, '='));
    }

    /**
     * Retourne la liste formatée des attributs liés à un caddy
     *
     * @param int       $ca_caddy_id L'identifiant de caddy
     * @param  Products $product     Le produit concerné par le caddy
     * @return array
     * @since 2.3.2009.03.23
     */
    public function getFormatedAttributesForCaddy($ca_caddy_id, Products $product)
    {
        //        $handlers   = HandlerManager::getInstance();
        $attributes = $ret = [];

The assignment to $attributes is dead and can be removed.

        $attributes = $this->getObjects(new \Criteria('ca_caddy_id', $ca_caddy_id, '='));
        if (0 === count($attributes)) {
            return $ret;
        }
        foreach ($attributes as $caddyAttribute) {
            $data      = [];
            $attribute = null;

The assignment to $attribute is dead and can be removed.

            $attribute = $attributesHandler->get($caddyAttribute->getVar('ca_attribute_id'));

The variable $attributesHandler does not exist. Did you maybe mean $attributes?

            if (is_object($attribute)) {
                $data = $attribute->toArray();
            }
            $data['attribute_options'] = $caddyAttribute->renderForInvoice($product);
            $ret[]                     = $data;
        }

        return $ret;
    }

    /**
     * Retourne le nombre de caddy attributs liés à un attribut
     *
     * @param int $ca_attribute_id L'Identifiant de l'attribut concerné
     * @return int
     * @since 2.3.2009.03.23
     */
    public function getCaddyCountFromAttributeId($ca_attribute_id)
    {
        return $this->getCount(new \Criteria('ca_attribute_id', $ca_attribute_id, '='));
    }

    /**
     * Retourne la liste des numéros de commandes "liés" à un attribut
     *
     * @param int $ca_attribute_id
     * @return array
     */
    public function getCommandIdFromAttribute($ca_attribute_id)
    {
        $ret       = $ordersIds = [];

The assignment to $ordersIds is dead and can be removed.

        $criteria  = new \Criteria('ca_attribute_id', $ca_attribute_id, '=');
        $ordersIds = $this->getObjects($criteria, false, true, 'ca_cmd_id', false);

The call to XoopsPersistableObjectHandler::getObjects() has too many arguments starting with 'ca_cmd_id'.

        foreach ($ordersIds as $order) {
            $ret[] = $order->ca_cmd_id;
        }

        return $ret;
    }

    /**
     * Supprime les caddies associés à une commande
     *
     * @param $ca_cmd_id
     * @return bool
     * @internal param int $caddy_cmd_id
     */
    public function removeCartsFromOrderId($ca_cmd_id)
    {
        $ca_cmd_id = (int)$ca_cmd_id;

        return $this->deleteAll(new \Criteria('ca_cmd_id', $ca_cmd_id, '='));
    }
}