notification.inc.php ➔ oledrion_notify_iteminfo() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (00e474)

by Michael

created 2016-10-10 11:01 UTC

notification.inc.php ➔ oledrion_notify_iteminfo() C

↳ Parent: Project

Complexity

Conditions	8
Paths	12

Size

Total Lines	47
Code Lines	31

Duplication

Lines	22
Ratio	46.81 %

Importance

Changes

Metric	Value
cc	8
eloc	31
nc	12
nop	2
dl	22
loc	47
rs	5.7377
c	0
b	0
f	0

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   The XOOPS Project http://sourceforge.net/projects/xoops/
 * @license     http://www.fsf.org/copyleft/gpl.html GNU public license
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 * @version     $Id: notification.inc.php 12290 2014-02-07 11:05:17Z beckmi $
 */

function oledrion_notify_iteminfo($category, $item_id)
{
    global $xoopsModule, $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}
    $item_id = intval($item_id);

    if (empty($xoopsModule) || $xoopsModule->getVar('dirname') != 'oledrion') {
        $module_handler = xoops_gethandler('module');
        $module = $module_handler->getByDirname('oledrion');
        $config_handler = xoops_gethandler('config');
        $config = $config_handler->getConfigsByCat(0, $module->getVar('mid'));
    } else {
        $module = $xoopsModule;
        // TODO: Jamais utilisé !!!
        $config = $xoopsModuleConfig;
    }

    if ($category == 'global') {
        $item['name'] = '';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $item['url'] = '';

        return $item;
    }

    if ($category == 'new_category') {

        include OLEDRION_PATH . 'include/common.php';
        $category = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $category = $h_oledrion_cat->get($item_id);

        if (is_object($category)) {
            $item['name'] = $category->getVar('cat_title');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $item['url'] = OLEDRION_URL . 'category.php?cat_cid=' . $item_id;
        }

        return $item;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    if ($category == 'new_product') {

        include OLEDRION_PATH . 'include/common.php';
        $product = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $product = $h_oledrion_products->get($item_id);

        if (is_object($product)) {
            $item['name'] = $product->getVar('product_title');
            $item['url'] = OLEDRION_URL . 'product.php?product_id=' . $item_id;
        }

        return $item;
    }
}


Branch — master (00e474)

notification.inc.php ➔ oledrion_notify_iteminfo() C

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1		<?php
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* oledrion
14		*
15		* @copyright The XOOPS Project http://sourceforge.net/projects/xoops/
16		* @license http://www.fsf.org/copyleft/gpl.html GNU public license
17		* @author Hervé Thouzard (http://www.herve-thouzard.com/)
18		* @version $Id: notification.inc.php 12290 2014-02-07 11:05:17Z beckmi $
19		*/
20
21		function oledrion_notify_iteminfo($category, $item_id)
22		{
23		global $xoopsModule, $xoopsModuleConfig;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
24		$item_id = intval($item_id);
25
26		if (empty($xoopsModule) \|\| $xoopsModule->getVar('dirname') != 'oledrion') {
27		$module_handler = xoops_gethandler('module');
28		$module = $module_handler->getByDirname('oledrion');
29		$config_handler = xoops_gethandler('config');
30		$config = $config_handler->getConfigsByCat(0, $module->getVar('mid'));
31		} else {
32		$module = $xoopsModule;
33		// TODO: Jamais utilisé !!!
34		$config = $xoopsModuleConfig;
35		}
36
37		if ($category == 'global') {
38		$item['name'] = '';
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report `$item` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$item = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
39		$item['url'] = '';
40
41		return $item;
42		}
43
44	View Code Duplication	if ($category == 'new_category') {
		0 ignored issues – show Duplication introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		include OLEDRION_PATH . 'include/common.php';
46		$category = null;
		0 ignored issues – show Unused Code introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report `$category` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
47		$category = $h_oledrion_cat->get($item_id);
		0 ignored issues – show Bug introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report The variable `$h_oledrion_cat` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
48		if (is_object($category)) {
49		$item['name'] = $category->getVar('cat_title');
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report `$item` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$item = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
50		$item['url'] = OLEDRION_URL . 'category.php?cat_cid=' . $item_id;
51		}
52
53		return $item;
		0 ignored issues – show Bug introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report The variable `$item` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
54		}
55
56	View Code Duplication	if ($category == 'new_product') {
		0 ignored issues – show Duplication introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		include OLEDRION_PATH . 'include/common.php';
58		$product = null;
		0 ignored issues – show Unused Code introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report `$product` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
59		$product = $h_oledrion_products->get($item_id);
		0 ignored issues – show Bug introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report The variable `$h_oledrion_products` does not exist. Did you mean `$product`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
60		if (is_object($product)) {
61		$item['name'] = $product->getVar('product_title');
62		$item['url'] = OLEDRION_URL . 'product.php?product_id=' . $item_id;
63		}
64
65		return $item;
66		}
67		}
68

XoopsModules25x / oledrion

Branch — master (00e474)

notification.inc.php ➔ oledrion_notify_iteminfo() C

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Duplication Side-by-Side

Filter issues like