XoopsModules25x / oledrion

class/RelatedHandler.php

<?php

namespace XoopsModules\Oledrion;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link https://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 */

/**
 * Gestion des produits relatifs
 */

use XoopsModules\Oledrion;

/**
 * Class RelatedHandler
 */
class RelatedHandler extends OledrionPersistableObjectHandler
{
    /**
     * RelatedHandler constructor.
     * @param \XoopsDatabase|null $db
     */
    public function __construct(\XoopsDatabase $db = null)
    {
        //                            Table               Classe                   Id
        parent::__construct($db, 'oledrion_related', Related::class, 'related_id');

It seems like $db can also be of type null; however, parameter $db of XoopsModules\Oledrion\OledrionPersistableObjectHandler::__construct() does only seem to accept XoopsDatabase, maybe add an additional type check?

    }

    /**
     * Supprime les produits relatifs rattachés à un produit
     *
     * @param int $related_product_id L'identifiant du produit pour lequel il faut faire la suppression
     */
    public function deleteProductRelatedProducts($related_product_id)
    {
        $criteria = new \Criteria('related_product_id', $related_product_id, '=');
        $this->deleteAll($criteria);
    }

    /**
     * Retourne la liste des produits relatifs d'une liste de produits
     *
     * @param  array $ids Les ID des produits dont on recherche les produits relatifs
     * @return array Objets de type Related
     */
    public function getRelatedProductsFromProductsIds($ids)
    {
        $ret = [];
        if (is_array($ids)) {

The condition is_array($ids) is always true.

            $criteria = new \Criteria('related_product_id', '(' . implode(',', $ids) . ')', 'IN');
            $ret      = $this->getObjects($criteria, true, true, '*', false);

The call to XoopsPersistableObjectHandler::getObjects() has too many arguments starting with '*'.

        }

        return $ret;
    }

    /**
     * Update product percent
     *
     * @param $id
     * @param $related
     * @param $percent
     * @return bool
     * @internal param $
     */
    public function updatePercent($id, $related, $percent)
    {
        if ($percent > 100) {
            return false;
        }

        $sql = 'UPDATE ' . $this->table . ' SET `related_product_percent` = ' . (int)$percent . ' WHERE (related_product_id = ' . (int)$id . ') AND (related_product_related = ' . (int)$related . ')';

        return $this->db->queryF($sql);
    }
}