Issues in menu.php - New Issues - Inspection of "Merge branch 'master' of https://github.com/XoopsM..." - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9d3fbd...af269e )

by Michael

created 2018-06-08 06:52 UTC

admin/menu.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link https://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 */

$moduleDirName = basename(dirname(__DIR__));

if (false !== ($moduleHelper = Xmf\Module\Helper::getHelper($moduleDirName))) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
} else {
    $moduleHelper = Xmf\Module\Helper::getHelper('system');
}
$adminObject = \Xmf\Module\Admin::getInstance();

$pathIcon32    = \Xmf\Module\Admin::menuIconPath('');
$pathModIcon32 = $moduleHelper->getModule()->getInfo('modicons32');

$moduleHelper->loadLanguage('modinfo');

$adminmenu              = array();
$i                      = 0;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU10;
$adminmenu[$i]['link']  = 'admin/index.php?op=dashboard';
$adminmenu[$i]['icon']  = $pathIcon32 . '/home.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU0;
$adminmenu[$i]['link']  = 'admin/index.php?op=vendors';
$adminmenu[$i]['icon']  = $pathIcon32 . '/user-icon.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU1;
$adminmenu[$i]['link']  = 'admin/index.php?op=vat';
$adminmenu[$i]['icon']  = $pathModIcon32 . '/money_delete.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU2;
$adminmenu[$i]['link']  = 'admin/index.php?op=categories';
$adminmenu[$i]['icon']  = $pathIcon32 . '/category.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU3;
$adminmenu[$i]['link']  = 'admin/index.php?op=manufacturers';
$adminmenu[$i]['icon']  = $pathModIcon32 . '/factory.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU4;
$adminmenu[$i]['link']  = 'admin/index.php?op=products';
$adminmenu[$i]['icon']  = $pathIcon32 . '/fileshare.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU13;
$adminmenu[$i]['link']  = 'admin/index.php?op=attributes';
$adminmenu[$i]['icon']  = $pathIcon32 . '/highlight.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU17;
$adminmenu[$i]['link']  = 'admin/index.php?op=property';
$adminmenu[$i]['icon']  = $pathIcon32 . '/view_detailed.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU5;
$adminmenu[$i]['link']  = 'admin/index.php?op=orders';
$adminmenu[$i]['icon']  = $pathIcon32 . '/cart_add.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU6;
$adminmenu[$i]['link']  = 'admin/index.php?op=discounts';
$adminmenu[$i]['icon']  = $pathIcon32 . '/discount.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU7;
$adminmenu[$i]['link']  = 'admin/index.php?op=newsletter';
$adminmenu[$i]['icon']  = $pathIcon32 . '/newsletter.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU8;
$adminmenu[$i]['link']  = 'admin/index.php?op=texts';
$adminmenu[$i]['icon']  = $pathIcon32 . '/content.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU9;
$adminmenu[$i]['link']  = 'admin/index.php?op=lowstock';
$adminmenu[$i]['icon']  = $pathIcon32 . '/alert.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU11;
$adminmenu[$i]['link']  = 'admin/index.php?op=files';
$adminmenu[$i]['icon']  = $pathIcon32 . '/attach.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU12;
$adminmenu[$i]['link']  = 'admin/index.php?op=gateways';
$adminmenu[$i]['icon']  = $pathIcon32 . '/export.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU15;
$adminmenu[$i]['link']  = 'admin/index.php?op=lists';
$adminmenu[$i]['icon']  = $pathIcon32 . '/index.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU18;
$adminmenu[$i]['link']  = 'admin/index.php?op=packing';
$adminmenu[$i]['icon']  = $pathModIcon32 . '/package.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU19;
$adminmenu[$i]['link']  = 'admin/index.php?op=location';
$adminmenu[$i]['icon']  = $pathIcon32 . '/globe.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU20;
$adminmenu[$i]['link']  = 'admin/index.php?op=delivery';
$adminmenu[$i]['icon']  = $pathIcon32 . '/delivery.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU21;
$adminmenu[$i]['link']  = 'admin/index.php?op=payment';
$adminmenu[$i]['icon']  = $pathIcon32 . '/cash_stack.png';
++$i;
$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU16;
$adminmenu[$i]['link']  = 'admin/index.php?op=maintain';
$adminmenu[$i]['icon']  = $pathIcon32 . '/synchronized.png';
++$i;
$adminmenu[$i]['title'] = _AM_MODULEADMIN_ABOUT;
$adminmenu[$i]['link']  = 'admin/about.php';
$adminmenu[$i]['icon']  = $pathIcon32 . '/about.png';


1			<?php
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* oledrion
14			*
15			* @copyright {@link https://xoops.org/ XOOPS Project}
16			* @license {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
17			* @author Hervé Thouzard (http://www.herve-thouzard.com/)
18			*/
19
20			$moduleDirName = basename(dirname(__DIR__));
21
22			if (false !== ($moduleHelper = Xmf\Module\Helper::getHelper($moduleDirName))) {
			0 ignored issues – show Unused Code introduced 2018-06-08 07:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
23			} else {
24			$moduleHelper = Xmf\Module\Helper::getHelper('system');
25			}
26			$adminObject = \Xmf\Module\Admin::getInstance();
27
28			$pathIcon32 = \Xmf\Module\Admin::menuIconPath('');
29			$pathModIcon32 = $moduleHelper->getModule()->getInfo('modicons32');
30
31			$moduleHelper->loadLanguage('modinfo');
32
33			$adminmenu = array();
34			$i = 0;
35			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU10;
36			$adminmenu[$i]['link'] = 'admin/index.php?op=dashboard';
37			$adminmenu[$i]['icon'] = $pathIcon32 . '/home.png';
38			++$i;
39			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU0;
40			$adminmenu[$i]['link'] = 'admin/index.php?op=vendors';
41			$adminmenu[$i]['icon'] = $pathIcon32 . '/user-icon.png';
42			++$i;
43			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU1;
44			$adminmenu[$i]['link'] = 'admin/index.php?op=vat';
45			$adminmenu[$i]['icon'] = $pathModIcon32 . '/money_delete.png';
46			++$i;
47			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU2;
48			$adminmenu[$i]['link'] = 'admin/index.php?op=categories';
49			$adminmenu[$i]['icon'] = $pathIcon32 . '/category.png';
50			++$i;
51			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU3;
52			$adminmenu[$i]['link'] = 'admin/index.php?op=manufacturers';
53			$adminmenu[$i]['icon'] = $pathModIcon32 . '/factory.png';
54			++$i;
55			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU4;
56			$adminmenu[$i]['link'] = 'admin/index.php?op=products';
57			$adminmenu[$i]['icon'] = $pathIcon32 . '/fileshare.png';
58			++$i;
59			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU13;
60			$adminmenu[$i]['link'] = 'admin/index.php?op=attributes';
61			$adminmenu[$i]['icon'] = $pathIcon32 . '/highlight.png';
62			++$i;
63			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU17;
64			$adminmenu[$i]['link'] = 'admin/index.php?op=property';
65			$adminmenu[$i]['icon'] = $pathIcon32 . '/view_detailed.png';
66			++$i;
67			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU5;
68			$adminmenu[$i]['link'] = 'admin/index.php?op=orders';
69			$adminmenu[$i]['icon'] = $pathIcon32 . '/cart_add.png';
70			++$i;
71			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU6;
72			$adminmenu[$i]['link'] = 'admin/index.php?op=discounts';
73			$adminmenu[$i]['icon'] = $pathIcon32 . '/discount.png';
74			++$i;
75			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU7;
76			$adminmenu[$i]['link'] = 'admin/index.php?op=newsletter';
77			$adminmenu[$i]['icon'] = $pathIcon32 . '/newsletter.png';
78			++$i;
79			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU8;
80			$adminmenu[$i]['link'] = 'admin/index.php?op=texts';
81			$adminmenu[$i]['icon'] = $pathIcon32 . '/content.png';
82			++$i;
83			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU9;
84			$adminmenu[$i]['link'] = 'admin/index.php?op=lowstock';
85			$adminmenu[$i]['icon'] = $pathIcon32 . '/alert.png';
86			++$i;
87			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU11;
88			$adminmenu[$i]['link'] = 'admin/index.php?op=files';
89			$adminmenu[$i]['icon'] = $pathIcon32 . '/attach.png';
90			++$i;
91			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU12;
92			$adminmenu[$i]['link'] = 'admin/index.php?op=gateways';
93			$adminmenu[$i]['icon'] = $pathIcon32 . '/export.png';
94			++$i;
95			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU15;
96			$adminmenu[$i]['link'] = 'admin/index.php?op=lists';
97			$adminmenu[$i]['icon'] = $pathIcon32 . '/index.png';
98			++$i;
99			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU18;
100			$adminmenu[$i]['link'] = 'admin/index.php?op=packing';
101			$adminmenu[$i]['icon'] = $pathModIcon32 . '/package.png';
102			++$i;
103			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU19;
104			$adminmenu[$i]['link'] = 'admin/index.php?op=location';
105			$adminmenu[$i]['icon'] = $pathIcon32 . '/globe.png';
106			++$i;
107			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU20;
108			$adminmenu[$i]['link'] = 'admin/index.php?op=delivery';
109			$adminmenu[$i]['icon'] = $pathIcon32 . '/delivery.png';
110			++$i;
111			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU21;
112			$adminmenu[$i]['link'] = 'admin/index.php?op=payment';
113			$adminmenu[$i]['icon'] = $pathIcon32 . '/cash_stack.png';
114			++$i;
115			$adminmenu[$i]['title'] = _MI_OLEDRION_ADMENU16;
116			$adminmenu[$i]['link'] = 'admin/index.php?op=maintain';
117			$adminmenu[$i]['icon'] = $pathIcon32 . '/synchronized.png';
118			++$i;
119			$adminmenu[$i]['title'] = _AM_MODULEADMIN_ABOUT;
120			$adminmenu[$i]['link'] = 'admin/about.php';
121			$adminmenu[$i]['icon'] = $pathIcon32 . '/about.png';
122

XoopsModules25x / oledrion

Push — master ( 9d3fbd...af269e )

admin/menu.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like