oledrion_cart.php ➔ b_oledrion_cart_show() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/XoopsM..." - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9d3fbd...af269e )

by Michael

created 2018-06-08 06:52 UTC

oledrion_cart.php ➔ b_oledrion_cart_show() B

↳ Parent: Project

Complexity

Conditions	4
Paths	3

Size

Total Lines	33
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	26
nc	3
nop	1
dl	0
loc	33
rs	8.5806
c	0
b	0
f	0

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link https://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 */

/**
 * block to display items in cart
 *
 * @param  integer $options [0] Count of items to show (0 = no limit)
 * @return array   Block's content

 */
function b_oledrion_cart_show($options)
{
    global $mod_pref, $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}
    include XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
    $productsCount = (int)$options[0];

    $cartForTemplate      = $block = array();
    $emptyCart            = false;
    $shippingAmount       = $commandAmount = $vatAmount = $discountsCount = 0;
    $goOn                 = '';
    $commandAmountTTC     = 0;
    $discountsDescription = array();
    // Calcul du montant total du caddy
    $reductions = new oledrion_reductions();
    $reductions->computeCart($cartForTemplate, $emptyCart, $shippingAmount, $commandAmount, $vatAmount, $goOn, $commandAmountTTC, $discountsDescription, $discountsCount);

    $dec = OledrionUtility::getModuleOption('decimals_count');
    if ($emptyCart) {
        return '';
    }
    $block['block_money_full']           = OledrionUtility::getModuleOption('money_full');
    $block['block_money_short']          = OledrionUtility::getModuleOption('money_short');
    $block['block_shippingAmount']       = sprintf('%0.' . $dec . 'f', $shippingAmount); // Montant des frais de port
    $block['block_commandAmount']        = sprintf('%0.' . $dec . 'f', $commandAmount); // Montant HT de la commande
    $block['block_vatAmount']            = sprintf('%0.' . $dec . 'f', $vatAmount); // Montant de la TVA
    $block['block_commandAmountTTC']     = sprintf('%0.' . $dec . 'f', $commandAmountTTC); // Montant TTC de la commande
    $block['block_discountsDescription'] = $discountsDescription; // Liste des réductions accordées
    if (($productsCount > 0) && (count($cartForTemplate) > $productsCount)) {
        array_slice($cartForTemplate, 0, $productsCount - 1);
    }
    $block['block_caddieProducts'] = $cartForTemplate; // Produits dans le caddy

    return $block;
}

/**
 * @param $options
 * @return string
 */
function b_oledrion_cart_edit($options)

{
    global $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}
    include XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
    $form = '';
    $form .= "<table border='0'>";
    $form .= '<tr><td>' . _MB_OLEDRION_MAX_ITEMS . "</td><td><input type='text' name='options[]' id='options' value='" . $options[0] . "'></td></tr>";
    $form .= '</table>';

    return $form;
}


Push — master ( 9d3fbd...af269e )

oledrion_cart.php ➔ b_oledrion_cart_show() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* oledrion
14		*
15		* @copyright {@link https://xoops.org/ XOOPS Project}
16		* @license {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
17		* @author Hervé Thouzard (http://www.herve-thouzard.com/)
18		*/
19
20		/**
21		* block to display items in cart
22		*
23		* @param integer $options [0] Count of items to show (0 = no limit)
24		* @return array Block's content
		0 ignored issues – show Documentation introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report Should the return type not be `string\|array`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
25		*/
26		function b_oledrion_cart_show($options)
27		{
28		global $mod_pref, $xoopsConfig;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
29		include XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
30		$productsCount = (int)$options[0];
31
32		$cartForTemplate = $block = array();
33		$emptyCart = false;
34		$shippingAmount = $commandAmount = $vatAmount = $discountsCount = 0;
35		$goOn = '';
36		$commandAmountTTC = 0;
37		$discountsDescription = array();
38		// Calcul du montant total du caddy
39		$reductions = new oledrion_reductions();
40		$reductions->computeCart($cartForTemplate, $emptyCart, $shippingAmount, $commandAmount, $vatAmount, $goOn, $commandAmountTTC, $discountsDescription, $discountsCount);
		0 ignored issues – show Bug introduced 2018-06-08 07:01 UTC by Report Bug Copy Issue Report The call to `computeCart()` misses a required argument `$checkoutAttributes`. This check looks for function calls that miss required arguments. Loading history...
41		$dec = OledrionUtility::getModuleOption('decimals_count');
42		if ($emptyCart) {
43		return '';
44		}
45		$block['block_money_full'] = OledrionUtility::getModuleOption('money_full');
46		$block['block_money_short'] = OledrionUtility::getModuleOption('money_short');
47		$block['block_shippingAmount'] = sprintf('%0.' . $dec . 'f', $shippingAmount); // Montant des frais de port
48		$block['block_commandAmount'] = sprintf('%0.' . $dec . 'f', $commandAmount); // Montant HT de la commande
49		$block['block_vatAmount'] = sprintf('%0.' . $dec . 'f', $vatAmount); // Montant de la TVA
50		$block['block_commandAmountTTC'] = sprintf('%0.' . $dec . 'f', $commandAmountTTC); // Montant TTC de la commande
51		$block['block_discountsDescription'] = $discountsDescription; // Liste des réductions accordées
52		if (($productsCount > 0) && (count($cartForTemplate) > $productsCount)) {
53		array_slice($cartForTemplate, 0, $productsCount - 1);
54		}
55		$block['block_caddieProducts'] = $cartForTemplate; // Produits dans le caddy
56
57		return $block;
58		}
59
60		/**
61		* @param $options
62		* @return string
63		*/
64	View Code Duplication	function b_oledrion_cart_edit($options)
		0 ignored issues – show Duplication introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		{
66		global $xoopsConfig;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
67		include XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
68		$form = '';
69		$form .= "<table border='0'>";
70		$form .= '<tr><td>' . _MB_OLEDRION_MAX_ITEMS . "</td><td><input type='text' name='options[]' id='options' value='" . $options[0] . "'></td></tr>";
71		$form .= '</table>';
72
73		return $form;
74		}
75

XoopsModules25x / oledrion

Push — master ( 9d3fbd...af269e )

oledrion_cart.php ➔ b_oledrion_cart_show() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like