OledrionOledrion_listsHandler::incrementListViews() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/XoopsM..." - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9d3fbd...af269e )

by Michael

created 2018-06-08 06:52 UTC

incrementListViews() A

↳ Parent: OledrionOledrion_listsHandler

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	1
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0

<?php

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link https://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 */
/**
 * Gestion des listes utilisateurs
 *
 * @since 2.3.2009.06.13
 */
require_once __DIR__ . '/classheader.php';

/**
 * Définition des types de listes
 */
define('OLEDRION_LISTS_ALL_PUBLIC', -2); // Que les publiques
define('OLEDRION_LISTS_ALL', -1); // Toutes sans distinction
define('OLEDRION_LISTS_PRIVATE', 0);
define('OLEDRION_LISTS_WISH', 1);
define('OLEDRION_LISTS_RECOMMEND', 2);

/**
 * Class Oledrion_lists
 */
class Oledrion_lists extends Oledrion_Object
namespace YourVendor;

class YourClass { }
{
    /**
     * constructor
     *
     * normally, this is called from child classes only
     *
     * @access public
     */
    public function __construct()
    {
        $this->initVar('list_id', XOBJ_DTYPE_INT, null, false);
        $this->initVar('list_uid', XOBJ_DTYPE_INT, null, false);
        $this->initVar('list_title', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('list_date', XOBJ_DTYPE_INT, null, false);
        $this->initVar('list_productscount', XOBJ_DTYPE_INT, null, false);
        $this->initVar('list_views', XOBJ_DTYPE_INT, null, false);
        $this->initVar('list_password', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('list_type', XOBJ_DTYPE_INT, null, false);
        $this->initVar('list_description', XOBJ_DTYPE_TXTAREA, null, false);
    }

    /**
     * Indique si la liste courante est accessible de l'utilisateur courant
     *
     * @return boolean
     */
    public function isSuitableForCurrentUser()
    {
        $uid = OledrionUtility::getCurrentUserID();
        if ($this->getVar('list_type') == OLEDRION_LISTS_PRIVATE) {
            if ($uid == 0 || $uid != $this->getVar('list_uid')) {
                return false;
            }
        }

        return true;
    }

    /**
     * Retourne un tableau associatif qui pour chaque type de liste indique son type sous forme de texte
     *
     * @return array
     */
    public static function getTypesArray()
    {
        return array(
            OLEDRION_LISTS_PRIVATE   => _OLEDRION_LIST_PRIVATE,
            OLEDRION_LISTS_WISH      => _OLEDRION_LIST_PUBLIC_WISH_LIST,
            OLEDRION_LISTS_RECOMMEND => _OLEDRION_LIST_PUBLIC_RECOMMENDED_LIST
        );
    }

    /**
     * Retourne la description de la liste courante
     *
     * @return string
     */
    public function getListTypeDescription()
    {
        $description = static::getTypesArray();

        return $description[$this->list_type];
    }

    /**
     * Retourne l'url à utiliser pour accéder à la liste en tenant compte des préférences du module
     *
     * @return string L'url à utiliser
     */
    public function getLink()

    {
        $url = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (OledrionUtility::getModuleOption('urlrewriting') == 1) { // On utilise l'url rewriting
            $url = OLEDRION_URL . 'list-' . $this->getVar('list_id') . OledrionUtility::makeSeoUrl($this->getVar('list_title', 'n')) . '.html';
        } else { // Pas d'utilisation de l'url rewriting
            $url = OLEDRION_URL . 'list.php?list_id=' . $this->getVar('list_id');
        }

        return $url;
    }

    /**
     * Retourne la date de création de la liste formatée
     *
     * @param  string $format
     * @return string
     */
    public function getFormatedDate($format = 's')
    {
        return formatTimestamp($this->list_date, $format);
    }

    /**
     * Rentourne la chaine à utiliser dans une balise <a> pour l'attribut href
     *
     * @return string
     */
    public function getHrefTitle()
    {
        return OledrionUtility::makeHrefTitle($this->getVar('list_title'));
    }

    /**
     * Retourne le nom de l'auteur de la liste courante
     *
     * @return string
     */
    public function getListAuthorName()
    {
        return XoopsUser::getUnameFromId($this->getVar('list_uid', true));
    }

    /**
     * Retourne les éléments formatés pour affichage (en général)
     *
     * @param  string $format
     * @return array
     */
    public function toArray($format = 's')
    {
        $ret                          = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $ret                          = parent::toArray($format);
        $ret['list_type_description'] = $this->getListTypeDescription();
        $ret['list_href_title']       = $this->getHrefTitle();
        $ret['list_url_rewrited']     = $this->getLink();
        $ret['list_formated_date']    = $this->getFormatedDate();
        $ret['list_username']         = $this->getListAuthorName();
        $ret['list_formated_count']   = sprintf(_OLEDRION_PRODUCTS_COUNT, $this->getVar('list_productscount'));

        return $ret;
    }
}

/**
 * Class OledrionOledrion_listsHandler
 */
class OledrionOledrion_listsHandler extends Oledrion_XoopsPersistableObjectHandler
namespace YourVendor;

class YourClass { }
{
    /**
     * OledrionOledrion_listsHandler constructor.
     * @param XoopsDatabase|null $db
     */
    public function __construct(XoopsDatabase $db)
    { //                            Table               Classe           Id       Identifiant
        parent::__construct($db, 'oledrion_lists', 'oledrion_lists', 'list_id', 'list_title');
    }

    /**
     * Incrémente le compteur de vues d'une liste
     *
     * @param  oledrion_lists $list
     * @return boolean
     */
    public function incrementListViews(Oledrion_lists $list)

    {
        $res = true;
        if (OledrionUtility::getCurrentUserID() != $list->getVar('list_uid')) {
            $sql = 'UPDATE ' . $this->table . ' SET list_views = list_views + 1 WHERE list_id = ' . $list->getVar('list_id');
            $res = $this->db->queryF($sql);
            $this->forceCacheClean();
        }

        return $res;
    }

    /**
     * Incrémente le nombre de produits dans une liste
     *
     * @param  oledrion_lists $list
     * @return boolean
     */
    public function incrementListProductsCount(Oledrion_lists $list)
    {
        $res = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $sql = 'UPDATE ' . $this->table . ' SET list_productscount = list_productscount + 1 WHERE list_id = ' . $list->getVar('list_id');
        $res = $this->db->queryF($sql);
        $this->forceCacheClean();

        return $res;
    }

    /**
     * Décrémente le nombre de produits dans une liste
     *
     * @param  oledrion_lists $list
     * @param  int            $value
     * @return bool
     */
    public function decrementListProductsCount(Oledrion_lists $list, $value = 1)

    {
        $value = (int)$value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $res   = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $sql   = 'UPDATE ' . $this->table . ' SET list_productscount = list_productscount - $value WHERE list_id = ' . $list->getVar('list_id');
        $res   = $this->db->queryF($sql);
        $this->forceCacheClean();

        return $res;
    }

    /**
     * Retourne la liste des listes récentes
     *
     * @param  Oledrion_parameters $parameters
     * @return array               Tableau d'objets de type oledrion_lists [clé] = id liste
     * @internal param int $start
     * @internal param int $limit
     * @internal param string $sort
     * @internal param string $order
     * @internal param bool $idAsKey
     * @internal param int $listType
     * @internal param int $list_uid
     */
    public function getRecentLists(Oledrion_parameters $parameters)
    {
        $parameters = $parameters->extend(new Oledrion_parameters(array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                                                                      'start'    => 0,
                                                                      'limit'    => 0,
                                                                      'sort'     => 'list_date',
                                                                      'order'    => 'DESC',
                                                                      'idAsKey'  => true,
                                                                      'listType' => OLEDRION_LISTS_ALL,
                                                                      'list_uid' => 0
                                                                  )));
        $criteria   = new CriteriaCompo();
        switch ($parameters['listType']) {

            case OLEDRION_LISTS_ALL:
                $criteria->add(new Criteria('list_id', 0, '<>'));
                break;
            case OLEDRION_LISTS_ALL_PUBLIC:
                $criteria->add(new Criteria('list_type', OLEDRION_LISTS_WISH, '='));
                $criteria->add(new Criteria('list_type', OLEDRION_LISTS_RECOMMEND, '='), 'OR');
                break;
            default:
                $criteria->add(new Criteria('list_type', $parameters['listType'], '='));
                break;
        }
        if ($parameters['list_uid'] > 0) {
            $criteria->add(new Criteria('list_uid', $parameters['list_uid'], '='));
        }
        $criteria->setSort($parameters['sort']);
        $criteria->setOrder($parameters['order']);
        $criteria->setStart($parameters['start']);
        $criteria->setLimit($parameters['limit']);

        return $this->getObjects($criteria, $parameters['idAsKey']);
    }

    /**
     * Retourne le nombre de listes d'un certain type
     *
     * @param  integer $listType
     * @param  integer $list_uid
     * @return integer
     */
    public function getRecentListsCount($listType = OLEDRION_LISTS_ALL, $list_uid = 0)
    {
        $criteria = new CriteriaCompo();
        switch ($listType) {

            case OLEDRION_LISTS_ALL:
                $criteria->add(new Criteria('list_id', 0, '<>'));
                break;
            case OLEDRION_LISTS_ALL_PUBLIC:
                $criteria->add(new Criteria('list_type', OLEDRION_LISTS_WISH, '='));
                $criteria->add(new Criteria('list_type', OLEDRION_LISTS_RECOMMEND, '='), 'OR');
                break;
            default:
                $criteria->add(new Criteria('list_type', $listType, '='));
                break;
        }
        if ($list_uid > 0) {
            $criteria->add(new Criteria('list_uid', $list_uid, '='));
        }

        return $this->getCount($criteria);
    }

    /**
     * Retourne une liste d'utilisateurs Xoops en fonction d'une liste de listes
     *
     * @param  array $oledrion_lists
     * @return array [clé] = id utilisateur
     */
    public function getUsersFromLists($oledrion_lists)
    {
        $usersList = array();
        foreach ($oledrion_lists as $list) {
            $usersList[] = $list->list_uid;
        }
        if (count($usersList) > 0) {
            return OledrionUtility::getUsersFromIds($usersList);
        } else {
            return array();
        }
    }

    /**
     * Suppression d'une liste (et des produits qui lui sont rattachés)
     *
     * @param  oledrion_lists $list
     * @return boolean
     */
    public function deleteList(Oledrion_lists $list)
    {
        $handlers = OledrionHandler::getInstance();
        $handlers->h_oledrion_products_list->deleteListProducts($list);

        return $this->delete($list, true);
    }

    /**
     * Retourne les produits d'une liste
     *
     * @param  oledrion_lists $list
     * @return array          Objets de type oledrion_products
     */
    public function getListProducts(Oledrion_lists $list)
    {
        $productsInList = $ret = $productsIds = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $handlers       = OledrionHandler::getInstance();
        $productsInList = $handlers->h_oledrion_products_list->getProductsFromList($list);
        if (count($productsInList) == 0) {
            return $ret;
        }
        foreach ($productsInList as $product) {
            $productsIds[] = $product->getVar('productlist_product_id');
        }
        if (count($productsIds) > 0) {
            $ret = $handlers->h_oledrion_products->getProductsFromIDs($productsIds);
        }

        return $ret;
    }

    /**
     * Indique si une liste appartient bien à un utilisateur
     *
     * @param  integer $list_id
     * @param  integer $list_uid
     * @return boolean
     */
    public function isThisMyList($list_id, $list_uid = 0)
    {
        if ($list_uid == 0) {
            $list_uid = OledrionUtility::getCurrentUserID();
        }
        $list = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $list = $this->get((int)$list_id);
        if (!is_object($list)) {
            return false;
        }
        if ($list->getVar('list_uid') == $list_uid) {
            return true;
        } else {
            return false;
        }
    }

    /**
     * Indique si un produit est dans une liste d'un utilisateur
     *
     * @param  integer $productlist_product_id
     * @param  integer $list_uid
     * @return boolean
     */
    public function isProductInUserList($productlist_product_id, $list_uid = 0)
    {
        //require_once __DIR__ . '/lite.php';

        if ($list_uid == 0) {
            $list_uid = OledrionUtility::getCurrentUserID();
        }
        if ($list_uid == 0) {
            return true;
        }
        $ret                    = false;
        $start                  = $limit = 0;
        $list_uid               = (int)$list_uid;
        $productlist_product_id = (int)$productlist_product_id;
        $sql                    = 'SELECT Count(*) FROM ' . $this->table . ' l, ' . $this->db->prefix('oledrion_products_list') . ' p WHERE (p.productlist_list_id = l.list_id) AND (l.list_uid = ' . $list_uid . ') AND (p.productlist_product_id =' . $productlist_product_id . ')';
        //$Cache_Lite = new oledrion_Cache_Lite($this->cacheOptions);

        $id = $this->_getIdForCache($sql, $start, $limit);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //$cacheData = $Cache_Lite->get($id);

        //if ($cacheData === false) {

        $result = $this->db->query($sql, $limit, $start);
        if ($result) {
            list($count) = $this->db->fetchRow($result);
            if ($count > 0) {
                $ret = true;
            }
        }

        //$Cache_Lite->save($ret);

        return $ret;
        //} else {
        //return $cacheData;
        //}
    }

    /**
     * Retourne les x dernières listes qui contiennent des produits dans une certaine catégorie
     *
     * @param          $categoryId
     * @param  integer $list_type Le type de liste
     * @param  integer $limit     Le nombre maximum de listes à retourner
     * @return array   Objets de type oledrion_lists, [clé] = id liste
     * @internal param int $cateGoryId L'identifiant de la catégorie
     */
    public function listsFromCurrentCategory($categoryId, $list_type, $limit)
    {
        //require_once __DIR__ . '/lite.php';

        $ret        = array();
        $start      = 0;
        $categoryId = (int)$categoryId;
        $list_type  = (int)$list_type;
        $limit      = (int)$limit;
        $sql        = 'SELECT DISTINCT(z.productlist_list_id) FROM '
                      . $this->db->prefix('oledrion_products_list')
                      . ' z, '
                      . $this->db->prefix('oledrion_products')
                      . ' p, '
                      . $this->db->prefix('oledrion_lists')
                      . ' l WHERE (l.list_type = '
                      . $list_type
                      . ') AND (p.product_cid = '
                      . $categoryId
                      . ') AND (l.list_id = z.productlist_list_id) AND (z.productlist_product_id = p.product_id) AND (p.product_online = 1) ORDER BY l.list_date DESC';
        //$Cache_Lite = new oledrion_Cache_Lite($this->cacheOptions);

        $id = $this->_getIdForCache($sql, $start, $limit);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //$cacheData = $Cache_Lite->get($id);

        //if ($cacheData === false) {

        $result = $this->db->query($sql, $limit, $start);
        if ($result) {
            while ($row = $this->db->fetchArray($result)) {
                $ret[] = $row['productlist_list_id'];
            }
            $ret = $this->getItemsFromIds($ret);
        }

        //$Cache_Lite->save($ret);

        return $ret;
        //} else {
        //  return $cacheData;
        //}
    }
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-06-01 04:06 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 29 and the first side effect is on line 24. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* oledrion
14			*
15			* @copyright {@link https://xoops.org/ XOOPS Project}
16			* @license {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
17			* @author Hervé Thouzard (http://www.herve-thouzard.com/)
18			*/
19			/**
20			* Gestion des listes utilisateurs
21			*
22			* @since 2.3.2009.06.13
23			*/
24			require_once __DIR__ . '/classheader.php';
25
26			/**
27			* Définition des types de listes
28			*/
29			define('OLEDRION_LISTS_ALL_PUBLIC', -2); // Que les publiques
30			define('OLEDRION_LISTS_ALL', -1); // Toutes sans distinction
31			define('OLEDRION_LISTS_PRIVATE', 0);
32			define('OLEDRION_LISTS_WISH', 1);
33			define('OLEDRION_LISTS_RECOMMEND', 2);
34
35			/**
36			* Class Oledrion_lists
37			*/
38			class Oledrion_lists extends Oledrion_Object
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...

XoopsModules25x / oledrion

Push — master ( 9d3fbd...af269e )

incrementListViews() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like