Issues in oledrion_location.php - New Issues - Inspection of "Merge pull request #6 from mambax7/master" - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00e474...9d3fbd )

by Michael

created 2017-05-24 21:17 UTC

class/oledrion_location.php (2 issues)

Labels

Documentation 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hossein Azizabadi ([email protected])
 */

require __DIR__ . '/classheader.php';

/**
 * Class Oledrion_location
 */
class Oledrion_location extends Oledrion_Object
{
    /**
     * constructor
     *
     * normally, this is called from child classes only
     *
     * @access public
     */
    public function __construct()
    {
        $this->initVar('location_id', XOBJ_DTYPE_INT, null, false);
        $this->initVar('location_pid', XOBJ_DTYPE_INT, null, false);
        $this->initVar('location_title', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('location_online', XOBJ_DTYPE_INT, null, false);
        $this->initVar('location_type', XOBJ_DTYPE_TXTBOX, null, false);
    }

    /**
     * Retourne les éléments du produits formatés pour affichage
     *
     * @param  string $format
     * @return array
     */
    public function toArray($format = 's')
    {
        $ret = array();
        $ret = parent::toArray($format);

        return $ret;
    }
}

/**
 * Class OledrionOledrion_locationHandler
 */
class OledrionOledrion_locationHandler extends Oledrion_XoopsPersistableObjectHandler
{
    /**
     * OledrionOledrion_locationHandler constructor.
     * @param XoopsDatabase|null $db
     */
    public function __construct(XoopsDatabase $db)
    { //                                        Table                   Classe              Id
        parent::__construct($db, 'oledrion_location', 'oledrion_location', 'location_id');
    }

    /**
     * @param  Oledrion_parameters $parameters
     * @return array
     */
    public function getAllLocation(Oledrion_parameters $parameters)
    {
        $parameters = $parameters->extend(new Oledrion_parameters(array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                                                                      'start' => 0,
                                                                      'limit' => 0,
                                                                      'sort'  => 'location_id',
                                                                      'order' => 'ASC'
                                                                  )));
        $critere    = new Criteria('location_id', 0, '<>');
        $critere->setLimit($parameters['limit']);
        $critere->setStart($parameters['start']);
        $critere->setSort($parameters['sort']);
        $critere->setOrder($parameters['order']);
        $location = array();
        $location = $this->getObjects($critere);

        return $location;
    }

    /**
     * @param  Oledrion_parameters $parameters
     * @return array
     */
    public function getAllPid(Oledrion_parameters $parameters)
    {
        $parameters = $parameters->extend(new Oledrion_parameters(array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                                                                      'start' => 0,
                                                                      'limit' => 0,
                                                                      'sort'  => 'location_id',
                                                                      'order' => 'ASC'
                                                                  )));
        $critere    = new CriteriaCompo();
        $critere->add(new Criteria('location_type', 'parent'));
        $critere->setLimit($parameters['limit']);
        $critere->setStart($parameters['start']);
        $critere->setSort($parameters['sort']);
        $critere->setOrder($parameters['order']);
        $pid = array();
        $pid = $this->getObjects($critere);

        return $pid;
    }

    /**
     * @param $id
     * @return array
     */
    public function getLocation($id)
    {
        $critere = new CriteriaCompo();
        $critere->add(new Criteria('location_online', 1));
        $critere->add(new Criteria('location_type', 'location'));
        $critere->add(new Criteria('location_pid', $id));
        $location = array();
        $location = $this->getObjects($critere);

        return $location;
    }

    /**
     * @param $id
     * @return int
     */
    public function haveChild($id)
    {
        $critere = new CriteriaCompo();
        $critere->add(new Criteria('location_online', 1));
        $critere->add(new Criteria('location_type', 'location'));
        $critere->add(new Criteria('location_pid', $id));
        $location = $this->getCount($critere);

        return $location;
    }
}


1		<?php
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* oledrion
14		*
15		* @copyright {@link http://xoops.org/ XOOPS Project}
16		* @license {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
17		* @author Hossein Azizabadi ([email protected])
18		*/
19
20		require __DIR__ . '/classheader.php';
21
22		/**
23		* Class Oledrion_location
24		*/
25	View Code Duplication	class Oledrion_location extends Oledrion_Object
26		{
27		/**
28		* constructor
29		*
30		* normally, this is called from child classes only
31		*
32		* @access public
33		*/
34		public function __construct()
35		{
36		$this->initVar('location_id', XOBJ_DTYPE_INT, null, false);
37		$this->initVar('location_pid', XOBJ_DTYPE_INT, null, false);
38		$this->initVar('location_title', XOBJ_DTYPE_TXTBOX, null, false);
39		$this->initVar('location_online', XOBJ_DTYPE_INT, null, false);
40		$this->initVar('location_type', XOBJ_DTYPE_TXTBOX, null, false);
41		}
42
43		/**
44		* Retourne les éléments du produits formatés pour affichage
45		*
46		* @param string $format
47		* @return array
48		*/
49		public function toArray($format = 's')
50		{
51		$ret = array();
52		$ret = parent::toArray($format);
53
54		return $ret;
55		}
56		}
57
58		/**
59		* Class OledrionOledrion_locationHandler
60		*/
61		class OledrionOledrion_locationHandler extends Oledrion_XoopsPersistableObjectHandler
62		{
63		/**
64		* OledrionOledrion_locationHandler constructor.
65		* @param XoopsDatabase\|null $db
66		*/
67		public function __construct(XoopsDatabase $db)
68		{ // Table Classe Id
69		parent::__construct($db, 'oledrion_location', 'oledrion_location', 'location_id');
70		}
71
72		/**
73		* @param Oledrion_parameters $parameters
74		* @return array
75		*/
76	View Code Duplication	public function getAllLocation(Oledrion_parameters $parameters)
77		{
78		$parameters = $parameters->extend(new Oledrion_parameters(array(
		0 ignored issues – show Documentation introduced 2017-05-24 21:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Oledrion_parameters...id', 'order' => 'ASC'))` is of type `object<Oledrion_parameters>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
79		'start' => 0,
80		'limit' => 0,
81		'sort' => 'location_id',
82		'order' => 'ASC'
83		)));
84		$critere = new Criteria('location_id', 0, '<>');
85		$critere->setLimit($parameters['limit']);
86		$critere->setStart($parameters['start']);
87		$critere->setSort($parameters['sort']);
88		$critere->setOrder($parameters['order']);
89		$location = array();
90		$location = $this->getObjects($critere);
91
92		return $location;
93		}
94
95		/**
96		* @param Oledrion_parameters $parameters
97		* @return array
98		*/
99	View Code Duplication	public function getAllPid(Oledrion_parameters $parameters)
100		{
101		$parameters = $parameters->extend(new Oledrion_parameters(array(
		0 ignored issues – show Documentation introduced 2017-05-24 21:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Oledrion_parameters...id', 'order' => 'ASC'))` is of type `object<Oledrion_parameters>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
102		'start' => 0,
103		'limit' => 0,
104		'sort' => 'location_id',
105		'order' => 'ASC'
106		)));
107		$critere = new CriteriaCompo();
108		$critere->add(new Criteria('location_type', 'parent'));
109		$critere->setLimit($parameters['limit']);
110		$critere->setStart($parameters['start']);
111		$critere->setSort($parameters['sort']);
112		$critere->setOrder($parameters['order']);
113		$pid = array();
114		$pid = $this->getObjects($critere);
115
116		return $pid;
117		}
118
119		/**
120		* @param $id
121		* @return array
122		*/
123	View Code Duplication	public function getLocation($id)
124		{
125		$critere = new CriteriaCompo();
126		$critere->add(new Criteria('location_online', 1));
127		$critere->add(new Criteria('location_type', 'location'));
128		$critere->add(new Criteria('location_pid', $id));
129		$location = array();
130		$location = $this->getObjects($critere);
131
132		return $location;
133		}
134
135		/**
136		* @param $id
137		* @return int
138		*/
139	View Code Duplication	public function haveChild($id)
140		{
141		$critere = new CriteriaCompo();
142		$critere->add(new Criteria('location_online', 1));
143		$critere->add(new Criteria('location_type', 'location'));
144		$critere->add(new Criteria('location_pid', $id));
145		$location = $this->getCount($critere);
146
147		return $location;
148		}
149		}
150

XoopsModules25x / oledrion

Push — master ( 00e474...9d3fbd )

class/oledrion_location.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like