Issues in oledrion_cat.php - New Issues - Inspection of "Merge pull request #6 from mambax7/master" - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00e474...9d3fbd )

by Michael

created 2017-05-24 21:17 UTC

class/oledrion_cat.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 */

/**
 * Gestion des catégories de produits
 */

require __DIR__ . '/classheader.php';

/**
 * Class Oledrion_cat
 */
class Oledrion_cat extends Oledrion_Object
{
    /**
     * constructor
     *
     * normally, this is called from child classes only
     *
     * @access public
     */
    public function __construct()
    {
        $this->initVar('cat_cid', XOBJ_DTYPE_INT, null, false);
        $this->initVar('cat_pid', XOBJ_DTYPE_INT, null, false);
        $this->initVar('cat_title', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('cat_imgurl', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('cat_description', XOBJ_DTYPE_TXTAREA, null, false);
        $this->initVar('cat_advertisement', XOBJ_DTYPE_TXTAREA, null, false);
        $this->initVar('cat_metakeywords', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('cat_metadescription', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('cat_metatitle', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('cat_footer', XOBJ_DTYPE_TXTAREA, null, false);
        // Pour autoriser le html
        $this->initVar('dohtml', XOBJ_DTYPE_INT, 1, false);
    }

    /**
     * Retourne l'URL de l'image de la catégorie courante
     * @return string L'URL
     */
    public function getPictureUrl()
    {
        return OLEDRION_PICTURES_URL . '/' . $this->getVar('cat_imgurl');
    }

    /**
     * Retourne le chemin de l'image de la catégorie courante
     * @return string Le chemin
     */
    public function getPicturePath()
    {
        return OLEDRION_PICTURES_PATH . '/' . $this->getVar('cat_imgurl');
    }

    /**
     * Indique si l'image de la catégorie existe
     *
     * @return boolean Vrai si l'image existe sinon faux
     */
    public function pictureExists()
    {
        $return = false;
        if (xoops_trim($this->getVar('cat_imgurl')) != ''
            && file_exists(OLEDRION_PICTURES_PATH . '/' . $this->getVar('cat_imgurl'))
        ) {
            $return = true;
        }

        return $return;
    }

    /**
     * Supprime l'image associée à une catégorie
     * @return void
     */
    public function deletePicture()
    {
        if ($this->pictureExists()) {
            @unlink(OLEDRION_PICTURES_PATH . '/' . $this->getVar('cat_imgurl'));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        $this->setVar('cat_imgurl', '');
    }

    /**
     * Retourne l'url à utiliser pour accéder à la catégorie en tenant compte des préférences du module
     *
     * @return string L'url à utiliser
     */
    public function getLink()
    {
        include_once XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
        $url = '';
        if (Oledrion_utils::getModuleOption('urlrewriting') == 1) { // On utilise l'url rewriting
            $url = OLEDRION_URL . 'category-' . $this->getVar('cat_cid') . Oledrion_utils::makeSeoUrl($this->getVar('cat_title', 'n')) . '.html';
        } else { // Pas d'utilisation de l'url rewriting
            $url = OLEDRION_URL . 'category.php?cat_cid=' . $this->getVar('cat_cid');
        }

        return $url;
    }

    /**
     * Rentourne la chaine à envoyer dans une balise <a> pour l'attribut href
     *
     * @return string
     */
    public function getHrefTitle()
    {
        return Oledrion_utils::makeHrefTitle($this->getVar('cat_title'));
    }

    /**
     * Retourne les éléments du produits formatés pour affichage
     *
     * @param  string $format
     * @return array
     */
    public function toArray($format = 's')
    {
        $ret                     = array();
        $ret                     = parent::toArray($format);
        $ret['cat_full_imgurl']  = $this->getPictureUrl();
        $ret['cat_href_title']   = $this->getHrefTitle();
        $ret['cat_url_rewrited'] = $this->getLink();

        return $ret;
    }
}

/**
 * Class OledrionOledrion_catHandler
 */
class OledrionOledrion_catHandler extends Oledrion_XoopsPersistableObjectHandler
namespace YourVendor;

class YourClass { }
{
    /**
     * OledrionOledrion_catHandler constructor.
     * @param XoopsDatabase|null $db
     */
    public function __construct(XoopsDatabase $db)
    { //                        Table               Classe       Id       Libellé
        parent::__construct($db, 'oledrion_cat', 'oledrion_cat', 'cat_cid', 'cat_title');
    }

    /**
     * Renvoie (sous forme d'objets) la liste de toutes les catégories
     *
     * @param  Oledrion_parameters $parameters
     * @return array               Taleau d'objets (catégories)
     * @internal param int $start Indice de début de recherche
     * @internal param int $limit Nombre maximum d'enregsitrements à renvoyer
     * @internal param string $sort Champ à utiliser pour le tri
     * @internal param string $order Ordre du tire (asc ou desc)
     * @internal param bool $idaskey Indique s'il faut renvoyer un tableau dont la clé est l'identifiant de l'enregistrement
     */
    public function getAllCategories(Oledrion_parameters $parameters)
    {
        $parameters = $parameters->extend(new Oledrion_parameters(array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                                                                      'start'   => 0,
                                                                      'limit'   => 0,
                                                                      'sort'    => 'cat_title',
                                                                      'order'   => 'ASC',
                                                                      'idaskey' => true
                                                                  )));
        $critere    = new Criteria('cat_cid', 0, '<>');
        $critere->setLimit($parameters['limit']);
        $critere->setStart($parameters['start']);
        $critere->setSort($parameters['sort']);
        $critere->setOrder($parameters['order']);
        $categories = array();
        $categories = $this->getObjects($critere, $parameters['idaskey']);

        return $categories;
    }

    /**
     * Fonction interne pour faire une vue développée des catégories
     *
     * @param  string $fieldName
     * @param  string $key
     * @param  string $ret
     * @param  object $tree
     * @return string
     */
    private function _makeLi($fieldName, $key, &$ret, $tree)
    {
        if ($key > 0) {
            $ret .= '<li><a href="';
            $ret .= $tree[$key]['obj']->getLink() . '">' . $tree[$key]['obj']->getVar('cat_title') . '</a>';
        }
        if (isset($tree[$key]['child']) && !empty($tree[$key]['child'])) {
            $ret .= "\n<ul>\n";
            foreach ($tree[$key]['child'] as $childkey) {
                $this->_makeLi($fieldName, $childkey, $ret, $tree);
            }
            $ret .= "</ul>\n";
        }
        $ret .= "</li>\n";
    }

    /**
     * Make a menu from the categories list
     *
     * @param  string  $fieldName Name of the member variable from the node objects that should be used as the title for the options.
     * @param  integer $key       ID of the object to display as the root of select options
     * @return string  HTML select box
     */
    public function getUlMenu($fieldName, $key = 0)
    {
        include_once XOOPS_ROOT_PATH . '/class/tree.php';
        $items      = $this->getAllCategories(new Oledrion_parameters());
        $treeObject = new XoopsObjectTree($items, 'cat_cid', 'cat_pid');
        $tree       =& $treeObject->getTree();

        $ret = '';
        $this->_makeLi($fieldName, $key, $ret, $tree);
        if (xoops_trim($ret) != '') {
            $ret = substr($ret, 0, -6);
        }

        return $ret;
    }

    /**
     * Supprime une catégorie (et tout ce qui lui est relatif)
     *
     * @param  Oledrion_cat $category
     * @return boolean      Le résultat de la suppression
     */
    public function deleteCategory(Oledrion_cat $category)
    {
        global $xoopsModule;
        $category->deletePicture();
        xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'new_category', $category->getVar('cat_cid'));

        return $this->delete($category, true);
    }

    /**
     * Retourne le nombre de produits d'une ou de plusieurs catégories
     *
     * @param  integer $cat_cid    L'identifiant de la catégorie dont on veut récupérer le nombre de produits
     * @param  boolean $withNested Faut il inclure les sous-catégories ?
     * @return integer Le nombre de produits
     */
    public function getCategoryProductsCount($cat_cid, $withNested = true)
    {
        global $h_oledrion_products;
        $childsIDs   = array();
        $childsIDs[] = $cat_cid;

        if ($withNested) { // Recherche des sous catégories de cette catégorie
            $items = $childs = array();
            include_once XOOPS_ROOT_PATH . '/class/tree.php';
            $items  = $this->getAllCategories(new Oledrion_parameters());
            $mytree = new XoopsObjectTree($items, 'cat_cid', 'cat_pid');
            $childs = $mytree->getAllChild($cat_cid);
            if (count($childs) > 0) {
                foreach ($childs as $onechild) {
                    $childsIDs[] = $onechild->getVar('cat_cid');
                }
            }
        }

        return $h_oledrion_products->getCategoryProductsCount($childsIDs);
    }

    /**
     * Retourne des catégories selon leur ID
     *
     * @param  array $ids Les ID des catégories à retrouver
     * @return array Objets de type Oledrion_cat
     */
    public function getCategoriesFromIds($ids)
    {
        $ret = array();
        if (is_array($ids) && count($ids) > 0) {
            $criteria = new Criteria('cat_cid', '(' . implode(',', $ids) . ')', 'IN');
            $ret      = $this->getObjects($criteria, true, true, '*', false);
        }

        return $ret;
    }

    /**
     * Retourne la liste des catégories mères (sous forme d'un tableau d'objets)
     *
     * @return array Objets de type Oledrion_cat
     */
    public function getMotherCategories()
    {
        $ret      = array();
        $criteria = new Criteria('cat_pid', 0, '=');
        $criteria->setSort('cat_title');
        $ret = $this->getObjects($criteria);

        return $ret;
    }

    /**
     * Get category count
     *
     * @return int number of category
     */
    public function getCategoriesCount()
    {
        $criteria = new CriteriaCompo();

        return $this->getCount($criteria);
    }
}


1		<?php
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* oledrion
14		*
15		* @copyright {@link http://xoops.org/ XOOPS Project}
16		* @license {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
17		* @author Hervé Thouzard (http://www.herve-thouzard.com/)
18		*/
19
20		/**
21		* Gestion des catégories de produits
22		*/
23
24		require __DIR__ . '/classheader.php';
25
26		/**
27		* Class Oledrion_cat
28		*/
29		class Oledrion_cat extends Oledrion_Object
30		{
31		/**
32		* constructor
33		*
34		* normally, this is called from child classes only
35		*
36		* @access public
37		*/
38		public function __construct()
39		{
40		$this->initVar('cat_cid', XOBJ_DTYPE_INT, null, false);
41		$this->initVar('cat_pid', XOBJ_DTYPE_INT, null, false);
42		$this->initVar('cat_title', XOBJ_DTYPE_TXTBOX, null, false);
43		$this->initVar('cat_imgurl', XOBJ_DTYPE_TXTBOX, null, false);
44		$this->initVar('cat_description', XOBJ_DTYPE_TXTAREA, null, false);
45		$this->initVar('cat_advertisement', XOBJ_DTYPE_TXTAREA, null, false);
46		$this->initVar('cat_metakeywords', XOBJ_DTYPE_TXTBOX, null, false);
47		$this->initVar('cat_metadescription', XOBJ_DTYPE_TXTBOX, null, false);
48		$this->initVar('cat_metatitle', XOBJ_DTYPE_TXTBOX, null, false);
49		$this->initVar('cat_footer', XOBJ_DTYPE_TXTAREA, null, false);
50		// Pour autoriser le html
51		$this->initVar('dohtml', XOBJ_DTYPE_INT, 1, false);
52		}
53
54		/**
55		* Retourne l'URL de l'image de la catégorie courante
56		* @return string L'URL
57		*/
58		public function getPictureUrl()
59		{
60		return OLEDRION_PICTURES_URL . '/' . $this->getVar('cat_imgurl');
61		}
62
63		/**
64		* Retourne le chemin de l'image de la catégorie courante
65		* @return string Le chemin
66		*/
67		public function getPicturePath()
68		{
69		return OLEDRION_PICTURES_PATH . '/' . $this->getVar('cat_imgurl');
70		}
71
72		/**
73		* Indique si l'image de la catégorie existe
74		*
75		* @return boolean Vrai si l'image existe sinon faux
76		*/
77	View Code Duplication	public function pictureExists()
78		{
79		$return = false;
80		if (xoops_trim($this->getVar('cat_imgurl')) != ''
81		&& file_exists(OLEDRION_PICTURES_PATH . '/' . $this->getVar('cat_imgurl'))
82		) {
83		$return = true;
84		}
85
86		return $return;
87		}
88
89		/**
90		* Supprime l'image associée à une catégorie
91		* @return void
92		*/
93	View Code Duplication	public function deletePicture()
94		{
95		if ($this->pictureExists()) {
96		@unlink(OLEDRION_PICTURES_PATH . '/' . $this->getVar('cat_imgurl'));
		0 ignored issues – show Security Best Practice introduced 2017-05-24 21:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
97		}
98		$this->setVar('cat_imgurl', '');
99		}
100
101		/**
102		* Retourne l'url à utiliser pour accéder à la catégorie en tenant compte des préférences du module
103		*
104		* @return string L'url à utiliser
105		*/
106	View Code Duplication	public function getLink()
107		{
108		include_once XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
109		$url = '';
110		if (Oledrion_utils::getModuleOption('urlrewriting') == 1) { // On utilise l'url rewriting
111		$url = OLEDRION_URL . 'category-' . $this->getVar('cat_cid') . Oledrion_utils::makeSeoUrl($this->getVar('cat_title', 'n')) . '.html';
112		} else { // Pas d'utilisation de l'url rewriting
113		$url = OLEDRION_URL . 'category.php?cat_cid=' . $this->getVar('cat_cid');
114		}
115
116		return $url;
117		}
118
119		/**
120		* Rentourne la chaine à envoyer dans une balise <a> pour l'attribut href
121		*
122		* @return string
123		*/
124		public function getHrefTitle()
125		{
126		return Oledrion_utils::makeHrefTitle($this->getVar('cat_title'));
127		}
128
129		/**
130		* Retourne les éléments du produits formatés pour affichage
131		*
132		* @param string $format
133		* @return array
134		*/
135		public function toArray($format = 's')
136		{
137		$ret = array();
138		$ret = parent::toArray($format);
139		$ret['cat_full_imgurl'] = $this->getPictureUrl();
140		$ret['cat_href_title'] = $this->getHrefTitle();
141		$ret['cat_url_rewrited'] = $this->getLink();
142
143		return $ret;
144		}
145		}
146
147		/**
148		* Class OledrionOledrion_catHandler
149		*/
150		class OledrionOledrion_catHandler extends Oledrion_XoopsPersistableObjectHandler
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-16 17:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2016-01-16 17:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
151		{
152		/**
153		* OledrionOledrion_catHandler constructor.
154		* @param XoopsDatabase\|null $db
155		*/
156		public function __construct(XoopsDatabase $db)
157		{ // Table Classe Id Libellé
158		parent::__construct($db, 'oledrion_cat', 'oledrion_cat', 'cat_cid', 'cat_title');
159		}
160
161		/**
162		* Renvoie (sous forme d'objets) la liste de toutes les catégories
163		*
164		* @param Oledrion_parameters $parameters
165		* @return array Taleau d'objets (catégories)
166		* @internal param int $start Indice de début de recherche
167		* @internal param int $limit Nombre maximum d'enregsitrements à renvoyer
168		* @internal param string $sort Champ à utiliser pour le tri
169		* @internal param string $order Ordre du tire (asc ou desc)
170		* @internal param bool $idaskey Indique s'il faut renvoyer un tableau dont la clé est l'identifiant de l'enregistrement
171		*/
172		public function getAllCategories(Oledrion_parameters $parameters)
173		{
174		$parameters = $parameters->extend(new Oledrion_parameters(array(
		0 ignored issues – show Documentation introduced 2017-05-24 21:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Oledrion_parameters...C', 'idaskey' => true))` is of type `object<Oledrion_parameters>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
175		'start' => 0,
176		'limit' => 0,
177		'sort' => 'cat_title',
178		'order' => 'ASC',
179		'idaskey' => true
180		)));
181		$critere = new Criteria('cat_cid', 0, '<>');
182		$critere->setLimit($parameters['limit']);
183		$critere->setStart($parameters['start']);
184		$critere->setSort($parameters['sort']);
185		$critere->setOrder($parameters['order']);
186		$categories = array();
187		$categories = $this->getObjects($critere, $parameters['idaskey']);
188
189		return $categories;
190		}
191
192		/**
193		* Fonction interne pour faire une vue développée des catégories
194		*
195		* @param string $fieldName
196		* @param string $key
197		* @param string $ret
198		* @param object $tree
199		* @return string
200		*/
201		private function _makeLi($fieldName, $key, &$ret, $tree)
202		{
203		if ($key > 0) {
204		$ret .= '<li><a href="';
205		$ret .= $tree[$key]['obj']->getLink() . '">' . $tree[$key]['obj']->getVar('cat_title') . '</a>';
206		}
207		if (isset($tree[$key]['child']) && !empty($tree[$key]['child'])) {
208		$ret .= "\n<ul>\n";
209		foreach ($tree[$key]['child'] as $childkey) {
210		$this->_makeLi($fieldName, $childkey, $ret, $tree);
211		}
212		$ret .= "</ul>\n";
213		}
214		$ret .= "</li>\n";
215		}
216
217		/**
218		* Make a menu from the categories list
219		*
220		* @param string $fieldName Name of the member variable from the node objects that should be used as the title for the options.
221		* @param integer $key ID of the object to display as the root of select options
222		* @return string HTML select box
223		*/
224		public function getUlMenu($fieldName, $key = 0)
225		{
226		include_once XOOPS_ROOT_PATH . '/class/tree.php';
227		$items = $this->getAllCategories(new Oledrion_parameters());
228		$treeObject = new XoopsObjectTree($items, 'cat_cid', 'cat_pid');
229		$tree =& $treeObject->getTree();
230
231		$ret = '';
232		$this->_makeLi($fieldName, $key, $ret, $tree);
233		if (xoops_trim($ret) != '') {
234		$ret = substr($ret, 0, -6);
235		}
236
237		return $ret;
238		}
239
240		/**
241		* Supprime une catégorie (et tout ce qui lui est relatif)
242		*
243		* @param Oledrion_cat $category
244		* @return boolean Le résultat de la suppression
245		*/
246		public function deleteCategory(Oledrion_cat $category)
247		{
248		global $xoopsModule;
249		$category->deletePicture();
250		xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'new_category', $category->getVar('cat_cid'));
251
252		return $this->delete($category, true);
253		}
254
255		/**
256		* Retourne le nombre de produits d'une ou de plusieurs catégories
257		*
258		* @param integer $cat_cid L'identifiant de la catégorie dont on veut récupérer le nombre de produits
259		* @param boolean $withNested Faut il inclure les sous-catégories ?
260		* @return integer Le nombre de produits
261		*/
262		public function getCategoryProductsCount($cat_cid, $withNested = true)
263		{
264		global $h_oledrion_products;
265		$childsIDs = array();
266		$childsIDs[] = $cat_cid;
267
268		if ($withNested) { // Recherche des sous catégories de cette catégorie
269		$items = $childs = array();
270		include_once XOOPS_ROOT_PATH . '/class/tree.php';
271		$items = $this->getAllCategories(new Oledrion_parameters());
272		$mytree = new XoopsObjectTree($items, 'cat_cid', 'cat_pid');
273		$childs = $mytree->getAllChild($cat_cid);
274		if (count($childs) > 0) {
275		foreach ($childs as $onechild) {
276		$childsIDs[] = $onechild->getVar('cat_cid');
277		}
278		}
279		}
280
281		return $h_oledrion_products->getCategoryProductsCount($childsIDs);
282		}
283
284		/**
285		* Retourne des catégories selon leur ID
286		*
287		* @param array $ids Les ID des catégories à retrouver
288		* @return array Objets de type Oledrion_cat
289		*/
290	View Code Duplication	public function getCategoriesFromIds($ids)
291		{
292		$ret = array();
293		if (is_array($ids) && count($ids) > 0) {
294		$criteria = new Criteria('cat_cid', '(' . implode(',', $ids) . ')', 'IN');
295		$ret = $this->getObjects($criteria, true, true, '*', false);
296		}
297
298		return $ret;
299		}
300
301		/**
302		* Retourne la liste des catégories mères (sous forme d'un tableau d'objets)
303		*
304		* @return array Objets de type Oledrion_cat
305		*/
306		public function getMotherCategories()
307		{
308		$ret = array();
309		$criteria = new Criteria('cat_pid', 0, '=');
310		$criteria->setSort('cat_title');
311		$ret = $this->getObjects($criteria);
312
313		return $ret;
314		}
315
316		/**
317		* Get category count
318		*
319		* @return int number of category
320		*/
321		public function getCategoriesCount()
322		{
323		$criteria = new CriteriaCompo();
324
325		return $this->getCount($criteria);
326		}
327		}
328

XoopsModules25x / oledrion

Push — master ( 00e474...9d3fbd )

class/oledrion_cat.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like