Issues in oledrion_random_lists.php - New Issues - Inspection of "Merge pull request #6 from mambax7/master" - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00e474...9d3fbd )

by Michael

created 2017-05-24 21:17 UTC

blocks/oledrion_random_lists.php (1 issue)

Labels

Documentation 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 */

/**
 * Affichage des listes au hasard
 *
 * @param  array $options [0] = Nombre maximum de listes à voir, [1] = Type de listes (0 = les 2, 1 = liste cadeaux, 2 = produits recommandés)
 * @return array
 */
function b_oledrion_random_lists_show($options)
{
    require XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
    Oledrion_utils::loadLanguageFile('main.php');
    $start    = 0;
    $limit    = (int)$options[0];
    $listType = (int)$options[1];
    $block    = array();
    $handlers = OledrionHandler::getInstance();
    $items    = array();
    //$items = $handlers->h_oledrion_lists->getRecentLists(new Oledrion_parameters(array('start' => $start, 'limit' => $limit, 'sort' => 'RAND()', 'order' => 'DESC', 'idAsKey' => true, 'listType' => $listType)));
    $items = $handlers->h_oledrion_lists->getRecentLists(new Oledrion_parameters(array(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                                                                     'start'    => $start,
                                                                                     'limit'    => $limit,
                                                                                     'sort'     => 'RAND()',
                                                                                     'order'    => 'DESC',
                                                                                     'idAsKey'  => true,
                                                                                     'listType' => OLEDRION_LISTS_ALL_PUBLIC
                                                                                 )));
    if (count($items) > 0) {
        foreach ($items as $item) {
            $block['random_lists'][] = $item->toArray();
        }
    }

    return $block;
}

/**
 * Edition des paramètres du bloc
 *
 * @param  array $options [0] = Nombre maximum de listes à voir, [1] = Type de listes (0 = les 2, 1 = liste cadeaux, 2 = produits recommandés)
 * @return array
 */
function b_oledrion_random_lists_edit($options)
{
    include XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
    $form = '';
    $form .= "<table border='0'>";
    $form .= '<tr><td>' . _MB_OLEDRION_LISTS_COUNT . "</td><td><input type='text' name='options[]' id='options' value='" . (int)$options[0] . "' /></td></tr>";
    $listTypes      = Oledrion_lists::getTypesArray();
    $listTypeSelect = Oledrion_utils::htmlSelect('options[]', $listTypes, (int)$options[1], false);
    $form .= '<tr><td>' . _MB_OLEDRION_LISTS_TYPE . '</td><td>' . $listTypeSelect . '</td></tr>';
    $form .= '</table>';

    return $form;
}

/**
 * Bloc à la volée
 * @param $options
 */
function b_oledrion_random_lists_duplicatable($options)
{
    $options = explode('|', $options);
    $block   = b_oledrion_random_lists_show($options);

    $tpl = new XoopsTpl();
    $tpl->assign('block', $block);
    $tpl->display('db:oledrion_block_random_lists.tpl');
}


1		<?php
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* oledrion
14		*
15		* @copyright {@link http://xoops.org/ XOOPS Project}
16		* @license {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
17		* @author Hervé Thouzard (http://www.herve-thouzard.com/)
18		*/
19
20		/**
21		* Affichage des listes au hasard
22		*
23		* @param array $options [0] = Nombre maximum de listes à voir, [1] = Type de listes (0 = les 2, 1 = liste cadeaux, 2 = produits recommandés)
24		* @return array
25		*/
26	View Code Duplication	function b_oledrion_random_lists_show($options)
27		{
28		require XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
29		Oledrion_utils::loadLanguageFile('main.php');
30		$start = 0;
31		$limit = (int)$options[0];
32		$listType = (int)$options[1];
33		$block = array();
34		$handlers = OledrionHandler::getInstance();
35		$items = array();
36		//$items = $handlers->h_oledrion_lists->getRecentLists(new Oledrion_parameters(array('start' => $start, 'limit' => $limit, 'sort' => 'RAND()', 'order' => 'DESC', 'idAsKey' => true, 'listType' => $listType)));
37		$items = $handlers->h_oledrion_lists->getRecentLists(new Oledrion_parameters(array(
		0 ignored issues – show Documentation introduced 2017-05-24 21:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `h_oledrion_lists` does not exist on `object<OledrionHandler>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38		'start' => $start,
39		'limit' => $limit,
40		'sort' => 'RAND()',
41		'order' => 'DESC',
42		'idAsKey' => true,
43		'listType' => OLEDRION_LISTS_ALL_PUBLIC
44		)));
45		if (count($items) > 0) {
46		foreach ($items as $item) {
47		$block['random_lists'][] = $item->toArray();
48		}
49		}
50
51		return $block;
52		}
53
54		/**
55		* Edition des paramètres du bloc
56		*
57		* @param array $options [0] = Nombre maximum de listes à voir, [1] = Type de listes (0 = les 2, 1 = liste cadeaux, 2 = produits recommandés)
58		* @return array
59		*/
60	View Code Duplication	function b_oledrion_random_lists_edit($options)
61		{
62		include XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
63		$form = '';
64		$form .= "<table border='0'>";
65		$form .= '<tr><td>' . _MB_OLEDRION_LISTS_COUNT . "</td><td><input type='text' name='options[]' id='options' value='" . (int)$options[0] . "' /></td></tr>";
66		$listTypes = Oledrion_lists::getTypesArray();
67		$listTypeSelect = Oledrion_utils::htmlSelect('options[]', $listTypes, (int)$options[1], false);
68		$form .= '<tr><td>' . _MB_OLEDRION_LISTS_TYPE . '</td><td>' . $listTypeSelect . '</td></tr>';
69		$form .= '</table>';
70
71		return $form;
72		}
73
74		/**
75		* Bloc à la volée
76		* @param $options
77		*/
78	View Code Duplication	function b_oledrion_random_lists_duplicatable($options)
79		{
80		$options = explode('\|', $options);
81		$block = b_oledrion_random_lists_show($options);
82
83		$tpl = new XoopsTpl();
84		$tpl->assign('block', $block);
85		$tpl->display('db:oledrion_block_random_lists.tpl');
86		}
87

XoopsModules25x / oledrion

Push — master ( 00e474...9d3fbd )

blocks/oledrion_random_lists.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like