comment_functions.php ➔ oledrion_com_approve() - Code Metrics - Inspection of "Merge pull request #6 from mambax7/master" - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00e474...9d3fbd )

by Michael

created 2017-05-24 21:17 UTC

comment_functions.php ➔ oledrion_com_approve() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 * @param $product_id
 * @param $total_num
 */

// defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');


function oledrion_com_update($product_id, $total_num)
{
    include XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
    global $h_oledrion_products;
function myFunction($a, $b) {
    // Do something
}
    if (!is_object($h_oledrion_products)) {
        $handlers            = OledrionHandler::getInstance();
        $h_oledrion_products = $handlers->oledrion_products;

    }
    $h_oledrion_products->updateCommentsCount($product_id, $total_num);
}

/**
 * @param $comment
 */
function oledrion_com_approve(&$comment)

{
    // notification mail here
}


Push — master ( 00e474...9d3fbd )

comment_functions.php ➔ oledrion_com_approve() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* oledrion
14			*
15			* @copyright {@link http://xoops.org/ XOOPS Project}
16			* @license {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
17			* @author Hervé Thouzard (http://www.herve-thouzard.com/)
18			* @param $product_id
19			* @param $total_num
20			*/
21
22			// defined('XOOPS_ROOT_PATH') \|\| exit('XOOPS root path not defined');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 21:21 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
23
24			function oledrion_com_update($product_id, $total_num)
25			{
26			include XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
27			global $h_oledrion_products;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
28			if (!is_object($h_oledrion_products)) {
29			$handlers = OledrionHandler::getInstance();
30			$h_oledrion_products = $handlers->oledrion_products;
			0 ignored issues – show Bug introduced 2017-05-24 21:21 UTC by Report Bug Copy Issue Report The property `oledrion_products` does not seem to exist in `OledrionHandler`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
31			}
32			$h_oledrion_products->updateCommentsCount($product_id, $total_num);
33			}
34
35			/**
36			* @param $comment
37			*/
38			function oledrion_com_approve(&$comment)
			0 ignored issues – show Unused Code introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report The parameter `$comment` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
39			{
40			// notification mail here
41			}
42

XoopsModules25x / oledrion

Push — master ( 00e474...9d3fbd )

comment_functions.php ➔ oledrion_com_approve() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like