Oledrion_shelf::getProducts() - Code Metrics - Inspection of "Merge pull request #6 from mambax7/master" - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 00e474...9d3fbd )

by Michael
created 2017-05-24 21:17 UTC
Oledrion_shelf::getProducts() F

↳ Parent: Oledrion_shelf
Complexity

Conditions	34
Paths	> 20000
Size

Total Lines	210
Code Lines	148
Duplication

Lines	18
Ratio	8.57 %
Importance

Changes
Metric	Value
cc	34
eloc	148
nc	272077
nop	1
dl	18
loc	210
rs	2
c	0
b	0
f	0
How to fix Long Method Complexity

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 */

/**
 * Facade pour les produits
 */
// defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');


class Oledrion_shelf
namespace YourVendor;

class YourClass { }
{
    private $handlers;

    /**
     * Oledrion_shelf constructor.
     */
    public function __construct()
    {
        $this->initHandlers();
    }

    /**
     * Chargement des handlers
     */
    private function initHandlers()
    {
        $this->handlers = OledrionHandler::getInstance();
    }

    /**
     * Retourne le nombre de produits d'un certain type
     *
     * @param  string $type Le type de produits dont on veut récupérer le nombre
     * @param  int    $category
     * @param  int    $excluded
     * @return int
     */
    public function getProductsCount($type = 'recent', $category = 0, $excluded = 0)
    {
        switch (strtolower($type)) {
            case 'recent':
                return $this->handlers->h_oledrion_products->getRecentProductsCount($category, $excluded);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }

        return 0;
    }

    /**
     * Supprime un produit (et tout ce qui lui est relatif)
     * @param oledrion_products $product
     */
    public function deleteProduct(Oledrion_products $product)

    {
        global $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
        $id = $product->getVar('product_id');

        // On commence par supprimer les commentaires
        $mid = $xoopsModule->getVar('mid');
        xoops_comment_delete($mid, $id);

        // Puis les votes
        $this->handlers->h_oledrion_votedata->deleteProductRatings($id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Puis les produits relatifs
        $this->handlers->h_oledrion_related->deleteProductRelatedProducts($id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Les images (la grande et la miniature)
        $product->deletePictures();

        // Le fichier attaché
        $product->deleteAttachment();

        // Les fichiers attachés
        $this->handlers->h_oledrion_files->deleteProductFiles($id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Suppression dans les paniers persistants enregistrés
        $this->handlers->h_oledrion_persistent_cart->deleteProductForAllCarts($id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Les attributs qui lui sont rattachés
        $this->handlers->h_oledrion_attributes->deleteProductAttributes($id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Le produit dans les listes
        $this->handlers->h_oledrion_products_list->deleteProductFromLists($id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // La relation entre le produit et le fabricant
        $this->handlers->h_oledrion_productsmanu->removeManufacturerProduct($id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Le produit dans les remises
        $this->handlers->h_oledrion_discounts->removeProductFromDiscounts($id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Et le produit en lui même, à la fin
        return $this->handlers->h_oledrion_products->delete($product, true);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Cherche et retourne la liste de produits relatifs à une liste de produits
     *
     * @param  array $productsIds La liste des produits dont on cherche les produits relatifs
     * @return array Clé = ID Produit, valeurs (deuxième dimension) = liste des produits relatifs
     */
    private function getRelatedProductsFromProductsIds($productsIds)
    {
        $relatedProducts = $relatedProductsIds = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (is_array($productsIds) && count($productsIds) > 0) {
            $relatedProductsIds = $this->handlers->h_oledrion_related->getRelatedProductsFromProductsIds($productsIds);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if (count($relatedProductsIds) > 0) {
                $tmp = array();
                foreach ($relatedProductsIds as $relatedProductId) {
                    $tmp[] = $relatedProductId->getVar('related_product_related');
                }
                $tmp = array_unique($tmp);
                sort($tmp);
                if (count($tmp) > 0) {
                    $tempRelatedProducts = $this->handlers->h_oledrion_products->getProductsFromIDs($tmp);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    foreach ($relatedProductsIds as $relatedProductId) {
                        if (isset($tempRelatedProducts[$relatedProductId->getVar('related_product_related')])) {
                            $relatedProducts[$relatedProductId->getVar('related_product_id')][] = $tempRelatedProducts[$relatedProductId->getVar('related_product_related')];
                        }
                    }
                }
            }
        }

        return $relatedProducts;
    }

    /**
     * Retourne une liste de produits selon certains critères
     *
     * @param  oledrion_shelf_parameters $parameters Les paramètres de filtrage
     * @return array                     Tableau prêt à être utilisé dans les templates
     */
    public function getProducts(Oledrion_shelf_parameters $parameters)
    {
        global $vatArray;
function myFunction($a, $b) {
    // Do something
}
        $parametersValues    = $parameters->getParameters();
        $productType         = $parametersValues['productsType'];
        $start               = $parametersValues['start'];
        $limit               = $parametersValues['limit'];
        $category            = $parametersValues['category'];
        $sort                = $parametersValues['sort'];
        $order               = $parametersValues['order'];
        $excluded            = $parametersValues['excluded'];
        $withXoopsUser       = $parametersValues['withXoopsUser'];
        $withRelatedProducts = $parametersValues['withRelatedProducts'];
        $withQuantity        = $parametersValues['withQuantity'];
        $thisMonthOnly       = $parametersValues['thisMonthOnly'];
        $ret                 = $xoopsUsersIDs = $users = $relatedProducts = $productsManufacturers = $manufacturersPerProduct = $products = $productsIds = $categoriesIds = $vendorsIds = $manufacturersIds = $manufacturers = $categories = $vendors = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        // On commence par récupérer la liste des produits
        switch (strtolower($productType)) {
            case 'recent':
                $products = $this->handlers->h_oledrion_products->getRecentProducts(new Oledrion_parameters(array(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                                                                                                'start'         => $start,
                                                                                                                'limit'         => $limit,
                                                                                                                'category'      => $category,
                                                                                                                'sort'          => $sort,
                                                                                                                'order'         => $order,
                                                                                                                'excluded'      => $excluded,
                                                                                                                'thisMonthOnly' => $thisMonthOnly
                                                                                                            )));
                break;

            case 'mostsold':
                $tempProductsIds = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $tempProductsIds = $this->handlers->h_oledrion_caddy->getMostSoldProducts($start, $limit, $category, $withQuantity);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                if (count($tempProductsIds) > 0) {
                    $products = $this->handlers->h_oledrion_products->getProductsFromIDs(array_keys($tempProductsIds));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                }
                break;

            case 'recentlysold':
                $tempProductsIds = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $tempProductsIds = $this->handlers->h_oledrion_caddy->getRecentlySoldProducts($start, $limit);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                if (count($tempProductsIds) > 0) {
                    $tempProductsIds = array_unique($tempProductsIds);
                }
                if (count($tempProductsIds) > 0) {
                    $products = $this->handlers->h_oledrion_products->getProductsFromIDs(array_keys($tempProductsIds));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                }
                break;

            case 'mostviewed':

                $products = $this->handlers->h_oledrion_products->getMostViewedProducts(new Oledrion_parameters(array(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                                                                                                    'start'    => $start,
                                                                                                                    'limit'    => $limit,
                                                                                                                    'category' => $category,
                                                                                                                    'sort'     => $sort,
                                                                                                                    'order'    => $order
                                                                                                                )));
                break;

            case 'bestrated':

                $products = $this->handlers->h_oledrion_products->getBestRatedProducts(new Oledrion_parameters(array(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                                                                                                   'start'    => $start,
                                                                                                                   'limit'    => $limit,
                                                                                                                   'category' => $category,
                                                                                                                   'sort'     => $sort,
                                                                                                                   'order'    => $order
                                                                                                               )));
                break;

            case 'recommended':

                $products = $this->handlers->h_oledrion_products->getRecentRecommended(new Oledrion_parameters(array(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                                                                                                   'start'    => $start,
                                                                                                                   'limit'    => $limit,
                                                                                                                   'category' => $category,
                                                                                                                   'sort'     => $sort,
                                                                                                                   'order'    => $order
                                                                                                               )));
                break;

            case 'promotional':

                $products = $this->handlers->h_oledrion_products->getPromotionalProducts(new Oledrion_parameters(array(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                                                                                                     'start'    => $start,
                                                                                                                     'limit'    => $limit,
                                                                                                                     'category' => $category,
                                                                                                                     'sort'     => $sort,
                                                                                                                     'order'    => $order
                                                                                                                 )));
                break;

            case 'random':

                $products = $this->handlers->h_oledrion_products->getRandomProducts(new Oledrion_parameters(array(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                                                                                                'start'         => $start,
                                                                                                                'limit'         => $limit,
                                                                                                                'category'      => $category,
                                                                                                                'sort'          => $sort,
                                                                                                                'order'         => $order,
                                                                                                                'thisMonthOnly' => $thisMonthOnly
                                                                                                            )));
        }

        if (count($products) > 0) {
            $productsIds = array_keys($products);
        } else {
            return $ret;
        }

        // Recherche des Id des catégories et des vendeurs
        foreach ($products as $product) {
            $categoriesIds[] = $product->getVar('product_cid');
            $vendorsIds[]    = $product->getVar('product_vendor_id');
            if ($withXoopsUser) {
                $xoopsUsersIDs[] = $product->getVar('product_submitter');
            }
        }

        $productsManufacturers = $this->handlers->h_oledrion_productsmanu->getFromProductsIds($productsIds);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        // Regroupement des fabricants par produit
        foreach ($productsManufacturers as $item) {

            $manufacturersIds[]                                        = $item->getVar('pm_manu_id');
            $manufacturersPerProduct[$item->getVar('pm_product_id')][] = $item;
        }
        // On récupère la liste des personnes qui ont soumis les produits
        if ($withXoopsUser) {
            $users = Oledrion_utils::getUsersFromIds($xoopsUsersIDs);
        }

        // Il faut récupérer la liste des produits relatifs
        if ($withRelatedProducts) {
            $relatedProducts = $this->getRelatedProductsFromProductsIds($productsIds);
        }

        $categoriesIds = array_unique($categoriesIds);
        sort($categoriesIds);

        $vendorsIds = array_unique($vendorsIds);
        sort($vendorsIds);

        $manufacturersIds = array_unique($manufacturersIds);
        sort($manufacturersIds);

        // Récupération des fabricants, des vendeurs et des catégories
        if (count($manufacturersIds) > 0) {
            $manufacturers = $this->handlers->h_oledrion_manufacturer->getManufacturersFromIds($manufacturersIds);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        if (count($categoriesIds) > 0) {
            $categories = $this->handlers->h_oledrion_cat->getCategoriesFromIds($categoriesIds);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        if (count($vendorsIds) > 0) {
            $vendors = $this->handlers->h_oledrion_vendors->getVendorsFromIds($vendorsIds);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        $count     = 1;
        $lastTitle = '';
        foreach ($products as $product) {
            $tmp       = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $tmp       = $product->toArray();
            $lastTitle = $product->getVar('product_title');
            // Le vendeur
            if (isset($vendors[$product->getVar('product_vendor_id')])) {
                $tmp['product_vendor'] = $vendors[$product->getVar('product_vendor_id')]->toArray();
            }
            // La catégorie
            if (isset($categories[$product->getVar('product_cid')])) {
                $tmp['product_category'] = $categories[$product->getVar('product_cid')]->toArray();
            }
            // Les produits relatifs
            if ($withRelatedProducts) {
                if (isset($relatedProducts[$product->getVar('product_id')])) {
                    $productsRelatedToThisOne = $relatedProducts[$product->getVar('product_id')];
                    foreach ($productsRelatedToThisOne as $oneRelatedProdut) {
                        $tmp['product_related_products'][] = $oneRelatedProdut->toArray();
                    }
                }
            }
            // Les fabricants du produit
            if (isset($manufacturersPerProduct[$product->getVar('product_id')])) {
                $productManufacturers = $manufacturersPerProduct[$product->getVar('product_id')];
                $tmpManufacturersList = array();
                foreach ($productManufacturers as $productManufacturer) {
                    if (isset($manufacturers[$productManufacturer->getVar('pm_manu_id')])) {
                        $manufacturer                   = $manufacturers[$productManufacturer->getVar('pm_manu_id')];
                        $tmp['product_manufacturers'][] = $manufacturer->toArray();
                        $tmpManufacturersList[]         = $manufacturer->getVar('manu_commercialname') . ' ' . $manufacturer->getVar('manu_name');
                    }
                }
                if (count($tmpManufacturersList) > 0) {
                    $tmp['product_joined_manufacturers'] = implode(OLEDRION_STRING_TO_JOIN_MANUFACTURERS, $tmpManufacturersList);
                }
            }

            // L'utilisateur Xoops (éventuellement)
            if ($withXoopsUser && isset($users[$product->getVar('product_submitter')])) {
                $thisUser = $users[$product->getVar('product_submitter')];
                if (xoops_trim($thisUser->getVar('name')) != '') {
                    $name = $thisUser->getVar('name');
                } else {
                    $name = $thisUser->getVar('uname');
                }
                $tmp['product_submiter_name'] = $name;
                $userLink                     = '<a href="' . XOOPS_URL . '/userinfo.php?uid=' . $thisUser->getVar('uid') . '">' . $name . '</a>';
                $tmp['product_submiter_link'] = $userLink;
            }
            $tmp['product_count'] = $count; // Compteur pour les templates (pour gérer les colonnes)
            $ret[]                = $tmp;
            ++$count;
        }
        $ret['lastTitle'] = $lastTitle;

        return $ret;
    }
}

Push — master ( 00e474...9d3fbd )

Oledrion_shelf::getProducts() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* oledrion
14			*
15			* @copyright {@link http://xoops.org/ XOOPS Project}
16			* @license {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
17			* @author Hervé Thouzard (http://www.herve-thouzard.com/)
18			*/
19
20			/**
21			* Facade pour les produits
22			*/
23			// defined('XOOPS_ROOT_PATH') \|\| exit('XOOPS root path not defined');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 21:21 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
24
25			class Oledrion_shelf
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
26			{
27			private $handlers;
28
29			/**
30			* Oledrion_shelf constructor.
31			*/
32			public function __construct()
33			{
34			$this->initHandlers();
35			}
36
37			/**
38			* Chargement des handlers
XoopsModules25x / oledrion

Push — master ( 00e474...9d3fbd )

Oledrion_shelf::getProducts() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
