OledrionOledrion_deliveryHandler::getThisLocationThisDelivery() - Code Metrics - Inspection of "Merge pull request #6 from mambax7/master" - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00e474...9d3fbd )

by Michael

created 2017-05-24 21:17 UTC

getThisLocationThisDelivery() A

↳ Parent: OledrionOledrion_deliveryHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	2
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0

<?php

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hossein Azizabadi ([email protected])
 */

require __DIR__ . '/classheader.php';

/**
 * Class Oledrion_delivery
 */
class Oledrion_delivery extends Oledrion_Object
namespace YourVendor;

class YourClass { }
{
    /**
     * constructor
     *
     * normally, this is called from child classes only
     *
     * @access public
     */
    public function __construct()
    {
        $this->initVar('delivery_id', XOBJ_DTYPE_INT, null, false);
        $this->initVar('delivery_title', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('delivery_description', XOBJ_DTYPE_TXTAREA, null, false);
        $this->initVar('delivery_online', XOBJ_DTYPE_INT, null, false);
        $this->initVar('delivery_image', XOBJ_DTYPE_TXTBOX, null, false);

        $this->initVar('dohtml', XOBJ_DTYPE_INT, 1, false);
    }

    /**
     * Retourne l'URL de l'image de la catégorie courante
     * @return string L'URL
     */
    public function getPictureUrl()

    {
        if (xoops_trim($this->getVar('product_image_url')) != '') {
            return OLEDRION_PICTURES_URL . '/' . $this->getVar('delivery_image');
        } else {
            return '';
        }
    }

    /**
     * Indique si l'image de la catégorie existe
     *
     * @return boolean Vrai si l'image existe sinon faux
     */
    public function pictureExists()

    {
        $return = false;
        if (xoops_trim($this->getVar('delivery_image')) != ''
            && file_exists(OLEDRION_PICTURES_PATH . '/' . $this->getVar('delivery_image'))
        ) {
            $return = true;
        }

        return $return;
    }

    /**
     * Supprime l'image associée à une catégorie
     * @return void
     */
    public function deletePicture()

    {
        if ($this->pictureExists()) {
            @unlink(OLEDRION_PICTURES_PATH . '/' . $this->getVar('delivery_image'));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        $this->setVar('delivery_image', '');
    }

    /**
     * Retourne les éléments du produits formatés pour affichage
     *
     * @param  string $format
     * @return array
     */
    public function toArray($format = 's')

    {
        global $h_oledrion_location_delivery;
function myFunction($a, $b) {
    // Do something
}
        $ret                       = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $ret                       = parent::toArray($format);
        $ret['delivery_image_url'] = $this->getPictureUrl();

        return $ret;
    }
}

/**
 * Class OledrionOledrion_deliveryHandler
 */
class OledrionOledrion_deliveryHandler extends Oledrion_XoopsPersistableObjectHandler
namespace YourVendor;

class YourClass { }
{
    /**
     * OledrionOledrion_deliveryHandler constructor.
     * @param XoopsDatabase|null $db
     */
    public function __construct(XoopsDatabase $db)
    { //                                        Table                   Classe              Id
        parent::__construct($db, 'oledrion_delivery', 'oledrion_delivery', 'delivery_id');
    }

    /**
     * @param  Oledrion_parameters $parameters
     * @return array
     */
    public function getAllDelivery(Oledrion_parameters $parameters)

    {
        $parameters = $parameters->extend(new Oledrion_parameters(array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                                                                      'start' => 0,
                                                                      'limit' => 0,
                                                                      'sort'  => 'delivery_id',
                                                                      'order' => 'ASC'
                                                                  )));
        $critere    = new Criteria('delivery_id', 0, '<>');
        $critere->setLimit($parameters['limit']);
        $critere->setStart($parameters['start']);
        $critere->setSort($parameters['sort']);
        $critere->setOrder($parameters['order']);
        $categories = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $categories = $this->getObjects($critere);

        return $categories;
    }

    /**
     * @param  Oledrion_parameters $parameters
     * @return array
     */
    public function getLocationDelivery(Oledrion_parameters $parameters)
    {
        global $h_oledrion_location_delivery;
function myFunction($a, $b) {
    // Do something
}
        $ret               = array();
        $parameters        = $parameters->extend(new Oledrion_parameters(array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                                                                             'start'    => 0,
                                                                             'limit'    => 0,
                                                                             'sort'     => 'delivery_id',
                                                                             'order'    => 'ASC',
                                                                             'location' => ''
                                                                         )));
        $location_delivery = $h_oledrion_location_delivery->getLocationDeliveryId($parameters);

        $critere = new CriteriaCompo();
        $critere->setLimit($parameters['limit']);
        $critere->setStart($parameters['start']);
        $critere->setSort($parameters['sort']);
        $critere->setOrder($parameters['order']);
        $obj = $this->getObjects($critere);
        if ($obj) {

            foreach ($obj as $root) {
                $tab = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $tab = $root->toArray();
                if (isset($location_delivery[$root->getVar('delivery_id')]['ld_delivery'])
                    && $location_delivery[$root->getVar('delivery_id')]['ld_delivery'] == $root->getVar('delivery_id')
                ) {
                    $tab['ld_id']['delivery_select']  = 1;
                    $tab['ld_id']['ld_id']            = $location_delivery[$root->getVar('delivery_id')]['ld_id'];
                    $tab['ld_id']['ld_location']      = $location_delivery[$root->getVar('delivery_id')]['ld_location'];
                    $tab['ld_id']['ld_delivery']      = $location_delivery[$root->getVar('delivery_id')]['ld_delivery'];
                    $tab['ld_id']['ld_price']         = $location_delivery[$root->getVar('delivery_id')]['ld_price'];
                    $tab['ld_id']['ld_delivery_time'] = $location_delivery[$root->getVar('delivery_id')]['ld_delivery_time'];
                }
                $ret[] = $tab;
            }
        }

        return $ret;
    }

    /**
     * @param $location_id
     * @return array
     */
    public function getThisLocationDelivery($location_id)
    {
        global $h_oledrion_location_delivery;
function myFunction($a, $b) {
    // Do something
}
        $oledrion_Currency = Oledrion_Currency::getInstance();
        $ret               = array();
        $parameters        = array('location' => $location_id);
        $location_delivery = $h_oledrion_location_delivery->getLocationDeliveryId($parameters);
        foreach ($location_delivery as $location) {
            $id[] = $location['ld_delivery'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        $critere = new CriteriaCompo();
        $critere->add(new Criteria('delivery_id', '(' . implode(',', $id) . ')', 'IN'));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $critere->add(new Criteria('delivery_online', 1));
        $obj = $this->getObjects($critere);
        if ($obj) {

            foreach ($obj as $root) {
                $tab                              = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $tab                              = $root->toArray();
                $tab['delivery_price']            = $location_delivery[$root->getVar('delivery_id')]['ld_price'];
                $tab['delivery_price_fordisplay'] = $oledrion_Currency->amountForDisplay($tab['delivery_price']);
                $tab['delivery_time']             = $location_delivery[$root->getVar('delivery_id')]['ld_delivery_time'];
                $ret[]                            = $tab;
            }
        }

        return $ret;
    }

    /**
     * @param $location_id
     * @param $delivery_id
     * @return array
     */
    public function getThisLocationThisDelivery($location_id, $delivery_id)
    {
        global $h_oledrion_location_delivery;
function myFunction($a, $b) {
    // Do something
}
        $location_delivery     = $h_oledrion_location_delivery->getDelivery($location_id, $delivery_id);
        $ret                   = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $obj                   = $this->get($location_id);
        $ret                   = $obj->toArray();
        $ret['delivery_price'] = $location_delivery['ld_price'];
        $ret['delivery_time']  = $location_delivery['ld_delivery_time'];

        return $ret;
    }
}


Push — master ( 00e474...9d3fbd )

getThisLocationThisDelivery() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-06-01 04:06 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 25 and the first side effect is on line 20. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* oledrion
14			*
15			* @copyright {@link http://xoops.org/ XOOPS Project}
16			* @license {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
17			* @author Hossein Azizabadi ([email protected])
18			*/
19
20			require __DIR__ . '/classheader.php';
21
22			/**
23			* Class Oledrion_delivery
24			*/
25			class Oledrion_delivery extends Oledrion_Object
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-18 10:28 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
26			{
27			/**
28			* constructor
29			*
30			* normally, this is called from child classes only
31			*
32			* @access public
33			*/
34			public function __construct()
35			{
36			$this->initVar('delivery_id', XOBJ_DTYPE_INT, null, false);
37			$this->initVar('delivery_title', XOBJ_DTYPE_TXTBOX, null, false);
38			$this->initVar('delivery_description', XOBJ_DTYPE_TXTAREA, null, false);

XoopsModules25x / oledrion

Push — master ( 00e474...9d3fbd )

getThisLocationThisDelivery() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like