OledrionOledrion_location_deliveryHandler

Complexity

Total Complexity

8

Size/Duplication

Total Lines	58
Duplicated Lines	32.76 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getLocationDeliveryId()	19	19	4
A	getDelivery()	0	17	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 25 and the first side effect is on line 20.

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hossein Azizabadi (azizabadi@faragostaresh.com)
 */

require __DIR__ . '/classheader.php';

/**
 * Class Oledrion_location_delivery
 */
class Oledrion_location_delivery extends Oledrion_Object

This class seems to be duplicated in your project.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * constructor
     *
     * normally, this is called from child classes only
     *
     * @access public
     */
    public function __construct()
    {
        $this->initVar('ld_id', XOBJ_DTYPE_INT, null, false);
        $this->initVar('ld_location', XOBJ_DTYPE_INT, null, false);
        $this->initVar('ld_delivery', XOBJ_DTYPE_INT, null, false);
        $this->initVar('ld_price', XOBJ_DTYPE_INT, null, false);
        $this->initVar('ld_delivery_time', XOBJ_DTYPE_INT, null, false);
    }

    /**
     * Retourne les éléments du produits formatés pour affichage
     *
     * @param  string $format
     * @return array
     */
    public function toArray($format = 's')
    {
        $ret = array();

$ret is not used, you could remove the assignment.

        $ret = parent::toArray($format);

        return $ret;
    }
}

/**
 * Class OledrionOledrion_location_deliveryHandler
 */
class OledrionOledrion_location_deliveryHandler extends Oledrion_XoopsPersistableObjectHandler

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * OledrionOledrion_location_deliveryHandler constructor.
     * @param XoopsDatabase|null $db
     */
    public function __construct(XoopsDatabase $db)
    { //                                          Table                            Classe                      Id
        parent::__construct($db, 'oledrion_location_delivery', 'oledrion_location_delivery', 'ld_id');
    }

    /**
     * @param $parameters
     * @return array
     */
    public function getLocationDeliveryId($parameters)

This method seems to be duplicated in your project.

    {
        $ret = array();
        if (!$parameters['location']) {
            return $ret;
        }
        $critere = new CriteriaCompo();
        $critere->add(new Criteria('ld_location', $parameters['location']));
        $obj = $this->getObjects($critere);
        if ($obj) {

The expression $obj of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($obj as $root) {
                $tab                               = array();

$tab is not used, you could remove the assignment.

                $tab                               = $root->toArray();
                $ret[$root->getVar('ld_delivery')] = $tab;
            }
        }

        return $ret;
    }

    /**
     * @param $ld_delivery
     * @param $ld_location
     * @return array
     */
    public function getDelivery($ld_delivery, $ld_location)
    {
        $ret     = array();
        $critere = new CriteriaCompo();
        $critere->add(new Criteria('ld_delivery', $ld_delivery));
        $critere->add(new Criteria('ld_location', $ld_location));
        $critere->setLimit(1);
        $obj = $this->getObjects($critere);
        if ($obj) {

The expression $obj of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($obj as $root) {
                $tab = array();

$tab is not used, you could remove the assignment.

                $ret = $root->toArray();
            }
        }

        return $ret;
    }
}