OledrionOledrion_caddyHandler - Code Metrics - Inspection of "Merge pull request #6 from mambax7/master" - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00e474...9d3fbd )

by Michael

created 2017-05-24 21:17 UTC

OledrionOledrion_caddyHandler C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	464
Duplicated Lines	10.34 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
dl	48
loc	464
rs	5.7474
c	0
b	0
f	0
wmc	66
lcom	1
cbo	3

19 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getBestWith()	0	16	3
C	getMostSoldProducts()	0	34	7
A	getRecentlySoldProducts()	0	22	3
A	isCartEmpty()	0	8	2
A	emptyCart()	0	10	3
B	reloadPersistentCart()	0	18	5
C	addProduct()	0	35	7
A	isInCart()	18	18	4
A	getProductAttributesFromCart()	16	16	4
A	renumberCart()	0	16	2
B	deleteProduct()	0	22	5
D	updateQuantites()	0	39	9
A	getCaddyFromCommand()	0	8	1
A	getProductsFromCaddy()	0	13	3
A	getCommandIdFromProduct()	14	14	3
A	getCaddyFromPassword()	0	12	2
A	markCaddyAsNotDownloadableAnyMore()	0	6	1
A	removeCartsFromOrderId()	0	6	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like OledrionOledrion_caddyHandler often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use OledrionOledrion_caddyHandler, and based on these observations, apply Extract Interface, too.

<?php

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * oledrion
 *
 * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @author      Hervé Thouzard (http://www.herve-thouzard.com/)
 */

/**
 * Gestion des caddy
 */
require __DIR__ . '/classheader.php';

/**
 * Class Oledrion_caddy
 */
class Oledrion_caddy extends Oledrion_Object
namespace YourVendor;

class YourClass { }
{
    /**
     * constructor
     *
     * normally, this is called from child classes only
     *
     * @access public
     */
    public function __construct()
    {
        $this->initVar('caddy_id', XOBJ_DTYPE_INT, null, false);
        $this->initVar('caddy_product_id', XOBJ_DTYPE_INT, null, false);
        $this->initVar('caddy_qte', XOBJ_DTYPE_INT, null, false);
        $this->initVar('caddy_price', XOBJ_DTYPE_TXTBOX, null, false); // Prix TTC
        $this->initVar('caddy_cmd_id', XOBJ_DTYPE_INT, null, false);
        $this->initVar('caddy_shipping', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('caddy_pass', XOBJ_DTYPE_TXTBOX, null, false);
    }

    /**
     * Retourne les éléments du produits formatés pour affichage
     *
     * @param  string $format Le format à utiliser
     * @return array  Les informations formatées
     */
    public function toArray($format = 's')
    {
        $ret                              = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $ret                              = parent::toArray($format);
        $oledrion_Currency                = Oledrion_Currency::getInstance();
        $ret['caddy_price_fordisplay']    = $oledrion_Currency->amountForDisplay($this->getVar('caddy_price'));
        $ret['caddy_shipping_fordisplay'] = $oledrion_Currency->amountForDisplay($this->getVar('caddy_shipping'));

        return $ret;
    }
}

/**
 * Class OledrionOledrion_caddyHandler
 */
class OledrionOledrion_caddyHandler extends Oledrion_XoopsPersistableObjectHandler
namespace YourVendor;

class YourClass { }
{
    const CADDY_NAME = 'oledrion_caddie'; // Nom du panier en session

    /**
     * OledrionOledrion_caddyHandler constructor.
     * @param XoopsDatabase|null $db
     */
    public function __construct(XoopsDatabase $db)
    { //                          Table             Classe          Id
        parent::__construct($db, 'oledrion_caddy', 'oledrion_caddy', 'caddy_id');
    }

    /**
     * Renvoie, si on en trouve un, un produit qui s'est bien vendu avec un produit particulier
     *
     * @param  integer $caddy_product_id Identifiant du produit dont on recherche le jumeau
     * @return integer Le n° du produit le plus vendu avec le produit en question
     */
    public function getBestWith($caddy_product_id)
    {
        $sql    = 'SELECT caddy_product_id, sum(caddy_qte) mv FROM ' . $this->table . ' WHERE caddy_cmd_id IN (SELECT caddy_cmd_id FROM ' . $this->table . ' WHERE caddy_product_id=' . (int)$caddy_product_id
                  . ') GROUP BY caddy_product_id ORDER BY mv DESC';
        $result = $this->db->query($sql, 1);
        if (!$result) {
            return 0;
        }
        $myrow = $this->db->fetchArray($result);
        $id    = $myrow['caddy_product_id'];
        if ($id != $caddy_product_id) {
            return $id;
        } else {
            return 0;
        }
    }

    /**
     * Renvoie la liste des produits les plus vendus toutes catégories confondues
     *
     * @param  integer $start Début de la recherche
     * @param  integer $limit Nombre maximum d'enregistrements à retourner
     * @param  int     $product_cid
     * @param  bool    $withQuantity
     * @return array   Les identifiants des X produits les plus vendus dans cette catégorie
     */
    public function getMostSoldProducts($start = 0, $limit = 0, $product_cid = 0, $withQuantity = false)
    {
        //require_once __DIR__ . '/lite.php';

        $ret = array();
        if (is_array($product_cid) && count($product_cid) > 0) {
            $sql = 'SELECT c.caddy_product_id, sum( c.caddy_qte ) AS mv FROM ' . $this->table . ' c, ' . $this->db->prefix('oledrion_products') . ' b WHERE (c.caddy_product_id = b.product_id) AND b.product_cid IN (' . implode(',', $product_cid)
                   . ') GROUP BY c.caddy_product_id ORDER BY mv DESC';
        } elseif ($product_cid > 0) {
            $sql = 'SELECT c.caddy_product_id, sum( c.caddy_qte ) AS mv FROM ' . $this->table . ' c, ' . $this->db->prefix('oledrion_products') . ' b WHERE (c.caddy_product_id = b.product_id) AND b.product_cid = ' . (int)$product_cid
                   . ' GROUP BY c.caddy_product_id ORDER BY mv DESC';
        } else {
            $sql = 'SELECT caddy_product_id, sum( caddy_qte ) as mv FROM ' . $this->table . ' GROUP BY caddy_product_id ORDER BY mv DESC';
        }
        //$Cache_Lite = new oledrion_Cache_Lite($this->cacheOptions);

        $id = $this->_getIdForCache($sql, $start, $limit);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //$cacheData = $Cache_Lite->get($id);

        //if ($cacheData === false) {

        $result = $this->db->query($sql, $limit, $start);
        if ($result) {
            while ($myrow = $this->db->fetchArray($result)) {
                if (!$withQuantity) {
                    $ret[$myrow['caddy_product_id']] = $myrow['caddy_product_id'];
                } else {
                    $ret[$myrow['caddy_product_id']] = $myrow['mv'];
                }
            }
        }

        //$Cache_Lite->save($ret);

        return $ret;
        //} else {
        //return $cacheData;
        //}
    }

    /**
     * Retourne la liste des ID de produits vendus récemment
     *
     * @param  integer $start
     * @param  integer $limit
     * @return array
     * @since 2.3.2009.04.08
     */
    public function getRecentlySoldProducts($start = 0, $limit = 0)
    {
        //require_once __DIR__ . '/lite.php';

        $ret = array();
        $sql = 'SELECT c.caddy_product_id FROM ' . $this->table . ' c, ' . $this->db->prefix('oledrion_commands') . ' o WHERE (c.caddy_cmd_id = o.cmd_id) AND (o.cmd_state = ' . OLEDRION_STATE_VALIDATED . ') ORDER BY cmd_date DESC';
        //$Cache_Lite = new oledrion_Cache_Lite($this->cacheOptions);

        $id = $this->_getIdForCache($sql, $start, $limit);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //$cacheData = $Cache_Lite->get($id);

        //if ($cacheData === false) {

        $result = $this->db->query($sql, $limit, $start);
        if ($result) {
            while ($row = $this->db->fetchArray($result)) {
                $ret[$row['caddy_product_id']] = $row['caddy_product_id'];
            }
        }

        //$Cache_Lite->save($ret);

        return $ret;
        //} else {
        //return $cacheData;
        //}
    }

    /**
     * Indique si le caddy est vide ou pas
     *
     * @return boolean vide, ou pas...
     */
    public function isCartEmpty()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_SESSION[self::CADDY_NAME])) {
            return false;
        } else {
            return true;
        }
    }

    /**
     * Vidage du caddy, s'il existe
     */
    public function emptyCart()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $xoopsUser, $h_oledrion_persistent_cart;
function myFunction($a, $b) {
    // Do something
}
        if (isset($_SESSION[self::CADDY_NAME])) {
            unset($_SESSION[self::CADDY_NAME]);
            if (is_object($xoopsUser)) {
                $h_oledrion_persistent_cart->deleteAllUserProducts();
            }
        }
    }

    /**
     * Recharge le dernier panier de l'utilisateur
     *
     * @return boolean
     */
    public function reloadPersistentCart()
    {
        global $xoopsUser, $h_oledrion_persistent_cart;
function myFunction($a, $b) {
    // Do something
}
        if (Oledrion_utils::getModuleOption('persistent_cart') == 0) {
            return false;
        }
        if (is_object($xoopsUser)) {
            $persistent_carts = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $persistent_carts = $h_oledrion_persistent_cart->getUserProducts();
            if (count($persistent_carts) > 0) {
                foreach ($persistent_carts as $persistent_cart) {
                    $this->addProduct($persistent_cart->getVar('persistent_product_id'), $persistent_cart->getVar('persistent_qty'), null);
                }
            }
        }

        return true;
    }

    /**
     * Ajout d'un produit au caddy
     *
     * @param  integer $product_id Identifiant du produit
     * @param  integer $quantity   Quantité à ajouter
     * @param  array   $attributes Les attributs du produit

     * @return void
     * @note : Structure du panier (tableau en session) :
     *                             [clé] = numéro de 1 à N
     *                             [valeur] = array (
     *                             'number' => numéro de 1 à N
     *                             'id' => ID du produit
     *                             'qty' => Quantité de produit
     *                             'attributes' => array(
     *                             'attr_id' => id attribut (son numéro dans la base)
     *                             'values' => array(valueId1, valueId2 ...)
     *                             )
     *                             )
     */
    public function addProduct($product_id, $quantity, $attributes = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $xoopsUser, $h_oledrion_persistent_cart;
function myFunction($a, $b) {
    // Do something
}
        $tbl_caddie = $tbl_caddie2 = array();
        if (isset($_SESSION[self::CADDY_NAME])) {
            $tbl_caddie = $_SESSION[self::CADDY_NAME];
        }
        $exists = false;
        foreach ($tbl_caddie as $produit) {
            if ($produit['id'] == $product_id) {
                $exists = true;
                $produit['qty'] += $quantity;
                $produit['attributes'] = $attributes;
                $newQuantity           = $produit['qty'];
            }
            $tbl_caddie2[] = $produit;
        }
        if (!$exists) {
            if (is_object($xoopsUser)) {
                $h_oledrion_persistent_cart->addUserProduct($product_id, $quantity);
            }
            $datas                      = array();
            $datas['number']            = count($tbl_caddie) + 1;
            $datas['id']                = $product_id;
            $datas['qty']               = $quantity;
            $datas['attributes']        = $attributes;
            $tbl_caddie[]               = $datas;
            $_SESSION[self::CADDY_NAME] = $tbl_caddie;
        } else {
            $_SESSION[self::CADDY_NAME] = $tbl_caddie2;
            if (is_object($xoopsUser)) { // Le produit était déjà dans le panier, on va mettre à jour la quantité
                $h_oledrion_persistent_cart->updateUserProductQuantity($product_id, $newQuantity);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            }
        }
    }

    /**
     * Inidique si un produit est dans le caddy
     *
     * @param  integer $caddy_product_id Le numéro interne du produit dans la table Produits
     * @return mixed   False si le produit n'est pas dans le caddy sinon son indice dans le caddy
     * @since 2.3.2009.03.15
     */
    public function isInCart($caddy_product_id)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $cart = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (isset($_SESSION[self::CADDY_NAME])) {
            $cart = $_SESSION[self::CADDY_NAME];
        } else {
            return false;
        }
        $counter = 0;
        foreach ($cart as $produit) {
            if ($produit['id'] == $caddy_product_id) {
                return $counter;
            }
            ++$counter;
        }

        return false;
    }

    /**
     * Retourne les attributs d'un produit depuis le panier
     *
     * @param  integer $caddy_product_id Le numéro interne du produit dans la table Produits
     * @return mixed   False si le produit n'est pas dans le caddy sinon ses attributs sous la forme d'un tableau
     * @since 2.3.2009.03.15
     */
    public function getProductAttributesFromCart($caddy_product_id)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $cart = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (isset($_SESSION[self::CADDY_NAME])) {
            $cart = $_SESSION[self::CADDY_NAME];
        } else {
            return false;
        }
        foreach ($cart as $produit) {
            if ($produit['id'] == $caddy_product_id) {
                return $produit['attributes'];
            }
        }

        return false;
    }

    /**
     * Renumérotage des produits dans le caddy après une suppression
     *
     * @param  array $caddy Le caddy actuel
     * @return array Le caddy avec 'number' renuméroté
     */
    private function renumberCart($caddy)
    {
        $newCaddy = array();
        $counter  = 1;
        foreach ($caddy as $values) {
            $temporary               = array();
            $temporary['number']     = $counter;
            $temporary['id']         = $values['id'];
            $temporary['qty']        = $values['qty'];
            $temporary['attributes'] = $values['attributes'];
            $newCaddy[]              = $temporary;
            ++$counter;
        }

        return $newCaddy;
    }

    /**
     * Suppression d'un produit du caddy
     *
     * @param integer $indice Indice de l'élément à supprimer
     */
    public function deleteProduct($indice)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $xoopsUser, $h_oledrion_persistent_cart;
function myFunction($a, $b) {
    // Do something
}
        $tbl_caddie = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (isset($_SESSION[self::CADDY_NAME])) {
            $tbl_caddie = $_SESSION[self::CADDY_NAME];
            if (isset($tbl_caddie[$indice])) {
                if (is_object($xoopsUser)) {
                    $datas = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    $datas = $tbl_caddie[$indice];
                    $h_oledrion_persistent_cart->deleteUserProduct($datas['id']);
                }
                unset($tbl_caddie[$indice]);
                if (count($tbl_caddie) > 0) {
                    $tbl_caddie                 = $this->renumberCart($tbl_caddie);
                    $_SESSION[self::CADDY_NAME] = $tbl_caddie;
                } else {
                    unset($_SESSION[self::CADDY_NAME]);
                }
            }
        }
    }

    /**
     * Mise à jour des quantités du caddy suite à la validation du formulaire du caddy
     */
    public function updateQuantites()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $h_oledrion_products, $xoopsUser, $h_oledrion_persistent_cart;
function myFunction($a, $b) {
    // Do something
}
        $tbl_caddie = $tbl_caddie2 = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (isset($_SESSION[self::CADDY_NAME])) {
            $tbl_caddie = $_SESSION[self::CADDY_NAME];
            foreach ($tbl_caddie as $produit) {
                $number = $produit['number'];
                $name   = 'qty_' . $number;
                if (isset($_POST[$name])) {
                    $valeur = (int)$_POST[$name];
                    if ($valeur > 0) {
                        $product_id = $produit['id'];
                        $product    = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                        $product    = $h_oledrion_products->get($product_id);
                        if (is_object($product)) {
                            if ($product->getVar('product_stock') - $valeur > 0) {
                                $produit['qty'] = $valeur;
                                $tbl_caddie2[]  = $produit;
                            } else {
                                $produit['qty'] = $product->getVar('product_stock');
                                $tbl_caddie2[]  = $produit;
                            }
                            if (is_object($xoopsUser)) {
                                $h_oledrion_persistent_cart->updateUserProductQuantity($product_id, $produit['qty']);
                            }
                        }
                    }
                } else {
                    $tbl_caddie2[] = $produit;
                }
            }
            if (count($tbl_caddie2) > 0) {
                $_SESSION[self::CADDY_NAME] = $tbl_caddie2;
            } else {
                unset($_SESSION[self::CADDY_NAME]);
            }
        }
    }

    /**
     * Renvoie les éléments constituants une commande
     *
     * @param  integer $caddy_cmd_id Identifiant de la commande
     * @return array   Tableau d'objets caddy
     */
    public function getCaddyFromCommand($caddy_cmd_id)
    {
        $ret     = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $critere = new Criteria('caddy_cmd_id', $caddy_cmd_id, '=');
        $ret     = $this->getObjects($critere);

        return $ret;
    }

    /**
     * Retourne tous les produits d'un caddy
     *
     * @param  array $carts Objets de type oledrion_caddy
     * @return array Tableau d'objets de type oledrion_products, Clé = Id produit
     * @since 2.31.2009.07.25
     */
    public function getProductsFromCaddy($carts)
    {
        $ret = $productsIds = array();
        foreach ($carts as $cart) {
            $productsIds[] = $cart->getVar('caddy_product_id');
        }
        if (count($productsIds) > 0) {
            $handlers = OledrionHandler::getInstance();
            $ret      = $handlers->h_oledrion_products->getProductsFromIDs($productsIds, true);
        }

        return $ret;
    }

    /**
     * Renvoie les ID de commandes pour un produit acheté
     *
     * @param  integer $product_id Identifiant du produit
     * @return array   Les ID des commandes dans lesquelles ce produit a été commandé
     */
    public function getCommandIdFromProduct($product_id)

    {
        $ret    = array();
        $sql    = 'SELECT caddy_cmd_id FROM ' . $this->table . ' WHERE caddy_product_id=' . (int)$product_id;
        $result = $this->db->query($sql);
        if (!$result) {
            return $ret;
        }
        while ($myrow = $this->db->fetchArray($result)) {
            $ret[] = $myrow['caddy_cmd_id'];
        }

        return $ret;
    }

    /**
     * Retourne un caddy à partir de son mot de passe
     *
     * @param  string $caddy_pass Le mot de passe à utiliser
     * @return mixed  Soit un object de type oledrion_caddy ou null
     */
    public function getCaddyFromPassword($caddy_pass)
    {
        $ret     = null;
        $caddies = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $critere = new Criteria('caddy_pass', $caddy_pass, '=');
        $caddies = $this->getObjects($critere);
        if (count($caddies) > 0) {
            $ret = $caddies[0];
        }

        return $ret;
    }

    /**
     * Marque un caddy comme ayant été téléchargé
     *
     * @param  oledrion_caddy $caddy
     * @return boolean        Le résultat de la mise à jour
     */
    public function markCaddyAsNotDownloadableAnyMore(Oledrion_caddy $caddy)
    {
        $caddy->setVar('caddy_pass', '');

        return $this->insert($caddy, true);
    }

    /**
     * Supprime les caddies associés à une commande
     *
     * @param  integer $caddy_cmd_id
     * @return boolean
     */
    public function removeCartsFromOrderId($caddy_cmd_id)
    {
        $caddy_cmd_id = (int)$caddy_cmd_id;

        return $this->deleteAll(new criteria('caddy_cmd_id', $caddy_cmd_id, '='));
    }
}


Push — master ( 00e474...9d3fbd )

OledrionOledrion_caddyHandler C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

19 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

XoopsModules25x / oledrion

Push — master ( 00e474...9d3fbd )

OledrionOledrion_caddyHandler C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

19 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like