Code Duplication - XoopsModules25x/oledrion - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 5-7 lines in 8 locations

admin/actions/attributes.php 4 locations



        $newFilter = false;

        if (isset($_POST['filter_attribute_id'])) {
            if ((int)$_POST['filter_attribute_id'] != 0) {
                $criteria->add(new Criteria('attribute_id', (int)$_POST['filter_attribute_id']), '=');
            }
            $filter_attribute_id = (int)$_POST['filter_attribute_id'];
            $newFilter           = true;
        }
        if (isset($_POST['filter_attribute_title']) && xoops_trim($_POST['filter_attribute_title']) != '') {
            $criteria->add(new Criteria('attribute_title', '%' . $_POST['filter_attribute_title'] . '%', 'LIKE'));
            $filter_attribute_title = $_POST['filter_attribute_title'];

            $filter_attribute_title = $_POST['filter_attribute_title'];
            $newFilter              = true;
        }
        if (isset($_POST['filter_attribute_product_id']) && (int)$_POST['filter_attribute_product_id'] != 0) {
            $criteria->add(new Criteria('attribute_product_id', (int)$_POST['filter_attribute_product_id']), '=');
            $filter_attribute_product_id = (int)$_POST['filter_attribute_product_id'];
            $newFilter                   = true;
        }
        if (isset($_POST['filter_attribute_weight']) && (int)$_POST['filter_attribute_weight'] != 0) {
            $criteria->add(new Criteria('attribute_weight', (int)$_POST['filter_attribute_weight']), '=');
            $filter_attribute_weight = (int)$_POST['filter_attribute_weight'];

            $filter_attribute_product_id = (int)$_POST['filter_attribute_product_id'];
            $newFilter                   = true;
        }
        if (isset($_POST['filter_attribute_weight']) && (int)$_POST['filter_attribute_weight'] != 0) {
            $criteria->add(new Criteria('attribute_weight', (int)$_POST['filter_attribute_weight']), '=');
            $filter_attribute_weight = (int)$_POST['filter_attribute_weight'];
            $newFilter               = true;
        }
        if (isset($_POST['filter_attribute_type']) && (int)$_POST['filter_attribute_type'] != 0) {
            $criteria->add(new Criteria('attribute_type', (int)$_POST['filter_attribute_type']), '=');
            $filter_attribute_type = (int)$_POST['filter_attribute_type'];

            $filter_attribute_weight = (int)$_POST['filter_attribute_weight'];
            $newFilter               = true;
        }
        if (isset($_POST['filter_attribute_type']) && (int)$_POST['filter_attribute_type'] != 0) {
            $criteria->add(new Criteria('attribute_type', (int)$_POST['filter_attribute_type']), '=');
            $filter_attribute_type = (int)$_POST['filter_attribute_type'];
            $newFilter             = true;
        }

        if ($filter_attribute_id == 0 && $filter_attribute_title == '' && $filter_attribute_weight == 0
            && $filter_attribute_type == 0) {

admin/actions/products.php 4 locations


        $criteria  = new CriteriaCompo();
        $criteria->add(new Criteria('product_id', 0, '<>'));

        if (isset($_POST['filter_product_id'])) {
            if ((int)$_POST['filter_product_id'] != 0) {
                $criteria->add(new Criteria('product_id', (int)$_POST['filter_product_id']), '=');
            }
            $filter_product_id = (int)$_POST['filter_product_id'];
            $newFilter         = true;
        }
        if (isset($_POST['filter_product_cid']) && (int)$_POST['filter_product_cid'] != 0) {
            $criteria->add(new Criteria('product_cid', (int)$_POST['filter_product_cid']), '=');
            $filter_product_cid = (int)$_POST['filter_product_cid'];

            $filter_product_id = (int)$_POST['filter_product_id'];
            $newFilter         = true;
        }
        if (isset($_POST['filter_product_cid']) && (int)$_POST['filter_product_cid'] != 0) {
            $criteria->add(new Criteria('product_cid', (int)$_POST['filter_product_cid']), '=');
            $filter_product_cid = (int)$_POST['filter_product_cid'];
            $newFilter          = true;
        }
        if (isset($_POST['filter_product_recommended']) && (int)$_POST['filter_product_recommended'] != 0) {
            if ((int)$_POST['filter_product_recommended'] == 1) {
                $criteria->add(new Criteria('product_recommended', '0000-00-00', '<>'));

            $filter_product_sku = $_POST['filter_product_sku'];
            $newFilter          = true;
        }
        if (isset($_POST['filter_product_online']) && (int)$_POST['filter_product_online'] != 0) {
            $criteria->add(new Criteria('product_online', (int)$_POST['filter_product_online'] - 1, '='));
            $filter_product_online = (int)$_POST['filter_product_online'];
            $newFilter             = true;
        }
        if (isset($_POST['filter_product_price']) && (int)$_POST['filter_product_price'] != 0) {
            $criteria->add(new Criteria('product_price', (int)$_POST['filter_product_price']), '>=');
            $filter_product_price = (int)$_POST['filter_product_price'];

            $filter_product_online = (int)$_POST['filter_product_online'];
            $newFilter             = true;
        }
        if (isset($_POST['filter_product_price']) && (int)$_POST['filter_product_price'] != 0) {
            $criteria->add(new Criteria('product_price', (int)$_POST['filter_product_price']), '>=');
            $filter_product_price = (int)$_POST['filter_product_price'];
            $newFilter            = true;
        }
        // B.R. Added: $filter_skip_packing $filter_skip_location $filter_skip_delivery
        if ($filter_product_id == 0
            && $filter_product_cid == 0

		@@ 72-78 (lines=7) @@
69
70		$newFilter = false;
71
72		if (isset($_POST['filter_attribute_id'])) {
73		if ((int)$_POST['filter_attribute_id'] != 0) {
74		$criteria->add(new Criteria('attribute_id', (int)$_POST['filter_attribute_id']), '=');
75		}
76		$filter_attribute_id = (int)$_POST['filter_attribute_id'];
77		$newFilter = true;
78		}
79		if (isset($_POST['filter_attribute_title']) && xoops_trim($_POST['filter_attribute_title']) != '') {
80		$criteria->add(new Criteria('attribute_title', '%' . $_POST['filter_attribute_title'] . '%', 'LIKE'));
81		$filter_attribute_title = $_POST['filter_attribute_title'];
		@@ 84-88 (lines=5) @@
81		$filter_attribute_title = $_POST['filter_attribute_title'];
82		$newFilter = true;
83		}
84		if (isset($_POST['filter_attribute_product_id']) && (int)$_POST['filter_attribute_product_id'] != 0) {
85		$criteria->add(new Criteria('attribute_product_id', (int)$_POST['filter_attribute_product_id']), '=');
86		$filter_attribute_product_id = (int)$_POST['filter_attribute_product_id'];
87		$newFilter = true;
88		}
89		if (isset($_POST['filter_attribute_weight']) && (int)$_POST['filter_attribute_weight'] != 0) {
90		$criteria->add(new Criteria('attribute_weight', (int)$_POST['filter_attribute_weight']), '=');
91		$filter_attribute_weight = (int)$_POST['filter_attribute_weight'];
		@@ 89-93 (lines=5) @@
86		$filter_attribute_product_id = (int)$_POST['filter_attribute_product_id'];
87		$newFilter = true;
88		}
89		if (isset($_POST['filter_attribute_weight']) && (int)$_POST['filter_attribute_weight'] != 0) {
90		$criteria->add(new Criteria('attribute_weight', (int)$_POST['filter_attribute_weight']), '=');
91		$filter_attribute_weight = (int)$_POST['filter_attribute_weight'];
92		$newFilter = true;
93		}
94		if (isset($_POST['filter_attribute_type']) && (int)$_POST['filter_attribute_type'] != 0) {
95		$criteria->add(new Criteria('attribute_type', (int)$_POST['filter_attribute_type']), '=');
96		$filter_attribute_type = (int)$_POST['filter_attribute_type'];
		@@ 94-98 (lines=5) @@
91		$filter_attribute_weight = (int)$_POST['filter_attribute_weight'];
92		$newFilter = true;
93		}
94		if (isset($_POST['filter_attribute_type']) && (int)$_POST['filter_attribute_type'] != 0) {
95		$criteria->add(new Criteria('attribute_type', (int)$_POST['filter_attribute_type']), '=');
96		$filter_attribute_type = (int)$_POST['filter_attribute_type'];
97		$newFilter = true;
98		}
99
100		if ($filter_attribute_id == 0 && $filter_attribute_title == '' && $filter_attribute_weight == 0
101		&& $filter_attribute_type == 0) {

		@@ 77-83 (lines=7) @@
74		$criteria = new CriteriaCompo();
75		$criteria->add(new Criteria('product_id', 0, '<>'));
76
77		if (isset($_POST['filter_product_id'])) {
78		if ((int)$_POST['filter_product_id'] != 0) {
79		$criteria->add(new Criteria('product_id', (int)$_POST['filter_product_id']), '=');
80		}
81		$filter_product_id = (int)$_POST['filter_product_id'];
82		$newFilter = true;
83		}
84		if (isset($_POST['filter_product_cid']) && (int)$_POST['filter_product_cid'] != 0) {
85		$criteria->add(new Criteria('product_cid', (int)$_POST['filter_product_cid']), '=');
86		$filter_product_cid = (int)$_POST['filter_product_cid'];
		@@ 84-88 (lines=5) @@
81		$filter_product_id = (int)$_POST['filter_product_id'];
82		$newFilter = true;
83		}
84		if (isset($_POST['filter_product_cid']) && (int)$_POST['filter_product_cid'] != 0) {
85		$criteria->add(new Criteria('product_cid', (int)$_POST['filter_product_cid']), '=');
86		$filter_product_cid = (int)$_POST['filter_product_cid'];
87		$newFilter = true;
88		}
89		if (isset($_POST['filter_product_recommended']) && (int)$_POST['filter_product_recommended'] != 0) {
90		if ((int)$_POST['filter_product_recommended'] == 1) {
91		$criteria->add(new Criteria('product_recommended', '0000-00-00', '<>'));
		@@ 108-112 (lines=5) @@
105		$filter_product_sku = $_POST['filter_product_sku'];
106		$newFilter = true;
107		}
108		if (isset($_POST['filter_product_online']) && (int)$_POST['filter_product_online'] != 0) {
109		$criteria->add(new Criteria('product_online', (int)$_POST['filter_product_online'] - 1, '='));
110		$filter_product_online = (int)$_POST['filter_product_online'];
111		$newFilter = true;
112		}
113		if (isset($_POST['filter_product_price']) && (int)$_POST['filter_product_price'] != 0) {
114		$criteria->add(new Criteria('product_price', (int)$_POST['filter_product_price']), '>=');
115		$filter_product_price = (int)$_POST['filter_product_price'];
		@@ 113-117 (lines=5) @@
110		$filter_product_online = (int)$_POST['filter_product_online'];
111		$newFilter = true;
112		}
113		if (isset($_POST['filter_product_price']) && (int)$_POST['filter_product_price'] != 0) {
114		$criteria->add(new Criteria('product_price', (int)$_POST['filter_product_price']), '>=');
115		$filter_product_price = (int)$_POST['filter_product_price'];
116		$newFilter = true;
117		}
118		// B.R. Added: $filter_skip_packing $filter_skip_location $filter_skip_delivery
119		if ($filter_product_id == 0
120		&& $filter_product_cid == 0

XoopsModules25x / oledrion

Code Duplication Length = 5-7 lines in 8 locations

admin/actions/attributes.php 4 locations

admin/actions/products.php 4 locations