listForm()

Complexity

Conditions	11
Paths	81

Size

Total Lines	75
Code Lines	57

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function listForm($op, $product_id = 0)
{
    global $baseurl;

    $db           = \XoopsDatabaseFactory::getDatabaseConnection();
    $listsHandler = new Oledrion\ListsHandler($db);

    if ('edit' === $op) {
        $title        = _OLEDRION_EDIT_LIST;
        $label_submit = _AM_OLEDRION_MODIFY;

The assignment to $label_submit is dead and can be removed.

        $list_id      = \Xmf\Request::getInt('list_id', 0, 'GET');
        if (empty($list_id)) {
            Oledrion\Utility::redirect(_AM_OLEDRION_ERROR_12, $baseurl, 5);
        }
        $item = null;

The assignment to $item is dead and can be removed.

        $item = $listsHandler->get($list_id);
        if (!is_object($item)) {
            Oledrion\Utility::redirect(_AM_OLEDRION_NOT_FOUND, $baseurl, 5);
        }
        // Vérification, est-ce que l'utilisateur courant est bien le propriétaire de cette liste ?
        if (!$listsHandler->isThisMyList($list_id)) {
            Oledrion\Utility::redirect(_OLEDRION_ERROR25, $baseurl, 8);
        }
        $edit         = true;
        $label_submit = _AM_OLEDRION_MODIFY;
    } else {
        $title        = _OLEDRION_ADD_LIST;
        $label_submit = _AM_OLEDRION_ADD;
        $item         = $listsHandler->create(true);
        $edit         = false;
    }

    $sform = new \XoopsThemeForm($title, 'frmList', $baseurl);
    $sform->addElement(new \XoopsFormHidden('op', 'save'));
    $sform->addElement(new \XoopsFormHidden('list_id', $item->getVar('list_id')));

It seems like $item->getVar('list_id') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

    $sform->addElement(new \XoopsFormText(_AM_OLEDRION_TITLE, 'list_title', 50, 255, $item->getVar('list_title', 'e')), true);

It seems like $item->getVar('list_title', 'e') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

    //$sform->addElement(new \XoopsFormText(_OLEDRION_LIST_PASSWORD, 'list_password', 50, 50, $item->getVar('list_password','e')), false);
    $selectTypes = \XoopsModules\Oledrion\Lists::getTypesArray();
    $selectType  = new \XoopsFormSelect(_OLEDRION_LIST_TYPE, 'list_type', $item->getVar('list_type', 'e'));
    $selectType->addOptionArray($selectTypes);
    $sform->addElement($selectType, true);
    $sform->addElement(new \XoopsFormTextArea(_OLEDRION_DESCRIPTION, 'list_description', $item->getVar('list_description', 'e'), 7, 60), false);

It seems like $item->getVar('list_description', 'e') can also be of type array and array; however, parameter $value of XoopsFormTextArea::__construct() does only seem to accept string, maybe add an additional type check?

    $listProducts = [];

The assignment to $listProducts is dead and can be removed.

    if ($edit) {
        $listProducts = $listsHandler->getListProducts($item);
        if (count($listProducts) > 0) {
            $productsTray = new \XoopsFormElementTray(_OLEDRION_PROD_IN_THIS_LIST, '<br>');
            $productsTray->addElement(new \XoopsFormLabel(_OLEDRION_CHECK_PRODUCTS), false);
            foreach ($listProducts as $product) {
                $caption  = "<a target='_blank' href='" . $product->getLink() . "'>" . $product->getVar('product_title') . '</a>';
                $checkbox = new \XoopsFormCheckBox($caption, 'productsList[]');
                $checkbox->addOption($product->getVar('product_id'), _DELETE);
                $productsTray->addElement($checkbox);
                unset($caption, $checkbox);
            }
            $sform->addElement($productsTray, false);
        }
    }
    if ($product_id > 0) {
        $product = null;

The assignment to $product is dead and can be removed.

        $product = $productsHandler->get($product_id);

The variable $productsHandler does not exist. Did you maybe mean $product?

        if (is_object($product) && $product->isProductVisible()) {
            $content = "<a target='_blank' href='" . $product->getLink() . "'>" . $product->getVar('product_title') . '</a>';
            $sform->addElement(new \XoopsFormLabel(_OLEDRION_PRODUCT_DO_ADD, $content));
            $sform->addElement(new \XoopsFormHidden('product_id', $product_id));
        }
    }
    $buttonTray = new \XoopsFormElementTray('', '');
    $submit_btn = new \XoopsFormButton('', 'post', $label_submit, 'submit');
    $buttonTray->addElement($submit_btn);
    $sform->addElement($buttonTray);

    $sform = Oledrion\Utility::formMarkRequiredFields($sform);

    return $sform;
}